labath added a comment.

This definitely aren't all of our watchpoint tests. What's the reason for 
picking this particular bunch? Are they the only ones enabled on NetBSD right 
now?

Anyway, given that all of the watchpoint tests are already annotated with the 
"watchpoint" category, I think it would be better to handle this similar to how 
we handle other category-based skips (debug info flavours, c++ library types, 
etc.). This would also enable us to get rid of the "expectedFailure(windows)" 
decorator on all of these tests by implementing the skip centrally (though you 
don't have to do that right now). The category-based skipping happens around 
here: 
https://github.com/llvm-mirror/lldb/blob/master/packages/Python/lldbsuite/test/dotest.py#L1143


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63380/new/

https://reviews.llvm.org/D63380



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to