[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

labath added inline comments. Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:169-170 + +Status ProcessDebugger::AttachProcess(lldb::pid_t pid, + const ProcessAttachInfo &attach_info, +

[Lldb-commits] [PATCH] D62502: Implement xfer:libraries-svr4:read packet

aadsm updated this revision to Diff 204423. aadsm added a comment. Herald added a subscriber: emaste. - Move SVR4 reading to NativeProcessELF - Made NetBSD and FreeBSD process implementations extend NativeProcessELF I'm not 100% confident on this last one because I don't have a net and free bsd

[Lldb-commits] [lldb] r363228 - [Reproducers] Remove call to lldb_private::GetVersion()

Author: jdevlieghere Date: Wed Jun 12 22:14:25 2019 New Revision: 363228 URL: http://llvm.org/viewvc/llvm-project?rev=363228&view=rev Log: [Reproducers] Remove call to lldb_private::GetVersion() Utility doesn't link against lldbBase so we cannot call GetVersion in keep. I already added a string m

[Lldb-commits] [PATCH] D62501: Implement GetSharedLibraryInfoAddress

aadsm updated this revision to Diff 204422. aadsm added a comment. Improve tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62501/new/ https://reviews.llvm.org/D62501 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp lldb/sour

[Lldb-commits] [PATCH] D62503: Add ReadCStringFromMemory for faster string reads

aadsm marked an inline comment as done. aadsm added a comment. Yeah, that's a good question and I did think about it at the time I wrote D62715 . Here's my rationale: Regarding the chunk reading in the ReadMemory I was not sure because I don't know how common tha

[Lldb-commits] [PATCH] D63229: [Reproducers] Include lldb version in the reproducer root

This revision was automatically updated to reflect the committed changes. Closed by commit rL363225: [Reproducers] Include lldb version in the reproducer root (authored by JDevlieghere, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[Lldb-commits] [lldb] r363225 - [Reproducers] Include lldb version in the reproducer root

Author: jdevlieghere Date: Wed Jun 12 21:35:22 2019 New Revision: 363225 URL: http://llvm.org/viewvc/llvm-project?rev=363225&view=rev Log: [Reproducers] Include lldb version in the reproducer root Generally, reproducers are rev-locked to the version of LLDB, so it's valuable to have the LLDB vers

[Lldb-commits] [PATCH] D63241: Fixed typos in Log.h

ziita created this revision. ziita added a reviewer: JDevlieghere. ziita added a project: LLDB. Herald added a subscriber: lldb-commits. Fixed typos in Log.h Repository: rLLDB LLDB https://reviews.llvm.org/D63241 Files: lldb/include/lldb/Utility/Log.h Index: lldb/include/lldb/Utility/Log

[Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

xiaobai created this revision. xiaobai added reviewers: labath, compnerd, JDevlieghere, davide. Instead of falling back to ObjCLanguageRuntime, we should be falling back to every loaded language runtime. This makes ValueObject more language agnostic. https://reviews.llvm.org/D63240 Files: inc

[Lldb-commits] [PATCH] D63229: [Reproducers] Include lldb version in the reproducer root

JDevlieghere updated this revision to Diff 204371. JDevlieghere added a comment. Rebased to use the nested `Info` struct instead of the typedef. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63229/new/ https://reviews.llvm.org/D63229 Files: lldb/include/lldb/Utility/Reproducer.h ll

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

Hui added a comment. In D63166#1539491 , @labath wrote: > Given that you're just moving code around, this should be fine, but I am > including @amccarth, as I believe he is more familiar with this code. > > The thing I would consider in your place is whet

[Lldb-commits] [lldb] r363211 - [Reproducers] Simplify providers with nested Info struct (NFC)

Author: jdevlieghere Date: Wed Jun 12 15:17:38 2019 New Revision: 363211 URL: http://llvm.org/viewvc/llvm-project?rev=363211&view=rev Log: [Reproducers] Simplify providers with nested Info struct (NFC) This replaces the `info` typedef with a nested struct named Info. This means we now have FooPro

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

Hui added a comment. > In D63165#1539118 , @amccarth wrote: > >> Sorry for the stupid question, but ... >> >> What exactly is meant here by "Native"? How is a NativeProcessWindows >> different from ProcessWindows? > > > The Native*** classes are meant

[Lldb-commits] [PATCH] D63229: [Reproducers] Include lldb version in the reproducer root

JDevlieghere updated this revision to Diff 204361. JDevlieghere marked 3 inline comments as done. JDevlieghere added a comment. Adrian's feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63229/new/ https://reviews.llvm.org/D63229 Files: lldb/include/lldb/Utility/Reproducer.h l

[Lldb-commits] [PATCH] D63229: [Reproducers] Include lldb version in the reproducer root

aprantl added inline comments. Comment at: lldb/include/lldb/Utility/Reproducer.h:114 +struct VersionInfo { + static const char *name; Isn't a struct with two static members basically a namespace? I'm curious, I have not seen this pattern before. ==

[Lldb-commits] [lldb] r363206 - Re-land r363103 ("When reading ObjC class table, use new SPI if it is avail")

Author: jmolenda Date: Wed Jun 12 14:44:53 2019 New Revision: 363206 URL: http://llvm.org/viewvc/llvm-project?rev=363206&view=rev Log: Re-land r363103 ("When reading ObjC class table, use new SPI if it is avail") with a call to snprintf() to find the size of the formatted string, malloc memory, th

[Lldb-commits] [PATCH] D63229: [Reproducers] Include lldb version in the reproducer root

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, davide. JDevlieghere added a project: LLDB. Herald added a subscriber: abidh. Generally, reproducers are rev-locked to the version of LLDB, so it's valuable to have the LLDB version in the reproducer. For now I just want t

[Lldb-commits] [lldb] r363202 - Skip failing test on older versions of clang.

Author: adrian Date: Wed Jun 12 14:30:00 2019 New Revision: 363202 URL: http://llvm.org/viewvc/llvm-project?rev=363202&view=rev Log: Skip failing test on older versions of clang. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/return-value/TestReturnValue.py Modified: l

[Lldb-commits] [PATCH] D62797: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL363183: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl (authored by xiaobai, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reposito

[Lldb-commits] [lldb] r363183 - [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl

Author: xiaobai Date: Wed Jun 12 10:47:06 2019 New Revision: 363183 URL: http://llvm.org/viewvc/llvm-project?rev=363183&view=rev Log: [Expression] Add PersistentExpressionState::GetCompilerTypeFromPersistentDecl Summary: PersistentStateExpressions (e.g. ClangPersistentVariables) have the ability

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

xiaobai marked an inline comment as done. xiaobai added a comment. In D63181#1539620 , @labath wrote: > Moving BreakpointPrecondition to a forward-declarable place sounds good to me. Alright, so I think I'll go ahead and change this patch to make that ha

[Lldb-commits] [PATCH] D63187: [LLDB] Fix FreeBSD build

aadsm added a comment. oops, thank you! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63187/new/ https://reviews.llvm.org/D63187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] r363172 - [lldb] Ignore null frames in lldb.macosx crashlog

Author: stefan.graenitz Date: Wed Jun 12 07:46:37 2019 New Revision: 363172 URL: http://llvm.org/viewvc/llvm-project?rev=363172&view=rev Log: [lldb] Ignore null frames in lldb.macosx crashlog Modified: lldb/trunk/examples/python/crashlog.py Modified: lldb/trunk/examples/python/crashlog.py UR

[Lldb-commits] [lldb] r363171 - [CMake] Two extra FOLDER properties for debugserver

Author: stefan.graenitz Date: Wed Jun 12 07:46:30 2019 New Revision: 363171 URL: http://llvm.org/viewvc/llvm-project?rev=363171&view=rev Log: [CMake] Two extra FOLDER properties for debugserver Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt Modified: lldb/trunk/tools/debugserve

[Lldb-commits] [lldb] r363146 - Recognise debug_types.dwo as a debug info section

Author: labath Date: Wed Jun 12 04:42:42 2019 New Revision: 363146 URL: http://llvm.org/viewvc/llvm-project?rev=363146&view=rev Log: Recognise debug_types.dwo as a debug info section This is a preparatory patch to allow reading type units from dwo files. Modified: lldb/trunk/include/lldb/lld

[Lldb-commits] [PATCH] D62894: DWARF: Share line tables of type units

This revision was automatically updated to reflect the committed changes. Closed by commit rL363143: DWARF: Share line tables of type units (authored by labath, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[Lldb-commits] [lldb] r363143 - DWARF: Share line tables of type units

Author: labath Date: Wed Jun 12 04:29:50 2019 New Revision: 363143 URL: http://llvm.org/viewvc/llvm-project?rev=363143&view=rev Log: DWARF: Share line tables of type units Summary: This patch creates a cache of file lists in line tables referenced by type units. This cache is used to avoid parsi

[Lldb-commits] [PATCH] D62756: Be consistent when adding names and mangled names to the index

labath added a comment. In D62756#1538439 , @clayborg wrote: > In D62756#1526996 , @labath wrote: > > > Being consistent definitely sounds like a good idea. Since this does change > > behavior somewhat, I'm wonderi

[Lldb-commits] [PATCH] D63181: [Target] Decouple ObjCLanguageRuntime from LanguageRuntime

labath added a comment. Moving BreakpointPrecondition to a forward-declarable place sounds good to me. Comment at: source/Target/ObjCLanguageRuntime.cpp:379 +void ObjCLanguageRuntime::SetBreakpointExceptionPrecondition( +BreakpointSP breakpoint, LanguageType language, bool

[Lldb-commits] [PATCH] D63171: Don't try to parse ObjC method if CU isn't ObjC

labath added a comment. In D63171#1539187 , @aprantl wrote: > In D63171#1539070 , @clayborg wrote: > > > In D63171#1539049 , @aprantl wrote: > > > > > I suppose one could com

[Lldb-commits] [PATCH] D63165: Initial support for native debugging of x86/x64 Windows processes

labath added a reviewer: amccarth. labath added a comment. I take it that D63166 is a prerequisite for this patch. Is that all, or is there something else that we ought to look at first? Overall, this patch is slightly larger that would be ideal for a proper re

[Lldb-commits] [PATCH] D63166: Move common functionality from processwindows into processdebugger

labath added a reviewer: amccarth. labath added a subscriber: amccarth. labath added a comment. Given that you're just moving code around, this should be fine, but I am including @amccarth, as I believe he is more familiar with this code. The thing I would consider in your place is whether putti

[Lldb-commits] [PATCH] D63187: [LLDB] Fix FreeBSD build

This revision was automatically updated to reflect the committed changes. Closed by commit rL363135: [LLDB] Fix FreeBSD build (authored by devnexen, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D63187?vs

[Lldb-commits] [lldb] r363135 - [LLDB] Fix FreeBSD build

Author: devnexen Date: Wed Jun 12 01:54:14 2019 New Revision: 363135 URL: http://llvm.org/viewvc/llvm-project?rev=363135&view=rev Log: [LLDB] Fix FreeBSD build The auxiliary vector method had the wrong signature. Reviewers: MaskRay, teemperor, aadsm Reviewed By: MaskRay, teemperor Differential

[Lldb-commits] [PATCH] D63187: [LLDB] Fix FreeBSD build

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63187/new/ https://reviews.llvm.org/D63187 ___ lldb-

[Lldb-commits] [PATCH] D63187: [LLDB] Fix FreeBSD build

devnexen created this revision. devnexen added reviewers: aadsm, MaskRay. devnexen created this object with visibility "All Users". Herald added subscribers: lldb-commits, emaste. Herald added a project: LLDB. The auxiliary vector method had wrong signature. Repository: rLLDB LLDB https://rev