labath added a reviewer: amccarth.
labath added a subscriber: amccarth.
labath added a comment.
Given that you're just moving code around, this should be fine, but I am
including @amccarth, as I believe he is more familiar with this code.
The thing I would consider in your place is whether putting this into a
separate class is enough, or if you want to put it into a separate
module/subfolder as well. The reason for that is that if this is in the same
module as the liblldb stuff, then you will still end up pulling the all the
transitive deps into lldb-server. If you put that into a separate module then
you can control the dependencies more precisely. I don't think this is that
important, since hopefully the local codepath (along with the deps) will
disappear once lldb-server starts to work, but you know.. temporary solutions
have a tendency for becoming permanent... Anyway, I'll leave the decision up to
you..
================
Comment at: source/Plugins/Process/Windows/Common/ProcessDebugger.cpp:32
+
+namespace {
+DWORD ConvertLldbToWinApiProtect(uint32_t protect) {
----------------
llvm prefers static functions over those in anonymous namespaces
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63166/new/
https://reviews.llvm.org/D63166
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
