[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

labath resigned from this revision. labath added a comment. Alex and Stefan are the standalone build experts these days, so I'll let them do the reviewing here. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58193/new/ https://reviews.llvm.org/D58193 ___

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

labath added a comment. Looks good to me now. I think that, for completeness, you ought to add the DYLD plugin to the list of dependencies for in the CMakeLists.txt for ProcessWindows. Thanks for putting up with me. Comment at: source/Plugins/Process/Windows/Common/ProcessWin

[Lldb-commits] [lldb] r354010 - [lldb-server] Add remote platform capabilities for Windows

Author: asmith Date: Wed Feb 13 21:34:46 2019 New Revision: 354010 URL: http://llvm.org/viewvc/llvm-project?rev=354010&view=rev Log: [lldb-server] Add remote platform capabilities for Windows Summary: Implement a few routines for Windows to support some basic process interaction and file system

[Lldb-commits] [PATCH] D56237: Implement GetLoadAddress for the Windows process plugin

asmith updated this revision to Diff 186796. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56237/new/ https://reviews.llvm.org/D56237 Files: source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.cpp source/Plugins/DynamicLoader/Windows-DYLD/DynamicLoaderWindowsDYLD.h s

[Lldb-commits] [PATCH] D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance.

JDevlieghere created this revision. JDevlieghere added reviewers: shafik, teemperor, clayborg. JDevlieghere added a project: LLDB. Herald added a subscriber: jdoerfert. I was looking at the ClangExpressionParser and noticed that we have a FileManager owned by the expression parser and later ask t

[Lldb-commits] [PATCH] D58222: [ClangExpressionParser] Reuse the FileManager from the compiler instance.

JDevlieghere updated this revision to Diff 186794. JDevlieghere added a comment. Keep/move the comment in the right place. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58222/new/ https://reviews.llvm.org/D58222 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.

[Lldb-commits] [PATCH] D58219: [dotest] Fix compiler version number comparison

friss updated this revision to Diff 186782. friss added a comment. Use LooseVersion as suggested by Zachary CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58219/new/ https://reviews.llvm.org/D58219 Files: packages/Python/lldbsuite/test/lldbtest.py Index: packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D57402: build: remove custom variables

compnerd updated this revision to Diff 186780. compnerd added a comment. Add HINTS Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57402/new/ https://reviews.llvm.org/D57402 Files: cmake/modules/LLDBStandalone.cmake Index: cmake/modules/LLDBStandalone.cmake

Re: [Lldb-commits] [PATCH] D58219: [dotest] Fix compiler version number comparison

Try `import distutils.LooseVersion` and use that to do the comparison. On Wed, Feb 13, 2019 at 4:49 PM Frederic Riss via Phabricator < revi...@reviews.llvm.org> wrote: > friss created this revision. > friss added reviewers: zturner, labath. > Herald added a reviewer: serge-sans-paille. > Herald ad

[Lldb-commits] [PATCH] D58219: [dotest] Fix compiler version number comparison

friss created this revision. friss added reviewers: zturner, labath. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. dotest's version comparision function is just a lexicographical compare of the version strings. This is obviously wrong. This patch implements a nu

[Lldb-commits] [lldb] r353979 - Add missing include

Author: adrian Date: Wed Feb 13 12:52:41 2019 New Revision: 353979 URL: http://llvm.org/viewvc/llvm-project?rev=353979&view=rev Log: Add missing include Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h Modified: lldb/trunk/include/lldb/Symbol/CompileUnit.h URL: http://llvm.org/viewvc/

[Lldb-commits] [lldb] r353978 - [CMake] Make lldb-test-deps a dependency of check-lldb

Author: jdevlieghere Date: Wed Feb 13 12:51:13 2019 New Revision: 353978 URL: http://llvm.org/viewvc/llvm-project?rev=353978&view=rev Log: [CMake] Make lldb-test-deps a dependency of check-lldb We have a custom target for lldb's test dependencies but it must have gotten lost in one of the recent

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

xiaobai added a reviewer: sgraenitz. xiaobai added a comment. I think you might need to rebase this patch because D57233 seems to accomplish part of what this patch does, but I don't see those changes here. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just a question of if we need an optional unwind table instance instead of just an instance. I am fine either way. Comment at: include/lldb/Core/Module.h:1108-1110 + ll

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

clayborg added inline comments. Comment at: include/lldb/Host/UserIDResolver.h:24 +public: + typedef uint32_t id_t; + virtual ~UserIDResolver(); // anchor make this 64 bit for future proofing? And if so, just use lldb::user_id_t? Comment at:

[Lldb-commits] [PATCH] D58090: Deserialize Clang module search path from DWARF

aprantl added a comment. I attempted to fix it in r353971, but I'm not sure. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58090/new/ https://reviews.llvm.org/D58090 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] r353971 - Add missing include

Author: adrian Date: Wed Feb 13 11:29:22 2019 New Revision: 353971 URL: http://llvm.org/viewvc/llvm-project?rev=353971&view=rev Log: Add missing include Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.h Modified: lldb/trunk/source/Plugins/ExpressionParser/C

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

jingham added a comment. You are using a mix of llvm & lldb naming conventions for local variables and arguments and the ivars of UserIDResolver (lots of "Uid", etc...) Probably better to stick with the lldb convention. Other than that it looks good to me. Comment at: sour

[Lldb-commits] [PATCH] D57402: build: remove custom variables

compnerd added a comment. @labath - absolutely, that I don't have a problem with. I think that having the additional LLDB specific paths with `LLDB_PATH_TO_*` is better done by using the standard CMake mechanisms. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[Lldb-commits] [PATCH] D58090: Deserialize Clang module search path from DWARF

stella.stamenova added a comment. This looks to have broken the windows build: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/1665 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58090/new/ https://reviews.llvm.org/D58090

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

stella.stamenova requested changes to this revision. stella.stamenova added inline comments. This revision now requires changes to proceed. Comment at: packages/Python/lldbsuite/support/seven.py:28 + +def bytes_to_string(b): +"""Take a string(PY2) or a bytes(PY3) object and r

[Lldb-commits] [PATCH] D58090: Deserialize Clang module search path from DWARF

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB353961: Deserialize Clang module search path from DWARF (authored by adrian, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D58090?vs=186571&id=186691

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58177/new/ https://reviews.llvm.org/D58177 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] r353961 - Deserialize Clang module search path from DWARF

Author: adrian Date: Wed Feb 13 10:10:41 2019 New Revision: 353961 URL: http://llvm.org/viewvc/llvm-project?rev=353961&view=rev Log: Deserialize Clang module search path from DWARF This patch properly extracts the full submodule path as well as its search paths from DWARF import decls and passes

[Lldb-commits] [PATCH] D58193: Do not explicitly depend on llvm tools during standalone build

serge-sans-paille created this revision. serge-sans-paille added a reviewer: labath. Herald added subscribers: lldb-commits, mgorny. Herald added a reviewer: alexshap. Herald added a project: LLDB. When building lldb in standalone mode, the llvm-nm, llvm-objdump etc target are not available, so o

[Lldb-commits] [PATCH] D58090: Deserialize Clang module search path from DWARF

aprantl added a comment. I think the problem was that I had an incompletely built libcxx in my build directory. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58090/new/ https://reviews.llvm.org/D58090 ___ lldb-commits mailing list lldb-com

Re: [Lldb-commits] [lldb] r353778 - Define _ENABLE_EXTENDED_ALIGNED_STORAGE on Windows.

Hi Pavel, I think the offending struct is XSAVE in RegisterContext_x86.h. I don't really know this code, would you mind having a look? It looks like you touched the alignment in the past and seems to know what this this is doing :-) tree f8fc1af1c62b728260b6c950649c55f7aba513f6 parent 68576926879

[Lldb-commits] [PATCH] D58172: Embed swig version into lldb.py in a different way

labath updated this revision to Diff 186676. labath added a comment. Include a basic test for this functionality I forgot to add CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58172/new/ https://reviews.llvm.org/D58172 Files: packages/Python/lldbsuite/test/python_api/lldbutil/TestSwig

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

serge-sans-paille added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:415 # Add zero-fill to the right/end (MSB side) of the value. -retval += "00" * (byte_size - len(retval) / 2) +retval

[Lldb-commits] [PATCH] D58177: Fix lldb-server test suite for python3

labath created this revision. labath added reviewers: davide, zturner. Herald added a reviewer: serge-sans-paille. This patch finishes the python3-ification of the lldb-server test suite. It reverts the partial attempt in r352709 to encode/decode the string via utf8 before writing to the socket. T

[Lldb-commits] [lldb] r353945 - Revert "Fix one more string/bytes issue in lldb-server tests"

Author: labath Date: Wed Feb 13 05:06:37 2019 New Revision: 353945 URL: http://llvm.org/viewvc/llvm-project?rev=353945&view=rev Log: Revert "Fix one more string/bytes issue in lldb-server tests" It looks like I was too hasty to submit the previous patch. It does fix some tests on python3, but it

[Lldb-commits] [lldb] r353944 - Fix one more string/bytes issue in lldb-server tests

Author: labath Date: Wed Feb 13 04:54:59 2019 New Revision: 353944 URL: http://llvm.org/viewvc/llvm-project?rev=353944&view=rev Log: Fix one more string/bytes issue in lldb-server tests This fixes about a dozen tests with python3. Modified: lldb/trunk/packages/Python/lldbsuite/test/tools/ll

[Lldb-commits] [PATCH] D58172: Embed swig version into lldb.py in a different way

labath created this revision. labath added reviewers: zturner, jingham. Herald added a reviewer: serge-sans-paille. Herald added a subscriber: jdoerfert. Instead of doing string chopping on the resulting python file, get swig to output the version for us. The two things which make slightly non-tri

[Lldb-commits] [PATCH] D58167: Refactor user/group name resolving code

labath created this revision. labath added reviewers: zturner, clayborg, jingham. Herald added a subscriber: mgorny. This creates an abstract base class called "UserIDResolver", which can be implemented to provide user/group ID resolution capabilities for various objects. Posix host implement a Po

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

labath marked an inline comment as done. labath added inline comments. Comment at: include/lldb/Core/Module.h:709 + //-- + UnwindTable *GetUnwindTable(); + clayborg wrote: > I would vote to return

[Lldb-commits] [PATCH] D58129: Move UnwindTable from ObjectFile to Module

labath updated this revision to Diff 186599. labath added a comment. Herald added a subscriber: jdoerfert. Changed Module::GetUnwindTable to return a referece. I also changed the UnwindTable to internally store a Module& (instead of ObjectFile&), to make sure it always has something to hold on to.

[Lldb-commits] [PATCH] D57995: [lldb] [cmake] Use install directories for LLVM_* variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL353925: [lldb] [cmake] Use install directories for LLVM_* variables (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[Lldb-commits] [lldb] r353925 - [lldb] [cmake] Use install directories for LLVM_* variables

Author: mgorny Date: Wed Feb 13 00:34:46 2019 New Revision: 353925 URL: http://llvm.org/viewvc/llvm-project?rev=353925&view=rev Log: [lldb] [cmake] Use install directories for LLVM_* variables Restore the previous behavior of using install directories for LLVM_MAIN_INCLUDE_DIR, LLVM_LIBRARY_DIR a