[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 184874. JDevlieghere added a comment. - Move framework in Utility - Update tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56322/new/ https://reviews.llvm.org/D56322 Files: include/lldb/API/SBReproducer.h include/lldb/Utility/Reproduce

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

clayborg added inline comments. Comment at: source/Target/PathMappingList.cpp:223 + + if (prefix_ref == ".") { +prefix_is_relative = true; We are we finding a "." in any path now? I thought we normalized those all out? Can a PathMappingList co

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere added a comment. In D56322#1381254 , @labath wrote: > In D56322#1380996 , @JDevlieghere > wrote: > > > In D56322#1380442 , @labath wrote: > > > > > I have a lot

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere updated this revision to Diff 184825. JDevlieghere marked 27 inline comments as done. JDevlieghere added a comment. Address Pavel's inline comments, modulo - Fixing the ODR violation (should be easier to verify inline comments are addressed before moving the code). - Fixing the endi

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere added inline comments. Comment at: source/API/SBReproducerPrivate.h:82-93 +/// Base class for tag dispatch used in the SBDeserializer. Different tags are +/// instantiated with different values. +template struct SBTag {}; + +/// We need to differentiate between poin

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. In D56322#1380996 , @JDevlieghere wrote: > In D56322#1380442 , @labath wrote: > > > I have a lot of comments. The two major ones are: > > > > - i think the way you link the tests is in the U

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

ted added a comment. In D57552#1381126 , @jingham wrote: > That sounds like it will have to be fixed somewhere else, and not part of > this patch then. Can you file a bug to get that fixed? Yeah, it's on my todo list. Which keeps growing! CHANGES SIN

[Lldb-commits] [lldb] r352902 - Fix the xcode build for r352845, attempt #2

Author: stefan.graenitz Date: Fri Feb 1 11:31:02 2019 New Revision: 352902 URL: http://llvm.org/viewvc/llvm-project?rev=352902&view=rev Log: Fix the xcode build for r352845, attempt #2 Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj UR

[Lldb-commits] [lldb] r352901 - Revert "Fix the xcode build for r352845."

Author: stefan.graenitz Date: Fri Feb 1 11:30:57 2019 New Revision: 352901 URL: http://llvm.org/viewvc/llvm-project?rev=352901&view=rev Log: Revert "Fix the xcode build for r352845." This reverts commit 72c1213a5e901b80c0f1d2794e5088d7f71a3632. Modified: lldb/trunk/lldb.xcodeproj/project.pb

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

This revision was automatically updated to reflect the committed changes. Closed by commit rL352899: [lldb] Relax libc++ ABI version checking (authored by thomasanderson, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57466?vs=184418&id=184798#t

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham added a comment. In D57552#1381094 , @ted wrote: > In D57552#1381046 , @jingham wrote: > > > In D57552#1380782 , @ted wrote: > > > > > FYI, @jingham , this is also an

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham marked 5 inline comments as done. jingham added a comment. Sure, that's clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D57552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham updated this revision to Diff 184790. jingham added a comment. Implemented Zachary's suggestions. Also added the source file sub-directory so the test will pass on other people's machines... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D5755

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

ted added a comment. In D57552#1381046 , @jingham wrote: > In D57552#1380782 , @ted wrote: > > > FYI, @jingham , this is also an issue with DYLD plugins, if the file in the > > link map starts with ".". "image sear

[Lldb-commits] [lldb] r352894 - Fix the xcode build for r352845.

Author: jingham Date: Fri Feb 1 10:26:08 2019 New Revision: 352894 URL: http://llvm.org/viewvc/llvm-project?rev=352894&view=rev Log: Fix the xcode build for r352845. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

zturner added inline comments. Comment at: source/Target/PathMappingList.cpp:204 FileSpec &new_spec) const { if (!m_pairs.empty()) { +std::string orig_path = orig_spec.GetPath(); Can we put some early returns in here? ``` n

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham marked 2 inline comments as done. jingham added a comment. In D57552#1380782 , @ted wrote: > FYI, @jingham , this is also an issue with DYLD plugins, if the file in the > link map starts with ".". "image search-paths add . /path/to/my/libraries"

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham marked 5 inline comments as done. jingham added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/source-map/TestTargetSourceMap.py:32-34 +#bp = target.BreakpointCreateByLocation(src_path, 2) +#self.assertTrue(bp.GetNumLocations(

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

jingham updated this revision to Diff 184784. jingham added a comment. Fixed some inadvertently commented out test code (test still passes...) Applied Pavel's suggestions (thanks!) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.or

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

JDevlieghere added a comment. In D56322#1380442 , @labath wrote: > I have a lot of comments. The two major ones are: > > - i think the way you link the tests is in the UB territory. I explain this > in detail in one of the inline comments. Thanks, you'r

[Lldb-commits] [PATCH] D55332: [CMake] Python bindings generation polishing

ted added a comment. Herald added a project: LLDB. @sgraenitz I've found an issue with this patch, using the Visual Studio 2015 generator. In scripts/CMakeLists.txt the old code (for Windows): if (CMAKE_CONFIGURATION_TYPES) set(SWIG_PYTHON_DIR ${CMAKE_BINARY_DIR}/\${CMAKE_INSTALL_CONFIG_

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

ted added a comment. FYI, @jingham , this is also an issue with DYLD plugins, if the file in the link map starts with ".". Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57552/new/ https://reviews.llvm.org/D57552 _

[Lldb-commits] [PATCH] D57552: Handle "." in target.source-map in PathMapListing::FindFiles

labath added inline comments. Herald added a subscriber: lldb-commits. Comment at: packages/Python/lldbsuite/test/functionalities/source-map/TestTargetSourceMap.py:32-34 +#bp = target.BreakpointCreateByLocation(src_path, 2) +#self.assertTrue(bp.GetNumLocations()

[Lldb-commits] [PATCH] D57466: [lldb] Relax libc++ ABI version checking

labath accepted this revision. labath added a comment. Yes, I suppose it is :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57466/new/ https://reviews.llvm.org/D57466 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D56322: [Reproducers] SBReproducer framework

labath added a comment. I have a lot of comments. The two major ones are: - i think the way you link the tests is in the UB territory. I explain this in detail in one of the inline comments. - I believe that your unit tests (not just in this patch) focus too much on testing the behavior of a si

[Lldb-commits] [lldb] r352858 - [PDB] Fix build after r352845

Author: aleksandr.urakov Date: Fri Feb 1 03:10:28 2019 New Revision: 352858 URL: http://llvm.org/viewvc/llvm-project?rev=352858&view=rev Log: [PDB] Fix build after r352845 Modified: lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbUtil.cpp Modified: lldb/trunk/source/Plugins/SymbolFile/Nat

[Lldb-commits] [PATCH] D55122: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME

This revision was automatically updated to reflect the committed changes. Closed by commit rL352845: [PDB] Fix location retrieval for function local variables and arguments that are (authored by aleksandr.urakov, committed by ). Herald added a project: LLVM. Changed prior to commit: https://rev

[Lldb-commits] [lldb] r352845 - [PDB] Fix location retrieval for function local variables and arguments that are

Author: aleksandr.urakov Date: Fri Feb 1 02:01:18 2019 New Revision: 352845 URL: http://llvm.org/viewvc/llvm-project?rev=352845&view=rev Log: [PDB] Fix location retrieval for function local variables and arguments that are stored relative to VFRAME Summary: This patch makes LLDB able to retrieve