ted added a comment.
Herald added a project: LLDB.
@sgraenitz I've found an issue with this patch, using the Visual Studio 2015
generator.
In scripts/CMakeLists.txt the old code (for Windows):
if (CMAKE_CONFIGURATION_TYPES)
set(SWIG_PYTHON_DIR
${CMAKE_BINARY_DIR}/\${CMAKE_INSTALL_CONFIG_NAME}/lib${LLVM_LIBDIR_SUFFIX}/site-packages)
else()
set(SWIG_PYTHON_DIR
${CMAKE_BINARY_DIR}/lib${LLVM_LIBDIR_SUFFIX}/site-packages)
endif()
Was changed to (for everything):
set(SWIG_PYTHON_DIR ${LLVM_LIBRARY_OUTPUT_INTDIR}/${swig_python_subdir})
Which changes <build>/tools/lldb/scripts/cmake_install.cmake from
if("${CMAKE_INSTALL_COMPONENT}" STREQUAL "Unspecified" OR NOT
CMAKE_INSTALL_COMPONENT)
file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/lib" TYPE DIRECTORY FILES
"i:/obj/${CMAKE_INSTALL_CONFIG_NAME}/lib/site-packages")
endif()
to
if("${CMAKE_INSTALL_COMPONENT}" STREQUAL "Unspecified" OR NOT
CMAKE_INSTALL_COMPONENT)
file(INSTALL DESTINATION "${CMAKE_INSTALL_PREFIX}/lib" TYPE DIRECTORY FILES
"I:/obj/$(Configuration)/lib/site-packages")
endif()
"$(Configuration)" is a Visual Studio variable, and not available to cmake, so
our bots error out with this error:
CMake Error at tools/lldb/scripts/cmake_install.cmake:31 (file):
file INSTALL cannot find "I:/obj/$(Configuration)/lib/site-packages".
Call Stack (most recent call first):
tools/lldb/cmake_install.cmake:41 (include)
tools/cmake_install.cmake:41 (include)
cmake_install.cmake:45 (include)
Verified with the latest CMake (3.13.3).
Will switching back to the old code for Windows cause any issues?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55332/new/
https://reviews.llvm.org/D55332
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
