[Lldb-commits] [PATCH] D56822: [WIP] Tool to insert SBReproducer macros

JDevlieghere created this revision. Herald added subscribers: teemperor, mgorny. Simple tool to automate/simplify the workflow of inserting SB_RECORD and SB_REGSITER macros. Because the tool won't be part of the build process I don't wan't to over-complicate it. Currently it prints a list of SB

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

JDevlieghere updated this revision to Diff 182158. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Feedback + Rebase on D56814 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/ https://reviews.llvm.org/D54617 Files:

[Lldb-commits] [PATCH] D56814: [Reproducers] Refactor reproducer info

JDevlieghere created this revision. JDevlieghere added reviewers: labath, davide. Herald added subscribers: abidh, mgrang. In the original reproducer design, I expected providers to be more dynamic than they turned out. For example, we don't have any instances where one provider has multiple fil

[Lldb-commits] [lldb] r351385 - XFAIL test on Windows

Author: adrian Date: Wed Jan 16 14:07:21 2019 New Revision: 351385 URL: http://llvm.org/viewvc/llvm-project?rev=351385&view=rev Log: XFAIL test on Windows http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/677/steps/test/logs/stdio Modified: lldb/trunk/packages/Python/lldbsuite

[Lldb-commits] [PATCH] D56798: Change TypeSystem::GetBitSize() to return an optional result.

stella.stamenova added a comment. TestFunctionRefs is failing on the Windows bot: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/677 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56798/new/ https://reviews.llvm.org/D56798 _

[Lldb-commits] [PATCH] D56798: Change TypeSystem::GetBitSize() to return an optional result.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351376: Change TypeSystem::GetBitSize() to return an optional result. (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D567

[Lldb-commits] [lldb] r351376 - Change TypeSystem::GetBitSize() to return an optional result.

Author: adrian Date: Wed Jan 16 13:19:20 2019 New Revision: 351376 URL: http://llvm.org/viewvc/llvm-project?rev=351376&view=rev Log: Change TypeSystem::GetBitSize() to return an optional result. This patch changes the behavior when printing C++ function references: where we previously would get a

[Lldb-commits] [PATCH] D56763: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds

xiaobai updated this revision to Diff 182131. xiaobai added a comment. Modified unittests/CMakeLists.txt to reflect this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56763/new/ https://reviews.llvm.org/D56763 Files: tools/debugserver/source/CMakeLists.txt unittests/CMakeLi

[Lldb-commits] [PATCH] D56798: Change TypeSystem::GetBitSize() to return an optional result.

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. The new "error" message definitely makes more sense. The rest of the patch seems fine too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56798/new/ https://reviews.llvm.org/D56798

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

labath added inline comments. Comment at: source/Host/common/FileSystem.cpp:48 -void FileSystem::Initialize() { +llvm::Error FileSystem::Initialize() { lldbassert(!InstanceImpl() && "Already initialized."); Would it be possible to have the overloads which al

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

I posted a patch that should fix this in https://reviews.llvm.org/D56798 . thanks for your feedback! -- adrian ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D56798: Change TypeSystem::GetBitSize() to return an optional result.

aprantl created this revision. aprantl added reviewers: labath, zturner, jingham, shafik. Herald added a reviewer: serge-sans-paille. This patch changes the behavior when printing C++ function references: where we previously would get a ``, there is now a ``. It's not clear to me whether this is

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

JDevlieghere planned changes to this revision. JDevlieghere added a comment. I'll add a more specific test for the collector. Comment at: source/Host/common/FileSystem.cpp:443 + + // If VFS mapped we know the underlying FS is a RedirectingFileSystem. + ErrorOr E = ---

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

JDevlieghere updated this revision to Diff 182090. JDevlieghere marked 6 inline comments as done. JDevlieghere added a comment. Address Pavel's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54617/new/ https://reviews.llvm.org/D54617 Files: include/lldb/Host/FileSystem.h i

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Note that the PDB code runs on all platforms, not just Windows. You can reproduce it by just running the affected test on darwin, as long as you've built lld. On Wed, Jan 16, 2019 at 8:50 AM Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > On 16/01/2019 17:38, Adrian Prantl

Re: [Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

On 16/01/2019 18:16, Stella Stamenova via Phabricator wrote: stella.stamenova added a comment. The Windows Buildbot is failing because of one of the tests (SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s) added in this change. You can see the failure here: http://lab.llvm.org:8011/

[Lldb-commits] [lldb] r351359 - Fix dir-separator-no-comp-dir-relative-name.s test added in r351328

Author: labath Date: Wed Jan 16 09:39:06 2019 New Revision: 351359 URL: http://llvm.org/viewvc/llvm-project?rev=351359&view=rev Log: Fix dir-separator-no-comp-dir-relative-name.s test added in r351328 In this test we have deliberately removed all information which may hint at the correct path sty

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

stella.stamenova added a comment. The Windows Buildbot is failing because of one of the tests (SymbolFile/DWARF/dir-separator-no-comp-dir-relative-name.s) added in this change. You can see the failure here: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/666. It looks like it i

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

On 16/01/2019 17:38, Adrian Prantl wrote: On Darwin I'm getting an also very misleading (lldb) target var ref (void (&)(bool)) ref = 0x00010920 (&::ref = ) Wait, no. I reverted the wrong patch:-( I get vs . I assume that's what's happening on Windows, too. If that's the case I should

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

> On Jan 16, 2019, at 8:36 AM, Adrian Prantl via lldb-commits > wrote: > >> >> On Jan 16, 2019, at 4:22 AM, Pavel Labath wrote: >> >> Hi Adrian, Zachary, >> >> this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test >>

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

> On Jan 16, 2019, at 4:22 AM, Pavel Labath wrote: > > Hi Adrian, Zachary, > > this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test > . This > is due do a slight behavioral change where previously thi

Re: [Lldb-commits] [PATCH] D56589: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

On 16/01/2019 17:07, Adrian Prantl via Phabricator wrote: aprantl added a comment. Looks like this test is failing on green dragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/17221/consoleFull#-97272088254eaf0-7326-4999-85b0-388101f2d404 Ooops. I reverted this in r351353. I'll i

[Lldb-commits] [lldb] r351353 - Revert "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()"

Author: labath Date: Wed Jan 16 08:09:13 2019 New Revision: 351353 URL: http://llvm.org/viewvc/llvm-project?rev=351353&view=rev Log: Revert "Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()" This reverts commit r351330 due to failures on MacOS bots. Removed: lldb/tr

[Lldb-commits] [PATCH] D56589: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

aprantl added a comment. Looks like this test is failing on green dragon: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/17221/consoleFull#-97272088254eaf0-7326-4999-85b0-388101f2d404 FAIL: LLDB :: SymbolFile/Breakpad/symtab-macho.test (126 of 1452) TEST 'LLDB

[Lldb-commits] [PATCH] D56763: [CMake] Prevent lldbDebugserverCommon from building if you disable debugserver builds

sgraenitz added a comment. Yes this sounds very reasonable. One little detail is, that on Darwin the `debugserverTests` unit test target depends on `lldbDebugserverCommon`. In `unittests/CMakeLists.txt` it's included `if(LLDB_CAN_USE_DEBUGSERVER)`, which should be changed to `if(NOT SKIP_TEST_D

Re: [Lldb-commits] [lldb] r351327 - Revert "Simplify Value::GetValueByteSize()"

Merged to the 8 branch in r351342. On Wed, Jan 16, 2019 at 1:23 PM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Jan 16 04:19:22 2019 > New Revision: 351327 > > URL: http://llvm.org/viewvc/llvm-project?rev=351327&view=rev > Log: > Revert "Simplify Value::GetValueByteSize()"

[Lldb-commits] [PATCH] D56589: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB351330: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec() (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D56589?vs=181243&id=182013#toc

[Lldb-commits] [lldb] r351331 - TestClangASTContext: Rewrite an if-else chain into a switch

Author: labath Date: Wed Jan 16 04:43:01 2019 New Revision: 351331 URL: http://llvm.org/viewvc/llvm-project?rev=351331&view=rev Log: TestClangASTContext: Rewrite an if-else chain into a switch This avoids the "ambiguous else" warning, which comes from within the EXPECT_TRUE macro. Modified:

[Lldb-commits] [lldb] r351330 - Teach the default symbol vendor to respect module.GetSymbolFileFileSpec()

Author: labath Date: Wed Jan 16 04:42:57 2019 New Revision: 351330 URL: http://llvm.org/viewvc/llvm-project?rev=351330&view=rev Log: Teach the default symbol vendor to respect module.GetSymbolFileFileSpec() Summary: Adding a breakpad symbol file to an existing MachO module with "target symbols ad

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB351328: DWARF: Add some support for non-native directory separators (authored by labath, committed by ). Changed prior to commit: https://reviews.llvm.org/D56543?vs=182010&id=182011#toc Repository:

[Lldb-commits] [lldb] r351328 - DWARF: Add some support for non-native directory separators

Author: labath Date: Wed Jan 16 04:30:41 2019 New Revision: 351328 URL: http://llvm.org/viewvc/llvm-project?rev=351328&view=rev Log: DWARF: Add some support for non-native directory separators Summary: If we opened a file which was produced on system with different path syntax, we would parse the

[Lldb-commits] [PATCH] D56543: DWARF: Add some support for non-native directory separators

labath updated this revision to Diff 182010. labath added a comment. - add a test for the no-DW_AT_comp_dir + relative-DW_AT_name case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56543/new/ https://reviews.llvm.org/D56543 Files: include/lldb/Utility/FileSpec.h lit/SymbolFile/DWAR

[Lldb-commits] [lldb] r351327 - Revert "Simplify Value::GetValueByteSize()"

Author: labath Date: Wed Jan 16 04:19:22 2019 New Revision: 351327 URL: http://llvm.org/viewvc/llvm-project?rev=351327&view=rev Log: Revert "Simplify Value::GetValueByteSize()" This reverts commit r351250 because it breaks the SymbolFile/NativePDB/function-types-builtins.cpp. Modified: lldb/

Re: [Lldb-commits] [lldb] r351250 - Simplify Value::GetValueByteSize()

Hi Adrian, Zachary, this commit breaks the SymbolFile/NativePDB/function-types-builtins.cpp test . This is due do a slight behavioral change where previously this function would consider a value 0 from GetByteSize to be fail

[Lldb-commits] [PATCH] D54617: [Reproducers] Add file provider

labath added a comment. Overall, I think the patch is pretty good. I made a bunch of inline suggestions/questions/comments, but they're all fairly minor. From a high-level view the two comments I have are: - I am slightly concerned about the non-temporality of this approach. Lldb does a fair a

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

This revision was automatically updated to reflect the committed changes. Closed by commit rL351313: [lldb] - Fix crash when listing the history with the key up. (authored by grimar, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D5601

[Lldb-commits] [PATCH] D56014: [lldb] - Fix crash when listing the history with the key up.

grimar added a comment. In D56014#1358769 , @JDevlieghere wrote: > Although I don't want to condone checking things in without a test case, > given that the fix is obvious and that testing it is non-trivial, I think > it's fine to check this in as is.

[Lldb-commits] [lldb] r351313 - [lldb] - Fix crash when listing the history with the key up.

Author: grimar Date: Wed Jan 16 01:27:04 2019 New Revision: 351313 URL: http://llvm.org/viewvc/llvm-project?rev=351313&view=rev Log: [lldb] - Fix crash when listing the history with the key up. This is https://bugs.llvm.org/show_bug.cgi?id=40112, Currently, lldb crashes after pressing the up arr