sgraenitz added a comment. Yes this sounds very reasonable.
One little detail is, that on Darwin the `debugserverTests` unit test target depends on `lldbDebugserverCommon`. In `unittests/CMakeLists.txt` it's included `if(LLDB_CAN_USE_DEBUGSERVER)`, which should be changed to `if(NOT SKIP_TEST_DEBUGSERVER)` now. IIUC this would make sense anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56763/new/ https://reviews.llvm.org/D56763 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits