On 02/01/2019 18:32, Zachary Turner wrote:
Just to be sure, this new test will fail without your Symtab changes
right? I'm not in a state where I can look at code right now, and you
say anything that symbolicates an address *can* use the symtab, but I
don't know if you really meant *must* use
labath added inline comments.
Comment at:
lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py:132
self.fail("Failed to stop at breakpoint 1.")
+self.await_token(exe)
Will this actually help? It could be I'm missing someth
zturner added a comment.
Should we use the GUID from the COFF Debug Directory instead? It certainly
seems more appropriate, if it's there. The UUID's purpose is to match symbol
to the executable, so if you use a hash of the path it might solve this one
problem, but won't solve the general cas
zturner added a comment.
We should probably have a test for this. It sounds like all you need to do to
test this is create a target, set a breakpoint, run the process, then verify
that you see some text that says the breakpoint was resolved. With the new
build.py script this should be able to
Very excited to see this. I'm technically on vacation so I might not be
able to review it immediately, but I'm looking forward to getting to it
soon.
On Wed, Jan 2, 2019 at 4:36 PM Aaron Smith via Phabricator <
revi...@reviews.llvm.org> wrote:
> asmith created this revision.
> asmith added revie
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added a subscriber: lldb-commits.
When a process is loaded, update its sections with the load address to resolve
any created breakpoints. For the remote debugging case, the debugged process is
launched remotely s
Author: asmith
Date: Wed Jan 2 16:54:08 2019
New Revision: 350281
URL: http://llvm.org/viewvc/llvm-project?rev=350281&view=rev
Log:
Check that a pointer is valid and fix a log message on Windows
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
Modified: lldb/tru
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added a subscriber: lldb-commits.
This adds unnamed pipe support in PipeWindows to support communication between
a debug server and child process.
Modify PipeWindows::CreateNew to support the creation of an unname
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added subscribers: lldb-commits, abidh, mgorny, srhines.
This is intended as a first step to make lldb-server work on Windows. Follow-up
changes to implement remote capabilities in PlatformWindows, launch gdbserve
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added a subscriber: lldb-commits.
Implement a few routines for Windows to support some basic process interaction
and file system operations.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D56232
Files:
so
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added subscribers: lldb-commits, abidh.
This commit contains the following changes:
- Rewrite vfile close/read/write packet handlers with portable routines from
lldb. This removes #if(s) and allows the handlers t
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added a subscriber: lldb-commits.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D56230
Files:
source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
Index: source/Plugins/Process/gdb-remote/GDBRemote
asmith created this revision.
asmith added reviewers: zturner, llvm-commits.
Herald added a subscriber: lldb-commits.
Provide an implementation of GetUUID() for remote debugging scenarios based on
the md5 of the object's path.
Include a simple lit test that checks the first 8 bytes of the UUID i
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB350274: Rearrange bitfield to allow for more space in
file_idx. (authored by adrian, committed by ).
Herald added a subscriber: abidh.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://revi
Author: adrian
Date: Wed Jan 2 15:37:54 2019
New Revision: 350274
URL: http://llvm.org/viewvc/llvm-project?rev=350274&view=rev
Log:
Rearrange bitfield to allow for more space in file_idx.
This is an alternate patch for the bug reported in
https://bugs.llvm.org/show_bug.cgi?id=39816 ("lldb doesn'
Author: jdevlieghere
Date: Wed Jan 2 14:38:16 2019
New Revision: 350267
URL: http://llvm.org/viewvc/llvm-project?rev=350267&view=rev
Log:
[Driver] Remove unused imports
Removes some unneeded includes from the driver.
Modified:
lldb/trunk/tools/driver/Driver.cpp
Modified: lldb/trunk/tools/d
Author: adrian
Date: Wed Jan 2 14:37:28 2019
New Revision: 350266
URL: http://llvm.org/viewvc/llvm-project?rev=350266&view=rev
Log:
Add file-based synching to places missed in r350247.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py
lldb/trunk/packages/Pyt
Author: adrian
Date: Wed Jan 2 14:23:51 2019
New Revision: 350264
URL: http://llvm.org/viewvc/llvm-project?rev=350264&view=rev
Log:
Remove Range.* from Xcode project
Modified:
lldb/trunk/lldb.xcodeproj/project.pbxproj
Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj
URL:
http://llvm.org
kubamracek created this revision.
kubamracek added a reviewer: jingham.
kubamracek added a project: LLDB.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D56221
Files:
include/lldb/Target/StackFrameRecognizer.h
packages/Python/lldbsuite/test/functionalities/frame-recognizer/TestFrameRecog
Author: zturner
Date: Wed Jan 2 13:04:22 2019
New Revision: 350262
URL: http://llvm.org/viewvc/llvm-project?rev=350262&view=rev
Log:
Try to fix Green Dragon bot.
It doesn't like this std::tie() for some reason, hopefuly this
fixes it.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB
aprantl created this revision.
aprantl added reviewers: JDevlieghere, clayborg, jasonmolenda.
aprantl added a reviewer: friss.
This is an alternate patch for the bug reported in
https://bugs.llvm.org/show_bug.cgi?id=39816 ("lldb doesn't show a file of line
entry for big project"). This limits th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350247: Add file-based synchronization to flaky test
(authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D56208?vs=179891&id=1
Author: adrian
Date: Wed Jan 2 11:06:22 2019
New Revision: 350247
URL: http://llvm.org/viewvc/llvm-project?rev=350247&view=rev
Log:
Add file-based synchronization to flaky test
TestQueues is failing randomly on green dragon and I suspect it is
because the enqueued threads haven't executed by the
Author: zturner
Date: Wed Jan 2 10:53:11 2019
New Revision: 350244
URL: http://llvm.org/viewvc/llvm-project?rev=350244&view=rev
Log:
Use map::insert instead of try_emplace.
try_emplace is C++17.
Modified:
lldb/trunk/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
Modified: lldb/trunk/sour
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Thanks Adrian, looks good.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56208/new/
https://reviews.llvm.org/D56208
___
lldb
aprantl created this revision.
aprantl added a reviewer: JDevlieghere.
TestQueues is failing randomly on green dragon and I suspect it is because the
enqueued threads haven't executed by the time we expect them.
https://reviews.llvm.org/D56208
Files:
packages/Python/lldbsuite/test/macosx/que
Author: zturner
Date: Wed Jan 2 10:33:54 2019
New Revision: 350243
URL: http://llvm.org/viewvc/llvm-project?rev=350243&view=rev
Log:
[NativePDB] Implement ParseDeclsForContext.
This is a first step towards getting lldb-test symbols working
with the native plugin. There is a remaining issue, whi
Author: zturner
Date: Wed Jan 2 10:33:32 2019
New Revision: 350242
URL: http://llvm.org/viewvc/llvm-project?rev=350242&view=rev
Log:
[NativePDB] Update function-types-classes test to check VarDecls.
A Previous patch added support for creating VarDecls for global
variables. This patch updates th
Author: zturner
Date: Wed Jan 2 10:32:50 2019
New Revision: 350240
URL: http://llvm.org/viewvc/llvm-project?rev=350240&view=rev
Log:
[NativePDB] Fix setting breakpoint by file and line.
There were several problems preventing this from working. The
first is that when the PDB had an absolute path
clayborg added inline comments.
Comment at: include/lldb/Core/RangeMap.h:636
-template class RangeDataArray
{
+template
+class RangeDataVector {
labath wrote:
> tberghammer wrote:
> > Would it make sense to have a default value of 0 for N so people don't hav
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56173/new/
https://reviews.llvm.org/D56173
___
lldb-commits mailing list
lldb-co
Just to be sure, this new test will fail without your Symtab changes
right? I'm not in a state where I can look at code right now, and you say
anything that symbolicates an address *can* use the symtab, but I don't
know if you really meant *must* use the symtab.
On Wed, Jan 2, 2019 at 12:19 AM Pa
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
Maybe add a unit test for the operator bool? Otherwise this LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56129/new/
https://reviews.llvm.org/D56129
_
labath marked 2 inline comments as done.
labath added inline comments.
Comment at: include/lldb/Core/RangeMap.h:636
-template class RangeDataArray
{
+template
+class RangeDataVector {
tberghammer wrote:
> Would it make sense to have a default value of 0 for
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
Comment at: include/lldb/Core/RangeMap.h:636
-template class RangeDataArray
{
+template
+class RangeDataVector {
Would it make sense to have a default value of 0 for N so people don't ha
Author: labath
Date: Wed Jan 2 02:37:38 2019
New Revision: 350209
URL: http://llvm.org/viewvc/llvm-project?rev=350209&view=rev
Log:
NativeProcessProtocolTest: fix -Winconsistent-missing-override warning
The warning comes from the fact that the MOCK_METHOD macros don't use the
override keyword in
labath marked an inline comment as done.
labath added inline comments.
Comment at: unittests/Core/RangeMapTest.cpp:52-54
+ // However, this does not always succeed.
+ // TODO: This should probably return the range (0, 40) as well.
+ EXPECT_THAT(Map.FindEntryThatContains(35), n
labath created this revision.
labath added reviewers: zturner, jingham, teemperor.
The target was being used in FinalizeFileActions to provide default
values for stdin/out/err. Also, most of the logic of this function was
very specific to how the lldb's Target class wants to launch processes,
so I
davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.
LG
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56170/new/
https://reviews.llvm.org/D56170
___
lldb-commits mailing list
lldb-commits@l
davide added inline comments.
Comment at: unittests/Core/RangeMapTest.cpp:52-54
+ // However, this does not always succeed.
+ // TODO: This should probably return the range (0, 40) as well.
+ EXPECT_THAT(Map.FindEntryThatContains(35), nullptr);
I think this is
labath updated this revision to Diff 179819.
labath added a comment.
Add some "image lookup" commands to the test. The test now goes through lldb
instead of lldb-test, but I've kept the lldb-test changes, as I think they make
sense regardless. The tricky part about the new test is the need to spec
41 matches
Mail list logo
