Very excited to see this. I'm technically on vacation so I might not be able to review it immediately, but I'm looking forward to getting to it soon.
On Wed, Jan 2, 2019 at 4:36 PM Aaron Smith via Phabricator < revi...@reviews.llvm.org> wrote: > asmith created this revision. > asmith added reviewers: zturner, llvm-commits. > Herald added subscribers: lldb-commits, abidh, mgorny, srhines. > > This is intended as a first step to make lldb-server work on Windows. > Follow-up changes to implement remote capabilities in PlatformWindows, > launch gdbserver, launch/attach processes using Windows APIs etc will come > in separate revisions. > > The changes in this commit include the following: > > - #ifdef what's not supported on Windows, for example signals > - Add a dummy 'waitpid' to the Windows PosixApi along with some > definitions that are needed for compilation. > - Setup WSAsocket connection in SystemInitializerLLGS::Initialize. > - Add a namespace to static function 'terminate()' in lldb-server.cpp > because its ambiguous with a Windows API. > - Better error handling in SocketAddress::GetAddressInfo. > - Clear the string before calling llvm::convertWideToUTF8 to avoid an > unexpected assertion. > > > Repository: > rLLDB LLDB > > https://reviews.llvm.org/D56233 > > Files: > cmake/modules/LLDBConfig.cmake > include/lldb/Host/windows/PosixApi.h > include/lldb/Target/Platform.h > source/Host/common/SocketAddress.cpp > source/Host/windows/HostInfoWindows.cpp > source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp > tools/lldb-server/SystemInitializerLLGS.cpp > tools/lldb-server/lldb-gdbserver.cpp > tools/lldb-server/lldb-platform.cpp > tools/lldb-server/lldb-server.cpp > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
