[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

labath added a comment. I'd go with the "conservative" approach first. The idea of having lldb loaded inside a lit process does not excite me. One of the problems we have with dotest is that when lldb crashes during the test, it takes a part of the test driver with it which causes some tests to

[Lldb-commits] [lldb] r347418 - Update call to EvaluateAsInt() to the new syntax.

Author: void Date: Wed Nov 21 12:44:38 2018 New Revision: 347418 URL: http://llvm.org/viewvc/llvm-project?rev=347418&view=rev Log: Update call to EvaluateAsInt() to the new syntax. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp U

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL347412: [lit] Add pthread to the compilation of the tests on Linux (authored by stella.stamenova, committed by ). Herald a

[Lldb-commits] [lldb] r347412 - [lit] Add pthread to the compilation of the tests on Linux

Author: stella.stamenova Date: Wed Nov 21 12:16:06 2018 New Revision: 347412 URL: http://llvm.org/viewvc/llvm-project?rev=347412&view=rev Log: [lit] Add pthread to the compilation of the tests on Linux Summary: Right now only some platforms add pthread to the compilation, however, at least one o

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

zturner added a subscriber: stella.stamenova. zturner added a comment. Lgtm Repository: rLLDB LLDB https://reviews.llvm.org/D54808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

Re: [Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

Lgtm On Wed, Nov 21, 2018 at 12:10 PM Stella Stamenova via Phabricator < revi...@reviews.llvm.org> wrote: > stella.stamenova created this revision. > stella.stamenova added reviewers: labath, zturner, asmith. > Herald added subscribers: lldb-commits, jfb. > > Right now only some platforms add pthr

[Lldb-commits] [PATCH] D54808: [lit] Add pthread to the compilation of the tests on Linux

stella.stamenova created this revision. stella.stamenova added reviewers: labath, zturner, asmith. Herald added subscribers: lldb-commits, jfb. Right now only some platforms add pthread to the compilation, however, at least one of the tests requires the pthread library on Linux as well. Since the

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

zturner added a comment. In https://reviews.llvm.org/D54731#1305183, @labath wrote: > I think that something like this would go a long way towards solving the > problems with lit tests we're having in lldb. > > However, the part that is not clear to me is whether it is actually necessary > to m

[Lldb-commits] [PATCH] D53759: [PDB] Support PDB-backed expressions evaluation

aleksandr.urakov added a comment. Ping! Can someone to have a look as well? https://reviews.llvm.org/D53759 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D53368: [Symbol] Search symbols with name and type in a symbol file

aleksandr.urakov updated this revision to Diff 174916. aleksandr.urakov added a comment. Update the patch, move symtab finalization back to object files. This patch makes object files and symbol files (in the case if they add symbols in a symtab) to be responsible for finalization of a symtab. I

[Lldb-commits] [PATCH] D54731: [lit] Enable the use of custom user-defined lit commands

labath added a comment. I think that something like this would go a long way towards solving the problems with lit tests we're having in lldb. However, the part that is not clear to me is whether it is actually necessary to modify lit (shtest) to achieve this. It seems to me an equivalent effec

[Lldb-commits] [lldb] r347391 - Revert 347365, its prerequisite 347364 got reverted.

Author: nico Date: Wed Nov 21 04:50:13 2018 New Revision: 347391 URL: http://llvm.org/viewvc/llvm-project?rev=347391&view=rev Log: Revert 347365, its prerequisite 347364 got reverted. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/ClangASTContext.cp