Author: davide
Date: Fri Sep 28 16:27:54 2018
New Revision: 343368
URL: http://llvm.org/viewvc/llvm-project?rev=343368&view=rev
Log:
[SBAPI/Target] Expose SetStatistics(bool enable)/GetStatistics().
Modified:
lldb/trunk/include/lldb/API/SBTarget.h
lldb/trunk/packages/Python/lldbsuite/t
jingham added a comment.
I agree with Zachary, converting to NativeProcess is enough of a project that
we should not block useful fixes to the current ProcessWindows plugin on it.
OTOH, it is a good project - somebody should add it to the Projects page.
https://reviews.llvm.org/D52618
Author: tkrasnukha
Date: Fri Sep 28 12:58:03 2018
New Revision: 343357
URL: http://llvm.org/viewvc/llvm-project?rev=343357&view=rev
Log:
[Driver] Remove unused declarations and "include" directives
Modified:
lldb/trunk/tools/driver/Driver.cpp
lldb/trunk/tools/driver/Driver.h
Modified: ll
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB343348: Clean-up usage of OptionDefinition arrays
(authored by tkrasnukha, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D52604?vs=167475&id=167515#toc
Repository:
rLLDB LLDB
Author: tkrasnukha
Date: Fri Sep 28 10:58:16 2018
New Revision: 343348
URL: http://llvm.org/viewvc/llvm-project?rev=343348&view=rev
Log:
Clean-up usage of OptionDefinition arrays
Differential Revision: https://reviews.llvm.org/D52604
Modified:
lldb/trunk/include/lldb/Target/Platform.h
ll
zturner added a comment.
I think it’s fine. Eventually when you are ready to support remote
debugging hopefully we can convert it over to using lldb-server
https://reviews.llvm.org/D52618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
htt
I think it’s fine. Eventually when you are ready to support remote
debugging hopefully we can convert it over to using lldb-server
On Fri, Sep 28, 2018 at 4:44 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov added a comment.
>
> Thanks for explanations!
>
grimar added a comment.
Thanks for the review! It still depends on -gsingle-file-split-dwarf
(https://reviews.llvm.org/D52403), I'll wait for it some time.
It should be possible to rewrite the comment in the test case to avoid
mentioning the flag, but I would prefer to use it.
https://reviews.
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good!
https://reviews.llvm.org/D52403
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
aleksandr.urakov added a reviewer: clayborg.
aleksandr.urakov added a comment.
In https://reviews.llvm.org/D52461#1245058, @clayborg wrote:
> Try to use and extend CPlusPlusLanguage::MethodName as needed. I believe it
> was recently backed by a new clang parser that knows how to chop up C++
> d
JDevlieghere created this revision.
JDevlieghere added reviewers: clayborg, jingham, teemperor.
JDevlieghere added a project: LLDB.
For the reproducer feature I need to be able to export and import the current
LLDB configuration. To realize this I've extended the existing functionality to
print
tatyana-krasnukha added inline comments.
Comment at: tools/driver/Driver.cpp:581-585
+ if (g_num_options == 0) {
if (argc > 1)
error.SetErrorStringWithFormat("invalid number of options");
return error;
}
clayborg wrote:
> Do we even need this
tatyana-krasnukha updated this revision to Diff 167475.
tatyana-krasnukha added a comment.
Modifies Driver::ParseArgs checks
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52604
Files:
include/lldb/Target/Platform.h
source/Commands/CommandObjectDisassemble.h
source/Commands/CommandOb
aleksandr.urakov added a comment.
Thanks for explanations!
Unfortunately I can't promise that I'll begin porting `lldb-server` on Windows
in the nearest future. I've looked at my working copy, and there are only two
small changes related to `ProcessWindows` plugin (but they are not related to
grimar updated this revision to Diff 167440.
grimar marked an inline comment as done.
grimar added a comment.
- Addressed review comments.
https://reviews.llvm.org/D52403
Files:
include/lldb/lldb-enumerations.h
lit/Breakpoint/Inputs/single-file-split-dwarf.o.yaml
lit/Breakpoint/Inputs/sin
grimar added inline comments.
Comment at: include/lldb/lldb-enumerations.h:643-660
+ eSectionTypeDWARFDebugAbbrevDwo,
eSectionTypeDWARFDebugAddr,
eSectionTypeDWARFDebugAranges,
eSectionTypeDWARFDebugCuIndex,
eSectionTypeDWARFDebugFrame,
eSectionTypeDWARFDebugInfo,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL343298: [PDB] Handle `char` as a builtin type (authored by
aleksandr.urakov, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D52468?vs=166876&i
Author: aleksandr.urakov
Date: Fri Sep 28 00:59:49 2018
New Revision: 343298
URL: http://llvm.org/viewvc/llvm-project?rev=343298&view=rev
Log:
[PDB] Handle `char` as a builtin type
Summary:
`char`, `signed char` and `unsigned char` are three different types,
and they are mangled differently:
```
aleksandr.urakov added a comment.
Yes, sure! Thanks all!
Repository:
rLLDB LLDB
https://reviews.llvm.org/D52468
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
19 matches
Mail list logo
