Author: jmolenda
Date: Wed Sep 5 17:55:27 2018
New Revision: 341511
URL: http://llvm.org/viewvc/llvm-project?rev=341511&view=rev
Log:
Re-instate a bit of code that was commented out in r188246 which
reads an ObjectFileMachO's string table in one chunk. Originally
this was commented out because b
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341506: Print column info in backtraces et al. if available
(authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D51661?vs=1641
Author: adrian
Date: Wed Sep 5 16:52:08 2018
New Revision: 341506
URL: http://llvm.org/viewvc/llvm-project?rev=341506&view=rev
Log:
Print column info in backtraces et al. if available
This patch allows LLDB to print column info in backtraces et al. if
available, which is useful when the backtrac
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL341497: Set Windows console mode to enable support for ansi
escape codes (authored by xbolva00, committed by ).
Herald add
aprantl updated this revision to Diff 164104.
aprantl added a comment.
Address review feedback.
Thanks you, I was wondering how to properly implement an optional element!
https://reviews.llvm.org/D51661
Files:
include/lldb/Core/FormatEntity.h
packages/Python/lldbsuite/test/functionalities/
Author: labath
Date: Wed Sep 5 11:08:56 2018
New Revision: 341487
URL: http://llvm.org/viewvc/llvm-project?rev=341487&view=rev
Log:
Modernize NativeProcessProtocol::GetSoftwareBreakpointTrapOpcode
return the opcode as a Expected instead of a
Status+pointer+size combo.
I also move the linux impl
clayborg added inline comments.
Comment at: source/Core/FormatEntity.cpp:1826
+}
+// Column info is optional, so this always succeeds.
+return true;
Remove this comment
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51661
___
clayborg added a comment.
See my inlined comments about returning true and false correctly for the column
and the correction to the format string
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE
\
+ "{ a
aprantl added inline comments.
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE
\
+ "{ at ${line.file.basename}:${line.number}${line.column}}"
#define IS_OPTIMIZED "{${function.is-optimized} [opt]}"
--
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB341482: Hold GIL while allocating memory for
PythonString. (authored by tkrasnukha, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51569
Files:
scripts/Python/python-extensions.
Author: tkrasnukha
Date: Wed Sep 5 10:07:29 2018
New Revision: 341482
URL: http://llvm.org/viewvc/llvm-project?rev=341482&view=rev
Log:
Hold GIL while allocating memory for PythonString.
Summary:
Swig wraps C++ code into SWIG_PYTHON_THREAD_BEGIN_ALLOW; ...
SWIG_PYTHON_THREAD_END_ALLOW;
Thus, L
clayborg added a comment.
We shouldn't have the colon character be part of the ${line.column} formatting
itself. See inlined comments.
Comment at: source/Core/Debugger.cpp:123
+#define FILE_AND_LINE
\
+ "{ at ${line.fi
xbolva00 updated this revision to Diff 164058.
xbolva00 added a comment.
- Check for _WIN32
https://reviews.llvm.org/D51615
Files:
source/Core/Debugger.cpp
Index: source/Core/Debugger.cpp
===
--- source/Core/Debugger.cpp
+++ so
xbolva00 updated this revision to Diff 164057.
https://reviews.llvm.org/D51615
Files:
source/Core/Debugger.cpp
Index: source/Core/Debugger.cpp
===
--- source/Core/Debugger.cpp
+++ source/Core/Debugger.cpp
@@ -50,14 +50,16 @@
#
zturner accepted this revision.
zturner added a comment.
lgtm after the one suggested change to the pre-processor conditional.
Comment at: source/Core/Debugger.cpp:815
+#if defined(_WIN32)
+ HANDLE hConsole = GetStdHandle(STD_OUTPUT_HANDLE);
+ DWORD consoleMode;
-
xbolva00 updated this revision to Diff 164053.
xbolva00 added a comment.
- use llvm::sys::Process::UseANSIEscapeCodes
https://reviews.llvm.org/D51615
Files:
source/Core/Debugger.cpp
Index: source/Core/Debugger.cpp
===
--- sourc
zturner added inline comments.
Comment at: source/Core/Debugger.cpp:819
+ consoleMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING;
+ SetUseColor(SetConsoleMode(hConsole, consoleMode));
+#endif
xbolva00 wrote:
> Should I rewrite it to more clear version like
>
> bool
zturner added a comment.
Lgtm, thanks!
https://reviews.llvm.org/D51162
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Lgtm, thanks!
On Wed, Sep 5, 2018 at 6:43 AM Aleksandr Urakov via Phabricator <
revi...@reviews.llvm.org> wrote:
> aleksandr.urakov updated this revision to Diff 164027.
> aleksandr.urakov added a comment.
>
> Code cleanup
>
>
> https://reviews.llvm.org/D51162
>
> Files:
> include/lldb/Symbol/Cl
teemperor added a comment.
LGTM from my side, but @zturner should take a look too.
https://reviews.llvm.org/D51615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: teemperor
Date: Wed Sep 5 07:27:48 2018
New Revision: 341471
URL: http://llvm.org/viewvc/llvm-project?rev=341471&view=rev
Log:
[www] Updated outdated download links [NFC]
Also added ubuntu and Arch Linux links.
Modified:
lldb/trunk/www/download.html
Modified: lldb/trunk/www/downloa
xbolva00 added a comment.
@teemperor please take a look again :)
https://reviews.llvm.org/D51615
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
aleksandr.urakov updated this revision to Diff 164026.
aleksandr.urakov added a comment.
- Fix a typo bug in `AddRecordMethods` (use `continue` instead of `break`);
- Do not search function declarations by name during getting of a declaration
for a symbol, it may lead to ambiguity.
https://revi
aleksandr.urakov updated this revision to Diff 164027.
aleksandr.urakov added a comment.
Code cleanup
https://reviews.llvm.org/D51162
Files:
include/lldb/Symbol/ClangASTContext.h
lit/SymbolFile/PDB/Inputs/AstRestoreTest.cpp
lit/SymbolFile/PDB/ast-restore.test
lit/SymbolFile/PDB/class-la
tatyana-krasnukha updated this revision to Diff 164008.
tatyana-krasnukha added a comment.
Use more readable aliases to set end clear the feature.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51569
Files:
scripts/Python/python-extensions.swig
Index: scripts/Python/python-extensions.sw
25 matches
Mail list logo
