Author: teemperor
Date: Thu Aug 23 16:21:52 2018
New Revision: 340589
URL: http://llvm.org/viewvc/llvm-project?rev=340589&view=rev
Log:
Add more pre-run asserts for the DirCompletionAbsolute test
Summary:
The DirCompletionAbsolute is still randomly failing on the nodes even after
D50722, so this
vsk added a comment.
Ping.
https://reviews.llvm.org/D50478
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340585: Reuse the SelectorTable from Clang's
Preprocessor (authored by teemperor, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51185
Files:
source/Plugins/ExpressionParser/Cla
Author: teemperor
Date: Thu Aug 23 15:40:54 2018
New Revision: 340585
URL: http://llvm.org/viewvc/llvm-project?rev=340585&view=rev
Log:
Reuse the SelectorTable from Clang's Preprocessor
Summary:
At the moment we create our own SelectorTable even though the Preprocessor
always
creates one for us
teemperor added a comment.
Yeah, but the FIXME has been around for like a decade, so I think that bug has
survived long enough to be promoted to a feature :).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51185
___
lldb-commits mailing list
l
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM. This is NFC, it seems. There's a FIXME in Preprocessor.h about the
lifetime of SelectorTable eventually not being tied to Preprocessor, but this
is correct for now.
Repository:
rLLDB LLDB
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340578: Restrict the set of plugins used for
ProcessMinidump (authored by lemo, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51176
Files:
source/Plugins/Process/minidump/Proce
Author: lemo
Date: Thu Aug 23 14:34:33 2018
New Revision: 340578
URL: http://llvm.org/viewvc/llvm-project?rev=340578&view=rev
Log:
Restrict the set of plugins used for ProcessMinidump
1. The dynamic loaders should not be needed for loading minidumps
and they may create problems (ex. the macOS loa
lemo marked an inline comment as done.
lemo added a comment.
In https://reviews.llvm.org/D51176#1211433, @jingham wrote:
> The other option would be to move the code that populates the section load
> list into the mini dump dynamic loader. That has the benefit of keeping this
> consistent with
lemo updated this revision to Diff 162270.
lemo added a comment.
Added the comment requested by zturner
https://reviews.llvm.org/D51176
Files:
source/Plugins/Process/minidump/ProcessMinidump.cpp
source/Plugins/Process/minidump/ProcessMinidump.h
Index: source/Plugins/Process/minidump/Proce
Author: adrian
Date: Thu Aug 23 14:08:30 2018
New Revision: 340574
URL: http://llvm.org/viewvc/llvm-project?rev=340574&view=rev
Log:
Change xfail to skipIf. The exact condition is really difficult to get
right and doesn't add much signal.
Modified:
lldb/trunk/packages/Python/lldbsuite/test/l
Author: adrian
Date: Thu Aug 23 14:00:37 2018
New Revision: 340573
URL: http://llvm.org/viewvc/llvm-project?rev=340573&view=rev
Log:
XFAIL test for older versions of clang
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/unicode/TestUnicodeSymbols.py
Modified:
lldb/trunk/packages
zturner accepted this revision.
zturner added inline comments.
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:399-404
+JITLoaderList &ProcessMinidump::GetJITLoaders() {
+ if (!m_jit_loaders_ap) {
+m_jit_loaders_ap = llvm::make_unique();
+ }
+ return *m_jit
This revision was automatically updated to reflect the committed changes.
Closed by commit rLLDB340571: Fix broken builtin functions in the expression
command (authored by teemperor, committed by ).
Repository:
rLLDB LLDB
https://reviews.llvm.org/D50481
Files:
packages/Python/lldbsuite/tes
Author: teemperor
Date: Thu Aug 23 13:40:45 2018
New Revision: 340571
URL: http://llvm.org/viewvc/llvm-project?rev=340571&view=rev
Log:
Fix broken builtin functions in the expression command
Summary:
Calling any non-libc builtin function in the expression command currently just
causes Clang
to s
lemo added subscribers: bgianfo, clayborg, zturner.
lemo added a comment.
It's an interesting idea, thanks! I don't object moving code around if
there's a strong case for it, but I'd like to keep the fix small and simple
for now, but it's worth considering if the current minidump loading path
will
It's an interesting idea, thanks! I don't object moving code around if
there's a strong case for it, but I'd like to keep the fix small and simple
for now, but it's worth considering if the current minidump loading path
will need more flexibility.
On Thu, Aug 23, 2018 at 1:27 PM, Greg Clayton via
teemperor updated this revision to Diff 162255.
teemperor added a comment.
This revision is now accepted and ready to land.
- Removed unrelated comments in the test.
- No longer using self.expect.
- Small refactoring in the parsing code.
https://reviews.llvm.org/D50481
Files:
packages/Python
clayborg added a comment.
In https://reviews.llvm.org/D51176#1211433, @jingham wrote:
> The other option would be to move the code that populates the section load
> list into the mini dump dynamic loader. That has the benefit of keeping this
> consistent with the other process plugins, but OTO
jingham added a comment.
The other option would be to move the code that populates the section load list
into the mini dump dynamic loader. That has the benefit of keeping this
consistent with the other process plugins, but OTOH is just moving code
around...
Repository:
rLLDB LLDB
https:/
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
I am fine with this change then. Probably best to get the OK from Zach as well.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51176
___
lemo added a comment.
In https://reviews.llvm.org/D51176#1211358, @clayborg wrote:
> So this might actually work. Take a look around and see what else the dynamic
> loader is used for and make sure that they won't be needed for anything else.
> If not, this fix should work, but we should docume
clayborg added a comment.
So this might actually work. Take a look around and see what else the dynamic
loader is used for and make sure that they won't be needed for anything else.
If not, this fix should work, but we should document it.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D511
lemo added a comment.
In https://reviews.llvm.org/D51176#1211307, @clayborg wrote:
> Dynamic loaders will fill out the section load list in the target that saids
> "__TEXT" from "/tmp/a.out" was loaded at address 0x120200. So yes they
> are needed. If the process minidump is manually settin
lemo added a comment.
> That's not changing the module list, that's changing the loaded section
> information. It is the dynamic loader's job to figure out what got loaded
> where, plus your stack trace show this happening after we've selected a
> plugin, not in the process of negotiating for t
clayborg added a comment.
Sounds good. I am ok with this as long as Jim Ingham is.
https://reviews.llvm.org/D50912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
Dynamic loaders will fill out the section load list in the target that saids
"__TEXT" from "/tmp/a.out" was loaded at address 0x120200. So yes they are
needed. If the process minidump is manually setting the section load list
itself, then there really is no need fo
teemperor updated this revision to Diff 162238.
teemperor added a comment.
- Add an assert against underflow checking.
- Fixed a (serious) typo that broke the test.
https://reviews.llvm.org/D50912
Files:
include/lldb/Core/Debugger.h
include/lldb/Target/Process.h
include/lldb/Target/Target
teemperor added inline comments.
Comment at: source/Target/Process.cpp:4696-4697
+// the IOHandler for Editline).
+bool cancel_top_handler = m_mod_id.IsRunningUtilityFunction();
+GetTarget().GetDebugger().PushIOHandler(io_handler_sp, cancel_top_handler);
return t
jingham added a comment.
That's not changing the module list, that's changing the loaded section
information. It is the dynamic loader's job to figure out what got loaded
where, plus your stack trace show this happening after we've selected a plugin,
not in the process of negotiating for the p
lemo added a comment.
> Dynamic loaders are needed for loading breakpad minidumps that are for MacOSX
> and iOS processes. They should also be needed for loading any minidumps that
> have stack traces.
Thanks. I just validated the change against a macOS minidump and everything
works fine in my
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Dynamic loaders are needed for loading breakpad minidumps that are for MacOSX
and iOS processes. They should also be needed for loading any minidumps that
have stack traces.
Re
clayborg added a comment.
No dynamic loader plug-ins should be affecting the module list during the
plug-in loading/selection, if that is happening, that is a bug and it should be
fixed.
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51176
__
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340560: [cmake] Add option to skip building lldb-server
(authored by xiaobai, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D49282?vs=155459&
Author: xiaobai
Date: Thu Aug 23 11:05:45 2018
New Revision: 340560
URL: http://llvm.org/viewvc/llvm-project?rev=340560&view=rev
Log:
[cmake] Add option to skip building lldb-server
Summary:
There is currently a way to skip the debugserver build. See how the CMake
variables SKIP_DEBUGSERVER and L
clayborg added inline comments.
Comment at: include/lldb/Target/Process.h:479
+else
+ m_running_utility_function--;
+ }
Might want this to be:
```
else if (m_running_utility_function > 0)
--m_running_utility_function;
```
Just to make sure we don't
lemo created this revision.
lemo added reviewers: clayborg, zturner.
lemo added a project: LLDB.
Herald added a subscriber: abidh.
1. The dynamic loaders should not be needed for loading minidumps and they may
create problems (ex. the macOS loader resets the list of loaded modules)
2. In general,
teemperor created this revision.
teemperor added a reviewer: LLDB.
This patch adds a framework for adding descriptions to the command completions
we provide.
It also adds descriptions for completed top-level commands so that we can test
this code.
Completions are in general supposed to be displ
Author: adrian
Date: Thu Aug 23 10:51:14 2018
New Revision: 340557
URL: http://llvm.org/viewvc/llvm-project?rev=340557&view=rev
Log:
Fix check for dictionary entry
Modified:
lldb/trunk/lit/Suite/lldbtest.py
Modified: lldb/trunk/lit/Suite/lldbtest.py
URL:
http://llvm.org/viewvc/llvm-project/
teemperor updated this revision to Diff 162227.
teemperor added a comment.
Herald added a subscriber: emaste.
I added an flag for this to the evaluation options. I also set this flag for
all utility calls I found.
https://reviews.llvm.org/D50912
Files:
include/lldb/Core/Debugger.h
include/
Author: adrian
Date: Thu Aug 23 10:30:56 2018
New Revision: 340550
URL: http://llvm.org/viewvc/llvm-project?rev=340550&view=rev
Log:
XFAIL test for older versions of dsymutil
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/c/unicode/TestUnicodeSymbols.py
Modified:
lldb/trunk/packa
Author: adrian
Date: Thu Aug 23 10:19:08 2018
New Revision: 340548
URL: http://llvm.org/viewvc/llvm-project?rev=340548&view=rev
Log:
lldbtest.py: Work around macOS SIP when testing ASANified builds.
Modified:
lldb/trunk/lit/Suite/lldbtest.py
Modified: lldb/trunk/lit/Suite/lldbtest.py
URL:
h
Author: adrian
Date: Thu Aug 23 10:02:39 2018
New Revision: 340543
URL: http://llvm.org/viewvc/llvm-project?rev=340543&view=rev
Log:
Add libc++ data formatter for std::function
- Added LibcxxFunctionSummaryProvider
- Removed LibcxxFunctionFrontEnd
- Modified data formatter tests to test new summa
This revision was automatically updated to reflect the committed changes.
Closed by commit rL340543: Add libc++ data formatter for std::function
(authored by adrian, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D50864?vs=161997&id=16
sgraenitz added a comment.
> This is another one of classes we should probably get rid of (it looks like
> all of this functionality is available in StringRef)
Late +1. Usage in `FormattersContainer.h` should be easy to replace. Apart form
that it could be an implementation detail of `AppleObjC
45 matches
Mail list logo
