zturner accepted this revision.
zturner added inline comments.
================
Comment at: source/Plugins/Process/minidump/ProcessMinidump.cpp:399-404
+JITLoaderList &ProcessMinidump::GetJITLoaders() {
+ if (!m_jit_loaders_ap) {
+ m_jit_loaders_ap = llvm::make_unique<JITLoaderList>();
+ }
+ return *m_jit_loaders_ap;
+}
----------------
Can you put a comment in here explaining that the base class implementation
does additional work that is unnecessary for a minidump plugin, so this is
basically a performance optimization?
Repository:
rLLDB LLDB
https://reviews.llvm.org/D51176
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
