zturner added a comment.
In https://reviews.llvm.org/D38897#897378, @gut wrote:
> Thanks for supporting this change. I guess @anajuliapc will add you both as
> reviewer as soon as she updates this patch.
>
> BTW, I agree that patches should be improving code quality but I wanted to
> highlight
gut added a comment.
Thanks for supporting this change. I guess @anajuliapc will add you both as
reviewer as soon as she updates this patch.
BTW, I agree that patches should be improving code quality but I wanted to
highlight that these changes were actually based on the current ARM64
implemen
clayborg added a comment.
Feel free to add me as a reviewer. Zach as well.
https://reviews.llvm.org/D38897
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg added a comment.
I agree with all of Zach's suggestions.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:98-99
+uint32_t refcount; // Serves as enable/disable and reference counter.
+long slot; // Saves the value
zturner added inline comments.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp:90-93
+ // 16 is just a maximum value, query hardware for actual watchpoint count
+ m_max_hwp_supported = 16;
+ m_max_hbp_supported = 16;
+ m_refresh_hwdebug_info =
anajuliapc created this revision.
Herald added subscribers: kbarton, nemanjai.
Add hardware watchpoint funcionality for ppc64le
https://reviews.llvm.org/D38897
Files:
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.cpp
source/Plugins/Process/Linux/NativeRegisterContextLinux_
