clayborg added a comment.

I agree with all of Zach's suggestions.



================
Comment at: 
source/Plugins/Process/Linux/NativeRegisterContextLinux_ppc64le.h:98-99
+    uint32_t refcount;      // Serves as enable/disable and reference counter.
+    long slot;              // Saves the value returned from PTRACE_SETHWDEBUG.
+    int mode;               // Defines if watchpoint is read/write/access.
+  };
----------------
As long as this code is only ever compiled native, using "long" and "int" are 
ok. Just beware of code that isn't always compiled native.


https://reviews.llvm.org/D38897



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to