ki.stfu requested changes to this revision.
ki.stfu added a comment.
This revision now requires changes to proceed.
Hi.
LGTM. Just fix a few minor issues before committing.
Thank you for your contribution to LLDB project!
Comment at:
packages/Python/lldbsuite/test/tools/lldb
krytarowski added a reviewer: jingham.
krytarowski added a comment.
Adding Jim as a reviewer, since Pavel is mostly out of the keyboard for longer
time.
Repository:
rL LLVM
https://reviews.llvm.org/D31450
___
lldb-commits mailing list
lldb-commi
krytarowski added a comment.
Next: watchpoints, FPR.
Current core(5) file format is a subject to change (AUXV can be shortened)...
I'm working on the final nits for the NetBSD-8 interfaces.
Repository:
rL LLVM
https://reviews.llvm.org/D31450
__
krytarowski created this revision.
krytarowski added a project: LLDB.
Include initial support for:
- single step mode (PT_STEP)
- single step trap handling (TRAP_TRACE)
- exec() trap (TRAP_EXEC)
- add placeholder interfaces for FPR
- initial code for NetBSD core(5) files
- minor tweaks
While the
Author: kamil
Date: Tue Mar 28 20:10:21 2017
New Revision: 298970
URL: http://llvm.org/viewvc/llvm-project?rev=298970&view=rev
Log:
Remove dead include from the NetBSD code.
Modified:
lldb/trunk/source/Host/netbsd/Host.cpp
Modified: lldb/trunk/source/Host/netbsd/Host.cpp
URL:
http://llvm.o
Author: jingham
Date: Tue Mar 28 18:25:34 2017
New Revision: 298958
URL: http://llvm.org/viewvc/llvm-project?rev=298958&view=rev
Log:
Print the error if dsymForUUID sometimes produces bad plists.
Not much we can do about it but at least we can print the bad
plist and the error.
Modified:
lld
This revision was automatically updated to reflect the committed changes.
Closed by commit rL298953: Add support for tracing hello-world application on
NetBSD (authored by kamil).
Changed prior to commit:
https://reviews.llvm.org/D31374?vs=93312&id=93315#toc
Repository:
rL LLVM
https://revi
Author: kamil
Date: Tue Mar 28 17:43:17 2017
New Revision: 298953
URL: http://llvm.org/viewvc/llvm-project?rev=298953&view=rev
Log:
Add support for tracing hello-world application on NetBSD
Summary:
This patch is a stripped down from features a NetBSD process
code (patch is kept under 2k LOC). Th
krytarowski updated this revision to Diff 93312.
krytarowski added a comment.
Apply changes from review.
Repository:
rL LLVM
https://reviews.llvm.org/D31374
Files:
source/Plugins/Process/NetBSD/CMakeLists.txt
source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp
source/Plugins/Process/
krytarowski added a comment.
This code is used as a base for further improvements, I'm going to commit it...
debugging hello world still works.
$ lldb ./hello
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
If SetName is the wrong thing to use for synthetic child providers, then we
need to make Clone available to the SB API's as well. In any case where they
want to return an extant V
krytarowski added a comment.
In https://reviews.llvm.org/D31374#712221, @labath wrote:
> I wasn't able to go into this too deeply, but here is what I have after a
> quick pass. I won't be able to review this thoroughly that soon, but I think
> it can go in after you take my comments into consid
jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.
This seems great. The only remaining thing is to document this in the
Synthetic Children section of the Variable Formatting page
(www/varformats.html).
https://reviews.llvm.org/
labath added a comment.
I wasn't able to go into this too deeply, but here is what I have after a quick
pass. I won't be able to review this thoroughly that soon, but I think it can
go in after you take my comments into consideration.
Comment at: source/Plugins/Process/NetBSD
labath added a comment.
I am afraid I will be away for two weeks as well.. :(
The FileLogCallback thingy seems a bit unfortunate, but I don't see anything
too controversial based on a quick scan..
https://reviews.llvm.org/D31357
___
lldb-commits m
labath added inline comments.
Comment at: source/CMakeLists.txt:25
+include_directories(
+ Plugins/Process/POSIX
+ )
krytarowski wrote:
> @labath are the includes for Plugins/Process/FreeBSD and
> Plugins/Process/FreeBSD necessary? I don't need to add Plugins/
tberghammer updated this revision to Diff 93241.
tberghammer added a comment.
Changed StackFrame to use Dereference instead of accessing the $$dereference$$
magic field.
https://reviews.llvm.org/D31368
Files:
packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/l
tberghammer added a comment.
My understanding (don't have an OSX machine at hand right now to try out) is
that OSX ships with the libstdc++ belonging to gcc-4.2.1 and that version of
libstdc++ is too old to support c++11 features such as std::unique_ptr.
Regarding skipping tests I am not aware
18 matches
Mail list logo
