[Lldb-commits] [lldb] r286565 - Revert unwanted changes in lldb when updating llvm::Error()

Author: mehdi_amini Date: Thu Nov 10 23:07:57 2016 New Revision: 286565 URL: http://llvm.org/viewvc/llvm-project?rev=286565&view=rev Log: Revert unwanted changes in lldb when updating llvm::Error() My script updated lldb::Errors, and I failed to fix it entirely before pushing. This restore everyt

Re: [Lldb-commits] [PATCH] D26528: Fix uninitialized members.

Maybe just inline the initializations so we don't have to repeat code across multiple constructors? i.e. bool m_is_resolved = false; in the header file. On Thu, Nov 10, 2016 at 8:54 PM Sam McCall via lldb-commits < lldb-commits@lists.llvm.org> wrote: > sammccall created this revision. > sammcc

[Lldb-commits] [PATCH] D26528: Fix uninitialized members.

sammccall created this revision. sammccall added a subscriber: lldb-commits. Fix uninitialized members. https://reviews.llvm.org/D26528 Files: source/Host/common/FileSpec.cpp source/Target/Process.cpp Index: source/Target/Process.cpp ===

[Lldb-commits] [lldb] r286562 - Prevent at compile time converting from Error::success() to Expected

Author: mehdi_amini Date: Thu Nov 10 22:29:25 2016 New Revision: 286562 URL: http://llvm.org/viewvc/llvm-project?rev=286562&view=rev Log: Prevent at compile time converting from Error::success() to Expected This would trigger an assertion at runtime otherwise. Differential Revision: https://revi

[Lldb-commits] [lldb] r286561 - Make the Error class constructor protected

Author: mehdi_amini Date: Thu Nov 10 22:28:40 2016 New Revision: 286561 URL: http://llvm.org/viewvc/llvm-project?rev=286561&view=rev Log: Make the Error class constructor protected This is forcing to use Error::success(), which is in a wide majority of cases a lot more readable. Differential Rev

[Lldb-commits] [lldb] r286528 - [CMake] Fixing CMake to append source properties instead of overwrite them.

Author: cbieneman Date: Thu Nov 10 17:56:32 2016 New Revision: 286528 URL: http://llvm.org/viewvc/llvm-project?rev=286528&view=rev Log: [CMake] Fixing CMake to append source properties instead of overwrite them. This is a small fix to the version output. Modified: lldb/trunk/source/CMakeList

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

Thanks, Chris! On Thu, Nov 10, 2016 at 2:22 PM, Todd Fiala wrote: > Okay cool, thanks Chris! > > -Todd > > On Nov 10, 2016, at 1:40 PM, Chris Bieneman wrote: > > I just pushed r286504, which expects the string to not be quoted. This > should solve the bot failures. > > -Chris > > On Nov 10, 201

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

Okay cool, thanks Chris! -Todd > On Nov 10, 2016, at 1:40 PM, Chris Bieneman wrote: > > I just pushed r286504, which expects the string to not be quoted. This should > solve the bot failures. > > -Chris > >> On Nov 10, 2016, at 1:30 PM, Todd Fiala > > wrote: >>

[Lldb-commits] [lldb] r286505 - One more try to fix the Xcode project

Author: cbieneman Date: Thu Nov 10 15:43:24 2016 New Revision: 286505 URL: http://llvm.org/viewvc/llvm-project?rev=286505&view=rev Log: One more try to fix the Xcode project This time I made sure it actually opened. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/ll

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

Failing differently here. Progress! 2016-11-10 13:47:14.203 xcodebuild[65554:42448173] Error Domain=NSCocoaErrorDomain Code=3840 "Unexpected character / at line 1" UserInfo={NSDebugDescription=Unexpected character / at line 1, kCFPropertyListOldStyleParsingError=Error Domain=NSCocoaErrorDomain Cod

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

I just pushed r286504, which expects the string to not be quoted. This should solve the bot failures. -Chris > On Nov 10, 2016, at 1:30 PM, Todd Fiala wrote: > > I'm at a point where I can look at it. > > On Thu, Nov 10, 2016 at 12:17 PM, Tim Hammerquist > wrote: > L

[Lldb-commits] [lldb] r286504 - Fixing the Xcode build that I broke in r286479

Author: cbieneman Date: Thu Nov 10 15:30:16 2016 New Revision: 286504 URL: http://llvm.org/viewvc/llvm-project?rev=286504&view=rev Log: Fixing the Xcode build that I broke in r286479 Since Xcode can't seem to handle quotes in preprocessor definitions, I've changed the build to assume that the de

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

I'm at a point where I can look at it. On Thu, Nov 10, 2016 at 12:17 PM, Tim Hammerquist wrote: > Looks like the quotes around the lldb version string aren't properly > preserved in the xcodeproj file as they are in CMake. > > Can any of the LLDB devs more comfortable with plumbing the depths of

Re: [Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

Looks like the quotes around the lldb version string aren't properly preserved in the xcodeproj file as they are in CMake. Can any of the LLDB devs more comfortable with plumbing the depths of Xcode project configuration provide some guidance here? http://lab.llvm.org:8080/green/job/lldb_build_te

[Lldb-commits] [lldb] r286490 - [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

Author: cbieneman Date: Thu Nov 10 13:16:17 2016 New Revision: 286490 URL: http://llvm.org/viewvc/llvm-project?rev=286490&view=rev Log: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities Summary: This patch reworks all the @skip... lines for sanitizer libraries to be b

[Lldb-commits] [PATCH] D26513: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rL286490: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D26513?vs=77506&id=77518#toc Repository:

[Lldb-commits] [PATCH] D26513: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

beanz added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:23 @skipIfRemote -@skipUnlessCompilerRt @skipUnlessThreadSanitizer def test(self): tfiala wrote: > Seems fine as long as @skipU

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

clayborg added a comment. If we do this the asserts we have will no longer fire. We tend not to use asserts too much, but it would be a good idea to take a look at any asserts in our code to make sure we won't die horribly in other ways that will cause us not to know what crashed us. https://

[Lldb-commits] [PATCH] D26513: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

tfiala added a comment. Looks fine to me pending that one question on the TSAN check (i.e. if the existing TSAN check is as good as your new ASAN check, LGTM). Comment at: packages/Python/lldbsuite/test/functionalities/tsan/basic/TestTsanBasic.py:23 @skipIfRemote -@s

[Lldb-commits] [PATCH] D26513: [Test-Suite] Fix all the sanitizer tests to be based on compiler capabilities

beanz created this revision. beanz added a reviewer: lldb-commits. beanz added subscribers: tfiala, kubabrecka. This patch reworks all the @skip... lines for sanitizer libraries to be based on whether or not the compiler actually works, rather than whether or not the compiler-rt sources are pres

[Lldb-commits] [lldb] r286479 - Unify Darwin and Non-Darwin printing of version output

Author: cbieneman Date: Thu Nov 10 11:33:19 2016 New Revision: 286479 URL: http://llvm.org/viewvc/llvm-project?rev=286479&view=rev Log: Unify Darwin and Non-Darwin printing of version output Summary: This change unifies and simplifies the code paths between the Darwin and non-Darwin code to prin

[Lldb-commits] [PATCH] D26478: Unify Darwin and Non-Darwin printing of version output

This revision was automatically updated to reflect the committed changes. Closed by commit rL286479: Unify Darwin and Non-Darwin printing of version output (authored by cbieneman). Changed prior to commit: https://reviews.llvm.org/D26478?vs=77403&id=77505#toc Repository: rL LLVM https://rev

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

tfiala added a comment. Adding Jim, as I just want one of him or Greg to review. https://reviews.llvm.org/D26510 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] r286476 - Un-XFail test on Windows. Has been in "unexpected success" mode for a while.

Author: amccarth Date: Thu Nov 10 11:21:22 2016 New Revision: 286476 URL: http://llvm.org/viewvc/llvm-project?rev=286476&view=rev Log: Un-XFail test on Windows. Has been in "unexpected success" mode for a while. Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/c/enum_types/TestEnumTy

[Lldb-commits] [PATCH] D26510: Xcode build: specify NDEBUG for all binaries built using the BuildAndIntegration configuration

tfiala created this revision. tfiala added a reviewer: clayborg. tfiala added a subscriber: lldb-commits. BuildAndIntegration is the configuration used to build Apple-built LLDB. This configuration currently requires NDEBUG to be specified. This change adds a new Xcode variable, LLDB_NDEBUG_CF

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

labath added a comment. Looks great. Ed, do you want to give this a try run? Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:113 +self.assertTrue(target, VALID_TARGET) +process = target.LoadCore("fpr_sse_x86_64.

[Lldb-commits] [PATCH] D26505: Remove a hack from the Android toolchain file

labath created this revision. labath added reviewers: tberghammer, beanz. labath added a subscriber: lldb-commits. Herald added subscribers: mgorny, srhines, danalbert. The fix is to make sure llvm does not pull in dlopen() in configurations where it is not available. https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

dvlahovski updated this revision to Diff 77477. dvlahovski added a comment. Generated the core files with make-core.sh https://reviews.llvm.org/D26300 Files: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py packages/Python/lldbsuite/test/functionalitie

[Lldb-commits] [PATCH] D26300: ELF core: Adding parsing of the floating-point and SSE registers on x86 32/64 bit elf core files

dvlahovski added a comment. I will generate the core files with the `make-core.sh` script and update the revision today or tomorrow. Comment at: packages/Python/lldbsuite/test/functionalities/postmortem/linux-core/TestLinuxCore.py:107 +@skipIf(oslist=['windows']) +

[Lldb-commits] [PATCH] D26478: Unify Darwin and Non-Darwin printing of version output

labath added a comment. Woohoo. https://reviews.llvm.org/D26478 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits