wallace added a comment.
oh, thank you, first time i'm sending lldb diffs
Repository:
rL LLVM
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
wallace added a comment.
This fixes some issues with arm architectures (where this was unsetting the
thumbv7 and was fallbacking to thumb).
This is also needed for https://reviews.llvm.org/D24284, where the objet file
requires a correct architecture inferred from the machine arch
Repository:
wallace created this revision.
wallace added reviewers: zturner, sas.
wallace added a subscriber: LLDB.
wallace set the repository for this revision to rL LLVM.
wallace added a project: LLDB.
When the local lldb doesn't have access to a copy of the modules in the target,
e.g. winphone, with this
zturner added a comment.
In https://reviews.llvm.org/D24283#535405, @wallace wrote:
> This fixes some issues with arm architectures (where this was unsetting the
> thumbv7 and was fallbacking to thumb).
> This is also needed for https://reviews.llvm.org/D24284, where the objet
> file requires
zturner added a comment.
Right, I'm just wondering if when you run `ninja check-lldb` before and after
this patch, do the results differ at all?
Repository:
rL LLVM
https://reviews.llvm.org/D24284
___
lldb-commits mailing list
lldb-commits@lists
zturner added a comment.
Can you rebase on top of tunk and re-upload? Also please use -U99 when
generating the diff (assuming you are using git) so we can see context.
Repository:
rL LLVM
https://reviews.llvm.org/D24284
___
lldb-commits mai
zturner added a comment.
BTW, you will need to rebase this on top of trunk, and make sure you run
clang-format before submitting.
Repository:
rL LLVM
https://reviews.llvm.org/D24283
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http:
zturner accepted this revision.
zturner added a comment.
This revision is now accepted and ready to land.
Does this affect the running of the test suite in any way? Is anything fixed
or regressed as a result of this?
Repository:
rL LLVM
https://reviews.llvm.org/D24283
___
Author: zturner
Date: Tue Sep 6 17:40:11 2016
New Revision: 280763
URL: http://llvm.org/viewvc/llvm-project?rev=280763&view=rev
Log:
Revert "Fix tests on Windows."
This reverts commit 9b757b6e3946311802972409f38c6cefbea917b3.
This seems to cause strange breakages about on Ubuntu.
Modified:
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please rebase code on trunk and run Clang-format.
https://reviews.llvm.org/D24251
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: zturner
Date: Tue Sep 6 17:14:22 2016
New Revision: 280759
URL: http://llvm.org/viewvc/llvm-project?rev=280759&view=rev
Log:
Fix tests on Windows.
This wasn't actually a problem with the reformat, but rather a
problem with Visual Studio 2015 Update 3, which uses some c++14
features in it
Thanks for clarifying. That said, I think we should still follow the LLVM
convention of putting system headers last. (i.e. everything in <> comes
after everything in "", but within <> you can still arrange according to
the system rules). This encourages "include what you use" as header files
wil
On NetBSD /usr/share/misc/style says:
/*
* Kernel include files come first.
*/
#include /* first, */
#include /* next, */
#include /* and then the rest, */
#include /* sorted lexicographically. */
#include
#include /* Non-local incl
Author: zturner
Date: Tue Sep 6 17:02:06 2016
New Revision: 280758
URL: http://llvm.org/viewvc/llvm-project?rev=280758&view=rev
Log:
Put the LLVM_ALIGNAS directive in the right place.
Modified:
lldb/trunk/source/Plugins/Process/Utility/RegisterContext_x86.h
Modified: lldb/trunk/source/Plugi
In general, and headers should be at the top, followed by
standard headers such as , then followed by application-specific
headers. IIRC this is also the case for Linux.
-Dimitry
> On 07 Sep 2016, at 00:02, Zachary Turner via lldb-commits
> wrote:
>
> Why was this causing a problem? The
Why was this causing a problem? The only headers that were re-ordered are
system headers. Does FreeBSD's libraries have requirements about certain
headers being included before other headers?
On Tue, Sep 6, 2016 at 2:33 PM Ed Maste via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author
Author: zturner
Date: Tue Sep 6 16:52:14 2016
New Revision: 280757
URL: http://llvm.org/viewvc/llvm-project?rev=280757&view=rev
Log:
Make LLDB compile on Windows after the reformat.
Most of these issues arose as a result of header re-ordering, but
it turned up a real bug, which is that MSVC does
Author: emaste
Date: Tue Sep 6 16:25:31 2016
New Revision: 280755
URL: http://llvm.org/viewvc/llvm-project?rev=280755&view=rev
Log:
Reorder FreeBSD Host.cpp #includes to fix build
Modified:
lldb/trunk/source/Host/freebsd/Host.cpp
Modified: lldb/trunk/source/Host/freebsd/Host.cpp
URL:
http:
Hello everyone,
LLVM buildmaster will be restarted in few minutes.
Sorry for inconvenience.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: kate
Date: Tue Sep 6 12:19:00 2016
New Revision: 280721
URL: http://llvm.org/viewvc/llvm-project?rev=280721&view=rev
Log:
Updated .clang-format rules so bring LLDB in line with LLVM standards.
Added:
lldb/trunk/packages/Python/lldbsuite/.clang-format
Modified:
lldb/trunk/.clang-
clayborg requested changes to this revision.
clayborg added a comment.
Just switch to using CFLAGS_EXTRAS and LD_EXTRAS and this is good to go.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6-11
@@ +5,8 @@
+ifeq "$(ARCH)" "
clayborg added a comment.
Just take a look and see if there is anything worth re-using. If there is too
much mac specific stuff in there, then just use the one created, but be sure to
make it your new format completely agnostic to any platform so it can work for
anything. It is OK to include pl
labath added a reviewer: jasonmolenda.
labath added a comment.
Hm... I was not aware of that packet. It does not appear to be directly
applicable to this situation, because it queries the module information by load
address, whereas here I query by file path. Also my packet does not return the
s
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Just add header doc and this is good to go.
Comment at: include/lldb/API/SBSection.h:74
@@ -73,1 +73,3 @@
+uint32_t
+GetPermissions () const;
-
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
Jason Molenda already has a packet that does multiple module infos. Is this
change using his packet format? Look for "jGetLoadedDynamicLibrariesInfos". We
should try to use the s
valentinagiusti added a comment.
Hi, inline there are my other replies.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:5
@@ +4,3 @@
+
+ifeq "$(ARCH)" "i386"
+ CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32
labath updated this revision to Diff 70409.
labath added a comment.
- fix a bug where we would mark all modules as invalid if communicating with a
stub which does not support this packet
- extend the packet documentation about what to do when modules are not found
and the server volunteering inf
valentinagiusti added a comment.
Thanks for the review! You can find my replies inline.
Comment at:
packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/TestMPXRegisters.py:27
@@ +26,3 @@
+
+@skipIfiOSSimulator
+@skipIf(compiler="clang")
-
Also given that the reformat is going to happen today, I wonder if we
should wait until after it is complete to put in any more high risk changes.
On Tue, Sep 6, 2016 at 8:07 AM Pavel Labath via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> labath requested changes to this revision.
> laba
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I have a couple of questions I'd like to be answered before this goes in. Apart
from the inline comments, all my questions from the previous version of this
commit still stand.
===
valentinagiusti created this revision.
valentinagiusti added a subscriber: lldb-commits.
Signed-off-by: Valentina Giusti
https://reviews.llvm.org/D24255
Files:
packages/Python/lldbsuite/test/functionalities/register/Makefile
packages/Python/lldbsuite/test/functionalities/register/TestRegist
Author: dvlahovski
Date: Tue Sep 6 07:48:10 2016
New Revision: 280707
URL: http://llvm.org/viewvc/llvm-project?rev=280707&view=rev
Log:
Fixing an MSVC error from rL280692
MSVC emits an error when one uses a const variable in a lambda without
capturing it.
gcc and clang don't emit an error in th
Author: labath
Date: Tue Sep 6 06:08:02 2016
New Revision: 280704
URL: http://llvm.org/viewvc/llvm-project?rev=280704&view=rev
Log:
Second round of fixups for r280692
Android targets don't have std::to_string and std::stoul. Use llvm::to_string
and strtoul
instead.
Modified:
lldb/trunk/sou
Author: dvlahovski
Date: Tue Sep 6 06:00:37 2016
New Revision: 280703
URL: http://llvm.org/viewvc/llvm-project?rev=280703&view=rev
Log:
Revert "Intel(R) Memory Protection Extensions (Intel(R) MPX) support."
This reverts commit rL280668 because the register tests fail on i386
Linux.
I investigat
On 6 September 2016 at 05:48, Sean Callanan via lldb-commits
wrote:
> +
> +struct Operand
> +{
> +enum class Type {
> +Invalid = 0,
> +Register,
> +Immediate,
> +Dereference,
> +Sum,
> +Product
> +} m_t
Author: labath
Date: Tue Sep 6 05:04:22 2016
New Revision: 280697
URL: http://llvm.org/viewvc/llvm-project?rev=280697&view=rev
Log:
Fix build breakage in r280692
The commit introduced an array of const objects, which libstdc++ does not like.
Make the object
non-const.
Also fix a compiler warni
36 matches
Mail list logo
