clayborg requested changes to this revision. clayborg added a comment. Just switch to using CFLAGS_EXTRAS and LD_EXTRAS and this is good to go.
================ Comment at: packages/Python/lldbsuite/test/functionalities/register/intel_xtended_registers/Makefile:6-11 @@ +5,8 @@ +ifeq "$(ARCH)" "i386" + CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32 + LDFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd -m32 +endif +ifeq "$(ARCH)" "x86_64" + CXXFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd + LDFLAGS += -mmpx -fcheck-pointer-bounds -fuse-ld=bfd +endif ---------------- It would be nice to not modify the CXXFLAGS or LDFLAGS directly. You should modify CFLAGS_EXTRAS and LD_EXTRAS. I am not sure if there is a CXXFLAGS_EXTRAS, but feel free to add it if you can't use CFLAGS_EXTRAS https://reviews.llvm.org/D24255 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits