Author: jingham
Date: Wed Aug 10 19:15:28 2016
New Revision: 278305
URL: http://llvm.org/viewvc/llvm-project?rev=278305&view=rev
Log:
dlopen & dlclose can't throw C++ or ObjC exceptions, so don't do the extra work
of
setting & deleting the breakpoints to watch for this.
Modified:
lldb/trun
Couple of random style comments below. You don't have to fix these, just
something to think about in the future.
On Wed, Aug 10, 2016 at 4:33 PM Greg Clayton via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> +
> +TEST_F(PythonDataObjectsTest, TestExtractingUInt64ThroughStructuredData)
>
Author: gclayton
Date: Wed Aug 10 18:25:57 2016
New Revision: 278304
URL: http://llvm.org/viewvc/llvm-project?rev=278304&view=rev
Log:
Fix a problem where if a uint64_t value is placed into a python dictionary and
sent up to LLDB and converted to StructuredData, it would not be able to parse
the
Author: gclayton
Date: Wed Aug 10 17:55:26 2016
New Revision: 278302
URL: http://llvm.org/viewvc/llvm-project?rev=278302&view=rev
Log:
Make pascal debugging work again.
Modified:
lldb/trunk/source/Symbol/ClangASTContext.cpp
Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp
URL:
http
clayborg accepted this revision.
clayborg added a reviewer: clayborg.
clayborg added a comment.
This revision is now accepted and ready to land.
This was committed with 278299. We can iterate on this as needed.
https://reviews.llvm.org/D22950
___
ll
Author: gclayton
Date: Wed Aug 10 17:43:48 2016
New Revision: 278299
URL: http://llvm.org/viewvc/llvm-project?rev=278299&view=rev
Log:
Centralize all select() calls into one place so that we can take advantage of
system specific optimizations to deal with more file descriptors than
FD_SETSIZE on
Author: tfiala
Date: Wed Aug 10 16:07:48 2016
New Revision: 278289
URL: http://llvm.org/viewvc/llvm-project?rev=278289&view=rev
Log:
xfailed TestObjCNewSyntax.py on macOS for gmodules
Tracked by:
rdar://27792848
Modified:
lldb/trunk/packages/Python/lldbsuite/test/lang/objc/objc-new-syntax/T
Author: gclayton
Date: Wed Aug 10 15:37:45 2016
New Revision: 278286
URL: http://llvm.org/viewvc/llvm-project?rev=278286&view=rev
Log:
Fix the lookup of dictionary values by name to not do a linear search.
Modified:
lldb/trunk/include/lldb/Core/StructuredData.h
Modified: lldb/trunk/include/
clayborg added a comment.
Is this something the user is typing in your IDE that you are forwarding to
LLDB via pipes? Again, why are you using the command and not the API. There are
API for everything you can do and no IDE should be doing code like:
void MyDebugger::ClearAllBreakpoints()
{
m
joshimbriani added a comment.
In https://reviews.llvm.org/D23290#511275, @clayborg wrote:
> Can you explain the scenarios where you are going to use LLDB with pipes?
Sure! Essentially we are duplicating some of the functionality of the command
line, specifically when commands need confirmation
Author: ismail
Date: Wed Aug 3 05:46:42 2016
New Revision: 277585
URL: http://llvm.org/viewvc/llvm-project?rev=277585&view=rev
Log:
Fix the BUILD_SHARED_LIBS=ON build, was getting the following error while
linking liblldb.so:
../include/llvm/Target/TargetOptions.h:104: error: undefined referenc
joshimbriani added a comment.
In https://reviews.llvm.org/D23290#511446, @clayborg wrote:
> I think we all got that part. The question is why are you interacting via
> text input/output and not using the C++ API?
Well we are using the C++ API to initiate the command but the command waits for
Author: zturner
Date: Wed Aug 10 12:59:03 2016
New Revision: 278253
URL: http://llvm.org/viewvc/llvm-project?rev=278253&view=rev
Log:
Remove a circular include dependency.
lldb-private-interfaces.h included lldb-private.h, and
lldb-private.h included lldb-private-interfaces.h.
Modified:
lldb
clayborg added a comment.
In https://reviews.llvm.org/D23290#511433, @joshimbriani wrote:
> In https://reviews.llvm.org/D23290#511275, @clayborg wrote:
>
> > Can you explain the scenarios where you are going to use LLDB with pipes?
>
>
> Sure! Essentially we are duplicating some of the functional
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
OK. I can't complain if it doesn't affect performance and could allow multiple
packets to be in flight with threading, though I think solving this issue with
threading is a bit of a hack,
clayborg added a comment.
Can you explain the scenarios where you are going to use LLDB with pipes?
https://reviews.llvm.org/D23290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Wed Aug 10 08:30:20 2016
New Revision: 278222
URL: http://llvm.org/viewvc/llvm-project?rev=278222&view=rev
Log:
Make sure files include what they use (part 1/N)
preparation for the big clang-format.
Modified:
lldb/trunk/include/lldb/Core/Flags.h
lldb/trunk/include/ll
labath updated this revision to Diff 67507.
labath added a comment.
The patch I used to run the tests. Still very much WIP.
https://reviews.llvm.org/D22914
Files:
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.cpp
source/Plugins/Process/gdb-remote/GDBRemoteClientBase.h
source/Plugi
labath added a comment.
In https://reviews.llvm.org/D22914#510084, @clayborg wrote:
> Let me know how things look on Mac. Our lock primitives are not as fast as
> linux. If all looks good on Mac speed wise, we should be good to go.
These are the results on Mac. Before:
Testing sending 1000
Zach, it looks like you have a `#define LLVM_PRETTY_FUNCTION
LLVM_PRETTY_FUNCTION` in the non-windows path in test_common.h, which
makes it a no-op. If you change the definition to __PRETTY_FUNCTION__
then it should work.
pl
On 10 August 2016 at 05:21, Todd Fiala via lldb-commits
wrote:
> That s
labath added inline comments.
Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:304
@@ +303,3 @@
+ $(subst $(3),$(1),$(2)), \
+ $(if $(findstring ar,$(1)), \
+$(if $(findstring gcc,$(3)), \
--
labath added a comment.
I would implement this logic slightly differently: Have a ternary setting,
let's call it `debugger.interactive`, whose values are `never, always, auto`,
with `auto` (the current behavior) being the default. I think that makes it the
behavior of the debugger more predicti
22 matches
Mail list logo