jaydeep accepted this revision.
jaydeep added a comment.
This revision is now accepted and ready to land.
Looks good to me
Repository:
rL LLVM
http://reviews.llvm.org/D12356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.l
Author: jingham
Date: Tue Sep 1 20:59:14 2015
New Revision: 246616
URL: http://llvm.org/viewvc/llvm-project?rev=246616&view=rev
Log:
Move more functionality from the LanguageRuntimes to the Languages.
Modified:
lldb/trunk/include/lldb/Target/CPPLanguageRuntime.h
lldb/trunk/include/lldb/T
Author: enrico
Date: Tue Sep 1 20:31:10 2015
New Revision: 246614
URL: http://llvm.org/viewvc/llvm-project?rev=246614&view=rev
Log:
Add a Language::ForAllLanguages helper function
Modified:
lldb/trunk/include/lldb/Target/Language.h
lldb/trunk/source/Target/Language.cpp
Modified: lldb/tr
Author: enrico
Date: Tue Sep 1 20:28:24 2015
New Revision: 246613
URL: http://llvm.org/viewvc/llvm-project?rev=246613&view=rev
Log:
Use Language::LanguageIsCPlusPlus instead of doing the same switch over language
Modified:
lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
M
Author: enrico
Date: Tue Sep 1 20:21:31 2015
New Revision: 246612
URL: http://llvm.org/viewvc/llvm-project?rev=246612&view=rev
Log:
Move the functions that FormatManager uses to actually load formatters into
their own file
These are useful helpers over the low-level API of the FormattersContain
Author: jingham
Date: Tue Sep 1 20:06:46 2015
New Revision: 246611
URL: http://llvm.org/viewvc/llvm-project?rev=246611&view=rev
Log:
Move things from the LanguageRuntime that obviously belong in the new Language
plugin instead.
Modified:
lldb/trunk/include/lldb/Target/Language.h
lldb/tr
By having a Mac(*) to fire up, you are already a better man than I...
Jim
* really non-primary platform system, but that's less euphonious...
> On Sep 1, 2015, at 4:00 PM, Zachary Turner wrote:
>
> Ahh thanks, you beat me to it. I was just firing up my Mac to fix this.
>
> On Tue, Sep 1, 20
Author: brucem
Date: Tue Sep 1 18:57:17 2015
New Revision: 246609
URL: http://llvm.org/viewvc/llvm-project?rev=246609&view=rev
Log:
Simplify find_first_of & find_last_of on single char.
Summary:
When calling find_first_of and find_last_of on a single character,
we can instead just call find / rf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246609: Simplify find_first_of & find_last_of on single
char. (authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12518?vs=33664&id=33759#toc
Repository:
rL LLVM
http://reviews.l
Author: brucem
Date: Tue Sep 1 18:51:30 2015
New Revision: 246608
URL: http://llvm.org/viewvc/llvm-project?rev=246608&view=rev
Log:
Remove ABIMacOSX_i386::PrepareNormalCall().
Summary:
This was removed from the other ABI plugins long ago. This removes
a warning that was happening in this unused
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246608: Remove ABIMacOSX_i386::PrepareNormalCall().
(authored by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12514?vs=33659&id=33757#toc
Repository:
rL LLVM
http://reviews.llvm.org/D1
Author: brucem
Date: Tue Sep 1 18:45:14 2015
New Revision: 246606
URL: http://llvm.org/viewvc/llvm-project?rev=246606&view=rev
Log:
[debugserver] Fix sign comparison warning.
Summary:
Comparing m_page_size against kInvalidPageSize was resulting in
a warning about comparing integers with differen
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246606: [debugserver] Fix sign comparison warning. (authored
by brucem).
Changed prior to commit:
http://reviews.llvm.org/D12519?vs=33666&id=33756#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246605: Use -Wno-vla-extension globally. (authored by
brucem).
Changed prior to commit:
http://reviews.llvm.org/D12515?vs=33660&id=33755#toc
Repository:
rL LLVM
http://reviews.llvm.org/D12515
Files
Author: brucem
Date: Tue Sep 1 18:43:51 2015
New Revision: 246605
URL: http://llvm.org/viewvc/llvm-project?rev=246605&view=rev
Log:
Use -Wno-vla-extension globally.
Summary:
This was previously only established within debugserver, but
there is a use of the VLA extension in source/Host/macosx/Sym
Ahh thanks, you beat me to it. I was just firing up my Mac to fix this.
On Tue, Sep 1, 2015 at 3:58 PM Jim Ingham via lldb-commits <
lldb-commits@lists.llvm.org> wrote:
> Author: jingham
> Date: Tue Sep 1 17:56:59 2015
> New Revision: 246601
>
> URL: http://llvm.org/viewvc/llvm-project?rev=2466
Author: jingham
Date: Tue Sep 1 17:56:59 2015
New Revision: 246601
URL: http://llvm.org/viewvc/llvm-project?rev=246601&view=rev
Log:
Fix ProcessKDP.cpp for the change in r246578.
Modified:
lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
lldb/trunk/source/Plugins/Process/Ma
Author: enrico
Date: Tue Sep 1 17:24:35 2015
New Revision: 246597
URL: http://llvm.org/viewvc/llvm-project?rev=246597&view=rev
Log:
std::initializer_list is not safe to return from a function, as copies are not
guaranteed to extend the lifetime of the underlying storage
Modified:
lldb/trun
Author: enrico
Date: Tue Sep 1 15:11:13 2015
New Revision: 246580
URL: http://llvm.org/viewvc/llvm-project?rev=246580&view=rev
Log:
Add logging to a couple of regions of code
Modified:
lldb/trunk/source/DataFormatters/TypeCategoryMap.cpp
lldb/trunk/source/Plugins/LanguageRuntime/ObjC/A
Author: zturner
Date: Tue Sep 1 15:02:29 2015
New Revision: 246578
URL: http://llvm.org/viewvc/llvm-project?rev=246578&view=rev
Log:
Have the Process hold a weak_ptr to the Target.
Modified:
lldb/trunk/include/lldb/Target/Process.h
lldb/trunk/include/lldb/lldb-private-interfaces.h
ll
Author: zturner
Date: Tue Sep 1 15:02:44 2015
New Revision: 246579
URL: http://llvm.org/viewvc/llvm-project?rev=246579&view=rev
Log:
Make ProcessWindows not create a strong reference to itself.
Added:
lldb/trunk/source/Plugins/Process/Windows/Live/ProcessWindowsForward.h
Modified:
lldb/t
dawn updated the summary for this revision.
dawn set the repository for this revision to rL LLVM.
dawn updated this revision to Diff 33721.
Repository:
rL LLVM
http://reviews.llvm.org/D11102
Files:
include/lldb/Target/StackFrame.h
source/Commands/CommandObjectExpression.cpp
source/Expres
Author: ovyalov
Date: Tue Sep 1 14:02:14 2015
New Revision: 246574
URL: http://llvm.org/viewvc/llvm-project?rev=246574&view=rev
Log:
Make remote-android platform to use dynamic local tcp ports when forwarding
device ports.
http://reviews.llvm.org/D12510
Modified:
lldb/trunk/source/Plugin
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Author: zturner
Date: Tue Sep 1 13:25:05 2015
New Revision: 246570
URL: http://llvm.org/viewvc/llvm-project?rev=246570&view=rev
Log:
Un-XFAIL a couple tests that are now passing.
Modified:
lldb/trunk/test/settings/quoting/TestQuoting.py
Modified: lldb/trunk/test/settings/quoting/TestQuoting
Author: zturner
Date: Tue Sep 1 13:24:49 2015
New Revision: 246569
URL: http://llvm.org/viewvc/llvm-project?rev=246569&view=rev
Log:
XFAIL TestHelloWorld on Windows.
https://llvm.org/pr24600
Modified:
lldb/trunk/test/python_api/hello_world/TestHelloWorld.py
Modified: lldb/trunk/test/python
Author: enrico
Date: Tue Sep 1 13:22:39 2015
New Revision: 246568
URL: http://llvm.org/viewvc/llvm-project?rev=246568&view=rev
Log:
Add support for language plugins to provide data formatters (second attempt)
Historically, data formatters all exist in a global repository (the category
map)
On t
dawn added a comment.
Just an update to let you know I'm still working on this (and a hundred other
things)...
Comment at: source/Expression/ClangExpressionParser.cpp:227
@@ +226,3 @@
+// for C++, and then we'll truly be able to follow the frame language.
For now,
+
Author: spyffe
Date: Tue Sep 1 13:00:35 2015
New Revision: 246563
URL: http://llvm.org/viewvc/llvm-project?rev=246563&view=rev
Log:
When looking up types, find the first type we can import rather than just taking
the first type we find and failing if it can't be imported.
Modified:
lldb/trun
Author: spyffe
Date: Tue Sep 1 12:58:03 2015
New Revision: 246562
URL: http://llvm.org/viewvc/llvm-project?rev=246562&view=rev
Log:
Add a predicate to allow a ClangASTContext to identify Clang types.
Modified:
lldb/trunk/include/lldb/Symbol/ClangASTContext.h
Modified: lldb/trunk/include/lld
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
See inlined comments.
Main fix themes:
- It would be great to try and avoid any manual function calls where we supply
the compile unit and a DIE offset that we assume comes from
Hello everyone,
Is anyone interesting in our existing builder
clang-mergefunc-x86_64-freebsd?
http://lab.llvm.org:8011/builders/clang-mergefunc-x86_64-freebsd
I do not see any activity on it, if no one use it I will remove it.
Please speak up if you need this builder!
Thanks
Galina
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246558: Implement DoReadMemory for Windows mini dumps.
(authored by amccarth).
Changed prior to commit:
http://reviews.llvm.org/D12507?vs=33644&id=33708#toc
Repository:
rL LLVM
http://reviews.llvm.o
Author: amccarth
Date: Tue Sep 1 11:59:31 2015
New Revision: 246558
URL: http://llvm.org/viewvc/llvm-project?rev=246558&view=rev
Log:
Implement DoReadMemory for Windows mini dumps.
Differential Revision: http://reviews.llvm.org/D12507
Modified:
lldb/trunk/source/Plugins/Process/Windows/MiniD
This revision was automatically updated to reflect the committed changes.
Closed by commit rL246557: Make ProcessGDBRemote get a //copy// of platform
Unix signals. (authored by chaoren).
Changed prior to commit:
http://reviews.llvm.org/D12420?vs=33485&id=33707#toc
Repository:
rL LLVM
http:/
Author: chaoren
Date: Tue Sep 1 11:58:45 2015
New Revision: 246557
URL: http://llvm.org/viewvc/llvm-project?rev=246557&view=rev
Log:
Make ProcessGDBRemote get a //copy// of platform Unix signals.
Summary: Update to http://reviews.llvm.org/rL243618.
Reviewers: jaydeep, clayborg
Subscribers: lab
zturner accepted this revision.
This revision is now accepted and ready to land.
Comment at:
source/Plugins/Process/Windows/MiniDump/ProcessWinMiniDump.cpp:249-252
@@ -240,3 +248,6 @@
{
-// TODO
-return 0;
+// I don't have a sense of how frequently this is called or
tberghammer updated this revision to Diff 33702.
tberghammer added a comment.
Move escaping code to Args
http://reviews.llvm.org/D12531
Files:
include/lldb/Interpreter/Args.h
source/Interpreter/Args.cpp
source/Interpreter/CommandInterpreter.cpp
test/functionalities/completion/Makefile
tberghammer updated this revision to Diff 33692.
tberghammer added a comment.
Address review comment (the function already exists in Args)
http://reviews.llvm.org/D12531
Files:
source/Interpreter/Options.cpp
test/functionalities/completion/Makefile
test/functionalities/completion/TestComp
Author: labath
Date: Tue Sep 1 10:00:51 2015
New Revision: 246549
URL: http://llvm.org/viewvc/llvm-project?rev=246549&view=rev
Log:
[NativeProcessLinux] Fix detach of multithreaded inferiors
When detaching, we need to detach from all threads of the inferior and not just
the main one.
Without th
labath added inline comments.
Comment at: source/Interpreter/Options.cpp:996
@@ +995,3 @@
+{
+if (c == ' ' || c == '\\')
+s.push_back('\\');
If there is any chance quotes will appear here (', ", `), you will need to
escape thos
labath updated this revision to Diff 33689.
labath added a comment.
I've found another source or racyness in the test. The test verified that the
process resumes and
stops after a "continue". However, if these two events happened two fast, the
initial start event
would be lost, and the test woul
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Fix tab completion for command arguments containing spaces
If a command argument contains a space then it have to be escaped with
backslash signs so the argument parsin
labath created this revision.
labath added reviewers: zturner, clayborg.
labath added a subscriber: lldb-commits.
The test (among other things) attempts to verify that detaching works while the
inferior is
running. However, this was racy since the inferior could end up stopping again
before we g
tberghammer requested changes to this revision.
This revision now requires changes to proceed.
Comment at:
source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:820-821
@@ -819,1 +819,4 @@
+
+ioVec.iov_len = (offsetof (struct user_hwdebug_state,
dbg_regs[m_ma
tberghammer added a comment.
Added some inline comments to explain some implementation decisions
Comment at: include/lldb/Symbol/ObjectFile.h:372
@@ -371,3 +371,3 @@
virtual SectionList *
-GetSectionList ();
+GetSectionList (bool update_module_section_list = true);
tberghammer updated the summary for this revision.
tberghammer updated this revision to Diff 33676.
tberghammer added a comment.
[RFC] DO NOT COMMIT!
Update the design based on the discussion for the previous diff.
The current version have ~35 failures with split dwarf (most of them hit an
asse
Author: labath
Date: Tue Sep 1 05:59:36 2015
New Revision: 246539
URL: http://llvm.org/viewvc/llvm-project?rev=246539&view=rev
Log:
[NativeProcessLinux] Fix assertion failure when killing a process
Linux sometimes sends us a PTRACE_EVENT_EXIT when an inferior process gets a
SIGKILL. This can be
omjavaid created this revision.
omjavaid added a reviewer: tberghammer.
omjavaid added a subscriber: lldb-commits.
Herald added subscribers: rengolin, aemerson.
This patch makes sure that we are setting the correct number of hardware
breakpoint or watchpoint registers while setting/clearing hardw
tberghammer accepted this revision.
tberghammer added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D12356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Hello,
the cmake fixes seem fine, but something about your changes broke all
libcxx tests, regardless of the build system: osx/xcode: <
http://lab.llvm.org:8011/builders/lldb-x86_64-darwin-13.4/builds/5309>,
linux/cmake: <
http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/575
Author: labath
Date: Tue Sep 1 04:02:54 2015
New Revision: 246536
URL: http://llvm.org/viewvc/llvm-project?rev=246536&view=rev
Log:
Revert "Add support for language plugins to provide data formatters"
This reverts r246515 (and related cmake fixes) as it breaks all libcxx tests.
Removed:
lld
52 matches
Mail list logo
