labath added inline comments.

================
Comment at: source/Interpreter/Options.cpp:996
@@ +995,3 @@
+        {
+            if (c == ' ' || c == '\\')
+                s.push_back('\\');
----------------
If there is any chance quotes will appear here (', ", `), you will need to 
escape those as well, as they are special to the command interpreter. It might 
be worth making a utility function out of that 
(Args::GetCommandInterpreterSafeArgument ?), as a canonical way to escape stuff.


http://reviews.llvm.org/D12531



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to