dawn added a comment.
In http://reviews.llvm.org/D12303#231759, @ted wrote:
> This is essentially reverting http://reviews.llvm.org/rL237053 , so we'd go
> back to the problem with it - LLDB won't be able to set the platform based on
> the architecture in the target binary, but will use the cur
ted added a comment.
This is essentially reverting http://reviews.llvm.org/rL237053 , so we'd go
back to the problem with it - LLDB won't be able to set the platform based on
the architecture in the target binary, but will use the currently selected
platform, even if it's not compatible.
Line
dawn created this revision.
dawn added reviewers: ted, clayborg.
dawn added a subscriber: lldb-commits.
dawn set the repository for this revision to rL LLVM.
This fixes dotest.py on OSX after svn rev.237053. After that commit, running
dotest.py on OSX would return nothing but ERRORs after runnin
tberghammer added a comment.
In the current version of the patch the compile units in the main object file
hands out only the compile unit DIE with the information what is available in
the main object file. I considered the other approach (hand out all DIEs by the
DWARF compile unit in the main
dawn accepted this commit.
dawn added a comment.
After some investigation, it appears your patch may have simply exposed an
existing bug, so in one sense I owe an appology, but in another, your patch
made that bug impossible to workaround. :) Before your change, it was possible
to count the tot
clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.
I see the need for a lot of this, but I feel like there are way too many places
where we do this:
SymbolFileDWARFDwo* dwo_symbol_file = dwarf_cu->GetDwoSymbolFile();
if (dwo_
dawn added a subscriber: dawn.
dawn raised a concern with this commit.
dawn added a comment.
This broke dotest.py on OSX. When running tests via:
./dotest.py -v --executable $INSTALLDIR/bin/lldb
Before this commit, all tests run:
Configuration: arch=x86_64 compiler=clang
---
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
DWARFExpression is unique in that it is separate from the DWARF plug-in itself
because DWARF expressions are in .eh_frame and other things that don't require
the rest of DWARF
dawn added a subscriber: lldb-commits.
Users:
ted (Author)
http://reviews.llvm.org/rL237053
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Add split dwarf support to SymbolFileDWARF
* Create new dwo symbol file class
* Add handling for .dwo sections
* Propagate queries from SymbolFileDWARF to the dwo symbol
tberghammer created this revision.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
Handle DW_OP_GNU_addr_index in DWARF expressions
This is a new operand in the dwarf expressions used when split dwarf is enabled
http://reviews.llvm.org/D12290
Files:
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks good.
http://reviews.llvm.org/D12239
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
Hello everyone,
LLVM buildmaster will be restarted after 5 PM Pacific time today.
Thanks
Galina
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: labath
Date: Mon Aug 24 10:49:12 2015
New Revision: 245848
URL: http://llvm.org/viewvc/llvm-project?rev=245848&view=rev
Log:
Add the correct decorator to TestCreateDuringInstructionStep
apparently, just placing the file under linux/ does not make the test linux
specific. :)
Modified:
Author: labath
Date: Mon Aug 24 09:24:20 2015
New Revision: 245842
URL: http://llvm.org/viewvc/llvm-project?rev=245842&view=rev
Log:
Fix TestCreateDuringInstructionStep on i386
Modified:
lldb/trunk/test/linux/thread/create_during_instruction_step/main.cpp
Modified: lldb/trunk/test/linux/thre
Author: labath
Date: Mon Aug 24 08:25:54 2015
New Revision: 245839
URL: http://llvm.org/viewvc/llvm-project?rev=245839&view=rev
Log:
Simplify NativeThreadLinux includes
there is no need to include architecture-specific register contexts when the
generic one will
suffice.
Modified:
lldb/trun
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245838: Make TestCreateDuringInstructionStep linux-specific
(authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12280?vs=32950&id=32952#toc
Repository:
rL LLVM
http://reviews.llv
Author: labath
Date: Mon Aug 24 08:23:48 2015
New Revision: 245838
URL: http://llvm.org/viewvc/llvm-project?rev=245838&view=rev
Log:
Make TestCreateDuringInstructionStep linux-specific
Summary:
There were a number of issues about the way I have designed this test
originally:
- it relied on singl
labath added a comment.
There is a similar issue during thread destruction, although the underlying
reason is a bit different. I have created bug #24551 to track that.
http://reviews.llvm.org/D12280
___
lldb-commits mailing list
lldb-commits@lists.
tberghammer accepted this revision.
tberghammer added a comment.
This revision is now accepted and ready to land.
Looks good with 2 minor comments
- After the renames the test path don't say that the test is thread related. I
think you should add it back to somewhere (e.g. to the test name)
- Sh
labath created this revision.
labath added a reviewer: tberghammer.
labath added a subscriber: lldb-commits.
Herald added subscribers: srhines, danalbert, tberghammer.
There were a number of issues about the way I have designed this test
originally:
- it relied on single-stepping through large pa
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:729
@@ -727,3 +728,3 @@
if (attributes.ExtractFormValueAtIndex(m_dwarf2Data, i,
form_value))
-name = form_value.AsCString(debug_str);
+
tberghammer updated this revision to Diff 32949.
tberghammer added a comment.
Change DWARFFormValue::AsCString to take SymbolFileDWARF as an argument instead
of DWARFDataExtractor
http://reviews.llvm.org/D12238
Files:
include/lldb/lldb-enumerations.h
source/Expression/IRExecutionUnit.cpp
tberghammer added inline comments.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.h:165
@@ -164,3 +164,3 @@
const DWARFCompileUnit* cu,
-const uint8_t *fixed_form_sizes,
+DWARFFormValue::FixedFormSizes f
tberghammer updated this revision to Diff 32946.
tberghammer added a comment.
Address review comments
http://reviews.llvm.org/D12239
Files:
source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp
source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
source/Plugins/SymbolFile/DWARF/DWARFDeb
Author: tberghammer
Date: Mon Aug 24 05:31:36 2015
New Revision: 245836
URL: http://llvm.org/viewvc/llvm-project?rev=245836&view=rev
Log:
Fix teardown cleanup in TestRecursiveTypes
Modified:
lldb/trunk/test/types/TestRecursiveTypes.py
Modified: lldb/trunk/test/types/TestRecursiveTypes.py
URL
Author: tberghammer
Date: Mon Aug 24 05:21:55 2015
New Revision: 245834
URL: http://llvm.org/viewvc/llvm-project?rev=245834&view=rev
Log:
Add absolute load address support for the DynamicLoader plugins
The POSIX linker generally reports the load bias for the loaded
libraries but in some case it i
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245834: Add absolute load address support for the
DynamicLoader plugins (authored by tberghammer).
Changed prior to commit:
http://reviews.llvm.org/D12233?vs=32813&id=32939#toc
Repository:
rL LLVM
h
Author: labath
Date: Mon Aug 24 04:22:04 2015
New Revision: 245831
URL: http://llvm.org/viewvc/llvm-project?rev=245831&view=rev
Log:
[NativeProcessLinux] Pass around threads by reference
Summary:
Most NPL private functions took (shared) pointers to threads as arguments. This
meant that the
calle
This revision was automatically updated to reflect the committed changes.
Closed by commit rL245831: [NativeProcessLinux] Pass around threads by
reference (authored by labath).
Changed prior to commit:
http://reviews.llvm.org/D12237?vs=32824&id=32937#toc
Repository:
rL LLVM
http://reviews.l
31 matches
Mail list logo
