ted added a comment.

This is essentially reverting http://reviews.llvm.org/rL237053 , so we'd go 
back to the problem with it - LLDB won't be able to set the platform based on 
the architecture in the target binary, but will use the currently selected 
platform, even if it's not compatible.

Line 131 has this:

  platform_sp = debugger.GetPlatformList().GetSelectedPlatform();

So platform_sp will always be true, unless LLDB doesn't have a current (or 
default host) platform. The code to check to see if the target arch and the 
platform are compatible will never be run.

What error is causing the tests to fail?


Repository:
  rL LLVM

http://reviews.llvm.org/D12303



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to