annotation at the right
position where necessary.
Signed-off-by: Uwe Kleine-König
---
Hello,
I don't know how arch/powerpc is maintained. So please tell me if I
should split this patch further.
I manually checked that all const annotations are OK, and the 0day build
bot didn't find a regress
5. To keep supporting MPC5121 this patch introduces a cpp
macro to select the right struct that defines the register layout.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/include/asm/mpc52xx_psc.h | 5 ++-
drivers/spi/spi-mpc512x-psc.c | 70 +++---
2 files c
On Tue, Jul 14, 2015 at 10:54:42AM +0100, Mark Brown wrote:
> On Tue, Jul 14, 2015 at 11:19:56AM +0200, Uwe Kleine-König wrote:
>
> > static const struct of_device_id mpc512x_psc_spi_of_match[] = {
> > - { .compatible = "fsl,mpc5121-psc-spi", },
> > + {
The drivers support MPC5125 additionally to MPC5121, and there is an spi
mode that is also supported. Additionally some minor corrections are
done.
Signed-off-by: Uwe Kleine-König
---
Hello,
I sent a patch adding mpc5125 support to the mpc512x driver and Mark
requested the new compatible to be
These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
according to the datasheet[1] MEMERROR is bit 25 (0x40) and ORERR is
bit 27 (0x10).
[1] MPC5125RM Rev. 2; 11/2009
Signed-off-by: Uwe Kleine-König
85dfc for some build configurations.
Fixes: 8bf960985dfc ("spi: mpc512x-psc: add support for Freescale MPC5125")
Signed-off-by: Uwe Kleine-König
---
Hello,
didn't check why "my" config doesn't throw this warning, but I could reproduce
and fix it with the .config an
machines.
Signed-off-by: Uwe Kleine-König
---
Hello,
got the parameters for git-send-email wrong and forgot to send this to the
powerpc folks.
Best regards
Uwe
arch/powerpc/boot/dts/fsl/mpc8536si-post.dtsi | 2 +-
arch/powerpc/boot/dts/fsl/mpc8572si-post.dtsi | 2 +-
2 files changed, 2 insertions
ower_flags(void)
> +static inline int cpu_corepower_flags(void)
> {
> return SD_SHARE_PKG_RESOURCES | SD_SHARE_POWERDOMAIN;
> }
Maybe the author's intention was:
static inline int cpu_corepower_flags(void) __attribute__((const));
?
This specifies that the function
e__((const));
static inline int cpu_corepower_flags(void)
{
...
Does this help?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
__
int __attribute_const__ read_cpuid_id(void)
{
return readl(BASEADDR_V7M_SCB + V7M_SCB_CPUID);
}
from arch/arm/include/asm/cputype.h. The V7M_SCB_CPUID register never
changes, but there is no way gcc can deduce that.
Best regards
Uwe
--
Pengutronix e.K.
driver isn't holding.
Fixes: bb74d9a4a87b ("fs_enet: use the new fixed PHY helpers")
Signed-off-by: Uwe Kleine-König
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fs_enet/fs
The ucc_geth_probe function assigns to ug_info->tbi_node and
ug_info->phy_node a value returned by of_parse_phandle which returns a
new reference. Put this reference again in the error path of
ucc_geth_probe and when removing the device.
Signed-off-by: Uwe Kleine-König
---
No Fixes: foote
driver isn't holding. Fix that by getting a
reference to the MAC.
Fixes: 87009814cdbb ("ucc_geth: use the new fixed PHY helpers")
Signed-off-by: Uwe Kleine-König
---
drivers/net/ethernet/freescale/ucc_geth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
xed PHY helpers")
Signed-off-by: Uwe Kleine-König
---
drivers/net/ethernet/freescale/ucc_geth.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index a22ff770f9e5..07415
On Thu, Aug 07, 2014 at 11:48:24PM +0200, Uwe Kleine-König wrote:
> The ucc_geth_probe function assigns to ug_info->tbi_node and
> ug_info->phy_node a value returned by of_parse_phandle which returns a
> new reference. Put this reference again in the error path of
> ucc_g
My series to fix the reference counting of dt nodes introduced a build
failure. Fix it.
Fixes: fa310789a488 ("net: ucc_geth: drop acquired references in probe error
path and remove")
Signed-off-by: Uwe Kleine-König
---
Hello,
I found a powerpc toolchain now, so this really builds
te' has no member named 'info'
> of_node_put(ugeth->info->phy_node);
>^
>
> Introduced by commit "net: ucc_geth: drop acquired references in probe error
> path and remove".
>
> From the context, it appears that the variable is named ug_info.
>
> Cc:
Hello Guenter,
On Sun, Aug 10, 2014 at 11:42:41AM -0700, Guenter Roeck wrote:
> On 08/10/2014 11:36 AM, Uwe Kleine-König wrote:
> >On Sun, Aug 10, 2014 at 09:19:14AM -0700, Guenter Roeck wrote:
> >>powerpc:mpc83xx_defconfig and other builds fail with
> >>
> &g
Hello,
On Tue, Jul 21, 2015 at 09:21:13AM +0200, Uwe Kleine-König wrote:
> These were introduced in commit 25ae3a0739c6 ("[POWERPC] mpc512x: Add
> MPC512x PSC support to MPC52xx psc driver") and never used. Moreover
> according to the datasheet[1] MEMERROR is bit 25 (0x40) an
look at the other patches in this series, but assuming that
they are similar in spirit, the same question applies for them.
Do I miss anything?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
From: Arnd Bergmann
[ukl: split Arnd's patch by driver]
Signed-off-by: Arnd Bergmann
Signed-off-by: Uwe Kleine-König
---
drivers/macintosh/mediabay.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
From: Arnd Bergmann
[ukl: split Arnd's patch by driver]
Signed-off-by: Arnd Bergmann
Signed-off-by: Uwe Kleine-König
---
drivers/i2c/busses/i2c-mpc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-
onst' qualifier from pointer target type [enabled by default]
Signed-off-by: Arnd Bergmann
[ukl: split Arnd's patch by driver and add changelog]
Signed-off-by: Uwe Kleine-König
---
drivers/watchdog/mpc8xxx_wdt.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
pointer target type [enabled by default]
Signed-off-by: Uwe Kleine-König
---
drivers/macintosh/mediabay.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/macintosh/mediabay.c b/drivers/macintosh/mediabay.c
index 831d751..54bf584 100644
--- a/drivers/macintosh/medi
From: Arnd Bergmann
This cast is unneeded since *of_device_id.data became const.
[ukl: split Arnd's patch by driver and add changelog]
Signed-off-by: Arnd Bergmann
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/sysdev/fsl_msi.c |6 +++---
1 file changed, 3 insertions(+), 3 dele
pointer target type [-Werror]
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/sysdev/fsl_msi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/fsl_msi.c b/arch/powerpc/sysdev/fsl_msi.c
index 6e097de..a40acd6 100644
--- a/arch/powerpc/sysdev/fsl_msi.c
+++ b
pointer target type [enabled by default]
Signed-off-by: Uwe Kleine-König
---
drivers/gpio/gpio-mpc8xxx.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 5a1817e..9ae29cc 100644
--- a/drivers/gpio/gpio-mpc8xxx.
#x27; qualifier from pointer target type [enabled by default]
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/platforms/cell/celleb_pci.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/cell/celleb_pci.c
b/arch/powerpc/platforms/cell/celleb_pci.c
in
pointer target type [enabled by default]
Signed-off-by: Uwe Kleine-König
---
drivers/i2c/busses/i2c-mpc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c
index b76731e..775062c 100644
--- a/drivers/i2c/busses/i2c-mpc
from pointer target type [-Werror]
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/platforms/83xx/suspend.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/platforms/83xx/suspend.c
b/arch/powerpc/platforms/83xx/suspend.c
index 1a04671..1d769a2 100644
--- a/ar
Hello,
On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2012-07-23 at 11:13 +0200, Uwe Kleine-König wrote:
> > This prepares *of_device_id.data becoming const. Without this change
> > the following warning would occur:
> >
> > drive
On Wed, Sep 05, 2012 at 07:23:43PM +1000, Benjamin Herrenschmidt wrote:
> On Wed, 2012-09-05 at 10:02 +0200, Uwe Kleine-König wrote:
> > Hello,
> >
> > On Wed, Sep 05, 2012 at 12:40:17PM +1000, Benjamin Herrenschmidt wrote:
> > > On Mon, 2012-07-23 at 11:13
y and so
cannot contain non-const variables.
Signed-off-by: Uwe Kleine-König
Cc: Josh Boyer
Cc: Matt Porter
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Anatolij Gustschin
Cc: Kumar Gala
Cc: Arnd Bergmann
Cc: linuxppc-dev@lists.ozlabs.org
Cc: cbe-oss-...@lists.ozlabs.org
---
arch/po
s and compile to see the error.
While touching these annotations I also corrected the position where it
was wrong to go between the variable name and the =.
Note this series is not compile tested.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Indus
On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> this series fixes a common error to use __initdata to mark const
> variables. Most of the time this works well enough to go unnoticed
> (though I wonder why the linker doesn't warn about that
y and so
cannot contain non-const variables.
Signed-off-by: Uwe Kleine-König
Cc: Josh Boyer
Cc: Matt Porter
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Anatolij Gustschin
Cc: Kumar Gala
Cc: Arnd Bergmann
Cc: linuxppc-dev@lists.ozlabs.org
Cc: cbe-oss-...@lists.ozlabs.org
---
changes
Hello,
On Thu, Mar 29, 2012 at 11:11:31PM +0200, Uwe Kleine-König wrote:
> this series fixes a common error to use __initdata to mark const
> variables. Most of the time this works well enough to go unnoticed
> (though I wonder why the linker doesn't warn about that).
> Just try
Uwe
[1] make mx27_defconfig
make savedefconfig
mv defconfig arch/arm/configs/mx27_defconfig
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
_
Hello,
On Sat, Mar 26, 2011 at 06:11:29PM +1100, Stephen Rothwell wrote:
> Uwe Kleine-König reported:
>
> while working on an defconfig (arm/mx27) I noticed that just updating
> it[1] results in removing CONFIG_EEPROM_AT24=y. The reason is that
>
octl can
register a device. But the fear for such code in the kernel made me
choose not to squash 737a3bb941 into 44f28bdea094. So my POV is that if
the maintainer of the radeon driver thinks registering the device is OK,
reverting 737a3bb9416 is fine for me.
Best regards
Uwe
--
Pengutronix e.K.
in the commit log would
be nice. Something like:
The BT_L2CAP and BT_SCO configs are bool since
6427451 (Bluetooth: Merge L2CAP and SCO modules into
bluetooth.ko)
. So change all defconfigs from =m to =y.
Other than that
Acked-by: Uwe Kleine-König
Best
2~43^2~4
so it was introduced just before -rc2.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linux
Hello Gabriel
On Wed, Apr 13, 2011 at 12:31:44PM +0200, Gabriel Paubert wrote:
> On Wed, Apr 13, 2011 at 10:59:14AM +0200, Andreas Schwab wrote:
> > Uwe Kleine-König writes:
> >
> > > $ git name-rev --refs=refs/tags/v2.6\*
> > > 69a07f0
h/esdhc.h in this
patch as advertised in the subject?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
n array
(as it's for the imx-spi driver) driver_data can hold flags, too, which
should be enough most of the time.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/
15 deletions(-)
Nice.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
Hello,
On Tue, Jul 13, 2010 at 09:07:41AM +0200, Uwe Kleine-König wrote:
> Hi
>
> On Mon, Jul 12, 2010 at 01:50:47PM -0600, Grant Likely wrote:
> > On Mon, Jul 12, 2010 at 1:34 PM, Linus Torvalds
> > wrote:
> > > On Mon, Jul 12, 2010 at 12:17 PM, Nicolas Pitre w
struct
usb_gadget_driver can go away.
Signed-off-by: Uwe Kleine-König
Cc: Michal Nazarewicz
Cc: Greg Kroah-Hartman
---
Hello,
there is an alternative patch in Greg's tree [1], but IMHO mine is
better as it doesn't need __ref.
Thoughts?
Uwe
[1]
http://www.kernel.org/pub/linux/kern
Hello Michał,
On Fri, Jul 30, 2010 at 05:16:46PM +0200, Michał Nazarewicz wrote:
> On Fri, 30 Jul 2010 16:49:14 +0200, Uwe Kleine-König
> wrote:
>
>> This is like usb_gadget_register_driver with the only difference that it
>> gets the bind function as parameter instead
;bind to allow driver to
live in .data and bind to live in .init.text without a section mismatch.
So the other cases are broken. I'll recheck.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutro
On Fri, Jul 30, 2010 at 06:08:23PM +0200, Michał Nazarewicz wrote:
> On Fri, 30 Jul 2010 17:26:02 +0200, Uwe Kleine-König
> wrote:
>> On Fri, Jul 30, 2010 at 05:16:46PM +0200, Michał Nazarewicz wrote:
>>> On Fri, 30 Jul 2010 16:49:14 +0200, Uwe Kleine-König
>>>
__init printer_bind()
All callers are fixed.
Signed-off-by: Uwe Kleine-König
Cc: Michał Nazarewicz
Cc: David Brownell
Cc: Julia Lawall
Cc: Greg Kroah-Hartman
---
Hello,
now that Michał seems to be happy with my approach I made the effort to come up
with a complete patch that fixes the section
| bind || !driver->setup
>
> I have the impression that this should be !bind rather than bind.
ah, now I see what you meant. Obviously you're right. I fixed it up
locally here for now. Greg, just tell me when/if you need a fixed
patch.
> That would be like what is done i
rning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/dma/fsldma.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index ddcf736d283d..18a6c4bf6275 100644
--- a/driver
ed a wrong subject prefix, please apply the remainder of
this series anyhow.
Best regards
Uwe
Uwe Kleine-König (59):
dma: altera-msgdma: Convert to platform remove callback returning void
dma: apple-admac: Convert to platform remove callback returning void
dma: at_hdmac: Convert to platform remov
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/soc/fsl/qe/tsa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/fsl/qe/tsa.c b/drivers/soc/fsl/qe/tsa.c
index 3646153117b3..3f9981335590 100644
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/soc/fsl/dpaa2-console.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/fsl/dpaa2-console.c b/drivers/soc/fsl/dpaa2-console.c
index 1dca693
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/soc/fsl/qe/qmc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/soc/fsl/qe/qmc.c b/drivers/soc/fsl/qe/qmc.c
index b3c292c9a14e..92ec76c03965 100644
you stop by negative feedback for other patches (unless it
applies to "your" patches, too, of course).
Best regards and thanks for considering,
Uwe
Uwe Kleine-König (40):
soc/aspeed: aspeed-lpc-ctrl: Convert to platform remove callback
returning void
soc/aspeed: aspeed-lpc-sn
On Wed, Sep 27, 2023 at 04:01:58PM -0700, Bjorn Andersson wrote:
> On Wed, Sep 27, 2023 at 10:43:16AM +0200, Arnd Bergmann wrote:
> > On Wed, Sep 27, 2023, at 04:25, Joel Stanley wrote:
> > > On Mon, 25 Sept 2023 at 09:55, Uwe Kleine-König
> > > wrote:
> > &
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/mtd/devices/powernv_flash.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/devices/powernv_flash.c
b/drivers/mtd/devices/powernv_flash.c
ll patches), please apply the remainder of this series anyhow.
I'll come back to the part that you (maybe) skipped at a later point.
Best regards
Uwe
Uwe Kleine-König (20):
mtd: rawnand: txx9ndfmc: Mark driver struct with __refdata to prevent
section mismatch warning
mtd: rawnand:
ide a remove
callback that returns no value") for the rationale.
On Thu, Sep 28, 2023 at 08:14:49AM +0200, Uwe Kleine-König wrote:
> On Wed, Sep 27, 2023 at 04:01:58PM -0700, Bjorn Andersson wrote:
> > On Wed, Sep 27, 2023
5.afswdgcv4axjf...@pengutronix.de
Uwe Kleine-König (6):
usb: gadget: at91-udc: Convert to use module_platform_driver()
usb: gadget: fsl-udc: Convert to use module_platform_driver()
usb: gadget: fusb300-udc: Convert to use module_platform_driver()
usb: gadget: lpc32xx-udc:
e and .remove are defined in plain .text), stop suffering from the
downsides and use module_platform_driver() instead of
module_platform_driver_probe().
Signed-off-by: Uwe Kleine-König
---
drivers/usb/gadget/udc/fsl_udc_core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dr
ion
and the eventual goal of this conversion.
Uwe Kleine-König (2):
tty: hvc: Make hvc_remove() return no value
tty: hvc: hvc_opal: Convert to platform remove callback returning void
drivers/tty/hvc/hvc_console.c | 3 +--
drivers/tty/hvc/hvc_console.h | 2 +-
drivers/tty/hvc/hvc_opal.c| 17
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/tty/hvc/hvc_opal.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/hvc/hvc_opal.c b/drivers/tty/hvc/hvc_opal.c
index 8995b253cf90..2cdf66e
The function hvc_remove() returns zero unconditionally. Make it return
void instead to make it obvious that the caller doesn't need to do any
error handling. Accordingly drop the error handling from
hvc_opal_remove().
Signed-off-by: Uwe Kleine-König
---
drivers/tty/hvc/hvc_console.c
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/tty/serial/ucc_uart.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/serial/ucc_uart.c b/drivers/tty/serial/ucc_uart.c
index ed7a6bb
n out of the #ifdef so it is always visible.
>
> Signed-off-by: Arnd Bergmann
Other than that:
Reviewed-by: Uwe Kleine-König
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
rge.
Best regards
Uwe
Uwe Kleine-König (52):
serial: 8250: omap: Don't skip resource freeing if
pm_runtime_resume_and_get() failed
serial: sccnxp: Improve error message if regulator_disable() fails
serial: 8250: Convert to platform remove callback returning void
serial: altera_jt
On Mon, Nov 13, 2023 at 07:45:27PM +1000, Nicholas Piggin wrote:
> On Mon Nov 6, 2023 at 7:44 AM AEST, Uwe Kleine-König wrote:
> > The function hvc_remove() returns zero unconditionally. Make it return
> > void instead to make it obvious that the caller doesn't need to do an
lways returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/net/wan/fsl_ucc_hdlc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
index fd50bb3
ut I don't think it's worth to add that to
stable, it was broken since v5.7-rc1 and nobody seems to have hit the
problem.
Best regards
Uwe
Uwe Kleine-König (10):
net: ipa: Don't error out in .remove()
net: ipa: Convert to platform remove callback returning void
net: fjes: C
ssage replacing the (less useful)
message by the core. Apart from the improved error message there is no
change in behaviour.
Signed-off-by: Uwe Kleine-König
---
drivers/usb/gadget/udc/fsl_udc_core.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/gadge
7;t make
a difference to the drivers apart from the improved error message.
See commit 5c5a7680e67b ("platform: Provide a remove callback that
returns no value") for an extended explanation and the eventual goal of
.remove_new().
Best regards
Uwe
Uwe Kleine-König (5):
usb: gadget:
ed-by: Simon Horman
Signed-off-by: Uwe Kleine-König
---
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 5 ++---
drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 6 ++
drivers/net/ethernet/freescale/fs_enet/mii-fec.c | 6 ++
3 files changed, 6 insertions(+), 11 deletions(-)
ed-by: Simon Horman
Signed-off-by: Uwe Kleine-König
---
drivers/net/ethernet/freescale/ucc_geth.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/ucc_geth.c
b/drivers/net/ethernet/freescale/ucc_geth.c
index 7a4cb4f07c32..2b3a15f24e7c 100644
Wei Fang and
rebased to v6.5-rc1.
There is only one dependency in this series: Patch #2 depends on patch
#1.
Best regards
Uwe
[1]
https://lore.kernel.org/netdev/20230606162829.166226-1-u.kleine-koe...@pengutronix.de
Uwe Kleine-König (8):
net: dpaa: Improve error reporting
net: dpaa: Convert
rning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/512x/mpc512x_lpbfifo.c
b/arch/powerpc/platforms
rning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
Changes since (implicit) v1:
- provide an actually compilable patch :-\
Best regards
Uwe
arch/powerpc/platforms/512x/mpc512x_lpbfifo.c | 6 ++
1 file changed, 2 insertions(+), 4 dele
ers need to
> explicitly include the correct includes.
>
> Signed-off-by: Rob Herring
Acked-by: Uwe Kleine-König # for imx
Thanks for your efforts!
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions
Instead of resorting to BUG() ensure that the driver isn't unbound by
suppressing its bind and unbind sysfs attributes. As the driver is
built-in there is no way to remove a device once bound.
As a nice side effect this allows to drop the remove function.
Signed-off-by: Uwe Kleine-
On Wed, Dec 28, 2022 at 03:51:29PM +0100, Uwe Kleine-König wrote:
> The four exported functions mpc52xx_lpbfifo_submit(),
> mpc52xx_lpbfifo_abort(), mpc52xx_lpbfifo_poll(), and
> mpc52xx_lpbfifo_start_xfer() are not used. So they can be dropped and the
> definitions needed to call
Hello,
On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> Hello,
>
> many bus remove functions return an integer which is a historic
> misdesign that makes driver authors assume that there is some kind of
> error handling in the upper layers. This is wrong howeve
Hello Leo,
On Wed, Apr 12, 2023 at 09:30:05PM +, Leo Li wrote:
> > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> > > Hello,
> > >
> > > many bus remove functions return an integer which is a historic
> > > misdesign that make
function and so the driver is effectively superfluous and can be deleted.
Also drop some defines and a struct from that are unused
now together with the declarations of the four mentioned functions.
Signed-off-by: Uwe Kleine-König
---
Hello Michael,
On Thu, Apr 13, 2023 at 10:11:25AM +1000, Michael
Hello Leo,
On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:
> On Wed, Apr 12, 2023 at 09:30:05PM +, Leo Li wrote:
> > > On Fri, Mar 10, 2023 at 11:41:22PM +0100, Uwe Kleine-König wrote:
> > > > Hello,
> > > >
> > > > many b
st to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
dr
st to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
dr
st to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
dr
st to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
dr
onverted as the others
drivers are.
The two davinci patches are also the only interdependency in this
series. I was unsure if I should split the series in two, the busses and
the mux changes; if convenient these can be applied independent of each
other.
Best regards
Uwe
Uwe Kleine-König (89):
i2c:
Hello,
On Thu, Apr 13, 2023 at 08:16:42AM +0200, Uwe Kleine-König wrote:
> While mpc5200b.dtsi contains a device that this driver can bind to, the
> only purpose of a bound device is to be used by the four exported functions
> mpc52xx_lpbfifo_submit(), mpc52xx_lpbf
rning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König
---
drivers/usb/gadget/udc/fsl_qe_udc.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/gadget/udc/fsl_qe_udc.c
b/drivers/usb/gadget/udc/fsl_qe_udc.c
quot;) for a more detailed rationale.
All drivers converted here already returned zero unconditionally in their
.remove() callback, so converting them to .remove_new() is trivial.
Best regards
Uwe
Uwe Kleine-König (97):
usb: c67x00-drv: Convert to platform remove callback returning void
usb:
be_new() from
struct i2c_driver.
Signed-off-by: Uwe Kleine-König
---
Hello,
this patch was generated using coccinelle, but I aligned the result to
the per-file indention.
I chose to convert all drivers below drivers/macintosh in a single
patch, but if you prefer I can split by driver.
v6.4-rc1 was
be_new() from
struct i2c_driver.
Signed-off-by: Uwe Kleine-König
---
sound/aoa/codecs/onyx.c | 2 +-
sound/aoa/codecs/tas.c | 2 +-
sound/pci/hda/cs35l41_hda_i2c.c | 2 +-
sound/ppc/keywest.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/aoa/c
be_new() from struct i2c_driver.
Signed-off-by: Uwe Kleine-König
---
arch/powerpc/platforms/44x/ppc476.c| 2 +-
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/44x/ppc476.c
b/arch/powerpc/platform
Hello,
On Mon, May 08, 2023 at 04:57:00PM -0500, Li Yang wrote:
> On Mon, May 8, 2023 at 8:44 AM Uwe Kleine-König
> wrote:
> > On Thu, Apr 13, 2023 at 08:00:04AM +0200, Uwe Kleine-König wrote:
> > > On Wed, Apr 12, 2023 at 09:30:05PM +, Leo Li wrote:
> > > >
1 - 100 of 311 matches
Mail list logo
