On Mon, Nov 13, 2023 at 07:45:27PM +1000, Nicholas Piggin wrote: > On Mon Nov 6, 2023 at 7:44 AM AEST, Uwe Kleine-König wrote: > > The function hvc_remove() returns zero unconditionally. Make it return > > void instead to make it obvious that the caller doesn't need to do any > > error handling. Accordingly drop the error handling from > > hvc_opal_remove(). > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koe...@pengutronix.de> > > IIUC these are functionally no change, just tidying and removing > dead code?
In case this isn't only a rethorical question: There is indeed no
change in behaviour. hvc_remove() returned always zero, so
rc = hvc_remove(hp);
if (rc == 0) {
... some code not changing rc ...
}
... some more code not changing rc ...
return rc
can be simplified to
hvc_remove(hp);
... some code not changing rc ...
... some more code not changing rc ...
return 0;
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
signature.asc
Description: PGP signature
