Re: [PATCH net-next] af_unix: fix a fatal race with bit fields

2013-05-01 Thread Stephen Hemminger
On Tue, 30 Apr 2013 22:04:32 -0700 Eric Dumazet wrote: > On Wed, 2013-05-01 at 13:24 +0930, Alan Modra wrote: > > On Tue, Apr 30, 2013 at 07:24:20PM -0700, Eric Dumazet wrote: > > > li 11,1 > > > ld 0,0(9) > > > rldimi 0,11,31,32 > > > std 0,0(9) > > > blr > > > .ident "GCC: (GNU) 4.

Re: [v3, 2/9] fsl/fman: Add the FMan port FLIB

2015-07-22 Thread Stephen Hemminger
On Wed, 22 Jul 2015 14:21:48 +0300 wrote: > diff --git a/drivers/net/ethernet/freescale/fman/Kconfig > b/drivers/net/ethernet/freescale/fman/Kconfig > index 8aeae29..af42c3a 100644 > --- a/drivers/net/ethernet/freescale/fman/Kconfig > +++ b/drivers/net/ethernet/freescale/fman/Kconfig > @@ -5,3 +

Re: [PATCH v5 01/45] percpu_rwlock: Introduce the global reader-writer lock backend

2013-01-22 Thread Stephen Hemminger
On Tue, 22 Jan 2013 13:03:22 +0530 "Srivatsa S. Bhat" wrote: > A straight-forward (and obvious) algorithm to implement Per-CPU Reader-Writer > locks can also lead to too many deadlock possibilities which can make it very > hard/impossible to use. This is explained in the example below, which help

Re: [PATCH net-next 17/22] hv_netvsc: fix return type of ndo_start_xmit function

2018-09-20 Thread Stephen Hemminger
On Thu, 20 Sep 2018 20:33:01 +0800 YueHaibing wrote: > The method ndo_start_xmit() is defined as returning an 'netdev_tx_t', > which is a typedef for an enum type, so make sure the implementation in > this driver has returns 'netdev_tx_t' value, and change the function > return type to netdev_tx_

RE: [PATCH V3 1/10] X86/Hyper-V: Add parameter offset for hyperv_fill_flush_guest_mapping_list()

2019-02-22 Thread Stephen Hemminger
int hyperv_fill_flush_guest_mapping_list( struct hv_guest_mapping_flush_list *flush, - u64 start_gfn, u64 pages) + int offset, u64 start_gfn, u64 pages) { u64 cur = start_gfn; u64 additional_pages; - int gpa_n = 0; + int gpa_n

Re: [PATCH] net: add Xilinx emac lite device driver

2009-08-18 Thread Stephen Hemminger
On Tue, 18 Aug 2009 09:30:41 -0600 John Linn wrote: > +/** > + * xemaclite_enable_interrupts - Enable the interrupts for the EmacLite > device > + * @drvdata: Pointer to the Emaclite device private data > + * > + * This function enables the Tx and Rx interrupts for the Emaclite device > along >

Re: [PATCH] [V3] net: add Xilinx emac lite device driver

2009-08-20 Thread Stephen Hemminger
On Thu, 20 Aug 2009 03:49:51 -0600 John Linn wrote: > +/** > + * xemaclite_ioctl - Perform IO Control operations on the network device > + * @dev: Pointer to the network device > + * @rq: Pointer to the interface request structure > + * @cmd: IOCTL command > + * > + * The onl

Re: net_device_ops support in bridging and fec_mpc52xx.c

2009-02-18 Thread Stephen Hemminger
On Wed, 18 Feb 2009 13:48:52 -0800 (PST) David Miller wrote: > From: Henk Stegeman > Date: Wed, 18 Feb 2009 11:41:14 +0100 > > Please CC: netdev, now added, on all networking reports and patches. > > Thank you. > > > I discovered the hard way that because linux bridging uses > > net_device_op

Re: Patch: Fix fec_mpc52xx driver to use net_device_ops

2009-03-31 Thread Stephen Hemminger
On Tue, 31 Mar 2009 12:44:15 +0200 Henk Stegeman wrote: > Fix fec_mpc52xx driver to use net_device_ops and to be careful not to > dereference phy_device if a phy has not yet been connected. > > Signed-off-by: Henk Stegeman > > diff --git a/drivers/net/fec_mpc52xx.c b/drivers/net/fec_mpc52xx.c

Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

2007-10-17 Thread Stephen Hemminger
Please don't use double underscore, for this function name. There is no reason to not make it a normal API call. The sky2 fix I am working on will use napi_synchronize as well. --- a/include/linux/netdevice.h 2007-10-16 16:48:20.0 -0700 +++ b/include/linux/netdevice.h 2007-10-17 08:29:55.

Re: [PATCH v4] FEC - fast ethernet controller for mpc52xx

2007-10-25 Thread Stephen Hemminger
ata). > > Yeah. Sorry. That won't be so easy. We'll either need to > squirrel away the mapped address, or change the interface to > bcom_retrieve_buffers() so we can get the address. > > IMO, it's still a requirement that we call dma_unmap_single() for > each call to dma_map_single(). > There exist some macro's for pci stuff to handle the nop case well see: pci_unmap_addr(), pci_unmap_len(). -- Stephen Hemminger <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: RFC: issues concerning the next NAPI interface

2007-08-24 Thread Stephen Hemminger
re to hold off interrupts until X packets or Y usecs have expired. The parameters for controlling it are already in ethtool, the issue is finding a good default set of values for a wide range of applications and architectures. Maybe some heuristic based on processor speed would be a good starting point. The dynamic irq moderation stuff is not widely used because it is too hard to get right. -- Stephen Hemminger <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v4] qe: miscellaneous code improvements and fixes to the QE library

2007-10-03 Thread Stephen Hemminger
On Wed, 3 Oct 2007 11:34:59 -0500 Timur Tabi <[EMAIL PROTECTED]> wrote: > This patch makes numerous miscellaneous code improvements to the QE library. > > 1. Remove struct ucc_common and merge ucc_init_guemr() into ucc_set_type() >(every caller of ucc_init_guemr() also calls ucc_set_type()).

Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

2007-10-16 Thread Stephen Hemminger
ait for a whole millisecond and sleep that is far longer than the napi routine should take. You could even optimize it like synchronize_irq() for the non-SMP case. -- Stephen Hemminger <[EMAIL PROTECTED]> ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [RFC v1] net: add PCINet driver

2008-10-23 Thread Stephen Hemminger
On Thu, 23 Oct 2008 15:49:32 -0700 Ira Snyder <[EMAIL PROTECTED]> wrote: > This adds support to Linux for a virtual ethernet interface which uses the > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > method of communication for two devices connected by a PCI interface

Re: [PATCH RFC v2] net: add PCINet driver

2008-10-29 Thread Stephen Hemminger
On Wed, 29 Oct 2008 13:20:27 -0700 Ira Snyder <[EMAIL PROTECTED]> wrote: > This adds support to Linux for a virtual ethernet interface which uses the > PCI bus as its transport mechanism. It creates a simple, familiar, and fast > method of communication for two devices connected by a PCI interface

Re: [PATCH 2/4][RFC] lro: Kconfig and Makefile

2007-07-30 Thread Stephen Hemminger
On Mon, 30 Jul 2007 17:24:45 +0200 Jan-Bernd Themann <[EMAIL PROTECTED]> wrote: > Kconfig and Makefile for LRO > > Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> > > --- > net/ipv4/Kconfig |8 > net/ipv4/Makefile |1 + > 2 files changed, 9 insertions(+), 0 deletions(-) >

Re: [PATCH 0/4][RFC] lro: Generic Large Receive Offload for TCP traffic

2007-07-30 Thread Stephen Hemminger
Could someone add this to: http://linux-net.osdl.org Wiki? ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH net-next] ibmvnic: Increase driver logging

2020-07-16 Thread Stephen Hemminger
On Thu, 16 Jul 2020 13:22:00 -0700 Jakub Kicinski wrote: > On Thu, 16 Jul 2020 18:07:37 +0200 Michal Suchánek wrote: > > On Thu, Jul 16, 2020 at 10:59:58AM -0500, Thomas Falcon wrote: > > > On 7/15/20 8:29 PM, David Miller wrote: > > > > From: Jakub Kicinski > > > > Date: Wed, 15 Jul 2020

Re: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h

2022-02-18 Thread Stephen Hemminger
On Fri, 18 Feb 2022 06:12:37 -0600 Segher Boessenkool wrote: > On Fri, Feb 18, 2022 at 10:35:48AM +0900, Masahiro Yamada wrote: > > On Fri, Feb 18, 2022 at 3:10 AM Segher Boessenkool > > wrote: > > > On Fri, Feb 18, 2022 at 02:27:16AM +0900, Masahiro Yamada wrote: > > > > On Fri, Feb 18, 202

Re: [PATCH net 1/5] ibmvnic: harden interrupt handler

2017-01-26 Thread Stephen Hemminger
On Wed, 25 Jan 2017 15:02:19 -0600 Thomas Falcon wrote: > static irqreturn_t ibmvnic_interrupt(int irq, void *instance) > { > struct ibmvnic_adapter *adapter = instance; > + unsigned long flags; > + > + spin_lock_irqsave(&adapter->crq.lock, flags); > + vio_disable_interrupts(a

RE: [PATCH 1/2] PCI: Add pci_set_vpd_timeout() to set VPD access timeout

2016-11-22 Thread Stephen Hemminger
; Bjorn Helgaas ; linuxppc-dev@lists.ozlabs.org; Stephen Hemminger Subject: Re: [PATCH 1/2] PCI: Add pci_set_vpd_timeout() to set VPD access timeout On 22/11/16 09:05, Bjorn Helgaas wrote: > Hi Matthew, > > On Mon, Nov 21, 2016 at 03:09:49PM -0600, Matthew R. Ochs wrote: >> The