On Thu, 20 Aug 2009 03:49:51 -0600
John Linn <john.l...@xilinx.com> wrote:
> +/**
> + * xemaclite_ioctl - Perform IO Control operations on the network device
> + * @dev: Pointer to the network device
> + * @rq: Pointer to the interface request structure
> + * @cmd: IOCTL command
> + *
> + * The only IOCTL operation supported by this function is setting the MAC
> + * address. An error is reported if any other operations are requested.
> + *
> + * Return: 0 to indicate success, or a negative error for failure.
> + */
> +static int xemaclite_ioctl(struct net_device *dev, struct ifreq *rq, int cmd)
> +{
> + struct net_local *lp = (struct net_local *) netdev_priv(dev);
> + struct hw_addr_data *hw_addr = (struct hw_addr_data *) &rq->ifr_hwaddr;
> +
> + switch (cmd) {
> + case SIOCETHTOOL:
> + return -EIO;
> +
> + case SIOCSIFHWADDR:
> + dev_err(&lp->ndev->dev, "SIOCSIFHWADDR\n");
> +
> + /* Copy MAC address in from user space */
> + copy_from_user((void __force *) dev->dev_addr,
> + (void __user __force *) hw_addr,
> + IFHWADDRLEN);
> + xemaclite_set_mac_address(lp, dev->dev_addr);
> + break;
> + default:
> + return -EOPNOTSUPP;
> + }
> +
> + return 0;
> +}
Do you really need this? I doubt the SIOCSIFHWADDR even reaches driver!
The normal call path for setting hardware address is:
dev_ifsioc
dev_set_mac_address
ops->ndo_set_mac_address -->
The driver should be:
1. defining new code to do ndo_set_mac_address
2. remove existing xmaclite_ioctl - all ioctl's handled by upper layers
FYI - the only ioctl's that make it to network device ndo_ioctl
are listed in dev_ifsioc
SIOCDEVPRIVATE ... SIOCDEVPRIVATE + 15
SIOCBOND*
SIOCMII*
SIOCBR*
SIOCHWTSTAMP
SIOCWANDEV
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
