Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-17 Thread Peter Korsgaard
en Doug> Signed-off-by: Doug Anderson For i2c-ocores.c + i2c-mux-gpio.c: Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 05/35 linux-next] tty: constify of_device_id array

2015-03-16 Thread Peter Korsgaard
>>>>> "Fabian" == Fabian Frederick writes: > of_device_id is always used as const. > (See driver.of_match_table and open firmware functions) > Signed-off-by: Fabian Frederick > --- For this: > drivers/tty/serial/uartlite.c | 2 +- Ac

Re: [PATCH 119/493] usb: remove use of __devexit_p

2012-11-20 Thread Peter Korsgaard
>>>>> "Nicolas" == Nicolas Ferre writes: Nicolas> On 11/19/2012 07:21 PM, Bill Pemberton : >> CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer >> needed. >> >> Signed-off-by: Bill Pemberton >> Cc: Peter Kor

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-14 Thread Peter Korsgaard
Wolfram> Based on v3.5-rc2. Only build tested, I don't have a OF based device Wolfram> around at the moment. Neither have I, but it looks good. Acked-by: Peter Korsgaard Wolfram> @Peter: Why does ocores do the device registration manually via Wolfram> platform_data instead of u

Re: [PATCH] powerpc: Consolidate obj-y assignments

2010-11-07 Thread Peter Korsgaard
insertions(+), 5 deletions(-) Michael> - signal.o sysfs.o cacheinfo.o Michael> -obj-y+= vdso32/ Michael> + signal.o sysfs.o cacheinfo.o time.o \ Michael> + time.o prom.o traps.o setup-common.o

Re: [RFC PATCH 07/15] dt: uartlite: merge platform and of_platform driver bindings

2011-02-23 Thread Peter Korsgaard
2->start); Grant> } Isn't this going to give a build warning about prop being unused on !CONFIG_OF builds? Perhaps move it down into the CONFIG_OF conditional? Other than that, Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 21/28] powerpc: sysdev/mpc8xxx_gpio irq_data conversion.

2011-03-16 Thread Peter Korsgaard
>>>>> "Lennert" == Lennert Buytenhek writes: Lennert> Signed-off-by: Lennert Buytenhek Lennert> --- Lennert> v2: get_irq_chip_data(d->irq) => irq_data_get_irq_chip_data(d) Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard

Re: GPIO driver for MPC8313.

2009-09-22 Thread Peter Korsgaard
MPC8xxx_GPIO and add a gpio-controller node to your dts, similar to how it's done in arch/powerpc/boot/dts/mpc837*_rdb.dts. See Documentation/powerpc/dts-bindings/fsl/8xxx_gpio.txt for details of the dts bindings. -- Bye, Peter Korsgaard ___ Linux

Re: GPIO driver for MPC8313.

2009-09-23 Thread Peter Korsgaard
rough sysfs. See 'Sysfs Interface for Userspace' section of Documentation/gpio.txt -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: GPIO driver for MPC8313.

2009-09-27 Thread Peter Korsgaard
I should port MPC8313-erdb pached to 2.6.28 opposite? It shouldn't be that hard to back port, but I would certainly go for 2.6.28 (or rather 2.6.31) unless something keeps you at 2.6.23. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH] i2c-mpc: Do not generate STOP after read.

2009-09-28 Thread Peter Korsgaard
>>>>> "Joakim" == Joakim Tjernlund writes: Hi, Joakim> Ah, that explains it. Who then will look after i2c-mpc? Kumar? Ben Dooks (embedded i2c maintainer). He's afaik coming home today, so give him a few days to catch up on

[PATCH 1/3] show_interrupts: use irq_chip::name if available

2009-12-01 Thread Peter Korsgaard
struct irq_chip::typename is going away (replaced by name). Use name if set instead of typename in show_interrupt to make ease transition. Signed-off-by: Peter Korsgaard --- arch/powerpc/kernel/irq.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH 2/3] asm/gpio.h: support gpio_to_irq()

2009-12-01 Thread Peter Korsgaard
gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's safe to always call. Signed-off-by: Peter Korsgaard --- arch/powerpc/include/asm/gpio.h |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/include/asm/gpio.h b/arch/powerpc/i

[PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-01 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- arch/powerpc/sysdev/mpc8xxx_gpio.c | 147 1 files changed, 147 insertions(+), 0 deletions(-) diff --git a/arch/powerpc/sysdev/mpc8xxx_gpio.c b/arch/powerpc/sysdev/mpc8xxx_gpio.c index 103eace..b46f28b 100644 --- a/arch

Re: [PATCH 1/3] show_interrupts: use irq_chip::name if available

2009-12-08 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Peter> struct irq_chip::typename is going away (replaced by name). Use name if Peter> set instead of typename in show_interrupt to make ease transition. Comments? Peter> Signed-off-by: Peter Korsgaard Peter> -

Re: [PATCH 2/3] asm/gpio.h: support gpio_to_irq()

2009-12-08 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Peter> gpiolib returns -ENXIO if struct gpio_chip::to_irq isn't set, so it's Peter> safe to always call. Comments? Peter> Signed-off-by: Peter Korsgaard Peter> --- Peter> arch/powerpc/include/a

Re: [PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-08 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Comments? Peter> Signed-off-by: Peter Korsgaard Peter> --- Peter> arch/powerpc/sysdev/mpc8xxx_gpio.c | 147 Peter> 1 files changed, 147 insertions(+), 0 deletions(-) Pe

Re: [PATCH 1/3] show_interrupts: use irq_chip::name if available

2009-12-09 Thread Peter Korsgaard
>>>>> "Benjamin" == Benjamin Herrenschmidt writes: Benjamin> On Wed, 2009-12-09 at 08:32 +0100, Peter Korsgaard wrote: >> >>>>> "Peter" == Peter Korsgaard writes: >> Peter> struct irq_chip::typename is going awa

Re: [PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-11 Thread Peter Korsgaard
ides the stuff in booting-without-of.txt -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] add gpio to mpc837X rdb

2009-01-29 Thread Peter Korsgaard
mpc8347-gpio", Reynes> "fsl,mpc8349-gpio"; The patch is wordwrapped, and you should use fsl,mpc8377-gpio, not mpc8347 (E.G. , mpc8349) -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] add gpio to mpc837X rdb

2009-02-02 Thread Peter Korsgaard
{ Reynes> + #gpio-cells = <2>; Reynes> + compatible = "fsl,mpc8377-gpio", Reynes> "fsl,mpc8349-gpio"; Still word wrapped. Please try sending the patch to yourself first and check if you can apply it before sending it to the list. --

Re: U-Boot image

2009-03-04 Thread Peter Korsgaard
d. Günter> Can someone explain me the different fileforamts for booting Günter> a powerpc with u-boot? Which is the simplest to use? Have a look at Documentation/powerpc/bootwrapper.txt -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-08 Thread Peter Korsgaard
> "Anton" == Anton Vorontsov writes: Hi, Anton> The advantages of this: Anton> - Don't encourage legacy support; Anton> - Less external symbols, less code to compile-in for !MPC832x_RDB Anton> platforms. It's nice with your cleanups, but I wonder how to handle more complicated chip se

Re: [PATCH 6/6] powerpc/fsl_soc: Isolate legacy fsl_spi support to mpc832x_rdb boards

2009-04-16 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Anyone? I've locally reverted the commit, but most likely I'm not the only one using the spi_mpc83xx driver without direct gpio controlled chip select handling. Anton> The advantages of this: Anton> - Don&#

Re: [MTD] ofpart: Partitions at same address cannot have the same name

2009-04-22 Thread Peter Korsgaard
*dev, Ricardo> /* check if this is a partition node */ Ricardo> partname = of_get_property(pp, "name", &len); Ricardo> - if (strcmp(partname, "partition") != 0) { Ricardo> + if (strncmp(part

Re: [PATCH 3/3] mpc8xxx_gpio: add interrupt support

2009-12-17 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: >>>>> "Kumar" == Kumar Gala writes: Peter> Hi, Kumar> We need a binding document to go with this. Peter> Ok, but where should it go? In the existing Peter> powerpc/dts-bindings/fsl/8xxx

[PATCH-V2] mpc8xxx_gpio: add interrupt support

2009-12-21 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- .../powerpc/dts-bindings/fsl/8xxx_gpio.txt | 22 +++- arch/powerpc/sysdev/mpc8xxx_gpio.c | 147 2 files changed, 168 insertions(+), 1 deletions(-) Changes since v1: - Document OF binding for IRQ as requested by

Re: Does gpio_to_irq() work for MPC52xx gpios?

2009-12-22 Thread Peter Korsgaard
rastructure for gpio_to_irq(). I've recently added irq support to the mpc8xxx driver, but so far nothing has been written for 52xx. http://patchwork.ozlabs.org/patch/41550/ -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@l

Re: [PATCH v2 3/3] powerpc: Add support for ram filesystems in FIT uImages

2009-12-31 Thread Peter Korsgaard
ile uimage support some time ago: http://thread.gmane.org/gmane.linux.ports.ppc64.devel/46825/ The fitimage stuff is the logical continuation of that. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 3/3] powerpc: Add support for ram filesystems in FIT uImages

2010-01-03 Thread Peter Korsgaard
ge.legacy" similar) and Wolfgang> "uImage", then. No, that would break stuff for the existing users. The existing format make/file names shouldn't change. The FIT images could be called fitimage or uImage.new or something. -- Bye, Peter Korsgaard __

Re: [PATCH v2 3/3] powerpc: Add support for ram filesystems in FIT uImages

2010-01-03 Thread Peter Korsgaard
ould we Wolfgang> name it then? "uImage.newer" ? "uImage.verynew" ? Wolfgang> "uImage.new2" ? Hence fitimage. The next thing will presumably be called something else again. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH-V2] mpc8xxx_gpio: add interrupt support

2010-01-04 Thread Peter Korsgaard
>>>>> "Peter" == Peter Korsgaard writes: Peter> Signed-off-by: Peter Korsgaard Comments? With the added documentation I believe it's ready to go.. Peter> --- Peter> .../powerpc/dts-bindings/fsl/8xxx_gpio.txt | 22 +++- Pet

[PATCH] spi_mpc8xxx: fix WARN_ON on remove after 4c1fba44296

2010-01-06 Thread Peter Korsgaard
same check in _cpm_free() as well. Signed-off-by: Peter Korsgaard --- drivers/spi/spi_mpc8xxx.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c index 1fb2a6e..0604d6b 100644 --- a/drivers/spi/spi_mpc8xxx.c +++ b/dr

[PATCHv2] spi_mpc8xxx: fix WARN_ON on remove after 4c1fba44296

2010-01-07 Thread Peter Korsgaard
same check in _cpm_free() as well. Signed-off-by: Peter Korsgaard --- drivers/spi/spi_mpc8xxx.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) Changes since v1: Fix return statement, mpc8xxx_spi_cpm_free() has void return type. diff --git a/drivers/spi/spi_mpc8xxx.c b/driver

[PATCH-V3] mpc8xxx_gpio: add interrupt support

2010-01-07 Thread Peter Korsgaard
Signed-off-by: Peter Korsgaard --- Changes since v1: - Document OF binding for IRQ as requested by Kumar. Changes since v2: - Fix xlate prototype mismatch warning (intspec should be const) .../powerpc/dts-bindings/fsl/8xxx_gpio.txt | 22 +++- arch/powerpc/sysdev/mpc8xxx_gpio.c

Re: [PATCH-V3] mpc8xxx_gpio: add interrupt support

2010-01-12 Thread Peter Korsgaard
>>>>> Peter Korsgaard writes: Hi, Anton, any comments on this? > Signed-off-by: Peter Korsgaard > --- > Changes since v1: > - Document OF binding for IRQ as requested by Kumar. > Changes since v2: > - Fix xlate prototype mismatch warning (intspec shou

Re: How to trun off udbg0 during bootup?

2010-01-21 Thread Peter Korsgaard
it configurable back in Dec 2008: http://lists.ozlabs.org/pipermail/linuxppc-dev/2008-December/066461.html You can probably still get it to apply with a bit of fuzz. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V5] powerpc/mpc512x: Add gpio driver

2010-07-07 Thread Peter Korsgaard
mr; Anatolij> + u32 gpicr1; Anatolij> +u32 gpicr2; Anatolij> +}; -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v4] powerpc/mpc8xxx_gpio.c: extend the driver to support mpc512x gpios

2010-08-20 Thread Peter Korsgaard
y Anatolij> with another gpio controller type. Anatolij> Signed-off-by: Anatolij Gustschin Sorry, was away on holiday. Acked-by: Peter Korsgaard -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH V3 4/4] Fabric bindings for STAC9766 on the Efika

2009-05-28 Thread Peter Korsgaard
make more sense to make this default y when it has such specific dependencies and is so deep down in the tree - Most efika users probably want to enable this if they have enabled ALSA and SND_SOC? -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
ch. I guess Wolfram referred to the context line which was clearly word wrapped: @@ -456,17 +456,22 @@ static int mpc_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num) The other lines look fine. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH v2] i2c-mpc: generate START condition after STOP caused by read i2c_msg

2009-05-28 Thread Peter Korsgaard
abs.org/pipermail/linuxppc-dev/2009-May/072274.html Please consider using git send-email for patches. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] [POWERPC] 83xx: Add support for the Thecus N1200 NAS device

2009-06-05 Thread Peter Korsgaard
rd, yes? Generally compatible should be David> listed from most specific to least specific, so the 8349 entry should David> go first. No, it's an 8347, to the gpio compatible is fine, but the soc8349 should be changed to 8347 above. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: SD card over (xilinx_)SPI, timeout error while CID

2009-06-06 Thread Peter Korsgaard
>>>>> "Joachim" == Joachim Foerster writes: Hi, Joachim> Any hints? Does anybody use SD card support with Joachim> mmc_spi+xilinx_spi ? I don't, but have you compared the spi signals on a scope in the 2 setups? Is timing significantly

[PATCH] mpc83xx/usb.c: fix usb mux setup for mpc834x

2009-06-09 Thread Peter Korsgaard
controller (and happened to use ULPI phys), which is what all the 834x dts have done, even though that configuration is physically invalid. Instead fix mpc8349_usb_cfg() and adjust the dts files to match reality. Signed-off-by: Peter Korsgaard --- arch/powerpc/boot/dts/asp834x-redboot.dts |2

Re: Device tree for c67x00

2009-06-29 Thread Peter Korsgaard
struct platform_device in your board file (or scan the DT in your board file and fill in the correct base address / interrupt number from it). Remember that arch/powerpc uses virtual interrupt numbers if you're going to fill in the platform_device by hand. -- Bye, Peter Korsgaard ___

Re: [PATCH] mpc83xx/usb.c: fix usb mux setup for mpc834x

2009-07-16 Thread Peter Korsgaard
>>>>> "Kumar" == Kumar Gala writes: Hi, Kumar> On Jun 9, 2009, at 6:43 AM, Peter Korsgaard wrote: >> usb0 and usb1 mux settings in the sicrl register were swapped (twice!) >> in mpc834x_usb_cfg(), leading to various strange issues with fsl-ehci >

Re: [PATCH 1/7] [POWERPC] Xilinx: Uartlite: Make console output actually work.

2008-01-09 Thread Peter Korsgaard
> + port->mapbase, base); > +return -ENODEV; Why change the error message? I found the old better. Also use dev_err istead of pr_debug. You again changed the error code. > } > -port = &ulite_ports[id]; > - > -spin_lock_init(&port->lock); > -port->fifosize = 16; > -port->regshift = 2; > -port->iotype = UPIO_MEM; > -port->iobase = 1; /* mark port in use */ port-> mapbase = base; > -port->membase = NULL; > -port->ops = &ulite_ops; port-> irq = irq; > -port->flags = UPF_BOOT_AUTOCONF; port-> dev = dev; > -port->type = PORT_UNKNOWN; > -port->line = id; > - > dev_set_drvdata(dev, port); > /* Register the port */ > -- > 1.5.3.4-dirty > ___ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 7/7] [POWERPC] Xilinx: Uartlite: Section type fixups

2008-01-09 Thread Peter Korsgaard
>>>>> "Stephen" == Stephen Neuendorffer <[EMAIL PROTECTED]> writes: Stephen> All the __devexit functions are now appropriately tagged. This fixes Stephen> some ppc link warnings. You forgot to add __devexit_p(ulite_remove) in ulite_platform_driver,

Re: Please pull linux-2.6-virtex.git

2008-01-09 Thread Peter Korsgaard
/git.secretlab.ca/git/linux-2.6-virtex.git virtex-for-2.6.25 Josh> Hm.. Seems Peter has some comments on the first one. Shall I wait for Josh> that to get hashed out? Yes please. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch v4 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-01-21 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-21 Thread Peter Korsgaard
of cleanups: checkpatch, interrupt handling, c67x00_ prefixes, .. - The dummy platform_device's created per serial engine are gone. - Gadget driver (WIP) Comments are very much appreciated. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Lin

[patch v4 1/4] USB: add Cypress c67x00 low level interface code

2008-01-21 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 426 + drivers/usb/c67x00/c67x00.h| 289 + 2 files changed, 715 insertions(+) Index:

[patch v4 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-01-21 Thread Peter Korsgaard
fig USB_C67X00_HCD - tristate "Cypress C67x00 HCD support" - depends on USB - help - The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role - host/peripheral/OTG USB controllers. - - Enable this option to support this chip in host controller mode. - If unsure, say N. - - To compile this driver as a module, choose M here: the - module will be called c67x00. Index: linux-2.6/drivers/usb/Makefile === --- linux-2.6.orig/drivers/usb/Makefile +++ linux-2.6/drivers/usb/Makefile @@ -17,7 +17,7 @@ obj-$(CONFIG_USB_U132_HCD) += host/ obj-$(CONFIG_USB_R8A66597_HCD) += host/ -obj-$(CONFIG_USB_C67X00_HCD) += c67x00/ +obj-$(CONFIG_USB_C67X00_DRV) += c67x00/ obj-$(CONFIG_USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig === --- linux-2.6.orig/drivers/usb/Kconfig +++ linux-2.6/drivers/usb/Kconfig @@ -91,6 +91,8 @@ source "drivers/usb/host/Kconfig" +source "drivers/usb/c67x00/Kconfig" + source "drivers/usb/class/Kconfig" source "drivers/usb/storage/Kconfig" Index: linux-2.6/drivers/usb/c67x00/Kconfig === --- /dev/null +++ linux-2.6/drivers/usb/c67x00/Kconfig @@ -0,0 +1,21 @@ +# +# Cypress C67x00 USB controller +# +config USB_C67X00_DRV + tristate "Cypress C67x00 support" + # only allowed to be =y if both USB!=m and USB_GADGET!=m + depends on (!USB && USB_GADGET) || (!USB_GADGET && USB) || (USB && USB_GADGET) + help + The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role + host/peripheral USB controllers. + + To compile this driver as a module, choose M here: the + module will be called c67x00. + +config USB_C67X00_HCD + bool "Cypress C67X00 HCD support" + depends on USB && USB_C67X00_DRV + default y + help + Enable this option to support the Cypress C67x00 in host + controller mode. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch v4 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-01-21 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 236 include/linux/usb/c67x00.h | 48 3 files change

Re: [patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-21 Thread Peter Korsgaard
; - Gadget driver (WIP) Grant> Can you please post/publish the diff between v3 and this series? Sure, http://peter.korsgaard.com/c67x00-v3-v4.patch (not posting as it's more than 100k) -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-21 Thread Peter Korsgaard
e following up on pushing it to mainline (some development was still done on it, and we've shipped it in products). Then Grant picked it up (which I'm grateful for) and posted his v1..v3 series. I have now taken his v3 series and merged it with my development. -- Bye, Peter Korsgaard

Re: [patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-21 Thread Peter Korsgaard
ress gadget work is based on it. But anyway, that's details - Most of all I would like to see c67x00 support in mainline, one way or another. Most of the work has been sitting on my hard drive gathering dust since spring 2006. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-23 Thread Peter Korsgaard
I don't feel strongly about the issue. >> >> #endif /* _USB_C67X00_HCD_H */ >> diff --git a/drivers/usb/c67x00/c67x00-sched.c >> b/drivers/usb/c67x00/c67x00-sched.c >> index 35d7318..3140d89 100644 >> --- a/drivers/usb/c67x00/c67x00-sched.c >> +++ b/drivers/usb/c67x00/c67x00-sched.c >> - /* Something went wrong; unwind the allocations */ >> - err_epdata: >> +err_epdata: >> kfree(urbp); >> - err_urbp: >> +err_urbp: >> usb_hcd_unlink_urb_from_ep(hcd, urb); >> - err_not_linked: >> +err_not_linked: Grant> ditto Grant> Cheers, Grant> g. Thanks for the feedback, I'll post an updated series. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-23 Thread Peter Korsgaard
t I've done the change based on your feedback: http://article.gmane.org/gmane.linux.usb.devel/53496 David> I can't think of a reason to demand multiple upstream links, though David> sharing them between root hubs like that isn't a common structure. David> - Dave --

[patch v5 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-01-24 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 236 include/linux/usb/c67x00.h | 48 3 files change

[patch v5 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-24 Thread Peter Korsgaard
: - Addressed Grant's comments (c67x00_dev->c67x00_hcd_dev, label indent) - Moved c67x00_ll_set_ep_{ctrl,packet_size}_reg() to patch 4 as they are only needed for gadget support. - Added c67x00_ prefix to struct lcp_int_data -- Bye, Peter K

[patch v5 1/4] USB: add Cypress c67x00 low level interface code

2008-01-24 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 409 + drivers/usb/c67x00/c67x00.h| 286 + 2 files changed, 695 insertions(+) Index:

[patch v5 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-01-24 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v5 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-01-24 Thread Peter Korsgaard
-hcd. -config USB_C67X00_HCD - tristate "Cypress C67x00 HCD support" - depends on USB - help - The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role - host/peripheral/OTG USB controllers. - - Enable this option to support this chip in host controller mode. - If unsure, say N. - - To compile this driver as a module, choose M here: the - module will be called c67x00. Index: linux-2.6/drivers/usb/Makefile === --- linux-2.6.orig/drivers/usb/Makefile +++ linux-2.6/drivers/usb/Makefile @@ -17,7 +17,7 @@ obj-$(CONFIG_USB_U132_HCD) += host/ obj-$(CONFIG_USB_R8A66597_HCD) += host/ -obj-$(CONFIG_USB_C67X00_HCD) += c67x00/ +obj-$(CONFIG_USB_C67X00_DRV) += c67x00/ obj-$(CONFIG_USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig === --- linux-2.6.orig/drivers/usb/Kconfig +++ linux-2.6/drivers/usb/Kconfig @@ -91,6 +91,8 @@ source "drivers/usb/host/Kconfig" +source "drivers/usb/c67x00/Kconfig" + source "drivers/usb/class/Kconfig" source "drivers/usb/storage/Kconfig" Index: linux-2.6/drivers/usb/c67x00/Kconfig === --- /dev/null +++ linux-2.6/drivers/usb/c67x00/Kconfig @@ -0,0 +1,21 @@ +# +# Cypress C67x00 USB controller +# +config USB_C67X00_DRV + tristate "Cypress C67x00 support" + # only allowed to be =y if both USB!=m and USB_GADGET!=m + depends on (!USB && USB_GADGET) || (!USB_GADGET && USB) || (USB && USB_GADGET) + help + The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role + host/peripheral USB controllers. + + To compile this driver as a module, choose M here: the + module will be called c67x00. + +config USB_C67X00_HCD + bool "Cypress C67X00 HCD support" + depends on USB && USB_C67X00_DRV + default y + help + Enable this option to support the Cypress C67x00 in host + controller mode. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v4 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-28 Thread Peter Korsgaard
y moved to after the Grant> SIE probe because the current probe code depends on interrupts Grant> being enabled. Below is an ugly workaround that solves the Grant> problem to me, but there is probably a better solution. Wouldn't it be simpler to just add a if (sie->dev) check to _ll_

[patch v6 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-01-29 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 232 include/linux/usb/c67x00.h | 48 3 files change

[patch v6 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-01-29 Thread Peter Korsgaard
as they are only needed for gadget support. - Added c67x00_ prefix to struct lcp_int_data Changes since v3: - Lots of cleanups: checkpatch, interrupt handling, c67x00_ prefixes, .. - The dummy platform_device's created per serial engine are gone. - Gadget driver (WIP) -- Bye, Pe

[patch v6 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-01-29 Thread Peter Korsgaard
-hcd. -config USB_C67X00_HCD - tristate "Cypress C67x00 HCD support" - depends on USB - help - The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role - host/peripheral/OTG USB controllers. - - Enable this option to support this chip in host controller mode. - If unsure, say N. - - To compile this driver as a module, choose M here: the - module will be called c67x00. Index: linux-2.6/drivers/usb/Makefile === --- linux-2.6.orig/drivers/usb/Makefile +++ linux-2.6/drivers/usb/Makefile @@ -17,7 +17,7 @@ obj-$(CONFIG_USB_U132_HCD) += host/ obj-$(CONFIG_USB_R8A66597_HCD) += host/ -obj-$(CONFIG_USB_C67X00_HCD) += c67x00/ +obj-$(CONFIG_USB_C67X00_DRV) += c67x00/ obj-$(CONFIG_USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig === --- linux-2.6.orig/drivers/usb/Kconfig +++ linux-2.6/drivers/usb/Kconfig @@ -92,6 +92,8 @@ source "drivers/usb/host/Kconfig" +source "drivers/usb/c67x00/Kconfig" + source "drivers/usb/class/Kconfig" source "drivers/usb/storage/Kconfig" Index: linux-2.6/drivers/usb/c67x00/Kconfig === --- /dev/null +++ linux-2.6/drivers/usb/c67x00/Kconfig @@ -0,0 +1,21 @@ +# +# Cypress C67x00 USB controller +# +config USB_C67X00_DRV + tristate "Cypress C67x00 support" + # only allowed to be =y if both USB!=m and USB_GADGET!=m + depends on (!USB && USB_GADGET) || (!USB_GADGET && USB) || (USB && USB_GADGET) + help + The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role + host/peripheral USB controllers. + + To compile this driver as a module, choose M here: the + module will be called c67x00. + +config USB_C67X00_HCD + bool "Cypress C67X00 HCD support" + depends on USB && USB_C67X00_DRV + default y + help + Enable this option to support the Cypress C67x00 in host + controller mode. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch v6 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-01-29 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v6 1/4] USB: add Cypress c67x00 low level interface code

2008-01-29 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 410 + drivers/usb/c67x00/c67x00.h| 285 + 2 files changed, 695 insertions(+) Index:

Re: [patch v6 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-01-30 Thread Peter Korsgaard
>>>>> "Alan" == Alan Stern <[EMAIL PROTECTED]> writes: Alan> On Tue, 29 Jan 2008, Peter Korsgaard wrote: >> This patch adds HCD support for the Cypress c67x00 family of devices. >> --- /dev/null >> +++ linux-2.6/drivers/usb/c67x00/c67x00-hc

[patch v7 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-02-19 Thread Peter Korsgaard
form_device's created per serial engine are gone. - Gadget driver (WIP) -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-19 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v7 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-02-19 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 232 include/linu

[patch v7 1/4] USB: add Cypress c67x00 low level interface code

2008-02-19 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 410 + drivers/usb/c67x00/c67x00.h| 285

[patch v7 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-02-19 Thread Peter Korsgaard
-hcd. -config USB_C67X00_HCD - tristate "Cypress C67x00 HCD support" - depends on USB - help - The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role - host/peripheral/OTG USB controllers. - - Enable this option to support this chip in host controller mode. - If unsure, say N. - - To compile this driver as a module, choose M here: the - module will be called c67x00. Index: linux-2.6/drivers/usb/Makefile === --- linux-2.6.orig/drivers/usb/Makefile +++ linux-2.6/drivers/usb/Makefile @@ -17,7 +17,7 @@ obj-$(CONFIG_USB_U132_HCD) += host/ obj-$(CONFIG_USB_R8A66597_HCD) += host/ -obj-$(CONFIG_USB_C67X00_HCD) += c67x00/ +obj-$(CONFIG_USB_C67X00_DRV) += c67x00/ obj-$(CONFIG_USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig === --- linux-2.6.orig/drivers/usb/Kconfig +++ linux-2.6/drivers/usb/Kconfig @@ -97,6 +97,8 @@ source "drivers/usb/host/Kconfig" +source "drivers/usb/c67x00/Kconfig" + source "drivers/usb/class/Kconfig" source "drivers/usb/storage/Kconfig" Index: linux-2.6/drivers/usb/c67x00/Kconfig === --- /dev/null +++ linux-2.6/drivers/usb/c67x00/Kconfig @@ -0,0 +1,21 @@ +# +# Cypress C67x00 USB controller +# +config USB_C67X00_DRV + tristate "Cypress C67x00 support" + # only allowed to be =y if both USB!=m and USB_GADGET!=m + depends on (!USB && USB_GADGET) || (!USB_GADGET && USB) || (USB && USB_GADGET) + help + The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role + host/peripheral USB controllers. + + To compile this driver as a module, choose M here: the + module will be called c67x00. + +config USB_C67X00_HCD + bool "Cypress C67X00 HCD support" + depends on USB && USB_C67X00_DRV + default y + help + Enable this option to support the Cypress C67x00 in host + controller mode. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-20 Thread Peter Korsgaard
>>>>> "Greg" == Greg KH <[EMAIL PROTECTED]> writes: Greg> On Tue, Feb 19, 2008 at 04:09:19PM +0100, Peter Korsgaard wrote: >> This patch adds HCD support for the Cypress c67x00 family of devices. >> >> Signed-off-by: Peter Korsgaard <

[patch v8 1/4] USB: add Cypress c67x00 low level interface code

2008-02-20 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 405 + drivers/usb/c67x00/c67x00.h| 285 +++

[patch v8 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-02-20 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 229 include/linux/

[patch v8 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-02-20 Thread Peter Korsgaard
00_ll_set_ep_{ctrl,packet_size}_reg() to patch 4 as they are only needed for gadget support. Changes since v3: - Lots of cleanups: checkpatch, interrupt handling, c67x00_ prefixes, .. - The dummy platform_device's created per serial engine are gone. - Gadget driver (WIP) -- By

[patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-20 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v8 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-02-20 Thread Peter Korsgaard
USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig ======= --- linux-2.6.orig/drivers/usb/Kconfig +++ linux-2.6/drivers/usb/Kconfig @@ -97,6 +97,8 @@ source "drivers/usb/host/Kconfig" +source "drivers/usb/c67x00/Kconfig" + source "drivers/usb/class/Kconfig" source "drivers/usb/storage/Kconfig" Index: linux-2.6/drivers/usb/c67x00/Kconfig === --- /dev/null +++ linux-2.6/drivers/usb/c67x00/Kconfig @@ -0,0 +1,21 @@ +# +# Cypress C67x00 USB controller +# +config USB_C67X00_DRV + tristate "Cypress C67x00 support" + # only allowed to be =y if both USB!=m and USB_GADGET!=m + depends on (!USB && USB_GADGET) || (!USB_GADGET && USB) || (USB && USB_GADGET) + help + The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role + host/peripheral USB controllers. + + To compile this driver as a module, choose M here: the + module will be called c67x00. + +config USB_C67X00_HCD + bool "Cypress C67X00 HCD support" + depends on USB && USB_C67X00_DRV + default y + help + Enable this option to support the Cypress C67x00 in host + controller mode. Index: linux-2.6/drivers/usb/c67x00/c67x00-hcd.h === --- linux-2.6.orig/drivers/usb/c67x00/c67x00-hcd.h +++ linux-2.6/drivers/usb/c67x00/c67x00-hcd.h @@ -112,8 +112,21 @@ * Functions used by c67x00-drv */ +#ifdef CONFIG_USB_C67X00_HCD int c67x00_hcd_probe(struct c67x00_sie *sie); void c67x00_hcd_remove(struct c67x00_sie *sie); +#else +static inline int c67x00_hcd_probe(struct c67x00_sie *sie) +{ + printk(KERN_ERR "hcd requested but CONFIG_USB_C67X00_HCD " + "not enabled!\n"); + return -ENODEV; +} + +static inline void c67x00_hcd_remove(struct c67x00_sie *sie) +{ +} +#endif /* CONFIG_USB_C67X00_HCD */ /* - * Transfer Descriptor scheduling functions -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v8 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-02-20 Thread Peter Korsgaard
>>>>> "Greg" == Greg KH <[EMAIL PROTECTED]> writes: Greg> On Wed, Feb 20, 2008 at 10:07:27AM +0100, Peter Korsgaard wrote: >> The Cypress c67x00 (EZ-Host/EZ-OTG) controllers are multi-role low/fullspeed >> USB controllers. This patch series imp

Re: [patch v8 1/4] USB: add Cypress c67x00 low level interface code

2008-02-20 Thread Peter Korsgaard
series). We could put it under hcd for now and then move it once the gadget driver gets finished/merged, but that seems silly to me.. -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-20 Thread Peter Korsgaard
o test it again :) Ahh, that seems to be a pretty new warning in checkpatch - I atleast haven't seen it before. The other things it complains about seems to be rubbish though (except for the single indented label). I'll send a v9 series shortly. -- Bye, Peter Korsgaard _

Re: [patch v7 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-20 Thread Peter Korsgaard
98: FILE: include/linux/usb/c67x00.h:41: + #define C67X00_SIE2_PERIPHERAL_B (C67X00_SIE_PERIPHERAL_B<< 4) But ok, the space before the #define shouldn't have been there. Greg> And yes, it's a new warning with the advent of 2.6.25-rc1, but Greg> that's no rea

[patch v9 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-02-20 Thread Peter Korsgaard
;s created per serial engine are gone. - Gadget driver (WIP) -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[patch v9 1/4] USB: add Cypress c67x00 low level interface code

2008-02-20 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 405 + drivers/usb/c67x00/c67x00.h| 285 +++

[patch v9 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-20 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile| 11 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v9 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-02-20 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 229 include/linux/

[patch v9 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-02-20 Thread Peter Korsgaard
USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig ======= --- linux-2.6.orig/drivers/usb/Kconfig +++ linux-2.6/drivers/usb/Kconfig @@ -97,6 +97,8 @@ source "drivers/usb/host/Kconfig" +source "drivers/usb/c67x00/Kconfig" + source "drivers/usb/class/Kconfig" source "drivers/usb/storage/Kconfig" Index: linux-2.6/drivers/usb/c67x00/Kconfig === --- /dev/null +++ linux-2.6/drivers/usb/c67x00/Kconfig @@ -0,0 +1,21 @@ +# +# Cypress C67x00 USB controller +# +config USB_C67X00_DRV + tristate "Cypress C67x00 support" + # only allowed to be =y if both USB!=m and USB_GADGET!=m + depends on (!USB && USB_GADGET) || (!USB_GADGET && USB) || (USB && USB_GADGET) + help + The Cypress C67x00 (EZ-Host/EZ-OTG) chips are dual-role + host/peripheral USB controllers. + + To compile this driver as a module, choose M here: the + module will be called c67x00. + +config USB_C67X00_HCD + bool "Cypress C67X00 HCD support" + depends on USB && USB_C67X00_DRV + default y + help + Enable this option to support the Cypress C67x00 in host + controller mode. Index: linux-2.6/drivers/usb/c67x00/c67x00-hcd.h === --- linux-2.6.orig/drivers/usb/c67x00/c67x00-hcd.h +++ linux-2.6/drivers/usb/c67x00/c67x00-hcd.h @@ -112,8 +112,21 @@ * Functions used by c67x00-drv */ +#ifdef CONFIG_USB_C67X00_HCD int c67x00_hcd_probe(struct c67x00_sie *sie); void c67x00_hcd_remove(struct c67x00_sie *sie); +#else +static inline int c67x00_hcd_probe(struct c67x00_sie *sie) +{ + printk(KERN_ERR "hcd requested but CONFIG_USB_C67X00_HCD " + "not enabled!\n"); + return -ENODEV; +} + +static inline void c67x00_hcd_remove(struct c67x00_sie *sie) +{ +} +#endif /* CONFIG_USB_C67X00_HCD */ /* - * Transfer Descriptor scheduling functions -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-20 Thread Peter Korsgaard
gt; And I realize that some of the drivers there have violated the David> normal "alphabetical order" convention, so maybe one big David> cleanup patch would be in order ... but still, I'd rather see David> such new options added in the right place, rather than need Da

[patch v10 3/4] USB: add Cypress c67x00 OTG controller HCD driver

2008-02-21 Thread Peter Korsgaard
This patch adds HCD support for the Cypress c67x00 family of devices. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> --- drivers/usb/Makefile |2 drivers/usb/c67x00/Makefile|9 drivers/usb/c67x00/c67x00-drv.c| 13 drivers/usb/c67x00/c67x00

[patch v10 2/4] USB: add Cypress c67x00 OTG controller core driver

2008-02-21 Thread Peter Korsgaard
behaviours; it just controls access to the chip. Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- MAINTAINERS |6 + drivers/usb/c67x00/c67x00-drv.c | 229 include/linux/

[patch v10 4/4] USB: add Cypress c67x00 OTG controller gadget driver

2008-02-21 Thread Peter Korsgaard
FIG_USB_C67X00_HCD) += c67x00/ +obj-$(CONFIG_USB_C67X00_DRV) += c67x00/ obj-$(CONFIG_USB_ACM) += class/ obj-$(CONFIG_USB_PRINTER) += class/ Index: linux-2.6/drivers/usb/Kconfig === --- linux-2.6.orig/drivers/usb/Kc

[patch v10 1/4] USB: add Cypress c67x00 low level interface code

2008-02-21 Thread Peter Korsgaard
interface (16bit SRAM-like parallel bus). Signed-off-by: Peter Korsgaard <[EMAIL PROTECTED]> Acked-by: David Brownell <[EMAIL PROTECTED]> --- drivers/usb/c67x00/c67x00-ll-hpi.c | 405 + drivers/usb/c67x00/c67x00.h| 285 +++

[patch v10 0/4] Cypress c67x00 (EZ-Host/EZ-OTG) support

2008-02-21 Thread Peter Korsgaard
ce v3: - Lots of cleanups: checkpatch, interrupt handling, c67x00_ prefixes, .. - The dummy platform_device's created per serial engine are gone. - Gadget driver (WIP) -- Bye, Peter Korsgaard ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.o

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

2008-02-21 Thread Peter Korsgaard
on> + depends on USB_EHCI_HCD && FSL_SOC Anton> select USB_EHCI_ROOT_HUB_TT Anton> - default y if MPC834x || PPC_MPC831x Notice that I have a patch in the USB queue which fixes up the MPC834x symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply. -- By

Re: [PATCH] [USB POWERPC] ehci-fsl: add PPC_MPC837x to default y

2008-02-21 Thread Peter Korsgaard
On Fri, Feb 22, 2008 at 2:36 AM, Peter Korsgaard <[EMAIL PROTECTED]> wrote: > Notice that I have a patch in the USB queue which fixes up the MPC834x > symbol (PPC_MPC834x instead of MPC834x) so this patch won't apply. Never mind, Greg fixed it. -- Bye

  1   2   3   >