Dear all,
I am hoping someone could help me diagnose the following bug report:
https://bugs.debian.org/798102
[...]
After waking from hibernate, I get lots of kworker activity that makes my
fans kick in. Top shows a process called kworker/0:3 always active using
around 3% cpu, and Powertop show
On Tue, Feb 26, 2019 at 9:36 PM Jakub Drnec wrote:
>
> Hi all,
>
> I think I observed a potential problem, is this the correct place to report
> it? (CC me, not on list)
>
> [1.] One line summary: monotonic clock can be made to decrease on ppc64
> [2.] Full description:
> Setting the realtime clo
Make sure to include to provide the following prototype:
hv_nmi_check_nonrecoverable.
Remove the following warning treated as error (W=1):
arch/powerpc/kernel/traps.c:393:6: error: no previous prototype for
'hv_nmi_check_nonrecoverable' [-Werror=missing-prototypes]
Signed-off-b
Add gcc attribute unused for `rc` variable.
Fix warnings treated as errors with W=1:
arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used
[-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/lib/sstep.c | 2 +-
1 file changed, 1
used.
Prefer using '__aligned' to get passed line over 80 characters warning
in checkpatch.
This remove the following warning:
arch/powerpc/kernel/process.c:1156:17: error: 'dummy_copy_buffer' defined but
not used [-Werror=unused-const-variable=]
Cc: Nicholas Piggin
S
rpc/platforms/embedded6xx/holly.c:243:6: error: no previous
prototype for 'holly_halt' [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/embedded6xx/holly.c | 19 ---
1 file changed, 4 insertions(+), 15 deletions(-)
diff --git
On Tue, Mar 12, 2019 at 9:56 PM Christophe Leroy
wrote:
>
>
>
> Le 12/03/2019 à 21:20, Mathieu Malaterre a écrit :
> > Add gcc attribute unused for `rc` variable.
> >
> > Fix warnings treated as errors with W=1:
> >
> >arch/powerpc/lib/sstep.c:1172
Fix warnings treated as errors with W=1:
arch/powerpc/lib/sstep.c:1172:31: error: variable 'rc' set but not used
[-Werror=unused-but-set-variable]
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
v2: as suggested prefer CONFIG_PPC64 sentinel instead of unus
: 'dummy_copy_buffer' defined but
not used [-Werror=unused-const-variable=]
Cc: Nicholas Piggin
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
v2: complely remove dummy_copy_buffer instead of marking it as used (since not
anymore)
arch/powerpc/kernel/process.c | 5
On Tue, Mar 12, 2019 at 10:26 PM Christophe Leroy
wrote:
>
>
>
> Le 12/03/2019 à 22:12, Mathieu Malaterre a écrit :
> > On Tue, Mar 12, 2019 at 9:56 PM Christophe Leroy
> > wrote:
> >>
> >>
> >>
> >> Le 12/03/2019 à 21:20, Mathie
On Tue, Mar 12, 2019 at 10:14 PM Christophe Leroy
wrote:
>
>
>
> Le 12/03/2019 à 21:31, Mathieu Malaterre a écrit :
> > In commit cb9e4d10c448 ("[POWERPC] Add support for 750CL Holly board")
> > new functions were added. Since these functions can be made static,
On Sat, Feb 16, 2019 at 3:26 AM Masahiro Yamada
wrote:
>
> On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote:
> >
> > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada
> > wrote:
> > >
> > > I often test all Kconfig commands for all architecture
Mark,
On Fri, Mar 15, 2019 at 3:08 PM Mark Cave-Ayland
wrote:
>
> Hi all,
>
> I've just done a git pull and rebuilt master on my Mac Mini G4 in order to
> test
> Michael's merge of my KVM PR fix, and unfortunately my kernel now hangs on
> boot :(
Ouch :(
> My last working git checkout was som
_halt' [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/embedded6xx/holly.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/powerpc/platforms/embedded6xx/holly.c
b/arch/powerpc/platforms/embedded6xx/holly.c
index 9d2eefef7b7b..829bf
ype for 'holly_restart' [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
v2: Split the patch in two operations
arch/powerpc/platforms/embedded6xx/holly.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/platforms/embedded6xx/hol
On Wed, Apr 3, 2019 at 2:51 AM Joel Stanley wrote:
>
> It turns out that some defconfig changes and kernel config option
> changes meant we accidentally dropped Ethernet support for Mellanox CLX5
> cards.
>
> Reported-by: Carol L Soto
> Suggested-by: Carol L Soto
> Signed-off-by: Stewart Smith
Hi,
On Fri, Apr 19, 2019 at 12:06 PM Masahiro Yamada
wrote:
>
> This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common
> place. We need to eliminate potential issues beforehand.
>
> If it is enabled for mips, the following errors are reported:
>
> arch/mips/mm/sc-mips.o: In function
On Wed, Aug 8, 2018 at 12:34 PM Michael Ellerman wrote:
>
> Andrew Morton writes:
> > On Mon, 6 Aug 2018 12:39:21 +0200 Geert Uytterhoeven
> > wrote:
> >
> >> CC Dan, Michael, AKPM, powerpc
> >>
> >> On Mon, Apr 16, 2018 at 3:10 PM Geert Uytterhoeven
> >> wrote:
> >> > Below is the list of bu
Frederic,
Could you double check with Michael what is now best to do.
Thanks
On Mon, Aug 13, 2018 at 1:23 PM Michael Ellerman
wrote:
>
> On Thu, 2018-03-22 at 21:05:28 UTC, Mathieu Malaterre wrote:
> > In commit 14baf4d9c739 ("cxl: Add guest-specific code") the follow
On Wed, Aug 29, 2018 at 9:59 AM Krzysztof Kozlowski wrote:
>
> On Wed, 29 Aug 2018 at 09:32, Krzysztof Kozlowski wrote:
> >
> > After commit faa16bc404d7 ("lib: Use existing define with
> > polynomial") the lib/xz/xz_crc32.c includes a header from include/linux
> > directory thus any other user o
/process.c:1302:6: error: no previous prototype for
‘show_user_instructions’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/process.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index bb
On Thu, Oct 18, 2018 at 6:37 AM Christophe LEROY
wrote:
>
>
>
> Le 17/10/2018 à 21:25, Mathieu Malaterre a écrit :
> > In commit 88b0fe175735 ("powerpc: Add show_user_instructions()") the
> > function show_user_instructions was added.
> >
> > This com
Type qualifier on return type is ignored. Remove warning in W=1:
arch/powerpc/include/asm/book3s/64/pgtable.h:1268:25: error: type qualifiers
ignored on function return type [-Werror=ignored-qualifiers]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/include/asm/book3s/64/pgtable.h | 2
g: orphan section `.data..Lubsan_type12' from
`init/main.o' being placed in section `.data..Lubsan_type12'.
...
This commit remove those warnings produced at W=1.
Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg135407.html
Suggested-by: Nicholas Piggin
[-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/process.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process.c
index 96f34730010f..b9f1a2408738 100644
--- a/arch/powerpc/kernel
On Thu, Nov 8, 2018 at 7:09 AM Christophe Leroy wrote:
>
>
>
> On 11/07/2018 08:26 PM, Mathieu Malaterre wrote:
> > Add gcc attribute unused for `cpumsr` variable.
> >
> > Fix warnings treated as errors with W=1:
> >
> >arch/powerpc/kernel/process.
On Sat, Nov 17, 2018 at 11:29 AM Christophe Leroy
wrote:
>
> Today we have:
>
> config PPC_BOOK3S_32
> bool "512x/52xx/6xx/7xx/74xx/82xx/83xx/86xx"
> [depends on PPC32 within a choice]
>
> config PPC_BOOK3S
> def_bool y
> depends on PPC_BOOK3S_32 || PPC_BOOK3S_64
>
On Tue, Dec 4, 2018 at 12:09 PM Benjamin Herrenschmidt
wrote:
>
> Hi folks !
>
> Does anybody still has the manual or schematics (or both!) of the old
> "ebony" ppc440gp eval board around by any chance ?
A google search for:
IBM/AMCC "PPC440GP" Evaluation Board datasheet
leads to:
https://4don
...
-mcpu=e300c2 ...
-mcpu=powerpc ...
../init/do_mounts.c
Cc: Christophe Leroy
Fixes: 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32")
Suggested-by: Michael Ellerman
Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg142315.html
Signed-off-by: Mathie
On Tue, Dec 4, 2018 at 10:28 PM Christophe LEROY
wrote:
>
>
>
> Le 04/12/2018 à 21:53, Mathieu Malaterre a écrit :
> > The code:
> >
> >ifdef CONFIG_6xx
> >KBUILD_CFLAGS += -mcpu=powerpc
> >endif
> >
> > was added in 20
...
-mcpu=e300c2 ...
-mcpu=powerpc ...
../init/do_mounts.c
Cc: Christophe Leroy
Fixes: 0e00a8c9fd92 ("powerpc: Allow CPU selection also on PPC32")
Suggested-by: Michael Ellerman
Link: https://www.mail-archive.com/linuxppc-dev@lists.ozlabs.org/msg142315.html
Signed-off-by: Mathieu Mala
Michael,
I have been wondering for a while now, but I failed to make sense of
this function: pt_regs_check (commit 002af9391bfbe). What is this
function meant for ?
Background, it breaks my W=1 build with:
../arch/powerpc/kernel/ptrace.c:3339:13: error: no previous prototype
for ‘pt_regs_check’
dds a prototype to fix warning at W=1:
arch/powerpc/kernel/ptrace.c:3339:13: error: no previous prototype for
‘pt_regs_check’ [-Werror=missing-prototypes]
Suggested-by: Christophe Leroy
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/ptrace.c | 4
1 file changed, 4 insertions(+)
diff
On Thu, Jun 13, 2019 at 10:27 AM Christoph Hellwig wrote:
>
> With the strict dma mask checking introduced with the switch to
> the generic DMA direct code common wifi chips on 32-bit powerbooks
> stopped working. Add a 30-bit ZONE_DMA to the 32-bit pmac builds
> to allow them to reliably allocat
On Wed, Jun 19, 2019 at 4:18 PM Benjamin Herrenschmidt
wrote:
>
> On Wed, 2019-06-19 at 22:32 +1000, Michael Ellerman wrote:
> > Christoph Hellwig writes:
> > > Any chance this could get picked up to fix the regression?
> >
> > Was hoping Ben would Ack it. He's still powermac maintainer :)
> >
>
clang") until a proper fix is implemented upstream in
clang and relax requirement for clang.
Link: https://github.com/ClangBuiltLinux/linux/issues/563
Cc: Joel Stanley
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/lib/Makefile | 4
1 file changed, 4 insertions(+)
diff --git a/arch/
On Tue, Jun 25, 2019 at 1:22 PM Christophe Leroy
wrote:
>
> Create ippc_gethwdinfo() to handle PPC_PTRACE_GETHWDBGINFO and
s/ippc_gethwdinfo/ppc_gethwdinfo/
> reduce ifdef mess
>
> Signed-off-by: Christophe Leroy
> ---
> arch/powerpc/kernel/ptrace/ptrace-adv.c | 15 +++
> arch/po
Does that ring a bell to anyone here ? Thanks
-- Forwarded message -
To:
Hi,
No log only a photo :
https://www.deb-multimedia.org/tests/20190812_143628.jpg
Christian
ch/powerpc/kernel/ptrace.c:3281:4: error: suggest braces around empty body
in an ‘if’ statement [-Werror=empty-body]
Fixes: a225f1567405 ("powerpc/ptrace: replace ptrace_report_syscall() with a
tracehook call")
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/kernel/ptrace.c | 4 ++-
s been removed.
Revert commit 05a4ab823983 ("powerpc/uaccess: fix warning/error with
access_ok()") to fix the following compilation error:
arch/powerpc/include/asm/uaccess.h:66:32: error: ‘type’ undeclared (first use
in this function)
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/incl
GCC supports -mcpu=G4
This patch gives the opportunity to select ALTIVEC for this variant.
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/Kconfig.cputype | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/powerpc/platforms/Kconfig.cputype
b/arch/powerpc/platforms
[Sorry to hijack this thread. ]
On Tue, Jan 15, 2019 at 5:22 AM Andrew Donnellan
wrote:
>
> kcov provides kernel coverage data that's useful for fuzzing tools like
> syzkaller.
>
> Wire up kcov support on powerpc. Disable kcov instrumentation on the same
> files where we currently disable gcov an
On Tue, Jan 15, 2019 at 8:22 AM Masahiro Yamada
wrote:
>
> Commit c3ff2a5193fa ("powerpc/32: add stack protector support")
> caused kernel panic on PowerPC if an external module is used with
> CONFIG_STACKPROTECTOR because the 'prepare' target was not executed
> for the external module build.
>
>
On Wed, Jan 16, 2019 at 6:09 AM Michael Ellerman wrote:
>
> Christophe Leroy writes:
> > Le 15/01/2019 à 08:26, Mathieu Malaterre a écrit :
> ...
> >>
> >> I did check that `custom_defconfig` is the minimal defconfig generated
> >> by `savedefconfig`
> Yeah I noticed this just yesterday.
Just FYI this has been accepted as regression in gcc, and fixed is
provided for GCC 9.0:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88273
On Fri, Jan 18, 2019 at 1:53 AM Tobias Ulmer wrote:
>
> On Fri, Jan 18, 2019 at 09:32:07AM +1100, Benjamin Herrenschmidt wrote:
> > On Thu, 2019-01-17 at 10:42 +0100, Tobias Ulmer wrote:
> > > On Wed, Jan 16, 2019 at 12:15:14PM +1100, Benjamin Herrenschmidt wrote:
> > > > On Tue, 2019-01-15 at 23:
There is not point in having a trailing semicolon after a closing curly
brace. Remove it.
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/sysdev/tsi108_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/sysdev/tsi108_dev.c b/arch/powerpc/sysdev/tsi108_dev.c
not at
beginning of declaration [-Werror=old-style-declaration]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/platforms/ps3/os-area.c| 4 ++--
arch/powerpc/platforms/ps3/system-bus.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/ps3/os-ar
for NF_TABLES_ARP
arch/powerpc/configs/ppc_defconfig:358:warning: symbol value 'm'
invalid for NF_TABLES_BRIDGE
arch/powerpc/configs/ppc_defconfig:1427:warning: symbol value 'm'
invalid for LIRC
#
# configuration written to .config
#
Tested-by: Mathieu Malaterre
> This c
On Thu, Feb 7, 2019 at 6:20 AM Michael Ellerman wrote:
>
> Our logic for choosing defconfig doesn't work well in some situations.
>
> For example if you're on a ppc64le machine but you specify a non-empty
> CROSS_COMPILE, in order to use a non-default toolchain, then defconfig
> will give you ppc6
exposure/overwrite on our
> hands.
>
> Rather than relying on that we can pass an explict end_pos based on
> the sizeof(vrsave). The result should be exactly the same but it's
> more obviously not over-reading/writing the stack and it avoids the
> compiler warning.
>
maybe
On Sat, Dec 8, 2018 at 4:46 PM Mathieu Malaterre wrote:
>
> `pt_regs_check` is a dummy function, its purpose is to break the build
> if struct pt_regs and struct user_pt_regs don't match.
>
> This function has no functionnal purpose, and will get eliminated at
> link time
On Fri, Feb 15, 2019 at 9:21 AM Christophe Leroy
wrote:
>
>
>
> Le 15/02/2019 à 09:11, Mathieu Malaterre a écrit :
> > On Sat, Dec 8, 2018 at 4:46 PM Mathieu Malaterre wrote:
> >>
> >> `pt_regs_check` is a dummy function, its purpose is to break the bui
On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada
wrote:
>
> I often test all Kconfig commands for all architectures. To ease my
> workflow, I want 'make defconfig' at least working without any cross
> compiler.
>
> Currently, arch/powerpc/Makefile checks CROSS_COMPILE to decide the
> default defco
Hi,
On Tue, May 8, 2018 at 4:34 PM, Michael Ellerman wrote:
> Mathieu Malaterre writes:
>
>> Hi there,
>>
>> Quick question (I have not investigate root cause): is support for
>> seccomp complete on ppc32 ?
>
> Doesn't look like it does it :)
>
&g
On Mon, May 28, 2018 at 5:07 PM, Segher Boessenkool
wrote:
> On Mon, May 28, 2018 at 02:39:37PM +, Christophe Leroy wrote:
>> In file included from arch/powerpc/kernel/syscalls.c:24:
>> ./include/linux/syscalls.h:233:18: warning: 'sys_mmap2' alias between
>> functions of incompatible types 'lo
On Mon, May 28, 2018 at 12:34 AM, Al Viro wrote:
> make it use copy_{from,to}_user(), rather than access_ok() +
> __copy_...
>
> Signed-off-by: Al Viro
> ---
> arch/powerpc/kernel/ptrace.c | 22 +++---
> 1 file changed, 7 insertions(+), 15 deletions(-)
>
> diff --git a/arch/power
On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell wrote:
> Hi all,
>
> My qemu boots of today's powerpc linux-next kernel produced the following
> boot message differences:
>
> -Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
> +Max number of cores passed to firmware: u (NR_CPUS = 20
> actually unsigned long long.
>
> Unfortunately prom_printf() doesn't know how to print "%llx", it just
> prints a literal "lx", eg:
>
> reserved memory map:
> lx - lx
> lx - lx
Sorry about that. Patch looks good, will try to work on ha
On Tue, May 29, 2018 at 1:56 PM, Mathieu Malaterre wrote:
> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell
> wrote:
>> Hi all,
>>
>> My qemu boots of today's powerpc linux-next kernel produced the following
>> boot message differences:
>>
>>
Michael,
On Tue, May 29, 2018 at 2:00 PM, Mathieu Malaterre wrote:
> On Tue, May 29, 2018 at 1:56 PM, Mathieu Malaterre wrote:
>> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell
>> wrote:
>>> Hi all,
>>>
>>> My qemu boots of today's powerpc li
Stephen,
On Tue, May 29, 2018 at 2:23 PM, Stephen Rothwell wrote:
> Hi Mathieu,
>
> On Tue, 29 May 2018 13:56:48 +0200 Mathieu Malaterre wrote:
>>
>> On Tue, May 29, 2018 at 1:02 PM, Stephen Rothwell
>> wrote:
>> > Hi all,
>> >
>> > My qe
t
print a literal "u", eg:
Max number of cores passed to firmware: u (NR_CPUS = 2048)
instead of:
Max number of cores passed to firmware: 2048 (NR_CPUS = 2048)
This commit adds support for the missing formatters.
Fixes: eae5f709a4d7 ("powerpc: Add __printf verification to pro
On Mon, May 28, 2018 at 12:49 PM, Christophe Leroy
wrote:
> At the time being, memcmp() compares two chunks of memory
> byte per byte.
>
> This patch optimises the comparison by comparing word by word.
>
> A small benchmark performed on an 8xx comparing two chuncks
> of 512 bytes performed 10
Where did the original go ?
https://patchwork.ozlabs.org/patch/868158/
On Mon, Jun 4, 2018 at 2:02 PM Dan Carpenter wrote:
>
> There is a copy and paste bug so we accidentally use the RX_ shift when
> we're in TX_ mode.
>
> Fixes: bb8b2062aff3 ("fsl/qe: setup clock source for TDM mode")
> Signe
Hi there,
I have a reproducible UBSAN appearing in dmesg after a while on my G4
(*). Could anyone suggest a way to diagnose the actual root issue here
(or is it just a false positive) ?
Thanks,
(*)
[41877.514338]
[
Hi Meelis,
On Mon, Jun 11, 2018 at 1:21 PM Meelis Roos wrote:
>
> I am seeing this on PowerMac G4 with sungem ethernet driver. 4.17 was
> OK, 4.17.0-10146-gf0dc7f9c6dd9 is problematic.
Same here.
> [ 140.518664] eth0: hw csum failure
> [ 140.518699] CPU: 0 PID: 1237 Comm: postconf Not tainted
Hi Balbir,
On Tue, Jun 12, 2018 at 9:39 AM Balbir Singh wrote:
>
>
> On 12/06/18 06:20, Mathieu Malaterre wrote:
>
> > Hi Meelis,
> >
> > On Mon, Jun 11, 2018 at 1:21 PM Meelis Roos wrote:
> >> I am seeing this on PowerMac G4 with sungem ethernet
Hi all,
On Tue, Jun 12, 2018 at 10:15 AM Mathieu Malaterre wrote:
>
> Hi Balbir,
>
> On Tue, Jun 12, 2018 at 9:39 AM Balbir Singh wrote:
> >
> >
> > On 12/06/18 06:20, Mathieu Malaterre wrote:
> >
> > > Hi Meelis,
> > >
> > >
On Wed, Jun 13, 2018 at 3:43 AM Michael Ellerman wrote:
>
> Mathieu Malaterre writes:
>
> > Hi there,
> >
> > I have a reproducible UBSAN appearing in dmesg after a while on my G4
> > (*). Could anyone suggest a way to diagnose the actual root issue here
&g
On Wed, Jun 13, 2018 at 10:43 AM Mathieu Malaterre wrote:
>
> On Wed, Jun 13, 2018 at 3:43 AM Michael Ellerman wrote:
> >
> > Mathieu Malaterre writes:
> >
> > > Hi there,
> > >
> > > I have a reproducible UBSAN appearing in dmesg after a whil
Arnd,
In 5bfd643583b2e I can see that you changed:
$ git show 5bfd643583b2e -- arch/powerpc/platforms/powermac/time.c
[...]
#ifdef CONFIG_ADB_PMU
-static unsigned long pmu_get_time(void)
+static time64_t pmu_get_time(void)
{
struct adb_request req;
- unsigned int now;
+ time
On Thu, Jun 14, 2018 at 1:46 PM Arnd Bergmann wrote:
>
> On Wed, Jun 13, 2018 at 10:24 PM, Mathieu Malaterre wrote:
> > Arnd,
> >
> > In 5bfd643583b2e I can see that you changed:
> >
> > $ git show 5bfd643583b2e -- arch/powerpc/platforms/powermac/time.c
Hi Eric,
On Fri, Jun 15, 2018 at 9:14 PM Eric Dumazet wrote:
>
>
>
> On 06/15/2018 11:56 AM, Mathieu Malaterre wrote:
> > This reverts commit 88078d98d1bb085d72af8437707279e203524fa5.
> >
> > It causes regressions for people using chips driven by the sungem
> &g
On Mon, Jun 18, 2018 at 7:54 PM Andreas Schwab wrote:
>
> On Jun 17 2018, Eric Dumazet wrote:
>
> > Oh this is silly, please try :
> >
> > diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> > index
> > c642304f178ce0a4e1358d59e45032a39f76fb3f..54dd9c18ecad817812898d6f335e1794a07dabbe
> > 1006
On Mon, Jun 18, 2018 at 8:18 PM Eric Dumazet wrote:
>
>
>
> On 06/18/2018 10:54 AM, Andreas Schwab wrote:
> > On Jun 17 2018, Eric Dumazet wrote:
> >
> >> Oh this is silly, please try :
> >>
> >> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> >> index
> >> c642304f178ce0a4e1358d59e45032a39
> The same code exists in arch/m68k/ and is patched in an identical way now
> in a separate patch.
>
> Fixes: 5bfd643583b2 ("powerpc: use time64_t in read_persistent_clock")
> Reported-by: Mathieu Malaterre
> Signed-off-by: Arnd Bergmann
> ---
> arch/pow
On Mon, Jun 18, 2018 at 10:04 PM Andreas Schwab wrote:
>
> On Jun 18 2018, Mathieu Malaterre wrote:
>
> > Sadly, trying again today does not work anymore. Adding some printk
> > just before WARN_ON:
> >
> > +printk(KERN_ERR " rtc DBG pmu_get_time1: %lld
s.
>
> The same code exists in arch/m68k/ and is patched in an identical way now
> in a separate patch.
>
> Fixes: 5bfd643583b2 ("powerpc: use time64_t in read_persistent_clock")
> Reported-by: Mathieu Malaterre
> Reported-by: Andreas Schwab
> Signed-off-by: Arnd
Hi there,
For some reason I am seeing some new warning (W=0) on some old code.
Anyone else seeing them ?
HOSTCC arch/powerpc/boot/addnote
arch/powerpc/boot/addnote.c: In function ‘main’:
arch/powerpc/boot/addnote.c:75:47: warning: right shift count >= width
of type [-Wshift-count-overflow]
#d
40:19: error: static declaration of
‘ppc_setup_l3cr’ follows non-static declaration
arch/powerpc/kernel/setup_32.c:186:19: error: static declaration of
‘ppc_init’ follows non-static declaration
Signed-off-by: Mathieu Malaterre
---
v3: correct subject line to be less confusing
v2: Previous version co
On Thu, Jun 21, 2018 at 1:27 PM Michael Ellerman wrote:
>
> Mathieu Malaterre writes:
>
> > In commit 4aea909eeba3 ("powerpc: Add missing prototypes in setup_32.c")
>
> I don't have that commit ^ ?
>
> That might be because I squashed some of your f
On Thu, Mar 29, 2018 at 6:09 PM LEROY Christophe
wrote:
>
> Mathieu Malaterre a écrit :
>
> > Since the value of x is never intended to be read, remove it. Fix warning
> > treated as error with W=1:
> >
> > arch/powerpc/platforms/powermac/udbg_scc.c:76:9: er
This one should be ok.
On Wed, Apr 4, 2018 at 10:08 PM Mathieu Malaterre wrote:
>
> Add gcc attribute unused for two variables. Fix warnings treated as errors
> with W=1:
>
> arch/powerpc/kernel/prom_init.c:1388:8: error: variable ‘path’ set but not
> used [-Werror=unuse
This one is also ok.
On Thu, Mar 22, 2018 at 9:21 PM Mathieu Malaterre wrote:
>
> The header `pmac.h` was not included, leading to the following warnings,
> treated as error with W=1:
>
> arch/powerpc/platforms/powermac/time.c:69:13: error: no previous prototype
> f
This one should also be good to go.
On Wed, Mar 28, 2018 at 9:39 PM Mathieu Malaterre wrote:
>
> These functions can all be static, make it so. Fix warnings treated as
> errors with W=1:
>
> arch/powerpc/platforms/powermac/pci.c:1022:6: error: no previous prototype
> for ‘p
On Fri, Jun 22, 2018 at 3:49 PM Christophe Leroy
wrote:
>
> This patch fixes the following warnings (obtained with make W=1).
>
> arch/powerpc/mm/slice.c: In function 'slice_range_to_mask':
> arch/powerpc/mm/slice.c:73:12: error: comparison is always true due to
> limited range of data type [-Wer
=missing-prototypes]
arch/powerpc/kernel/setup_32.c:238:13: error: no previous prototype for
‘setup_power_save’ [-Werror=missing-prototypes]
arch/powerpc/kernel/setup_32.c:253:13: error: no previous prototype for
‘initialize_cache_info’ [-Werror=missing-prototypes]
Signed-off-by: Mathieu Malaterre
clobbered by
‘longjmp’ or ‘vfork’ [-Werror=clobbered]
Signed-off-by: Mathieu Malaterre
---
arch/powerpc/xmon/xmon.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
index 47166ad2a669..982848c784ff 100644
--- a/arch
‘type’ is only used when CONFIG_DEBUG_HIGHMEM is set. So add a possibly
unused tag to variable. Remove warning treated as error with W=1:
arch/powerpc/mm/highmem.c:59:6: error: variable ‘type’ set but not used
[-Werror=unused-but-set-variable]
Signed-off-by: Mathieu Malaterre
---
arch
On Sat, Jun 23, 2018 at 7:12 PM christophe leroy
wrote:
>
>
>
> Le 22/06/2018 à 21:27, Mathieu Malaterre a écrit :
> > ‘type’ is only used when CONFIG_DEBUG_HIGHMEM is set. So add a possibly
> > unused tag to variable. Remove warning treated as error with W=1:
> >
&g
On Sat, Jun 23, 2018 at 9:47 PM Segher Boessenkool
wrote:
>
> On Sat, Jun 23, 2018 at 06:59:27PM +0200, christophe leroy wrote:
> >
> >
> > Le 22/06/2018 à 21:27, Mathieu Malaterre a écrit :
> > >Move initialization of variables after data definitions. This silen
On Mon, Jul 2, 2018 at 10:25 AM Finn Thain wrote:
>
> The pmu_init() function has the __init qualifier, but the ops struct
> that holds a pointer to it does not. This causes a build warning.
> The driver works fine because the pointer is only dereferenced early.
>
> The function is so small that t
Hi Nick,
I am building my kernel (ppc32) with both
CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y and CONFIG_UBSAN=y. This leads
to ~316428 warnings such as:
+ powerpc-linux-gnu-ld -EB -m elf32ppc -Bstatic --orphan-handling=warn
--build-id --gc-sections -X -o .tmp_vmlinux1 -T
./arch/powerpc/kernel/vmlinu
On Tue, Jul 3, 2018 at 9:23 AM Nicholas Piggin wrote:
>
> On Tue, 3 Jul 2018 09:03:46 +0200
> Mathieu Malaterre wrote:
>
> > Hi Nick,
> >
> > I am building my kernel (ppc32) with both
> > CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=y and CONFIG_UBSAN=y. This l
Hi Nick,
Would you consider this a bug:
$ touch drivers/macintosh/via-pmu.c
$ CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n make ARCH=powerpc
CROSS_COMPILE=powerpc-linux-gnu-
...
LD vmlinux.o
MODPOST vmlinux.o
WARNING: vmlinux.o(.data+0x216018): Section mismatch in reference from
the variable v
On Tue, Jul 3, 2018 at 11:40 AM Mathieu Malaterre wrote:
>
> Hi Nick,
>
> Would you consider this a bug:
>
> $ touch drivers/macintosh/via-pmu.c
> $ CONFIG_LD_DEAD_CODE_DATA_ELIMINATION=n make ARCH=powerpc
> CROSS_COMPILE=powerpc-linux-gnu-
> ...
> LD v
On Sun, Jul 8, 2018 at 1:53 PM Michael Ellerman wrote:
>
> Randy Dunlap writes:
> > Hi,
> >
> > Is there a good way (or a shortcut) to do something like:
>
> The best I know of is:
>
> > $ make ARCH=powerpc O=PPC32 [other_options] allmodconfig
> > to get a PPC32/32BIT allmodconfig
>
> $ echo CO
On Mon, Jul 9, 2018 at 4:24 PM Michael Ellerman wrote:
>
> Because the allmodconfig logic just sets every symbol to M or Y, it
> has the effect of always generating a 64-bit config, because
> CONFIG_PPC64 becomes Y.
>
> So to make it easier for folks to test 32-bit code, provide a phony
> defconfi
On Tue, Jul 10, 2018 at 3:47 PM Michael Ellerman wrote:
>
> Mathieu Malaterre writes:
> > On Mon, Jul 9, 2018 at 4:24 PM Michael Ellerman wrote:
> >>
> >> Because the allmodconfig logic just sets every symbol to M or Y, it
> >> has the effect of alw
1 - 100 of 308 matches
Mail list logo
