On Thu, Mar 29, 2018 at 6:09 PM LEROY Christophe <christophe.le...@c-s.fr> wrote: > > Mathieu Malaterre <ma...@debian.org> a écrit : > > > Since the value of x is never intended to be read, remove it. Fix warning > > treated as error with W=1: > > > > arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable > > ‘x’ set but not used [-Werror=unused-but-set-variable] > > > > Suggested-by: Christophe Leroy <christophe.le...@c-s.fr> > > Signed-off-by: Mathieu Malaterre <ma...@debian.org> > > Reviewed-by: Christophe Leroy <christophe.le...@c-s.fr>
Michael, can you take this one ? > > --- > > v2: remove x completely > > > > arch/powerpc/platforms/powermac/udbg_scc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/powerpc/platforms/powermac/udbg_scc.c > > b/arch/powerpc/platforms/powermac/udbg_scc.c > > index d83135a9830e..8901973ed683 100644 > > --- a/arch/powerpc/platforms/powermac/udbg_scc.c > > +++ b/arch/powerpc/platforms/powermac/udbg_scc.c > > @@ -73,7 +73,7 @@ void udbg_scc_init(int force_scc) > > struct device_node *stdout = NULL, *escc = NULL, *macio = NULL; > > struct device_node *ch, *ch_def = NULL, *ch_a = NULL; > > const char *path; > > - int i, x; > > + int i; > > > > escc = of_find_node_by_name(NULL, "escc"); > > if (escc == NULL) > > @@ -120,7 +120,7 @@ void udbg_scc_init(int force_scc) > > mb(); > > > > for (i = 20000; i != 0; --i) > > - x = in_8(sccc); > > + in_8(sccc); > > out_8(sccc, 0x09); /* reset A or B side */ > > out_8(sccc, 0xc0); > > > > -- > > 2.11.0 > >
