Hi Scott,
>> +spin_lock_irqsave(&cmd_lock, flags);
>
> I'm a little uneasy about this -- what's the longest it can take for the
> CPM command to complete (or timeout)? I'd rather use a mutex, if we can
> make sure that it's never called from atomic context.
Unfortunately, fs_enet may call t
This patch moves the CPM command handling into commproc.c
for CPM1 and cpm2_common.c. This is yet another preparation
to get rid of drivers accessing the CPM via the global cpmp.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev/commproc.c
Hi Vitaly,
> With that patch fixed.c now fully emulates MDIO bus, thus no need
> to duplicate PHY layer functionality. That, in turn, drastically
> simplifies the code, and drops down line count.
>
> As an additional bonus, now there is no need to register MDIO bus
> for each PHY, all emulated PHY
Hi Anton,
> +int gpio_direction_input(unsigned int gpio)
> +{
> + unsigned long flags;
> + int port = gpio / 32;
> + int pin = gpio % 32;
> +
> + spin_lock_irqsave(&cpm2_port_locks[port], flags);
> +
> + cpm2_set_pin(port, pin, CPM_PIN_INPUT | CPM_PIN_GPIO);
> +int gpio_direct
This patch adds support to use the fixed-link property
of an ethernet node to fs_enet for the
CONFIG_PPC_CPM_NEW_BINDING case.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/net/fs_enet/fs_enet-main.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff
This is based on [PATCH RFC 3/7] [POWERPC] CPM2: implement GPIO API.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/Kconfig |1 +
arch/powerpc/sysdev/commproc.c | 199 +++-
2 files changed, 199 insertions
Hi Jeff,
> ACK, pass this through paulus?
Yes, that's fine for me.
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
This patch adds support to use the fixed-link property
of an ethernet node to fs_enet for the
CONFIG_PPC_CPM_NEW_BINDING case.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Acked-by: Jeff Garzik <[EMAIL PROTECTED]>
Acked-by: Vitali Bordug <[EMAIL PROTECTED]>
---
drivers/n
Initialize I2C pins on boards with CPM1/CPM2 controllers.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 ++
arch/powerpc/boot/dts/mpc866ads.dts | 10 ++
arch/powerpc/boot/dts/mpc885ads.dts
dbox2 hardware) and
CPM2 (MPC8272).
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-cpm.c | 728 ++
3 files changed, 739 insertions(+),
Hi Kumar,
>> Also move the probe code into subsys_initcall, because we want start
>> pinging the watchdog ASAP, and misc devices are available in
>> subsys_initcall.
>>
>> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
>> ---
>> drivers/watchdog/Kconfig |4 +-
>> drivers/watchdog/mpc8
Hi David,
>> As I pointed out earlier, this patch is sticking dts-v0 style constants
>> into a dts-v1 file. It will not work.
>
> Enough of this. *Sends patch converting all remaining dts files to
> v1*. With any luck we can merge that soon, and forget about the
> mistakes of v0 forever.
Ma
Initialize I2C pins on boards with CPM1/CPM2 controllers.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt | 39 ++
arch/powerpc/boot/dts/mpc8272ads.dts | 12
arch/powerpc/boot/dts/mpc866a
Hi Anton,
> - New patch supporting MPC8xx watchdogs (ok to drop until tested);
Unfortunately, current 2.6.26-rc2 doesn't boot at all on MPC823. I'll
have to bisect which patch broke it. I hope to have some testing results, soon.
Thanks,
Jochen
___
Linu
ed to work on the actual hardware.
>
> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
Tested-by: Jochen Friedrich <[EMAIL PROTECTED]>
The driver works OK on MPC823.
One nit however ist the late initialisation of the wdt timer. I had to add
two hardcoded wdt resets in the board se
Initialize I2C pins on boards with CPM1/CPM2 controllers.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt | 39 ++
arch/powerpc/boot/dts/mpc8272ads.dts | 11 +++
arch/powerpc/boot/dts/mpc866a
dbox2 hardware) and
CPM2 (MPC8272).
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-cpm.c | 745 ++
3 files changed, 756 insertions(+),
Hi Scott,
>> + - linux,i2c-index : Can be used to hard code an i2c bus number.
>> + - linux,i2c-class : Can be used to override the i2c class.
>
> Why do we need this?
There are still a bunch of i2c drivers using the old API (mainly v4l and dvb
stuff)
which are slowly being converted by thei
Initialize I2C pins on boards with CPM1/CPM2 controllers.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt | 42 ++
arch/powerpc/boot/dts/mpc8272ads.dts | 11 +++
arch/powerpc/boot/dts/mpc866a
dbox2 hardware) and
CPM2 (MPC8272).
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-cpm.c | 745 ++
3 files changed, 756 insertions(+),
Hi Grant,
>> + - compatible : should be "linux,mmc-spi".
>> + - linux,modalias - should be "of_mmc_spi".
>
> I'm not even sure if the whole linux,modalias is even a good idea. I
> had kind of thrown it in there as a convenient way to override
> compatible when needed, but I haven't re
Grant Likely schrieb:
> On Sat, May 24, 2008 at 12:26 AM, Grant Likely
> <[EMAIL PROTECTED]> wrote:
>> On Thu, May 22, 2008 at 8:05 PM, David Brownell <[EMAIL PROTECTED]> wrote:
>>> On Wednesday 21 May 2008, Anton Vorontsov wrote:
> +++ b/drivers/spi/spi_of.c
I think better placement for t
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
MAINTAINERS |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0a6d2ca..bdfc7bd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1659,6 +1659,13 @@ L: [EMAIL PRO
Hi Timur,
> In situations where it doesn't matter which I2C bus is #1 and which one is #2,
> then I think the code should just initialize idx based on the order the nodes
> are found in the tree.
>
> In situations where it does matter, then we should use cell-index.
that's what I did in i2c-cpm,
Hi Grant,
> if you need explicit indexing then use an alias. My opinion however
> is that explicit indexing is unnecessary and is just an artifact of
> current i2c subsystem internals. There is already enough information
> in the device tree to match i2c devices with i2c busses without
> resorti
Hi Timur,
> It's a little late for that. I'm okay with coming up with a new property to
> provide system-level indexing, but it needs to be the same property name for
> each type of device. I don't want linux,i2c-index and linux,dma-index and
> linux,ssi-index, etc. I also don't understand why
> >>> Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
>> > > >> Acked-by: Olof Johansson <[EMAIL PROTECTED]>
>> > > > Acked-by: Scott Wood <[EMAIL PROTECTED]>
>> > > Acked-by: Becky Bruce <[EMAIL PROTECTED]>
>&
Hi Laurent,
Agreed. Jochen, will you resubmit or should I do it ?
Please do as i'm currently away and won't be back until next week.
Thanks,
Jochen
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxp
Hi Timur,
> Anyone know when of_i2c.c is going to come "online" replace what's in
> fsl_soc.c?
There is a patch being prepared to convert i2c-mpc from a platform driver to an
of_platform driver
making the fsl_soc.c code obsolete. See:
http://patchwork.ozlabs.org/linuxppc/patch?id=18898
Thanks
Hi Laurent,
> Is there any pending issue or can this be applied to powerpc-next ?
Looks OK to me.
>> Signed-off-by: Laurent Pinchart <[EMAIL PROTECTED]>
>> Cc: Jochen Friedrich <[EMAIL PROTECTED]>
Acked-by: Jochen Friedrich <[EMA
Hi Jon,
> This version adds of_find_i2c_device_by_node() which is needed by ASOC
> drivers.
Cool. I was about to do something similar (of_get_adapter_nr_by_node).
IMHO, the patch should be splitted into the addition of
of_find_i2c_device_by_node()
and the actual patch of i2c-mpc.
Thanks,
Joch
Hi Grant,
sorry for the late response on this one.
> 2. You need to specifiy exact chip names in your compatible string.
> "fsl,cpm1-pario-" is a made up thing.
>> + for_each_compatible_node(np, NULL, "fsl,cpm1-pario-bank16")
>> + cpm1_gpiochip_add16(np);
>> +
>> +
Hi Jean,
> I'm not the one to push this upstream though, as the patch is
> essentially an openfirmware patch. That would be something for Jochen
> Friedrich and Paul Mackerras I guess. Would be nice to have a
> MAINTAINERS entry for OF...
Nope. I only did a small contribution t
Hi Paul,
On Tuesday 01 July 2008, Paul Mackerras wrote:
> The following commits have been added to the master and powerpc-next
> branches of the powerpc.git repository. This includes patches pulled
> from Kumar's and Josh's trees.
Now that the I2C driver for CPM1/CPM2 boards is in the i2c tree,
Hi Kumar,
>> any chance to get this one into 2.6.27?
>>
>> [POWERPC] Add i2c pins to dts and board setup
>> http://patchwork.ozlabs.org/linuxppc/patch?person=1023&id=18603
>
> Will we always want defconfig updates to enable the driver?
Good question. Maybe not, as the i2c bus seems to be unused
Within the Freescale Communications Processor Module chapter, both
Serial and Network have the same section number iii). Renumber the
sections to make them unique again.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt | 12 ++---
d-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt | 42 ++
arch/powerpc/boot/dts/mpc8272ads.dts | 11 +++
arch/powerpc/boot/dts/mpc866ads.dts | 11 +++
arch/powerpc/boot/dts/mpc885ads.dts
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/booting-without-of.txt | 39 ++
1 files changed, 39 insertions(+), 0 deletions(-)
diff --git a/Documentation/powerpc/booting-without-of.txt
b/Documentation/powerpc/booting-without-
This patch implement GPIO LIB support for the CPM1 GPIOs.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
This patch depends on the GPIO LIB support for the CPM2 GPIOs patch
from Laurent Pinchart.
Changes since last submission:
- of_gc->gpio_cells = 2 to allow passing port o
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
Documentation/powerpc/device-tree/fsl/cpm/gpio.txt | 38
1 files changed, 38 insertions(+), 0 deletions(-)
create mode 100644 Documentation/powerpc/device-tree/fsl/cpm/gpio.txt
diff --git a/Documentation/p
Hi Scott,
>> I'm going to move all the Freescale SoC related bindings into this new
>> file. One of the aspects of the new file is we will NOT having an
>> ordinal heading index.
>
> How about splitting up like this:
>
> Documentation/powerpc/device-tree/fsl/cpm.txt
> Documentation/powerpc/de
Hi Grant,
> What is the reason that info.irq is set to -1 in the first place? This
> looks like another bug to me. Does something in the i2c layer depend on
> the -1 value?
Nope, it was a bug in the i2c documentation fixed recently:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.
Hi Anton,
> diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
> index b2ccdcb..95a24de 100644
> --- a/drivers/of/of_i2c.c
> +++ b/drivers/of/of_i2c.c
> @@ -93,10 +93,8 @@ void of_register_i2c_devices(struct i2c_adapter *adap,
> if (info.irq == NO_IRQ)
> inf
Implement GPIO LIB API on CPM1 Freescale SoC.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
This is based on the series starting at
http://patchwork.ozlabs.org/linuxppc/patch?id=17299
arch/powerpc/platforms/8xx/Kconfig |2 +
arch/powerpc/sysdev/cpm1.c
mplements various helpers to support OF bindings for
the i2c API.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/of/Kconfig |6 +++
drivers/of/Makefile|1 +
drivers/of/i2c.c | 113
include/linux/of_
el even bigger than it already is unless it's actually needed.
Are you more comfortable with this?
Implement GPIO LIB API on CPM1 Freescale SoC.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/Kconfig | 10 ++
arch/powerpc/sysdev/cpm1.c |
Hi Laurent,
> I haven't checked all CPM1-based parts, but for the MPC855 family this
> doesn't
> look right. The MPC855 has two 32-bit ports, port B and port E. Registers for
> port B are dir, par, odr and dat, and registers for port E are dir, par, sor,
> odr and dat.
You probably mean MPC88
This series of patches implements the framework needed by of_platform_driver
i2c bus drivers.
i2c-mpc is then converted to an of_platform_driver and i2c-cpm is added as new
driver.
This is based on earlier work by Jon Smirl and Jean Delvare.
[PATCH1/7] i2c: Add support for device alias names
[P
Based on earlier work by Jon Smirl and Jean Delvare.
This patch allows new-style i2c chip drivers to have alias names using
the official kernel aliasing system and MODULE_DEVICE_TABLE(). At this
point, the old i2c driver binding scheme (driver_name/type) is still
supported.
Signed-off-by: Jochen
Based on earlier work by Jon Smirl and Jean Delvare.
Update all the new-style i2c drivers to use standard module aliasing
instead of the old driver_name/type driver matching scheme.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Cc: Jean Delvare <[EMAIL PROTECTED]>
Cc: Jon S
This patch implements various helpers to support OF bindings for
the i2c API.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/of/Kconfig |6 +++
drivers/of/Makefile|1 +
drivers/of/i2c.c | 115
include
c_ to make them match the file name. Common
code moved to of-common.* Orginal ppc driver left intact for deletion when ppc
arch is removed.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Cc: Jon Smirl <[EMAIL PROTECTED]>
---
arch/powerpc/sysdev
Based on earlier work by Jon Smirl and Jean Delvare.
Remove the old driver_name/type scheme for i2c driver matching. Only the
standard aliasing model will be used from now on.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Cc: Jean Delvare <[EMAIL PROTECTED]>
Cc: Jon Smirl <[
dbox2 hardware) and
CPM2 (MPC8272).
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/i2c/busses/Kconfig | 10 +
drivers/i2c/busses/Makefile |1 +
drivers/i2c/busses/i2c-cpm.c | 728 ++
3 files changed, 739 insertions(+),
Initialize I2C pins on boards with CPM1/CPM2 controllers.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 ++
arch/powerpc/boot/dts/mpc866ads.dts | 10 ++
arch/powerpc/boot/dts/mpc885ads.dts
This patch implements various helpers to support OF bindings for
the i2c API.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/of/Kconfig |6 +++
drivers/of/Makefile|1 +
drivers/of/i2c.c | 115
include
David Miller schrieb:
> I wouldn't mind trying to use this infrastructure on
> sparc64, and I don't see any powerpc specific interfaces
> being invoked, so if you could remove the PPC_OF
> requirement I'd appreciate it.
I've resenf the patch without the dependency on PPC_OF.
Thanks for the comme
Initialize I2C pins on boards with CPM1/CPM2 controllers.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/boot/dts/mpc8272ads.dts | 10 ++
arch/powerpc/boot/dts/mpc866ads.dts | 10 ++
arch/powerpc/boot/dts/mpc885ads.dts
Hi Kumar,
> I'm guessing the "[POWERPC] i2c: OF helpers for the i2c API"
>
> http://git.kernel.org/?p=linux/kernel/git/paulus/powerpc.git;a=commitdiff;h=612212a3f2f053ea68ce9cd16d3deeca7754e8c9
>
> is causing this build failure:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/24375/
It loo
Hi Laurent,
> This patch implement GPIO LIB support for the CPM2 GPIOs.
>
> The code is based on Jochen Friedrich's patch for the CPM1.
I guess most of this should go to cpm_common.c and should be used for
Port E on CPM1, as well. This port uses the same layout as CPM2 while
Port B uses a diffe
Hi Laurent,
>> http://patchwork.ozlabs.org/linuxppc/patch?id=16282
>
> The link doesn't seem to be related.
http://patchwork.ozlabs.org/linuxppc/patch?id=17490 is the correct one.
> I'll rework the patch to move CPM2 GPIO support to cpm_common.c. Have you
> thought about a proper name for the
Hi Laurent,
> BTW, what's the purpose of the shadow data register in the CPM GPIO chip
> structure ? As the set operation is protected by a spinlock, the only use I
> can think of is to prevent changing bits in the PDAT register for pins
> configured as inputs. Is that correct ? If so this shou
Hi Laurent,
> Any preference for common function names ? cpm2_gpio32* might be too
> CPM2-specific for cpm_common.c. cpm_gpio32* is a bit too generic as it
> doesn't support port E on the CPM1.
I would keep the cpm2 name. I'll just add a comment to cpm1.c that
fsl,cpm1-pario-bank32e uses cpm2 l
Hi Jean,
> (blind shot) Maybe this means that some code that is in i2c-core should
> be moved to i2c-boardinfo instead? i2c-boardinfo is always built into
> the kernel even when i2c-core is modular.
unfortunately, i2c_new_device() tries to attach the module, so this function
really needs full i2c
Hi Paul,
> Which way around is this dependency? Do you mean that the patches you
> listed depend on the "OF helpers for the i2c API" patch, or that the
> OF helpers patch depends on these other ones?
The OF helpers patch depends on the patches below to support autoloading
i2c modules using the a
This patch implements various helpers to support OF bindings for
the i2c API.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Acked-by: David S. Miller <[EMAIL PROTECTED]>
Acked-by: Stephen Rothwell <[EMAIL PROTECTED]>
---
drivers/of/Kconfig |6 +++
drivers/of/
Fix build breakage introduced in commit
"[POWERPC] i2c: OF helpers for the i2c API".
If i2c-core is compiled as module, the helper needs to be
compiled as module, as well. Rename i2c.c to of_i2c.c to
avoid name space conflict.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Based on earlier work by Laurent Pinchart.
This patch implement GPIO LIB support for the CPM2 GPIOs.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Cc: Laurent Pinchart <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/Kconfig |2 +
arch/powerpc/sysdev/cpm2.c | 1
This patch implement GPIO LIB support for the CPM1 GPIOs.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/8xx/Kconfig | 10 ++
arch/powerpc/sysdev/cpm1.c | 261 +++-
2 files changed, 266 insertions(+), 5 deletions(-)
Based on earlier work by Laurent Pinchart.
This patch implement GPIO LIB support for the CPM2 GPIOs.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Cc: Laurent Pinchart <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/Kconfig |2 +
arch/powerpc/sysdev/cpm2.c | 1
Jean Delvare wrote:
> On Sat, 19 Apr 2008 15:09:55 +0200, Jochen Friedrich wrote:
>> Hi Jean,
>>
>>>>> Is the new-style driver conversion patch in 2.6.25-rc8-mm2 scheduled for
>>>>> 2.6.26 ?
>>>> hope so! :)
>>> Note that this p
Adrian Bunk schrieb:
> After commit 585468e5d5962660867c269e26f0a4b89a599473
> ([POWERPC] i2c: Fix build breakage introduced by OF helpers)
> drivers/of/of_i2c.c needs a MODULE_LICENSE.
>
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
Acked-by: Jochen Friedrich <[E
Hi Stefan,
> Please don't get we wrong, I didn't want to put additional pressure on you
> here. I just wanted to express that I'm waiting for these patches to arrive
> upstream quite some time now too.
and unfortunately, the longer we wait the more drivers are ported to new-style
and the bigger
Hi Jean,
> Jochen, I'm a bit confused by the dependencies that exist - or not -
> between these 7 patches you sent at once. I thought they had to be
> applied in sequence but it seems not? And some of them should
> apparently go through me i2c tree but others (e.g. [7/7]) not?
[1/7] and [2/7] are
Hi Wolfram,
> Hello,
>
> I finally could get the work started with I2C on a MPC8260-based
> platform. I applied Jochen's series on top of 2.6.25 and it seems I
> could get the i2c-cpm and the rtc-rs5c372 driver working (except that it
> doesn't autoload as a module, but I think this is my fault s
Hi Jean,
>> -if ((err = f75375_probe(client)) < 0)
>> +err = f75375_probe(client, NULL);
>> +if (err < 0)
>> goto exit_detach;
>>
>> return 0;
>
> These coding style cleanups don't belong to this patch (if they belong
> anywhere - I don't much see the point)
I jus
Hi Wolfram,
> I tested on this hardware
>
> MPC8260 (powerpc) + PCF8575 (io expander) + LM84 (sensor)
> + RS5C372 (rtc) + X24645 (eeprom)
It's also OK on dbox2 hardware: MPC823 (powerpc)
+ saa7127 (patch needed to add id_table) + dbox frontprocessor
(8051 controller with i2c interface).
Thank
Now that of_i2c may be compiled as module, the header must be
exported for module compilation, as well.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
include/linux/of_i2c.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/linux/of_i2c.h b/include
Hi Wolfram,
>> +/* Begin transmission */
>> +setbits8(&i2c_reg->i2com, 0x80);
> Hardcoded value. (I also wonder if 0x81 might be more suitable, as it
> keeps the "be-a-master"-bit set. Still, both values work with my setup.)
>> +#ifdef I2C_CHIP_ERRATA
>> +/*
>> + * Chip errata, cl
Hi Paul,
>> -#ifdef CONFIG_OF_I2C
>> +#if defined(CONFIG_OF_I2C) || defined(CONFIG_OF_I2C_MODULE)
>>
>> void of_register_i2c_devices(struct i2c_adapter *adap,
>> struct device_node *adap_node);
>
> Why do we have that ifdef there at all? There's only that one
> exter
Remove #ifdef CONFIG_OF_I2C as this breaks module compilation.
Drivers using this header should depend on OF_I2C anyways, so
there's no need to make this conditional
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
include/linux/of_i2c.h |4
1 files changed, 0 inser
9ed300;hb=ae429083efe996ca2c569c44fd6fea440676dc33;hpb=60b129d7bfa3e20450816983bd52c49bb0bc1c21)
So your patch is correct.
> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]>
Acked-by: Jochen Friedrich <[EMAIL PROTECTED]>
Thanks,
Jochen
___
Linuxppc-d
Hi Jean,
> Eeeek. The patch you mention here is only the conversion of ONE driver.
> It is absolutely not relevant as to what the general rule is.
Sorry, i must have misunderstood you then.
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=af294867a52bf718df835a688e
Hi Grant,
> On Wed, Jul 16, 2008 at 12:47:25PM +0200, Wolfgang Grandegger wrote:
>> Currently, the I2C buses are probed for HWMON I2C devices, which might
>> not be acceptable in same cases. This patch makes device probing
>> configurable through the property "probe" of the FDT I2C device node:
>>
Hi Kumar,
> On Jun 18, 2008, at 12:08 PM, Laurent Pinchart wrote:
>
>> +#if defined(CONFIG_CPM2) || defined(CONFIG_8xx_GPIO)
>> +
>> +struct cpm2_ioports {
>> +u32 dir, par, sor, odr, dat;
>> +u32 res[3];
>> +};
>> +
>
> is this really common for both CPM2 and 8xx? if so why the name?
Hi Kumar,
> but ports a-d are different on cpm1? I guess I'd like to see both
> patches to understand the commonality and differences.
Yes. Both patches are still in patchwork:
http://patchwork.ozlabs.org/linuxppc/patch?id=19045
http://patchwork.ozlabs.org/linuxppc/patch?id=19386
Thanks,
Joc
The watchdog driver mpc8xx_wdt.c was a device interface to
arch/ppc/syslib/m8xx_wdt.c for MPC8xx hardware. Now that ARCH=ppc is
gone, this driver is of no more use. For ARCH=powerpc, MPC8xx hardware
is supported by mpc8xxx_wdt.c.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
d
Hi Anton,
> Though, with this patch:
> http://lkml.org/lkml/2008/7/10/269
>
> We'll only have to select ARCH_WANT_OPTIONAL_GPIOLIB. Maybe for whole
> powerpc.
That would simplify the GPIO support patches for CPM1/2, as well.
Thanks,
Jochen
___
Linuxpp
Hi Wolfgang,
> The I2C driver for the MPC currently uses a fixed speed hard-coded into
> the driver. This patch adds the FDT properties "fdr" and "dfsrr" for the
> corresponding I2C registers to make the speed configurable via FDT,
> e.g.:
>
> [EMAIL PROTECTED] {
> compatible = "fsl-
This conclusion is correct. One possible way to fix this is to add support for
blacklisting to drivers/of/base.c (untested):
[RFC] of: Support blacklisting and blacklist cs4270.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
---
drivers/of/base.c |8 +++-
1 files changed, 7
Hi Wolfgang,
> $ grep I2C_CLASS_HWMON *
> i2c-cpm.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> i2c-mpc.c: .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> i2c-ibm_iic.c: adap->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> i2c-pasemi.c: smbus->adapter.class = I2C_CLASS_HWM
The watchdog driver mpc8xx_wdt.c was a device interface to
arch/ppc/syslib/m8xx_wdt.c for MPC8xx hardware. Now that ARCH=ppc is
gone, this driver is of no more use. For ARCH=powerpc, MPC8xx hardware
is supported by mpc8xxx_wdt.c.
Signed-off-by: Jochen Friedrich <[EMAIL PROTECTED]>
Ac
The CPM1 GPIO library code uses the non thread-safe clrbits32/setbits32
macros. This patch protects them with a spinlock.
Based on the CPM2 patch from Laurent Pinchart <[EMAIL PROTECTED]>,
commit 639d64456e20cbfc866b18dc03cf9f9babc9c7cd.
Signed-off-by: Jochen Friedrich <[EMAIL
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi Paul,
> This looks like a biggish change for after -rc6, and the commit
> message doesn't tell me what dire things will happen if the patch
> doesn't go in, or what systems see this breakage, or whether this is a
> regression since 2.6.26 (I assume
Hi Scott,
>> This isn't a regression since the stuff is new in 2.6.27. IMHO this can
>> wait until 2.6.28.
>
> It would be a bug in 2.6.27 that did not exist in 2.6.26... is there
> anything that used to use another mechanism that now uses this?
No, GPIO support on CPM1/CPM2 is new in 2.6.27. B
Wolfram Sang schrieb:
> Similar to commit 618b26d52843c0f85b8eb143cf2695d7f6fd072d, also remove
> automatic probing for this i2c controller. Might need updates to dts files
> using it.
>
> Signed-off-by: Wolfram Sang <[EMAIL PROTECTED]>
Acked-by: Jochen Friedr
Hi Mike,
> This patch adds the ability to enable the digital filter in the device
> tree (with the "clock-filter" boolean property) and automates the
> predivider selection according to the clock-frequency and clock-filter
> properties.
looks good.
David, is "clock-filter" an appropriate dts pro
Hi Ben,
> On Fri, Oct 31, 2008 at 05:29:25PM -0700, Mike Ditto wrote:
>> Make the driver report an ENXIO error immediately upon NAK instead of
>> waiting for another interrupt and getting a timeout.
>>
>> Signed-off-by: Mike Ditto <[EMAIL PROTECTED]>
Acked-by: J
wider range of I2C bus frequencies.
>
> Signed-off-by: Mike Ditto <[EMAIL PROTECTED]>
Acked-by: Jochen Friedrich <[EMAIL PROTECTED]>
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
Hi Laurent,
> The two messages making up the transaction are parsed. The driver fills a TX
> buffer descriptor for the first one, and a TX and an RX buffer descriptor for
> the second one.
>
>> rbase 0x01e0 tbase 0x01c0 rfcr 0x30 tfcr 0x30 mrblr 0x0201
>> rstate 0x rptr 0x rbptr
101 - 200 of 202 matches
Mail list logo
