When I build the MTD Common Flush Interface(CFI) driver as modules,
the kernel stops at BUG() in symbol_put_addr() called by
cfi_cmdset_unknown()[gen_probe.c] and shows the following message.
I found this problem on Toshiba Cell Reference Set. I think this
problem relates with powerpc64 ABI.
ker
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-12-21 at 20:15 +0100, Arnd Bergmann wrote:
> > > It seems platforms/cell should have the shared and/or generic code,
> > and the other
> > > stuff moved into a new platform directory, but is it worth the
> > effort?
> >
> > There is
> This patch adds checking for NULL value returned to prevent possible
> NULL pointer dereference.
> Also two unneeded 'return' are removed.
>
> Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
Thanks, I tested your patch and it works.
My original code supposes that the device-tree is provided
Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> On 11/28/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> > On 11/28/07, Michael Ellerman <[EMAIL PROTECTED]> wrote:
> > > On Mon, 2007-11-26 at 10:46 +0300, Cyrill Gorcunov wrote:
> > > > This patch adds checking for NULL value returned to prevent possi
From: Cyrill Gorcunov <[EMAIL PROTECTED]>
This patch adds checking for NULL returned value to
prevent possible NULL pointer dereference.
Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
---
Paul,
This is a resend of a patch from Cyrill. I changed it to inline style.
Cyrill,
This works good o
This patch fixes the following link error with
CONFIG_PPC_CELL_NATIVE=y and CONFIG_PPC_CELL_BLADE=n:
arch/powerpc/platforms/built-in.o: In function `.cell_setup_arch':
setup.c:(.init.text+0xe80): undefined reference to `.mmio_nvram_init'
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index:
This patch updates celleb_defconfig to support for native CBE.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/configs/celleb_defconfig
===
--- linux-powerpc-git.orig/arch/powerpc/configs/cel
This patch adds supporting for native CBE on Celleb. Many codes in
platforms/cell/ are used when native CBE environment.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/cell/iommu.c
==
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Tuesday 04 December 2007, Ishizaki Kou wrote:
> >
> > +#ifdef CONFIG_MMIO_NVRAM
> > mmio_nvram_init();
> > +#endif
> > }
>
> The patch is technically correct, but the preferred way of doing this is
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Tuesday 04 December 2007, Ishizaki Kou wrote:
> > This patch adds supporting for native CBE on Celleb. Many codes in
> > platforms/cell/ are used when native CBE environment.
> >
> > Signed-off-by: Kou Ishizaki <[
This patch splits machine definition for celleb into two definitoins,
one is for celleb_beat, and another is for celleb_native. Though this
patch looks complex because of sorting some functions, there are no
more semantic changes than that for the splitting.
Signed-off-by: Kou Ishizaki <[EMAIL PRO
This patch adds conditional initialization for mmio_nvram_init().
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Here is the previous discussion:
http://ozlabs.org/pipermail/linuxppc-dev/2007-December/047435.html
Index: linux-powerpc-git/arch/powerpc/platforms/cell/setup.c
===
Christian Krafft wrote:
> On Thu, 23 Aug 2007 18:12:19 +0200
> Arnd Bergmann <[EMAIL PROTECTED]> wrote:
>
> > On Thursday 23 August 2007, [EMAIL PROTECTED] wrote:
> > > Please check "unit-id" if "physical-id" doesn't exist. Because
Celleb
> > > uses "unit-id" to provide spe_id.
>
> Sorry for the
This is a workaround NOT to insert EA=0 entry at initializing SLB.
Without this patch, you can see /sbin/init hanging at a machine
which has less or equal than 256MB memory.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/kernel/setup_64.c
===
This patch is an update for "Beat on Celleb"
- Move beat_pause(), beat_kexec_cpu_down() from setup.c to beat.c
Signed-off-by: <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/beat.h
===
--- linux-power
This is a patch to support Power/Reset buttons on Beat on Celleb.
On Beat, we have an event from Beat if Power button or Reset button
is pressed. This patch catches the event and convert it to a signal
to INIT process.
/sbin/inittab have no entry to turn the machine power off so we have
to detect
This is an update patch for Serial I/O on Celleb.
- Detection algorithm has been changed
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/scc_sio.c
===
--- linux-powerpc-git
This is a patch kit to support PCI bus on Celleb with new "I/O routines
for PowerPC." External PCI on Celleb must do explicit synchronization
with devices (Bus has no automatic synchronization feature).
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/plat
This is a patch kit to work with new Guest OS Interface
to tweak HTAB on Beat. It detects old and new Guest OS Interfaces
automatically.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/setup.c
=
This is a patch to support VFD on Celleb 2.
VFD is a small LCD to show miscellaneous messages.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/Kconfig
===
--- linux-powerpc-g
> On Wednesday 26 September 2007, Ishizaki Kou wrote:
> > This patch is an update for "Beat on Celleb"
> > - Move beat_pause(), beat_kexec_cpu_down() from setup.c to beat.c
> >=20
> > Signed-off-by: <[EMAIL PROTECTED]>
>=20
> Acked-by: Arnd Be
Ben-san,
> On Thu, 2007-09-27 at 17:01 +0900, [EMAIL PROTECTED] wrote:
>
> > Celleb does not set get_paca()->kstack properly (I don't know which
> > function should set it up), so we need to workaround.
>
> paca->kstack is set in asm (via the PACAKSAVE macro), from either
> __secondary_start for n
> On Thu, 2007-09-27 at 16:53 +0900, Ishizaki Kou wrote:
> > This is a patch kit to work with new Guest OS Interface
> > to tweak HTAB on Beat. It detects old and new Guest OS Interfaces
> > automatically.
>
> You may also consider adding an API to Beat to invalidat
Ben-san,
> > It should have been set in setup_64.c, in setup_paca() (which is
called
> > twice) in that statement:
> >
> > local_paca = &paca[cpu];
> >
> > As local_paca is defined as being a variable held in register r13.
Maybe
> > something bad's happening with the compiler ?
> Can you ch
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Wednesday 26 September 2007, Ishizaki Kou wrote:
> > This is a patch kit to support PCI bus on Celleb with new "I/O routines
> > for PowerPC." External PCI on Celleb must do explicit synchronization
> &g
Follwing patch series is an update to support Cell Reference Set (Celleb).
Two patches of former series are declined, two are updated, and rest
three still remain.
Declined patches are "fixing SLB initialization" and "VFD support for
Celleb 2." I found former patch not necessary anymore, and latt
This patch is an update for "Beat on Celleb"
- Move beat_pause(), beat_kexec_cpu_down() from setup.c to beat.c
Signed-off-by: <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/beat.h
===
This is a patch to support Power/Reset buttons on Beat on Celleb.
On Beat, we have an event from Beat if Power button or Reset button
is pressed. This patch catches the event and convert it to a signal
to INIT process by calling ctrl_alt_del() function.
/sbin/inittab have no entry to turn the mac
This is a patch kit to work with new Guest OS Interface
to tweak HTAB on Beat. It detects old and new Guest OS Interfaces
automatically.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/setup.c
=
This is an update patch for Serial I/O on Celleb.
- Detection algorithm has been changed
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/scc_sio.c
===
--- linux-powerpc-git
This is a patch kit to support PCI bus on Celleb with new "I/O routines
for PowerPC." External PCI on Celleb must do explicit synchronization
with devices (Bus has no automatic synchronization feature).
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/plat
This patch moves the SCC (Super Companion Chip) related code for celleb
into platforms/cell/.
All files in this patch are used by celleb-beat and celleb-native commonly.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/celleb_scc.h | 145 +++
arch/powerpc/
This patch moves files for Beat hvcall interfaces into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/beat_hvCall.S| 287 ++
arch/powerpc/platforms/cell/beat_syscal
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/celleb/beat.c | 17 +++--
arch/powerpc/platforms/celleb/beat.h |4 ++--
arch/powerpc/platforms/celleb/beat_wrapper.h |3 ++-
arch/powerpc/platforms/celleb/htab.c |7 ---
This patch moves files for mmu and iommu on Beat into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/beat_htab.c | 441 +++
arch/powerpc/platforms/cell/beat_iommu.
This patch moves the base code for celleb support into platforms/cell/.
All files in this patch are used by celleb-beat and celleb-native commonly.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/Kconfig |1
arch/powerpc/platforms/Makefile|
This is a patchset for 2.6.26 which contains following changes:
- cleanup [PATCH 1/11]
- move celleb files into platforms/cell/ [PATCH 2/11]..[PATCH 7/11]
- consolidate io-workarounds code [PATCH 8/11]..[PATCH 9/11]
- add support for celleb PCI Express
This patch moves miscellaneous files for Beat into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/beat.c | 264 +
arch/powerpc/platforms/cell/beat.h
This patch splits cell io-workaround code into spider-pci dependent
code and a generic part, and also adds interfaces to the generic
io-workaround mechanism.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Please test on CellBlade because I don't have any access to CellBlade.
arch/powerpc/
Now, we can use generic io-workarounds mechanism and the workaround
code for spider-pci. This patch changes Celleb PCI code to use
spider-pci code.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/celleb_pci.c | 53 +++-
arch/powerpc/platforms/cell/celleb_pc
This patch fixes a potential bug at drivers/char/hvc_beat.c.
- hvc_put_term_char routine will decrement "rest" variable twice,
and forget to advance "buf" pointer by "nlen" bytes.
This bug was not hit because the output handler in
drivers/char/hvc_console.c splits given output into 16 bytes
at
This patch moves SPU support code on Beat into platforms/cell/.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/beat_spu_priv1.c | 207 +++
arch/powerpc/platforms/celleb/spu_priv1.c| 207 ---
2 files changed, 20
This patch adds support for PCI Express port on Celleb. I/O space
of this PCI Express port is not mapped in memory space. So we use
the io-workaround mechanism to make accesses indirect.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/celleb_pci.c |9
ar
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Wednesday 05 March 2008, Ishizaki Kou wrote:
> > This patch moves the base code for celleb support into platforms/cell/.
> > All files in this patch are used by celleb-beat and celleb-native commonly.
>
> Moving around the
Roel Kluin <[EMAIL PROTECTED]> wrote:
> Roel Kluin wrote:
> > This patch was not yet tested. Please confirm it's right.
>
> was too quick with the send button. the batch below is probably better
> ---
> strncpy does not append '\0' if the length of the source string equals
> the size parameter, st
Arnd Bergmann <[EMAIL PROTECTED]> wrote:
> On Wednesday 05 March 2008, Ishizaki Kou wrote:
> > This patch adds support for PCI Express port on Celleb. I/O space
> > of this PCI Express port is not mapped in memory space. So we use
> > the io-workaround mechanis
This is a second round of the patchset for 2.6.26 which contains
following changes:
- cleanup [PATCH 1/11]
- consolidate io-workarounds code [PATCH 2/11]..[PATCH 3/11]
- move celleb files into platforms/cell/ [PATCH 4/11]..[PATCH 9/11]
- add support for cel
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/celleb/beat.c | 17 +++--
arch/powerpc/platforms/celleb/beat.h |4 ++--
arch/powerpc/platforms/celleb/beat_wrapper.h |3 ++-
arch/powerpc/pla
This patch splits cell io-workaround code into spider-pci dependent
code and a generic part, and also adds interfaces to the generic
io-workaround mechanism.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Please test on CellBlade because I don't have any access to CellBlade.
arch/powerpc/
Now, we can use generic io-workarounds mechanism and the workaround
code for spider-pci. This patch changes Celleb PCI code to use
spider-pci code.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |6
This patch moves the base code for celleb support into platforms/cell/.
All files in this patch are used by celleb-beat and celleb-native commonly.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/Kconfig |1
arch/powerpc/platforms/cell/Kconfig|
This patch moves the SCC (Super Companion Chip) related code for celleb
into platforms/cell/.
All files in this patch are used by celleb-beat and celleb-native commonly.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Mak
This patch moves files for Beat hvcall interfaces into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |3
arch/powerpc/platform
This patch moves files for mmu and iommu on Beat into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |3
arch/powerpc/platforms/cel
This patch moves SPU support code on Beat into platforms/cell/.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |1
arch/powerpc/platforms/cell/beat_spu_priv1.c | 207 +++
ar
This patch moves miscellaneous files for Beat into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/Makefile |1
arch/powerpc/platforms/ce
This patch adds support for PCI Express port on Celleb. I/O space
of this PCI Express port is not mapped in memory space. So we use
the io-workaround mechanism to make accesses indirect.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/p
This patch fixes a potential bug at drivers/char/hvc_beat.c.
- hvc_put_term_char routine will decrement "rest" variable twice,
and forget to advance "buf" pointer by "nlen" bytes.
This bug was not hit because the output handler in
drivers/char/hvc_console.c splits given output into 16 bytes
at
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> I may have missed something in your patch but if the workarounds are
> specific to a given bridge, they may as well set the top level
> indirections once straight to the right workarounds.
>
> Also, my understanding is that we are pretty much usi
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> > As you said, if read/write/in/out functions take device parameter,
> > taking I/O function pointers into the dev_archdata structure should be
> > the best solution. But they don't take device parameter, and they must
> > search I/O function poin
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> On Wed, 2008-04-02 at 19:52 +0900, Ishizaki Kou wrote:
> > Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> > > > As you said, if read/write/in/out functions take device parameter,
> > > > takin
Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote:
> On Fri, 2008-04-04 at 15:42 +0900, Ishizaki Kou wrote:
> >
> > As you pointed, spider I/O functions in Cell blades need 2 step
> > indirections by our patch. Shall I make another one for Cell blades
> > whose s
Paul Mackerras <[EMAIL PROTECTED]> wrote:
> The following patches have been added to the master and powerpc-next
> branches of the powerpc.git repository. There is a bunch that I
Paul-san,
Could you apply my "take 2" patchset?
[PATCH 0/11] celleb: patchset for 2.6.26 (take 2)
http://ozlabs.org/
Ben-san,
I'm sorry to have kept you waiting for my response.
I just finished reviewing your patch. Your patch works well on
Celleb, and I found I also should do the same thing for Celleb as you
pointed. I will send a new patch which includes your fix.
Benjamin Herrenschmidt <[EMAIL PROTECTED]
Ben-san,
I'm sorry to have kept you waiting for my response.
I just finished reviewing your patch. Your patch works well on
Celleb, and I found I also should do the same thing for Celleb as you
pointed. I will send a new patch which includes your fix.
Benjamin Herrenschmidt <[EMAIL PROTECTED]
Now, we can use generic io-workarounds mechanism and the workaround
code for spider-pci. This patch changes Celleb PCI code to use
spider-pci code.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |6
This patch moves the base code for celleb support into platforms/cell/.
All files in this patch are used by celleb-beat and celleb-native commonly.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/Kconfig |1
arch/powerpc/platforms/cell/Kconfig|
This patch splits cell io-workaround code into spider-pci dependent
code and a generic part, and also moves io-workarounds initialization
into cell_setup_phb. This patch includes BenH's fix.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
-
This patch moves the SCC (Super Companion Chip) related code for celleb
into platforms/cell/.
All files in this patch are used by celleb-beat and celleb-native commonly.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Mak
This patch moves files for Beat hvcall interfaces into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |3
arch/powerpc/platform
This patch moves files for mmu and iommu on Beat into platforms/cell/.
All files in this patch are used by celleb-beat only.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |3
arch/powerpc/platforms/cel
This patch moves SPU support code on Beat into platforms/cell/.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
---
arch/powerpc/platforms/cell/Makefile |1
arch/powerpc/platforms/cell/beat_spu_priv1.c | 207 +++
ar
This patch adds support for PCI Express port on Celleb. I/O space
of this PCI Express port is not mapped in memory space. So we use
the io-workaround mechanism to make accesses indirect.
I send this patch again because it would be lost.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
Acked-by: Ar
Paul-san,
Could you add these two patches?
[PATCH] of_serial: ignore unknown serial port
http://patchwork.ozlabs.org/linuxppc/patch?id=11421
[PATCH] of_serial: add port type checking
http://patchwork.ozlabs.org/linuxppc/patch?id=11422
Best regards,
Kou Ishizaki
___
In some configuration, xmon help string is larger than xmon output
buffer. To show whole help string, this patch splits it into 2 parts.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/xmon/xmon.c
=
> On Thu, 2007-07-12 at 16:59 +0900, Ishizaki Kou wrote:
> > In some configuration, xmon help string is larger than xmon output
> > buffer. To show whole help string, this patch splits it into 2
parts.
> >
> > Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
(sni
In some configuration, xmon help string is larger than xmon_printf
buffer. We need not to use printf. This patch adds xmon_puts and
change to use it to show help string.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
This patch depends on [PATCH 1/2].
Index: linux-powerpc-git/arch/powerpc
Because xmon_write doesn't change the buffer, we should add 'const'
qualifier to the argument which points it.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/xmon/start.c
===
--- linux-power
Milton Miller <[EMAIL PROTECTED]> wrote:
> On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote:
>
> > Milton Miller <[EMAIL PROTECTED]> writes:
> >
> >>> case '?':
> >>> - printf(help_string);
> >>> + xmon_puts(help_string);
> >>>
This patch cleans up xmon to keep consistency.
In xmon, we should use console I/O functions that are named the same
as user space stdio functions. But commit
4d404edce30f911004850d472e05a31efd751662 broke this consistency.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-
Fix following warnings:
WARNING: vmlinux.o(.text+0x44ad0): Section mismatch: reference to
.init.text:.__alloc_bootmem (between '.celleb_setup_phb' and
'.celleb_fake_pci_write_config')
WARNING: vmlinux.o(.text+0x44dd8): Section mismatch: reference to
.init.text:.free_bootmem (between '.celleb_set
There are some variables and functions that we should place in init
section. And this patch changes some '__devinit' to '__init', because
the device is platform device and not hot-pluggable.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb
Fix warnings about section mismatch.
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/drivers/char/hvc_beat.c
===
--- linux-powerpc-git.orig/drivers/char/hvc_beat.c
+++ linux-powerpc-git/drivers/char/hvc_b
Fix following warning:
WARNING: vmlinux.o(.text+0x45fd4): Section mismatch: reference to
.init.text:.early_serial_txx9_setup (between '.txx9_serial_init' and
'.txx9_serial_config')
Signed-off-by: Kou Ishizaki <[EMAIL PROTECTED]>
---
Index: linux-powerpc-git/arch/powerpc/platforms/celleb/scc_sio
Michael Ellerman <[EMAIL PROTECTED]> wrote:
> On Wed, 2007-07-25 at 16:21 +1000, Benjamin Herrenschmidt wrote:
> > On Wed, 2007-07-25 at 11:57 +0900, Ishizaki Kou wrote:
> > > This patch cleans up xmon to keep consistency.
> > >
> > > In xmon, we shoul
85 matches
Mail list logo