Re: [PATCH] crypto: crypto4xx - Perform read/modify/write on device control register

ntentionally disable other functions like the PKA or TRNG > when the driver is loaded. > > Perform a read/modify/write to enable the 3DES function instead. > > Signed-off-by: Josh Boyer Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org

Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

Josh Boyer > > Looks good. > > Acked-by: Matt Mackall Also applied. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing l

Re: [PATCH 1/3] AMCC Crypto4xx Device Driver v7

inst splitting it up, but if you are going to do it please make sure that each patch compiles by itself since we want a bisectable tree. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.a

Re: [PATCH 1/3] crypto: talitos - simplify hmac data size calculation

t http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] crypto: vmx/xts - use fallback for ciphertext stealing

/aes_xts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: nx - remove unused variables 'nx_driver_string' and 'nx_driver_version'

gt; They are never used, so just remove it. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > drivers/crypto/nx/nx.h | 3 --- > 1 file changed, 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: talitos - fix hash result for VMAP_STACK

> --- > drivers/crypto/talitos.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/4] crypto: nx - convert to skcipher API

---- > 7 files changed, 176 insertions(+), 215 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto: vmx: Improved AES/XTS performance of 6-way unrolling for ppc.

gt; drivers/crypto/vmx/aesp8-ppc.pl | 141 +--- > 1 file changed, 92 insertions(+), 49 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/5] crypto: mxs-dcp: Add support for hardware-bound keys

--- > include/soc/fsl/dcp.h| 17 +++ > 2 files changed, 110 insertions(+), 11 deletions(-) > create mode 100644 include/soc/fsl/dcp.h Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2 0/5] crypto: Accelerated Chacha20/Poly1305 implementation

0644 arch/powerpc/crypto/chacha-p10le-8x.S > create mode 100644 arch/powerpc/crypto/poly1305-p10-glue.c > create mode 100644 arch/powerpc/crypto/poly1305-p10le_64.S > > -- > 2.31.1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

locate memory page by page as you decompress means that: 1. We're not affected by memory fragmentation. 2. We don't waste memory by always allocating for the worst case. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

On Fri, Jul 28, 2023 at 11:57:42AM +0200, Ard Biesheuvel wrote: > > So will IPcomp be able to simply assign those pages to the SKB afterwards? Yes that is the idea. The network stack is very much in love with SG lists :) Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.

Re: [RFC PATCH 00/21] crypto: consolidate and clean up compression APIs

afety-net for those weird jumbo packets. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3] hwrng: Explicitly include correct DT includes

rs/char/hw_random/pasemi-rng.c| 3 +-- > drivers/char/hw_random/pic32-rng.c | 5 ++--- > drivers/char/hw_random/stm32-rng.c | 3 ++- > drivers/char/hw_random/xgene-rng.c | 5 ++--- > drivers/char/hw_random/xiphera-trng.c | 1 - > 12 files changed, 12 insertions(+),

crypto: powerpc/chacha20,poly1305-p10 - Add dependency on VSX

: https://lore.kernel.org/oe-kbuild-all/202308251906.syawej6g-...@intel.com/ Signed-off-by: Herbert Xu diff --git a/arch/powerpc/crypto/Kconfig b/arch/powerpc/crypto/Kconfig index f25024afdda5..7a66d7c0e6a2 100644 --- a/arch/powerpc/crypto/Kconfig +++ b/arch/powerpc/crypto/Kconfig @@ -113,7 +11

Re: [PATCH v2 0/2] Remove POWER10_CPU dependency and move PPC_MODULE_FEATURE_P10.

.h | 1 + > 3 files changed, 2 insertions(+), 2 deletions(-) > > -- > 2.31.1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

)) : 0; What is this for? The usual way is to select CRYPTO_SKCIPHER rather than have a mysterious failure at run-time. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

On Tue, Apr 25, 2023 at 01:37:22PM +0800, Herbert Xu wrote: > On Mon, Apr 24, 2023 at 02:47:23PM -0400, Danny Tsen wrote: > > > > +static int __init chacha_p10_init(void) > > +{ > > + static_branch_enable(&have_p10); > > + > > +

Re: [PATCH 2/5] Glue code for optmized Chacha20 implementation for ppc64le.

= walk.nbytes; > + > + if (nbytes < walk.total) > + nbytes = rounddown(nbytes, walk.stride); > + > + if (!static_branch_likely(&have_p10) || You don't need the static branch in the Crypto API code since the registration is already conditional. Cheers,

Re: [PATCH 4/5] Glue code for optmized Poly1305 implementation for ppc64le.

if (likely(used)) { > + srclen -= used; > + src += used; > + } > + if (srclen >= POLY1305_BLOCK_SIZE*4) { > + vsx_begin(); Your chacha code has a SIMD-fallback, how come this one doesn't? Thank

Re: [PATCH 5/5] Update Kconfig and Makefile.

CHABLE test was so that you could build this without the Crypto API? Colour me confused. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] powerpc/crypto: fix build warnings when DEBUG_FS is not enabled

x > encryption") > Fixes: aef7b31c8833 ("powerpc/crypto: Build files for the nx device driver") > Signed-off-by: Randy Dunlap > Cc: Breno Leitão > Cc: Nayna Jain > Cc: Paulo Flabiano Smorigo > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: linux-c

Re: linux-next: build failure after merge of the crypto tree

hat? (cc'ing the ppc guys in case > they have any ideas.) > > I have reverted that commit (and the following one) for today. Thanks Stephen. I've just pushed out a fix for this. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH linux-next] crypto: nx - Remove the unneeded result variable

/crypto/nx/nx-aes-ccm.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] powerpc/crypto: Avoid -Wstringop-overflow warnings

pe; and just for consistency, do the same for parameter `Xi`. > > Reported-by: Stephen Rothwell > Closes: > https://lore.kernel.org/linux-next/20231121131903.68a37...@canb.auug.org.au/ > Signed-off-by: Gustavo A. R. Silva > --- > arch/powerpc/crypto/aes-gcm-p10-glue.c

Re: [PATCH] crypto:vmx: Move ppc vmx diirectory to arch/powerpc/crypto.

drivers/crypto/vmx/.gitignore > delete mode 100644 drivers/crypto/vmx/Kconfig > delete mode 100644 drivers/crypto/vmx/Makefile > delete mode 100644 drivers/crypto/vmx/ppc-xlate.pl Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] MAINTAINERS: adjust file entries after crypto vmx file movement

werpc/crypto/Kconfig > +F: arch/powerpc/crypto/Makefile > +F: arch/powerpc/crypto/aes* Are you sure about this? There are non-vmx aes* files in that directory. Perhaps something more specific is needed here? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] MAINTAINERS: adjust file entries after crypto vmx file movement

please pick this minor clean-up patch on your -next tree. > > MAINTAINERS | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header

On Tue, Mar 14, 2023 at 08:47:30AM +, Christophe Leroy wrote: > > Any reason for resending ? The p10 patches were reverted, and have only just been re-instated. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~h

Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header

pc patches in future. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header

ication of perl scripts we now have. Yes I think that would certainly make sense. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: p10-aes-gcm - remove duplicate include header

lied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: Cannot load wireguard module

On Wed, Mar 20, 2024 at 11:41:32PM +1100, Michael Ellerman wrote: > > This diff fixes it for me: Yes I think this is the correct fix. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH][next] crypto/nx: Avoid -Wflex-array-member-not-at-end warning

^~ > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/crypto/nx/nx-842.c | 6 -- > drivers/crypto/nx/nx-842.h | 10 ++ > 2 files changed, 10 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] powerpc/crypto/chacha-p10: Fix failure on non Power10

315122005.gg20...@kitsune.suse.cz/ > Signed-off-by: Michael Ellerman > --- > arch/powerpc/crypto/chacha-p10-glue.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) Acked-by: Herbert Xu Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v8 6/6] docs: trusted-encrypted: add DCP as new trust source

On Wed, Apr 03, 2024 at 06:47:51PM +0300, Jarkko Sakkinen wrote: > > Reviewed-by: Jarkko Sakkinen > > I can only test that this does not break a machine without the > hardware feature. Please feel free to take this through your tree. Thanks, -- Email: Herbert Xu

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

cture which is not good. I think the following changes > are a better fix for the warnings: This works for me. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - Fix sparse warnings

On Sat, Oct 03, 2020 at 07:15:53PM +0200, Christophe Leroy wrote: > > The following changes fix the sparse warnings with less churn: Yes that works too. Can you please submit this patch? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key

Re: [PATCH] crypto: talitos - Endianess in current_desc_hdr()

ed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: talitos - Fix return type of current_desc_hdr()

3e721aeb3df3 ("crypto: talitos - handle descriptor not found in error > path") > Signed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http

[PATCH] crypto: api - Use linux/cache.h instead of asm/cache.h

nstead. Fixes: e634ac4a8aaa ("crypto: api - Add crypto_tfm_ctx_dma") Reported-by: Stephen Rothwell Signed-off-by: Herbert Xu diff --git a/include/crypto/algapi.h b/include/crypto/algapi.h index 8722fd67f40a..61b327206b55 100644 --- a/include/crypto/algapi.h +++ b/include/cryp

crypto: p10-aes-gcm - Add asm markings necessary for kernel code

gcm - Glue code for AES/GCM stitched implementation") Fixes: 3b47eccaaff4 ("crypto: p10-aes-gcm - Supporting functions for AES") Signed-off-by: Herbert Xu diff --git a/arch/powerpc/crypto/aesp8-ppc.pl b/arch/powerpc/crypto/aesp8-ppc.pl index 50a0a18f35da..cdbcf6e13efc 100644 ---

Re: crypto: p10-aes-gcm - Add asm markings necessary for kernel code

27;ve reverted these changes completely. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] synchronize_irq needs a barrier

t; value). I prefer a full barrier to also ensure all previous stores are > pushed out. We already have a compiler barrier there in the form of cpu_relax. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondo

Re: [PATCH] synchronize_irq needs a barrier

o think about barriers we may not be helping them at all. In any case, such writers should use easier tools like spin locks rather than trying to go lockless. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.

Re: [PATCH] synchronize_irq needs a barrier

smp_wmb(); If we patch synchronize_irq() as discussed here then you can use it in place of smp_wmb() and remove the smp_rmb from the interrupt handler (the latter is the path that matters). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} &l

Re: [PATCH] synchronize_irq needs a barrier

e right. In this case we do have barriers everywhere else so this should work. Although if you want napi_synchronize to have the property that when it returns all NAPI processing effects are visible then you'd need another smp_mb() after the loop. Cheers, -- Visit Openswan at http://www.opensw

[NET]: Fix possible dev_deactivate race condition

On Fri, Oct 19, 2007 at 12:20:25PM +0800, Herbert Xu wrote: > > In fact this bug exists elsewhere too. For example, the network > stack does this in net/sched/sch_generic.c: > > /* Wait for outstanding qdisc_run calls. */ > while (test_bit(__LINK_STATE_QDISC_RU

Re: [PATCH] synchronize_irq needs a barrier

RESS. I missed this case earlier. In fact this bug exists elsewhere too. For example, the network stack does this in net/sched/sch_generic.c: /* Wait for outstanding qdisc_run calls. */ while (test_bit(__LINK_STATE_QDISC_RUNNING, &dev->state)) yield(); This has the same probl

Re: [PATCH] synchronize_irq needs a barrier

clear IRQ_INPROGRESS spin unlock return So because we're using the same lock on both sides, it does do the right thing even without the memory barrier. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~

Re: [PATCH] synchronize_irq needs a barrier

he smp_mb from tg3.c. BTW, a lot of drivers (including the fusion example Ben quoted) call synchronize_irq before free_irq. This is unnecessary because the latter already calls it anyway. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]&g

Re: [PATCH] synchronize_irq needs a barrier

On Fri, Oct 19, 2007 at 12:20:25PM +0800, Herbert Xu wrote: > > That's why I think this patch is in fact the only one that > solves all the races in this thread. The case that it solves > which the lock/unlock patch does not is the one where action > flows downwards

Re: [NET]: Fix possible dev_deactivate race condition

ss context then we'll gladly accept your patch :) Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt _

[IRQ]: Fix synchronize_irq races with IRQ handler

ay return followed by the result of netif_rx_schedule being made visible. This patch (mostly written by Linus) fixes this by using spin locks instead of memory barries on the synchronize_irq() path. Signed-off-by: Herbert Xu <[EMAIL PROTECTED]> Acked-by: Benjamin Herrenschmidt <[EMAIL P

Re: [PATCH/RFC] net: Add __napi_sycnhronize() to sync with napi poll

oblems to worry about. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linux

Re: [PATCH 2/2 v2] talitos: Freescale integrated security engine (SEC) driver

ary by AEAD algorithms? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxpp

Re: [PATCH 2/2 v2] talitos: Freescale integrated security engine (SEC) driver

enswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 1/4] crypto/talitos: rm duplicate timeout definition

On Mon, Jun 16, 2008 at 11:10:40AM -0500, Kim Phillips wrote: > Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> I've merged these patches into the original changeset. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECT

Re: [PATCH 1/6] crypto: talitos - remove calls to of_node_put

.6. Thanks! -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH 4/6] crypto: talitos - fix GFP flag usage

n. Kim? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailin

Re: [PATCH] crypto: talitos - Fix modpost warning

L PROTECTED]> OK, but what about the __devexit_p reference on talitos_remove? We should remove that too. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: h

Re: mal_probe crash

eds to go back to the old fake dev setup. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH] AMCC Crypto4xx Device Driver v5

Please always attach a proper changelog with each submission so I don't have to do this. You can put the changelog elsewhere in the email. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbe

Re: [PATCH] AMCC Crypto4xx Device Driver v5

against the changelog you had but it should be present along with the patch description so it can actually be applied. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~her

Re: [PATCH 00/20] Rid W=1 warnings in Crypto

ld not be kernel-doc > crypto: nx: nx_debugfs: Header comments should not be kernel-doc > crypto: nx: Demote header comment and add description for 'nbytes' > crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers Thanks for doing this. But please don

Re: [PATCH] crypto: powerpc: remove unneeded semicolon

-glue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v2] crypto/nx: add missing call to of_node_put()

anged, 3 insertions(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: sha: remove unneeded semicolon

+- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 00/10] Rid W=1 warnings in Crypto

Cc: Aymen Sghaier > Cc: Ayush Sawal > Cc: Benjamin Herrenschmidt > Cc: Berne Hebark > Cc: "Breno Leitão" > Cc: Daniele Alessandrelli > Cc: "David S. Miller" > Cc: Declan Murphy > Cc: Harsh Jain > Cc: Henrique Cerri > Cc: Herbert Xu &g

Re: [PATCH] crypto: vmx: fix incorrect kernel-doc comment syntax in files

es_cbc.c | 2 +- > drivers/crypto/vmx/aes_ctr.c | 2 +- > drivers/crypto/vmx/aes_xts.c | 2 +- > drivers/crypto/vmx/ghash.c | 2 +- > drivers/crypto/vmx/vmx.c | 2 +- > 6 files changed, 6 insertions(+), 6 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: nx: fix incorrect kernel-doc comment syntax in files

> drivers/crypto/nx/nx-sha256.c | 2 +- > drivers/crypto/nx/nx-sha512.c | 2 +- > drivers/crypto/nx/nx.c | 2 +- > drivers/crypto/nx/nx_debugfs.c | 2 +- > 10 files changed, 10 insertions(+), 10 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v3 1/2] crypto: vmx - merge CRYPTO_DEV_VMX_ENCRYPT into CRYPTO_DEV_VMX

ot force the options that it selects to y/n. The select still operates on the basis of the tristate. So I don't see the point to this code churn unless the powerpc folks want to move in this direction. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://go

Re: [PATCH v3 2/2] crypto: vmx - add missing dependencies

/vmx/Kconfig) > * change commit subject to be compatible > > drivers/crypto/Kconfig | 4 > 1 file changed, 4 insertions(+) Please respin this patch to add the selects to the existing tristate. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH v4 1/1] crypto: vmx - add missing dependencies

r XTS") > Fixes: d2e3ae6f3aba ("crypto: vmx - Enabling VMX module for PPC64") > > Suggested-by: Nicolai Stange > Signed-off-by: Petr Vorel > --- > Changes v3->v4: > * Drop commit which merged CRYPTO_DEV_VMX and CRYPTO_DEV_VMX_ENCRYPT > (Herbert) >

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

still avoids the build failures fixed by commit 4ee812f6143d > ("crypto: vmx - Avoid weird build failures"). > > Signed-off-by: Masahiro Yamada > --- > > drivers/crypto/vmx/Makefile | 17 +++-- > 1 file changed, 3 insertions(+), 14 deletio

Re: [PATCH] crypto: vmx - Align the short log with Makefile cleanups

rg/ > > > Could you replace it, or fix it up, please? Please send me an incremental patch. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: vmx - Fix build error

t > Signed-off-by: Masahiro Yamada > --- > > drivers/crypto/vmx/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [V3 PATCH 13/16] crypto/nx: Rename nx-842-pseries file name to nx-common-pseries

gt; diff --git a/drivers/crypto/nx/nx-842-pseries.c > b/drivers/crypto/nx/nx-common-pseries.c > similarity index 100% > rename from drivers/crypto/nx/nx-842-pseries.c > rename to drivers/crypto/nx/nx-common-pseries.c Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [V3 PATCH 14/16] crypto/nx: Register and unregister VAS interface

t; drivers/crypto/nx/nx-common-pseries.c | 9 + > 2 files changed, 10 insertions(+) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [V3 PATCH 15/16] crypto/nx: Get NX capabilities for GZIP coprocessor type

ic > features phyp supports. Then retrieve NXGZIP specific capabilities. > > Signed-off-by: Haren Myneni > --- > drivers/crypto/nx/nx-common-pseries.c | 83 +++ > 1 file changed, 83 insertions(+) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page:

Re: [V3 PATCH 16/16] crypto/nx: Add sysfs interface to export NX capabilities

ed, 43 insertions(+) Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH -next] crypto: nx842: add missing MODULE_DEVICE_TABLE

off-by: Bixuan Cui > --- > drivers/crypto/nx/nx-842-pseries.c | 1 + > 1 file changed, 1 insertion(+) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 0/3] Rid W=1 warnings from Crypto

| 2 +- > drivers/crypto/nx/nx-842-pseries.c| 24 +-- > 8 files changed, 27 insertions(+), 27 deletions(-) > > Cc: Benjamin Herrenschmidt > Cc: "David S. Miller" > Cc: Gary R Hook > Cc: George Cherian > Cc: Haren Myneni >

Re: [PATCH 09/16] ps3disk: use memcpy_{from,to}_bvec

rypto API has the same check. This all goes back to commit 4f3e797ad07d52d34983354a77b365dfcd48c1b4 Author: Herbert Xu Date: Mon Feb 9 14:22:14 2009 +1100 crypto: scatterwalk - Avoid flush_dcache_page on slab pages It's illegal to call flush_dcache_page on slab pages on a numb

[PATCH] soc: fsl: Remove bogus packed attributes from qman.h

There are two __packed attributes in qman.h that are both unnecessary and causing compiler warnings because they're conflicting with explicit alignment requirements set on members within the structure. This patch removes them both. Signed-off-by: Herbert Xu diff --git a/include/soc/fsl/q

Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero

On Mon, Aug 10, 2020 at 10:20:20AM +, Van Leeuwen, Pascal wrote: > > With all due respect, but this makes no sense. I agree. This is a lot of churn for no gain. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~h

Re: [PATCH 19/22] crypto: inside-secure - add check for xts input length equal to zero

and several other algorithms > mentioned in the cover letter. CTR accepts any input size. > What's the rule in these cases? What input size is accepted depends on the algorithm. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

On Thu, Jul 30, 2020 at 10:52:59PM +1000, Herbert Xu wrote: > There are two __packed attributes in qman.h that are both unnecessary > and causing compiler warnings because they're conflicting with > explicit alignment requirements set on members within the structure. > > Thi

Re: [PATCH] soc: fsl: Remove bogus packed attributes from qman.h

structs contain no holes. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: talitos - Work around SEC6 ERRATA (AES-CTR mode data size error)

; Fixes: 5e75ae1b3cef ("crypto: talitos - add new crypto modes") > Signed-off-by: Christophe Leroy > --- > drivers/crypto/talitos.c | 28 > drivers/crypto/talitos.h | 1 + > 2 files changed, 17 insertions(+), 12 deletions(-) All applied. Than

Re: [next-20200621] LTP tests af_alg02/05 failure on POWER9 PowerVM LPAR

rough recvmsg(2). Setting the MSG_MORE flag indicates that your request has not been sent in full. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: af_alg - Fix regression on empty requests

t distinguish the case of no metadata as opposed to an empty request. IOW it is always assumed that if you call recv(2) before sending metadata that you are working with an empty request. Reported-by: Sachin Sant Reported-by: Naresh Kamboju Fixes: f3c802a1f300 ("crypto: algif_aead - Onl

[v2 PATCH] crypto: af_alg - Fix regression on empty requests

x->init as long as one sendmsg(2) has been made, with or without a control message. Reported-by: Sachin Sant Reported-by: Naresh Kamboju Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when...") Signed-off-by: Herbert Xu diff --git a/crypto/af_alg.c b/crypto/af_alg.c index 9

Re: [PATCH 04/11] crypto: marvell: cesa: change FPGA indirect article to an

On Tue, Jun 08, 2021 at 02:23:43PM -0700, t...@redhat.com wrote: > From: Tom Rix > > Change use of 'a fpga' to 'an fpga' > > Signed-off-by: Tom Rix > --- > drivers/crypto/marvell/cesa/cesa.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) P

Re: [PATCH 01/18] mm: add a kunmap_local_dirty helper

why flush_kernel_dcache_page() needs so much logic around it > before complicating the general kernel users. > > I would like to see it go away if possible. This thread may be related: https://lwn.net/Articles/240249/ Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[PATCH] crypto: scatterwalk - Remove obsolete PageSlab check

is now legal to call flush_dcache_page on slab pages we no longer need to do the check in the Crypto API. Reported-by: Ira Weiny Signed-off-by: Herbert Xu diff --git a/include/crypto/scatterwalk.h b/include/crypto/scatterwalk.h index c837d0775474..7af08174a721 100644 --- a/include/crypto/scatte

Re: [PATCH] crypto: nx: Fix memcpy() over-reading in nonce

pto/nx/nx-aes-ctr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: DRBG - select SHA512

Signed-off-by: Stephan Mueller > --- > crypto/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] crypto: DRBG - select SHA512

On Sat, Aug 14, 2021 at 06:23:26PM +0200, Borislav Petkov wrote: > On Fri, Jul 16, 2021 at 04:14:12PM +0800, Herbert Xu wrote: > > Stephan Mueller wrote: > > > With the swtich to use HMAC(SHA-512) as the default DRBG type, the > > > configuration must now also select

<    1   2   3   4   >