Re: scheduler crash on Power

2014-07-31 Thread Dietmar Eggemann
Hi Sukadev, On 30/07/14 08:22, Sukadev Bhattiprolu wrote: > > I am getting this crash on a Powerpc system using 3.16.0-rc7 kernel plus > some patches related to perf (24x7 counters) that Cody Schafer posted here: > > https://lkml.org/lkml/2014/5/27/768 > > I don't get the crash on an unpa

Re: scheduler crash on Power

2014-08-04 Thread Dietmar Eggemann
On 04/08/14 04:20, Michael Ellerman wrote: > On Fri, 2014-08-01 at 14:24 -0700, Sukadev Bhattiprolu wrote: >> Dietmar Eggemann [dietmar.eggem...@arm.com] wrote: >> | > ltcbrazos2-lp07 login: [ 181.915974] [ cut here >> ] >> | > [ 181.91

Re: [RFC 0/1] sched/fair: Consider asymmetric scheduler groups in load balancer

2023-07-06 Thread Dietmar Eggemann
On 04/07/2023 11:11, Tobias Huschle wrote: > On 2023-05-16 18:35, Dietmar Eggemann wrote: >> On 15/05/2023 13:46, Tobias Huschle wrote: >>> The current load balancer implementation implies that scheduler groups, >>> within the same scheduler domain, all host the same n

Re: [RFC 0/1] sched/fair: Consider asymmetric scheduler groups in load balancer

2023-05-16 Thread Dietmar Eggemann
On 15/05/2023 13:46, Tobias Huschle wrote: > The current load balancer implementation implies that scheduler groups, > within the same scheduler domain, all host the same number of CPUs. > > This appears to be valid for non-s390 architectures. Nevertheless, s390 > can actually have scheduler grou

[PATCH 3/3] sched/core: Update task_prio() function header

2021-01-28 Thread Dietmar Eggemann
The description of the RT offset and the values for 'normal' tasks needs update. Moreover there are DL tasks now. task_prio() has to stay like it is to guarantee compatibility with the /proc//stat priority field: # cat /proc//stat | awk '{ print $18; }' Signed-off-

[PATCH 2/3] sched: Remove USER_PRIO, TASK_USER_PRIO and MAX_USER_PRIO

2021-01-28 Thread Dietmar Eggemann
he {*_}USER_PRIO defines. Signed-off-by: Dietmar Eggemann --- arch/powerpc/platforms/cell/spufs/sched.c | 2 +- include/linux/sched/prio.h| 9 - kernel/sched/sched.h | 2 +- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/arch/powe

[PATCH 0/3] sched: Task priority related cleanups

2021-01-28 Thread Dietmar Eggemann
t why this range is mentioned here? Maybe the influence of the 'sleep-bonus interactivity' feature which was removed by commit f3479f10c5d6 ("sched: remove the sleep-bonus interactivity code")? Dietmar Eggemann (3): sched: Remove MAX_USER_RT_PRIO sched: Remove

[PATCH 1/3] sched: Remove MAX_USER_RT_PRIO

2021-01-28 Thread Dietmar Eggemann
Get rid of MAX_USER_RT_PRIO and make everything use MAX_RT_PRIO instead. Signed-off-by: Dietmar Eggemann --- include/linux/sched/prio.h | 9 + kernel/sched/core.c| 7 +++ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/include/linux/sched/prio.h b/include/linux/sched/pr

Re: [PATCH v5 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-08-16 Thread Dietmar Eggemann
On 06/08/2024 10:53, Yicong Yang wrote: > From: Yicong Yang > > Currently if architectures want to support HOTPLUG_SMT they need to > provide a topology_is_primary_thread() telling the framework which > thread in the SMT cannot offline. However arm64 doesn't have a > restriction on which thread i

Re: [PATCH v5 2/4] arch_topology: Support SMT control for OF based system

2024-08-16 Thread Dietmar Eggemann
On 06/08/2024 10:53, Yicong Yang wrote: > From: Yicong Yang > > On building the topology from the devicetree, we've already > gotten the SMT thread number of each core. Update the largest > SMT thread number to enable the SMT control. Do we have SMT Device Tree (DT) systems out there? But you ri

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-08-16 Thread Dietmar Eggemann
On 06/08/2024 10:53, Yicong Yang wrote: > From: Yicong Yang > > For ACPI we'll build the topology from PPTT and we cannot directly > get the SMT number of each core. Instead using a temporary xarray > to record the SMT number of each core when building the topology > and we can know the largest S

Re: [PATCH v5 3/4] arm64: topology: Support SMT control on ACPI based system

2024-08-22 Thread Dietmar Eggemann
On 19/08/2024 09:03, Yicong Yang wrote: > On 2024/8/16 23:55, Dietmar Eggemann wrote: >> On 06/08/2024 10:53, Yicong Yang wrote: >>> From: Yicong Yang [...] >> So the xarray contains one element for each core_id with the information >> how often the core_id occurs

Re: [PATCH v9 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2024-11-18 Thread Dietmar Eggemann
On 18/11/2024 11:50, Yicong Yang wrote: > On 2024/11/15 17:42, Pierre Gondois wrote: >> Hello Yicong, >> >> >> On 11/14/24 15:11, Yicong Yang wrote: >>> From: Yicong Yang [...] >>>   diff --git a/include/linux/topology.h b/include/linux/topology.h >>> index 52f5850730b3..b8e860276518 100644 >>>

Re: [PATCH v11 2/4] arch_topology: Support SMT control for OF based system

2025-03-04 Thread Dietmar Eggemann
On 03/03/2025 15:03, Yicong Yang wrote: > On 2025/2/28 19:11, Dietmar Eggemann wrote: >> On 18/02/2025 15:10, Yicong Yang wrote: >>> From: Yicong Yang [...] >>> If a system have more than one SMT thread number the 2) may >> >> s/have/has >> >>&

Re: [PATCH v11 1/4] cpu/SMT: Provide a default topology_is_primary_thread()

2025-02-28 Thread Dietmar Eggemann
On 18/02/2025 15:10, Yicong Yang wrote: > From: Yicong Yang [...] > diff --git a/include/linux/topology.h b/include/linux/topology.h > index 52f5850730b3..b3aba443c4eb 100644 > --- a/include/linux/topology.h > +++ b/include/linux/topology.h > @@ -240,6 +240,28 @@ static inline const struct cpuma

Re: [PATCH v11 2/4] arch_topology: Support SMT control for OF based system

2025-02-28 Thread Dietmar Eggemann
On 18/02/2025 15:10, Yicong Yang wrote: > From: Yicong Yang > > On building the topology from the devicetree, we've already > gotten the SMT thread number of each core. Update the largest > SMT thread number and enable the SMT control by the end of > topology parsing. > > The core's SMT control

Re: [PATCH v11 3/4] arm64: topology: Support SMT control on ACPI based system

2025-02-28 Thread Dietmar Eggemann
On 18/02/2025 15:10, Yicong Yang wrote: > From: Yicong Yang [...] > @@ -67,6 +108,31 @@ int __init parse_acpi_topology(void) > cpu_topology[cpu].package_id = topology_id; > } > > + /* > + * This should be a short loop depending on the number of heterogeneous

Re: [PATCH v11 0/4] Support SMT control on arm64

2025-02-28 Thread Dietmar Eggemann
/topology.h | 1 + > arch/x86/include/asm/topology.h | 2 +- > drivers/base/arch_topology.c| 27 > include/linux/topology.h| 22 ++ > 6 files changed, 118 insertions(+), 1 deletion(-) With the review comments on the individual patches [0-3]/4: Reviewed-by: Dietmar Eggemann

Re: [PATCH v12 2/4] arch_topology: Support SMT control for OF based system

2025-03-17 Thread Dietmar Eggemann
On 17/03/2025 12:29, Yicong Yang wrote: > On 2025/3/17 17:56, Dietmar Eggemann wrote: >> On 11/03/2025 08:51, Yicong Yang wrote: >>> From: Yicong Yang [...] >>> Both method support to completely disable/enable the SMT cores so both >>> work correctly for s

Re: [PATCH v12 2/4] arch_topology: Support SMT control for OF based system

2025-03-17 Thread Dietmar Eggemann
On 11/03/2025 08:51, Yicong Yang wrote: > From: Yicong Yang > > On building the topology from the devicetree, we've already gotten the > SMT thread number of each core. Update the largest SMT thread number > and enable the SMT control by the end of topology parsing. > > The framework's SMT contr