Re: [bug] userspace hitting sporadic SIGBUS on xfs (Power9, ppc64le), v4.19 and later

2019-12-03 Thread Darrick J. Wong
On Tue, Dec 03, 2019 at 09:35:28AM -0500, Jan Stancek wrote: > > - Original Message - > > On Tue, Dec 03, 2019 at 07:50:39AM -0500, Jan Stancek wrote: > > > My theory is that there's a race in iomap. There appear to be > > > interleaved calls to iomap_set_range_uptodate() for same page > >

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-13 Thread Darrick J. Wong
recover logs but still wants to write to the fs" checkpointing problem. (Or maybe we should just put all that stuff in a vfat filesystem, I don't know...) --D > Signed-off-by: Pingfan Liu > Cc: "Darrick J. Wong" > Cc: Dave Chinner > Cc: Eric Sandeen > Cc:

Re: [PATCH] xfs: introduce "metasync" api to sync metadata to fsblock

2019-10-15 Thread Darrick J. Wong
On Tue, Oct 15, 2019 at 09:10:04AM -0400, Theodore Y. Ts'o wrote: > On Tue, Oct 15, 2019 at 01:01:02AM -0700, Christoph Hellwig wrote: > > On Mon, Oct 14, 2019 at 03:09:48PM -0500, Eric Sandeen wrote: > > > We're in agreement here. ;) I only worry about implementing things like > > > this > > >

Re: [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers

2023-09-28 Thread Darrick J. Wong
On Thu, Sep 28, 2023 at 01:06:03PM -0400, Jeff Layton wrote: > On Thu, 2023-09-28 at 11:48 -0400, Arnd Bergmann wrote: > > On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote: > > > This shaves 8 bytes off struct inode, according to pahole. > > > > > > Signed-off-by: Jeff Layton > > > > FWIW, this

Re: linux-next: build failure after merge of the mm tree

2023-08-21 Thread Darrick J. Wong
On Tue, Aug 22, 2023 at 02:34:06AM +0100, Matthew Wilcox wrote: > On Tue, Aug 22, 2023 at 11:22:17AM +1000, Stephen Rothwell wrote: > > Hi Matthew, > > > > On Tue, 22 Aug 2023 02:11:44 +0100 Matthew Wilcox > > wrote: > > > > > > On Tue, Aug 22, 2023 at 09:55:37AM +1000, Stephen Rothwell wrote: >

Re: [PATCH v4 1/6] treewide: use prandom_u32_max() when possible, mechanically

2022-10-07 Thread Darrick J. Wong
# for mmc > Signed-off-by: Jason A. Donenfeld For the XFS part, Acked-by: Darrick J. Wong --D > --- > arch/arm/kernel/process.c | 2 +- > arch/s390/kernel/vdso.c | 2 +- > arch/um/kernel/process.c |

Re: [PATCH v4 2/6] treewide: use prandom_u32_max() when possible

2022-10-07 Thread Darrick J. Wong
use_crazy_algorithm(...); But this translation change looks correct to me, so for the XFS parts: Acked-by: Darrick J. Wong --D > return 0; > #endif > > diff --git a/fs/xfs/libxfs/xfs_ialloc.c b/fs/xfs/libxfs/xfs_ialloc.c > index 6cdfd64bc56b..7838b31126e2 1

Re: [PATCH v4 4/6] treewide: use get_random_u32() when possible

2022-10-07 Thread Darrick J. Wong
ika Westerberg # for thunderbolt > Signed-off-by: Jason A. Donenfeld For the XFS parts, Acked-by: Darrick J. Wong --D > --- > Documentation/networking/filter.rst| 2 +- > arch/parisc/kernel/process.c | 2 +- > arch/parisc/kernel/sys_parisc.c

Re: [PATCH v1 1/5] treewide: use get_random_u32_below() instead of deprecated function

2022-10-21 Thread Darrick J. Wong
k ok. Though I'm trusting you that all the mathematics are correct since that's /really/ not my department (more of a languages guy ;). Acked-by: Darrick J. Wong --D > --- > arch/arm/kernel/process.c | 2 +- > arch/arm64/kernel/process.c

Re: [RFC PATCH 2/3] fs: remove duplicate ifdefs

2024-01-18 Thread Darrick J. Wong
; STATIC ssize_t > bload_leaf_slack_store( > @@ -319,10 +317,8 @@ static struct attribute *xfs_dbg_attrs[] = { > ATTR_LIST(log_recovery_delay), > ATTR_LIST(mount_delay), > ATTR_LIST(always_cow), > -#ifdef DEBUG > ATTR_LIST(pwork_threads), > A

Re: [PATCH] tracing/treewide: Remove second parameter of __assign_str()

2024-05-17 Thread Darrick J. Wong
mis.org/ > > Cc: Masami Hiramatsu > Cc: Mathieu Desnoyers > Cc: Linus Torvalds > Cc: Julia Lawall > Signed-off-by: Steven Rostedt (Google) /me finds this pretty magical, but such is the way of macros. Thanks for being much smarter about them than me. :) Acked-by: Darrick J. Wong# xfs --D

Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()

2008-03-10 Thread Darrick J. Wong
nges > > behaviour (it should be a bugfix, but who knows). > > Maybe someone can test this? I did. No regressions observed and it fixes that bug as well. Sorry I didn't catch it earlier... :/ Acked-by: Darrick J. Wong <[EMAIL PROTECTED]> --D

Re: [next-20220215] WARNING at fs/iomap/buffered-io.c:75 with xfstests

2022-02-16 Thread Darrick J. Wong
[adding fsdevel to this party, since iomap is core code, not just XFS...] On Wed, Feb 16, 2022 at 12:55:02PM +0530, Sachin Sant wrote: > While running xfstests on IBM Power10 logical partition (LPAR) booted > with 5.17.0-rc4-next-20220215 following warning was seen: > > [ 2547.384210] xfs filesys

Re: [linux-next][XFS][trinity] WARNING: CPU: 32 PID: 31369 at fs/iomap.c:993

2017-09-18 Thread Darrick J. Wong
On Mon, Sep 18, 2017 at 05:00:58PM -0500, Eric Sandeen wrote: > On 9/18/17 4:31 PM, Dave Chinner wrote: > > On Mon, Sep 18, 2017 at 09:28:55AM -0600, Jens Axboe wrote: > >> On 09/18/2017 09:27 AM, Christoph Hellwig wrote: > >>> On Mon, Sep 18, 2017 at 08:26:05PM +0530, Abdul Haleem wrote: > Hi

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Darrick J. Wong
struct xfs_buf *bp) > - { > +{ > struct xfs_agf *agf = XFS_BUF_TO_AGF(bp); > > if (xfs_sb_version_hascrc(&mp->m_sb)) { > @@ -2449,8 +2449,7 @@ xfs_agf_verify( >be32_to_cpu(agf->agf_refcount_level) > XFS_BTREE_MAXLEVELS)) >

kernel bug in "Drop WIMG in favour of new constants"?

2016-06-15 Thread Darrick J. Wong
Hi Aneesh, I noticed when trying out 4.7-rc3 on qemu-2.5 that the kernel no longer boots. 4.6 booted just fine, so I bisected the kernel to the commit 30bda41aba4efb2370c97e2cbe7385de93ccc372, which is "powerpc/mm: Drop WIMG in favour of new constants". The changelog suggests that the KVM change

Re: kernel bug in "Drop WIMG in favour of new constants"?

2016-06-15 Thread Darrick J. Wong
On Thu, Jun 16, 2016 at 03:23:47PM +1000, Michael Ellerman wrote: > On Wed, 2016-06-15 at 21:33 -0700, Darrick J. Wong wrote: > > > Hi Aneesh, > > > > I noticed when trying out 4.7-rc3 on qemu-2.5 that the kernel no longer > > boots. 4.6 booted just fine, so I bis

Re: kernel bug in "Drop WIMG in favour of new constants"?

2016-06-16 Thread Darrick J. Wong
On Thu, Jun 16, 2016 at 04:16:00PM +0530, Aneesh Kumar K.V wrote: > "Aneesh Kumar K.V" writes: > > > "Darrick J. Wong" writes: > > > >> On Thu, Jun 16, 2016 at 03:23:47PM +1000, Michael Ellerman wrote: > >>> On Wed, 2016-06-15 at 2

Re: kernel bug in "Drop WIMG in favour of new constants"?

2016-06-16 Thread Darrick J. Wong
On Thu, Jun 16, 2016 at 08:01:55PM +0530, Aneesh Kumar K.V wrote: > "Aneesh Kumar K.V" writes: > > > "Aneesh Kumar K.V" writes: > > > >> "Aneesh Kumar K.V" writes: > >> > >>> "Darrick J. Wong" writes: &

Re: linux-next: boot warning after merge of the vfs-brauner tree

2024-08-26 Thread Darrick J. Wong
On Mon, Aug 26, 2024 at 01:52:54PM -0700, Luis Chamberlain wrote: > On Mon, Aug 26, 2024 at 07:43:20PM +0200, Christophe Leroy wrote: > > > > > > Le 26/08/2024 à 17:48, Pankaj Raghav (Samsung) a écrit : > > > On Mon, Aug 26, 2024 at 05:59:31PM +1000, Stephen Rothwell wrote: > > > > Hi all, > > >

Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Darrick J. Wong
- > - return ext4_has_feature_metadata_csum(sb) && > -(EXT4_SB(sb)->s_chksum_driver != NULL); > + return ext4_has_feature_metadata_csum(sb); > } Nit: Someone might want to s/ext4_has_metadata_csum/ext4_has_feature_metadata_csum/ here to get rid of the conf

Re: [PATCH v3 16/18] jbd2: switch to using the crc32c library

2024-11-04 Thread Darrick J. Wong
hksum_driver: > - * > - * Reference to checksum algorithm driver via cryptoapi. > - */ > - struct crypto_shash *j_chksum_driver; > - > /** >* @j_csum_seed: >* >* Precomputed journal UUID checksum for seeding other checksums. >*/ > @@ -1748,

Re: [PATCH v6 05/26] fs/dax: Create a common implementation to break DAX layouts

2025-01-12 Thread Darrick J. Wong
On Mon, Jan 13, 2025 at 11:47:41AM +1100, Alistair Popple wrote: > On Fri, Jan 10, 2025 at 08:44:38AM -0800, Darrick J. Wong wrote: > > On Fri, Jan 10, 2025 at 05:00:33PM +1100, Alistair Popple wrote: > > > Prior to freeing a block file systems supporting FS DAX must ch

Re: [PATCH v6 07/26] fs/dax: Ensure all pages are idle prior to filesystem unmount

2025-01-12 Thread Darrick J. Wong
On Mon, Jan 13, 2025 at 11:57:18AM +1100, Alistair Popple wrote: > On Fri, Jan 10, 2025 at 08:50:19AM -0800, Darrick J. Wong wrote: > > On Fri, Jan 10, 2025 at 05:00:35PM +1100, Alistair Popple wrote: > > > File systems call dax_break_mapping() prior to reallocating file >

Re: [PATCH v6 07/26] fs/dax: Ensure all pages are idle prior to filesystem unmount

2025-01-13 Thread Darrick J. Wong
On Mon, Jan 13, 2025 at 04:48:31PM +1100, Alistair Popple wrote: > On Sun, Jan 12, 2025 at 06:49:40PM -0800, Darrick J. Wong wrote: > > On Mon, Jan 13, 2025 at 11:57:18AM +1100, Alistair Popple wrote: > > > On Fri, Jan 10, 2025 at 08:50:19AM -0800, Darrick J. Wong wrote: >

Re: [PATCH v6 07/26] fs/dax: Ensure all pages are idle prior to filesystem unmount

2025-01-10 Thread Darrick J. Wong
On Fri, Jan 10, 2025 at 05:00:35PM +1100, Alistair Popple wrote: > File systems call dax_break_mapping() prior to reallocating file > system blocks to ensure the page is not undergoing any DMA or other > accesses. Generally this is needed when a file is truncated to ensure > that if a block is real

Re: [PATCH v6 05/26] fs/dax: Create a common implementation to break DAX layouts

2025-01-10 Thread Darrick J. Wong
On Fri, Jan 10, 2025 at 05:00:33PM +1100, Alistair Popple wrote: > Prior to freeing a block file systems supporting FS DAX must check > that the associated pages are both unmapped from user-space and not > undergoing DMA or other access from eg. get_user_pages(). This is > achieved by unmapping the

Re: [PATCH v6 21/26] fs/dax: Properly refcount fs dax pages

2025-01-10 Thread Darrick J. Wong
On Fri, Jan 10, 2025 at 05:00:49PM +1100, Alistair Popple wrote: > Currently fs dax pages are considered free when the refcount drops to > one and their refcounts are not increased when mapped via PTEs or > decreased when unmapped. This requires special logic in mm paths to > detect that these page

Re: [PATCH] treewide: const qualify ctl_tables where applicable

2025-01-09 Thread Darrick J. Wong
he > proc_handlers. Sounds like a good idea, Reviewed-by: "Darrick J. Wong" # xfs --D

Re: [PATCH] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-01-14 Thread Darrick J. Wong
On Thu, Jan 09, 2025 at 06:45:40PM +0100, Andrey Albershteyn wrote: > From: Andrey Albershteyn > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > extended attributes/flags. The syscalls take parent directory FD and > path to the child together with struct fsxattr. > > Thi

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-02-21 Thread Darrick J. Wong
On Tue, Feb 11, 2025 at 06:22:47PM +0100, Andrey Albershteyn wrote: > From: Andrey Albershteyn > > Introduce getfsxattrat and setfsxattrat syscalls to manipulate inode > extended attributes/flags. The syscalls take parent directory fd and > path to the child together with struct fsxattr. > > Thi

Re: [PATCH v3] fs: introduce getfsxattrat and setfsxattrat syscalls

2025-02-25 Thread Darrick J. Wong
On Tue, Feb 25, 2025 at 12:24:08PM +0100, Christian Brauner wrote: > On Tue, Feb 25, 2025 at 11:40:51AM +0100, Arnd Bergmann wrote: > > On Tue, Feb 25, 2025, at 11:22, Christian Brauner wrote: > > > On Tue, Feb 25, 2025 at 09:02:04AM +0100, Arnd Bergmann wrote: > > >> On Mon, Feb 24, 2025, at 12:32