mpt2sas DMA mask

2015-05-12 Thread Brian King
25087.html This would fix the issue I'm seeing on mpt2sas. Do you plan to dust that patch set off and upstream it? Were there issues with it that still need to be resolved? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technol

[PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-12 Thread Brian King
On 05/12/2015 05:10 PM, Benjamin Herrenschmidt wrote: > On Tue, 2015-05-12 at 17:07 -0500, Brian King wrote: >> The mpt2sas driver was changed late last year in that it now requests a 64 >> bit DMA >> mask, then requests a 32 bit coherent DMA mask, then later requests a 64 bi

Re: [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-13 Thread Brian King
On 05/13/2015 03:10 AM, Arnd Bergmann wrote: > On Tuesday 12 May 2015 18:24:43 Brian King wrote: >> >> Commit 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7db9c broke 64 bit DMA for mpt2sas >> on Power. >> That commit changed the sequence for setting up the DMA and coherent DMA

Re: [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-13 Thread Brian King
On 05/13/2015 08:31 AM, Arnd Bergmann wrote: > On Wednesday 13 May 2015 08:23:41 Brian King wrote: >> On 05/13/2015 03:10 AM, Arnd Bergmann wrote: >>> On Tuesday 12 May 2015 18:24:43 Brian King wrote: >>>> >>>> Commit 5fb1bf8aaa832e1e9ca3198de7bbecb8eff7

Re: [PATCH] mpt2sas: Fall back to 64 bit coherent mask if 64 bit DMA / 32 bit coherent mask not supported

2015-05-13 Thread Brian King
the DDW available (or the > legacy and bypass on "nv"), we can then route individual DMAs according > to the corresponding applicable mask. > > I'll try to come up with a patch but I'll need you to test it. Sure. I can help with that. Thanks, Brian > > Cheer

Re: [RFC/PATCH] powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask

2015-05-14 Thread Brian King
ask. I worked around it with the hack below and saw that I was able to get 64 bit DMA and the card showed up all the drives. We'll need a better a better fix for upstream obviously, but I wanted to be able to check out the rest of the patch a bit... Thanks, Brian -- Brian King Power Linu

Re: [RFC/PATCH v3] powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask

2015-05-15 Thread Brian King
to have an active IOMMU table. > > Signed-off-by: Benjamin Herrenschmidt > --- > Thanks. This one works fine for me with mpt2sas. Tested-by: Brian King -Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-

Re: [PATCH 1/2] ipr: Convert to generic DMA API

2014-10-29 Thread Brian King
Acked-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 2/2] ipr: set coherent DMA mask

2014-10-29 Thread Brian King
Acked-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 1/2] ipr: Convert to generic DMA API

2014-10-30 Thread Brian King
On 10/30/2014 04:11 AM, Christoph Hellwig wrote: > On Wed, Oct 29, 2014 at 12:34:49PM -0500, Brian King wrote: >> Acked-by: Brian King > > Doesn't apply to me. > > Brain, can you please resend a rebased version of these two patches with > ipr error handlign patch (

[PATCH 1/3] ipr: Convert to generic DMA API

2014-10-30 Thread Brian King
From: Anton Blanchard Even though the ipr driver is only used on PCI, convert it to use the generic DMA API. Signed-off-by: Anton Blanchard Signed-off-by: Brian King --- drivers/scsi/ipr.c | 103 +++-- drivers/scsi/ipr.h |2 - 2 files

[PATCH 3/3] ipr: Wait for aborted command responses

2014-10-30 Thread Brian King
in a double completion causing a kernel oops. Cc: Signed-off-by: Brian King --- drivers/scsi/ipr.c | 92 + drivers/scsi/ipr.h |1 2 files changed, 93 insertions(+) diff -puN drivers/scsi/ipr.c~ipr_eh_wait drivers/scsi/ipr.c --- scsi-

[PATCH 2/3] ipr: set coherent DMA mask

2014-10-30 Thread Brian King
From: Anton Blanchard Use dma_set_mask_and_coherent() to set both the DMA and coherent DMA mask. Signed-off-by: Anton Blanchard Signed-off-by: Brian King --- drivers/scsi/ipr.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff -puN drivers/scsi/ipr.c

Re: [PATCH 3/3] ipr: Wait for aborted command responses

2014-10-31 Thread Brian King
Adding Wendy... On 10/30/2014 05:27 PM, Brian King wrote: > Fixes a race condition in abort handling that was injected > when multiple interrupt support was added. When only a single > interrupt is present, the adapter guarantees it will send > responses for aborted commands prior to

[PATCH 1/1] powerpc: Force 32 bit MSIs for devices that require it

2013-05-03 Thread Brian King
The following patch implements a new PAPR change which allows the OS to force the use of 32 bit MSIs, regardless of what the PCI capabilities indicate. This is required for some devices that advertise support for 64 bit MSIs but don't actually support them. Signed-off-by: Brian King ---

[PATCH 1/1] powerpc: Force 32 bit MSIs on systems lacking firmware support

2013-05-21 Thread Brian King
only enable this on Gen2 slots, which should limit this to configurations where this hack is needed and tested to work. Signed-off-by: Brian King --- arch/powerpc/platforms/pseries/msi.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff -puN arch/powerpc

[PATCHv2 1/1] powerpc: Force 32 bit MSIs on systems lacking firmware support

2013-05-22 Thread Brian King
only enable this on Gen2 slots, which should limit this to configurations where this hack is needed and tested to work. Signed-off-by: Brian King --- arch/powerpc/platforms/pseries/msi.c | 35 --- 1 file changed, 32 insertions(+), 3 deletions(-) diff -puN arch

Re: IBM OpenPower 720 ipr driver woes

2013-05-29 Thread Brian King
r driver no longer support this (admittedly ancient) > hardware? Do you have a boot log you can share? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://list

Re: IBM OpenPower 720 ipr driver woes

2013-06-04 Thread Brian King
o one of these systems so we could take a look at this? -Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: IBM OpenPower 720 ipr driver woes

2013-06-06 Thread Brian King
lder power5 boxes? >>> >> Yes, Tony. "ibm,get-config-addr-info" should be supported on Power5 box. >> Newer PowerBox (e.g. P7) should support "ibm,get-config-addr-info2" >> >> Please have a try on the attached patch, which is based on mainline (3.10). >> >> Thanks, >> Gavin >> >> > The system boots with that patch. I applied it to kernel-3.8.11-100. Does that patch resolve all your issues, or are there still issues with ipr remaining after applying the patch? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask

2015-06-19 Thread Brian King
u explain the changes to dart, pseries and powernv. > > There's also some whitespace changes in iommu.h that I assume you didn't want? Hi Ben, Do you plan to resubmit with these changes? The patch seems to work fine in my testing. Would be nice to get this merged. Thanks,

Re: powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask

2015-06-29 Thread Brian King
On 06/19/2015 06:01 PM, Benjamin Herrenschmidt wrote: > On Fri, 2015-06-19 at 16:19 -0500, Brian King wrote: >> On 05/18/2015 01:40 AM, Michael Ellerman wrote: >>> On Mon, 2015-18-05 at 03:56:51 UTC, Benjamin Herrenschmidt wrote: >>>> This patch adds the ability to

Re: [PATCH 3/3] powerpc/iommu: Support "hybrid" iommu/direct DMA ops for coherent_mask < dma_mask

2015-07-24 Thread Brian King
Ben, It looks like this patch has bit rot. I have a system now where I can test the latest version. Any chance you can rediff and resend and I can test? Thanks, Brian ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org

Re: [PATCH RFC 36/77] ipr: Enable MSI-X when IPR_USE_MSIX type is set, not IPR_USE_MSI

2013-10-02 Thread Brian King
k to MSI if MSI-X is not available or does not work. We then set intr_flag to indicate what we are actually using on the specific adapter. Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/3] pci: Export pci_dev_type

2013-04-04 Thread Brian King
Export pci_dev_type so that arch specific PCI probing code can initialize a new PCI device struct. Signed-off-by: Brian King --- drivers/pci/pci.h |1 - include/linux/pci.h |1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/pci/pci.h~pci_export_pci_dev_type

[PATCH 2/3] powerpc: Enable boot_vga sysfs attribute for graphics adapters on Power

2013-04-04 Thread Brian King
Initialize dev->dev.type such that the PCI group attributes for boot_vga and SR-IOV can be displayed if appropriate. This fixes an issue seen on Power preventing X from auto initializing a graphics adapter when using KMS. Signed-off-by: Brian King --- arch/powerpc/kernel/pci_of_scan.c |

[PATCH 3/3] powerpc: Set default VGA device

2013-04-04 Thread Brian King
device. This ensures that X autoconfiguration will work. Signed-off-by: Brian King --- arch/powerpc/kernel/pci-common.c | 13 + 1 file changed, 13 insertions(+) diff -puN arch/powerpc/kernel/pci-common.c~powerpc_vga_default_device arch/powerpc/kernel/pci-common.c --- linux/arch

Re: [PATCH 3/3] powerpc: Set default VGA device

2013-04-05 Thread Brian King
On 04/05/2013 01:52 AM, Michael Ellerman wrote: > Hi Brian, > > > On Thu, Apr 04, 2013 at 04:58:17PM -0500, Brian King wrote: >> >> Add a PCI quirk for VGA devices on Power to set the default VGA device. >> Ensures a default VGA is always set if a graphics adapter i

[PATCH 2/2] powerpc: Set default VGA device

2013-04-08 Thread Brian King
device. This ensures that X autoconfiguration will work. Signed-off-by: Brian King --- arch/powerpc/kernel/pci-common.c | 13 + 1 file changed, 13 insertions(+) diff -puN arch/powerpc/kernel/pci-common.c~powerpc_vga_default_device arch/powerpc/kernel/pci-common.c --- linux/arch

[PATCH 1/2] pci: Set dev->dev.type in alloc_pci_dev

2013-04-08 Thread Brian King
Set dev->dev.type in alloc_pci_dev so that archs that have their own versions of pci_setup_device get this set properly in order to ensure things like the boot_vga sysfs parameter get created as expected. Signed-off-by: Brian King --- drivers/pci/probe.c |2 +- 1 file changed, 1 insert

Re: [PATCH 2/3] powerpc: Enable boot_vga sysfs attribute for graphics adapters on Power

2013-04-08 Thread Brian King
On 04/08/2013 12:25 AM, Michael Ellerman wrote: > On Fri, Apr 05, 2013 at 02:11:01PM -0600, Bjorn Helgaas wrote: >> On Thu, Apr 4, 2013 at 3:58 PM, Brian King wrote: >>> >>> Initialize dev->dev.type such that the PCI group attributes for boot_vga >>> and

Re: [PATCH] ibmvfc: fix little endian issues

2014-07-07 Thread Brian King
On 06/26/2014 07:03 PM, Tyrel Datwyler wrote: > Added big endian annotations to relevant data structure fields, and necessary > byte swappings to support little endian builds. Acked-by: Brian King Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology

[PATCH 1/1] powerpc: Increase EEH recovery timeout for SR-IOV

2013-11-25 Thread Brian King
account for this. Signed-off-by: Brian King --- arch/powerpc/kernel/eeh.c|2 +- arch/powerpc/kernel/eeh_driver.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff -puN arch/powerpc/kernel/eeh.c~eeh_sriov_vf_delay arch/powerpc/kernel/eeh.c --- linux/arch/powerpc/kernel/eeh.c

Re: [PATCH 2/2] MAINTAINERS: ibmvfc driver maintainer change

2015-01-22 Thread Brian King
On 01/18/2015 09:27 AM, Christoph Hellwig wrote: > Brian, can you ACK this one? Acked-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.

Re: [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required

2015-01-26 Thread Brian King
4 @@ static int pseries_eeh_reset(struct eeh_pe *pe, int >>>>>> option) >>>>>> /* We need reset hold or settlement delay */ >>>>>> if (option == EEH_RESET_FUNDAMENTAL || >>>>>> option == EEH_RESET_HOT) >>>>&

Re: [PATCH] powerpc/pseries: Avoid context switch in EEH reset if required

2015-01-27 Thread Brian King
On 01/26/2015 10:31 PM, Benjamin Herrenschmidt wrote: > On Mon, 2015-01-26 at 17:36 -0600, Brian King wrote: >> To set some context, this function is only used by ipr for some old >> broken adapters. These are adapters that are not supported on p8, >> so will never show up und

Re: [PATCH] ibmveth: Add function to enable live MAC address changes

2015-02-26 Thread Brian King
> + mac_address = ibmveth_encode_mac_addr(dev->dev_addr); > + rc = h_change_logical_lan_mac(adapter->vdev->unit_address, mac_address); > + > + return rc; Do you still want to be changing dev->dev_addr if h_change_logical_lan_mac re

Re: [PATCH v2 01/30] cxlflash: Fix to avoid invalid port_sel value

2015-09-17 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 02/30] cxlflash: Replace magic numbers with literals

2015-09-17 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 03/30] cxlflash: Fix read capacity timeout

2015-09-17 Thread Brian King
n future would be good to either call out the fact that there are a couple of unrelated formatting changes, or keep them out and stick them in a separate cleanup patch. Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 04/30] cxlflash: Fix potential oops following LUN removal

2015-09-17 Thread Brian King
eference per-context > for each LUN attached to the context. > > This resolves a potential Oops in the release handler when a > dealing with a LUN that has already been removed. > > Signed-off-by: Matthew R. Ochs > Signed-off-by: Manoj N. Kumar > Suggested-by: Brian

Re: [PATCH v2 05/30] cxlflash: Fix data corruption when vLUN used over multiple cards

2015-09-17 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 06/30] cxlflash: Fix to avoid sizeof(bool)

2015-09-17 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 07/30] cxlflash: Fix context encode mask width

2015-09-17 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 08/30] cxlflash: Fix to avoid CXL services during EEH

2015-09-18 Thread Brian King
unlikely(rc)) > + break; > + goto retry; > + case STATE_FAILTERM: > + dev_dbg(dev, "%s: Failed/Terminating!\n", __func__); > + rc = -ENODEV; > + break; > + default: > + break; > + } > + > + return rc; > +} > + > +/** > * cxlflash_disk_attach() - attach a LUN to a context > * @sdev:SCSI device associated with LUN. > * @attach: Attach ioctl data structure. -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 10/30] cxlflash: Correct naming of limbo state and waitq

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 11/30] cxlflash: Make functions static

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 12/30] cxlflash: Refine host/device attributes

2015-09-18 Thread Brian King
ug prone hard coded 22, how about never incrementing buf and do something similar to this: > + bytes += scnprintf(buf, PAGE_SIZE, "%03d: %016llX\n", > +i, readq_be(&fc_port[i])); bytes += scnprintf(&buf[bytes], PAGE

Re: [PATCH v2 13/30] cxlflash: Fix to avoid spamming the kernel log

2015-09-18 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 14/30] cxlflash: Fix to avoid stall while waiting on TMF

2015-09-21 Thread Brian King
ition you were seeing. Its not obvious to me what this fixes. Do you have softlockup logs from the failure? -Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlab

Re: [PATCH v2 15/30] cxlflash: Fix location of setting resid

2015-09-21 Thread Brian King
bly an AFU bug. I would tend to agree with this statement. ioasa->resid should be zero in an overrun case. >*/ > scp->result = (DID_ERROR << 16); > } Reviewed-by: Brian King -- Brian Kin

Re: [PATCH v2 16/30] cxlflash: Fix host link up event handling

2015-09-21 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 17/30] cxlflash: Fix async interrupt bypass logic

2015-09-21 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 18/30] cxlflash: Remove dual port online dependency

2015-09-21 Thread Brian King
if (afu->internal_lun) { > - pr_debug("%s: Overriding port %d online timeout!!!\n", > - __func__, port); > - ret = 0; > - } > } > > - pr_debug("%s: returning rc=%d\n", __func__, ret); > + pr_deb

Re: [PATCH v2 19/30] cxlflash: Fix AFU version access/storage and add check

2015-09-22 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 18/30] cxlflash: Remove dual port online dependency

2015-09-22 Thread Brian King
On 09/22/2015 03:44 PM, Matthew R. Ochs wrote: >> On Sep 21, 2015, at 5:02 PM, Brian King wrote: >> On 09/16/2015 04:30 PM, Matthew R. Ochs wrote: >>> At present, both ports must be online for the device to >>> configure properly. Remove this dependency and th

Re: [PATCH v2 20/30] cxlflash: Correct usage of scsi_host_put()

2015-09-22 Thread Brian King
he call to alloc_mem that has failed in this leg, not the call to scsi_host_alloc. > __func__); > rc = -ENOMEM; > + scsi_host_put(cfg->host); > goto out; > } > -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 22/30] cxlflash: Correct behavior in device reset handler following EEH

2015-09-22 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 23/30] cxlflash: Remove unnecessary scsi_block_requests

2015-09-22 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 24/30] cxlflash: Fix function prolog parameters and return codes

2015-09-22 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 25/30] cxlflash: Fix MMIO and endianness errors

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 26/30] cxlflash: Fix to prevent EEH recovery failure

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 27/30] cxlflash: Correct spelling, grammar, and alignment mistakes

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 30/30] MAINTAINERS: Add cxlflash driver

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v2 28/30] cxlflash: Fix to prevent stale AFU RRQ

2015-09-23 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 04/32] cxlflash: Fix potential oops following LUN removal

2015-09-24 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 08/32] cxlflash: Fix to avoid CXL services during EEH

2015-09-24 Thread Brian King
if (unlikely(rc)) > + break; > + goto retry; > + case STATE_FAILTERM: > + dev_dbg(dev, "%s: Failed/Terminating!\n", __func__); > + rc = -ENODEV; > + break; > + default: > +

Re: [PATCH v3 11/32] cxlflash: Refine host/device attributes

2015-09-24 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 13/32] cxlflash: Fix to avoid stall while waiting on TMF

2015-09-25 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 19/32] cxlflash: Correct usage of scsi_host_put()

2015-09-25 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 20/32] cxlflash: Fix to prevent workq from accessing freed memory

2015-09-25 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 28/32] cxlflash: Fix to avoid state change collision

2015-09-25 Thread Brian King
te) { > case STATE_RESET: > dev_dbg_ratelimited(dev, "%s: device is in reset!\n", __func__); > rc = SCSI_MLQUEUE_HOST_BUSY; -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 30/32] cxlflash: Fix to double the delay each time

2015-09-25 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 31/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-25 Thread Brian King
/* On very first attach set fileops for adapter */ > + if (cfg->cxl_fops.owner != THIS_MODULE) > cfg->cxl_fops = cxlflash_cxl_fops; Hmm... Why not just set this up once at probe time instead? > > if (attach->num_interrupts > 4) { >

Re: [PATCH v3 32/32] cxlflash: Correct trace string

2015-09-25 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v4 08/32] cxlflash: Fix to avoid CXL services during EEH

2015-09-28 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v4 32/32] cxlflash: Fix to avoid potential deadlock on EEH

2015-09-28 Thread Brian King
__func__, result); > + rc = -ENODEV; Since check_state only returns 0 or -ENODEV, this is a bit redundant, but not worth redoing the patch in my mind. Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___

Re: [PATCH v4 30/32] cxlflash: Fix to avoid corrupting adapter fops

2015-09-30 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v5 34/34] cxlflash: Fix to escalate to LINK_RESET on login timeout

2015-10-21 Thread Brian King
Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] ibmvscsi: use GFP_ATOMIC with dma_alloc_coherent in map_sg_data

2019-01-10 Thread Brian King
> GFP_ATOMIC); > if (!evt_struct->ext_list) { > if (!firmware_has_feature(FW_FEATURE_CMO)) > sdev_printk(KERN_ERR, cmd->device, > Reviewed-by: Brian King -- Brian King Power Linux I/O IBM Linux Technology Center

Re: [PATCH] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool

2019-01-10 Thread Brian King
->dev, > pool->size * sizeof(*pool->iu_storage), > -&pool->iu_token, 0); > +&pool->iu_token, GFP_KERNEL); > if (!pool->iu_storage) { > kfree(pool->even

[PATCH 1/1] hvcs: Ensure page aligned partner info buffer

2011-09-13 Thread Brian King
The Power platform requires the partner info buffer to be page aligned otherwise it will fail the partner info hcall with H_PARAMETER. Switch from using kmalloc to allocate this buffer to __get_free_page to ensure page alignment. Signed-off-by: Brian King --- drivers/tty/hvc/hvcs.c |6

[PATCH 1/1] powerpc: Fix partition migration hang in stop_topology_update

2012-01-11 Thread Brian King
: ebe1fff8 4e800020 fbe1fff8 7c0802a6 f8010010 7c7f1b78 f821ff81 78290464 80090014 5400019e 7cd0 78000fe0 <0b00> 480c 7c210b78 7c421378 Signed-off-by: Brian King --- arch/powerpc/kernel/rtas.c |5 +++-- arch/powerpc/platforms/pseries/suspend.c |6 +- 2

Re: tlb flushing on Power

2012-01-26 Thread Brian King
k) to send to it. > > I was wondering if you have any ideas. Any help is greatly appreciated! > > -- > Seth -- Brian King Linux on Power Virtualization IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] scsi/ibmvscsi: add module alias for ibmvscsic

2012-07-31 Thread Brian King
n you submit a patch to the maintainers file, adding yourself as the ibmvscsi maintainer? Thanks, Brian -- Brian King Power Linux I/O IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/1] powerpc: Add page coalescing support

2011-03-14 Thread Brian King
some page coalescing statistics available from firmware via lparcfg. Signed-off-by: Brian King --- arch/powerpc/include/asm/firmware.h |3 +- arch/powerpc/include/asm/hvcall.h | 12 arch/powerpc/include/asm/pSeries_reconfig.h |6 arch/powerpc/kernel

[PATCH 1/1] powerpc: Fix to handle slb resize across migration

2009-08-28 Thread Brian King
scenarios where the SLB size will change. Signed-off-by: Brian King --- arch/powerpc/include/asm/mmu-hash64.h |2 ++ arch/powerpc/kernel/lparcfg.c |3 +++ arch/powerpc/kernel/rtas.c|7 ++- arch/powerpc/mm/slb.c | 16

Re: [PATCH 1/5] dynamic logical partitioning infrastructure

2009-09-14 Thread Brian King
.c2009-09-11 > 12:51:52.0 -0500 > @@ -95,7 +95,7 @@ > return parent; > } > > -static BLOCKING_NOTIFIER_HEAD(pSeries_reconfig_chain); > +struct blocking_notifier_head pSeries_reconfig_chain = > BLOCKING_NOTIFIER_INIT(pSeries_reconfig_chain); Can't this just b

Re: [PATCH 2/5] move of_drconf_cell definition to prom.h

2009-09-15 Thread Brian King
DRCONF_MEM_ASSIGNED0x0008 > -#define DRCONF_MEM_AI_INVALID0x0040 > -#define DRCONF_MEM_RESERVED0x0080 > - > /* > * Read the next lmb list entry from the ibm,dynamic-memory property > * and return the information in the provided of_drconf_cell structure.

Re: [PATCH 5/5] kernel handling of CPU DLPAR

2009-09-15 Thread Brian King
e(dn->full_name); > +dn->full_name = cpu_name; > + > +rc = add_device_tree_nodes(dn); > +if (rc) > +release_drc(drc_index); > + > +return rc ? rc : count; > +} > + -- Brian King Linux on Power Virtualization IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

[PATCH 1/1] powerpc: Add kdump support to Collaborative Memory Manager

2009-09-29 Thread Brian King
aned. Pages that are marked as "loaned" which are not in the balloon will automatically get switched to "active" the next time we touch the page. This also fixes the case where totalram_pages is smaller than min_mem_mb, which can occur during kdump. Signed-off-by: Brian King -

[PATCH 1/1] powerpc: Add kdump support to Collaborative Memory Manager

2009-10-19 Thread Brian King
aned. Pages that are marked as "loaned" which are not in the balloon will automatically get switched to "active" the next time we touch the page. This also fixes the case where totalram_pages is smaller than min_mem_mb, which can occur during kdump. Signed-off-by: Brian King -

[PATCH 1/1] powerpc: Fix partition migration hang under load

2009-01-29 Thread Brian King
rtas_percpu_suspend_me. Fix this by calling H_JOIN multiple times if necessary during the migration. Signed-off-by: Brian King --- arch/powerpc/kernel/rtas.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff -puN arch/powerpc/kernel/rtas.c~powerpc_migration_hang_fix arch

Re: [PATCH 1/1] powerpc: Fix partition migration hang under load

2009-01-30 Thread Brian King
Nathan Lynch wrote: > Brian King wrote: >> While testing partition migration with heavy CPU load using >> shared processors, it was observed that sometimes the migration >> would never complete and would appear to hang. Currently, the >> migration code assumes that if

[PATCH 1/1] powerpc: Fix partition migration hang under load

2009-02-17 Thread Brian King
rtas_percpu_suspend_me. Fix this by calling H_JOIN multiple times if necessary during the migration. Signed-off-by: Brian King --- arch/powerpc/kernel/rtas.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff -puN arch/powerpc/kernel/rtas.c~powerpc_migration_hang_fix arch

[PATCH 1/2] powerpc: Partition hibernation support

2010-02-23 Thread Brian King
Enables support for HMC initiated partition hibernation. This is a firmware assisted hibernation, since the firmware handles writing the memory out to disk, along with other partition information, so we just mimic suspend to ram. Signed-off-by: Brian King --- arch/powerpc/Kconfig

[PATCH 2/2] powerpc: Add power management support to VIO bus

2010-02-23 Thread Brian King
Adds support for suspend/resume for VIO devices. This is needed for support for HMC initiated hibernation. Signed-off-by: Brian King --- arch/powerpc/kernel/vio.c | 24 1 file changed, 24 insertions(+) diff -puN arch/powerpc/kernel/vio.c~powerpc_vio_bus_pm arch

Re: [PATCH 3/4] Provide VIO modalias

2010-02-23 Thread Brian King
gt; }; You'll want to add this to vio_cmo_dev_attrs as well, as that is the device attribute array that gets used when active memory sharing is enabled. Thanks, Brian -- Brian King Linux on Power Virtualization IBM Linux Technology Center ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Badness in xics_ipi_dispatch

2010-04-20 Thread Brian King
c0 <4>[c0003fe33d40] [c00c6f0c] .run_workqueue+0xf4/0x1e0 <4>[c0003fe33e00] [c00c70b8] .worker_thread+0xc0/0x180 <4>[c0003fe33ed0] [c00cce74] .kthread+0xb4/0xc0 <4>[c0003fe33f90] [c00309fc] .kernel_thread+0x54/0x70 <4

[PATCH 1/1] powerpc: Ignore IPIs to offline CPUs

2010-04-20 Thread Brian King
Since there is nothing to stop an IPI from occurring to an offline CPU, rather than printing a warning to the logs, just ignore the IPI. This was seen while stress testing SMT enable/disable. Signed-off-by: Brian King --- arch/powerpc/platforms/pseries/xics.c |3 ++- 1 file changed, 2

  1   2   3   4   >