Re: [PATCH] [RFC] Xilinx SystemACE: Add media hotplug support

2007-12-20 Thread Andy Whitcroft
On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote: > + /* Make the sysace device 'live' */ > + if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA); > + add_disk(ace->gd); checkpatch.pl reports the above if as suspect due to the trailing ;.

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-29 Thread Andy Whitcroft
On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Kluin wrote: > Joe Perches wrote: > > On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: > >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > >> --- > >> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c > >> index ebf9e21..dcfb459 10064

Re: [PATCH][NET] gianfar: fix obviously wrong #ifdef CONFIG_GFAR_NAPI placement

2007-10-18 Thread Andy Whitcroft
The check then is to see if a non {}'d block has no statements in it if the ifdef is null. Hmmm. May be possible. Will think on it. if (err) +#ifdef CONFIG_GFAR_NAPI napi_disable(&priv->napi); +#endif -apw ___ Linuxppc-dev mai

Re: 2.6.24-rc1-git15 Kernel build fails on powerpc - Unrecognized opcode: `dssall'

2007-11-06 Thread Andy Whitcroft
On Tue, Nov 06, 2007 at 07:09:40PM +0530, Balbir Singh wrote: > Kamalesh Babulal wrote: > > David Miller wrote: > >> From: Johannes Berg <[EMAIL PROTECTED]> > >> Date: Tue, 06 Nov 2007 11:54:46 +0100 > >> > > CHK include/linux/compile.h > > AS arch/powerpc/kernel/swsusp_32.o >

[PATCH 2/6] powerpc: hash_preload fails to preload under CONFIG_PPC_MM_SLICES

2007-08-16 Thread Andy Whitcroft
Seems that a trailing ';' has slipped onto the end of the get_slice_psize checks under CONFIG_PPC_MM_SLICES causing us to return unconditionally and never preload. Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> Cc: Paul Mackerras <[EMAIL PROTECTED]> Cc: linuxppc-de

Re: 2.6.23-rc4-mm1 -- powerpc per_cpu__cpu_sibling_map compile failure

2007-09-10 Thread Andy Whitcroft
Am seeing the following compile error on all of my powerpc platforms: CC kernel/sched.o kernel/sched.c: In function `cpu_to_phys_group': kernel/sched.c:5937: error: `per_cpu__cpu_sibling_map' undeclared (first use in this function) kernel/sched.c:5937: error: (Each undeclared identif

Re: [BUG][2.6.23-rc6] Badness at arch/powerpc/kernel/smp.c:202

2007-09-14 Thread Andy Whitcroft
Anton, this seems a little reminicient of that bug which popped up in 2.6.23-rc3 so do with SLB loading (if memory serves), with machine checks and signal 7's. Of course that is _supposed_ to be fixed by this time ... I believe it was Paul who fixed up that one, and he is already copied. -apw O

Re: 2.6.23-rc6-mm1

2007-09-18 Thread Andy Whitcroft
On Tue, Sep 18, 2007 at 02:43:48PM +0530, Kamalesh Babulal wrote: > Andrew Morton wrote: > >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc6/2.6.23-rc6-mm1/ > > > >2.6.23-rc6-mm1 is a 29MB diff against 2.6.23-rc6. > > > > > > > Hi Andrew, > > The 2.6.23-rc6-mm1build fai

2.6.23-rc6-mm1 -- powerpc link failure

2007-09-19 Thread Andy Whitcroft
I am seeing this strange link error from a PowerMac G5 (powerpc): [...] KSYM.tmp_kallsyms2.S AS .tmp_kallsyms2.o LD vmlinux.o ld: dynreloc miscount for fs/built-in.o, section .opd ld: can not edit opd Bad value make: *** [vmlinux.o] Error 1 Compiler version below

2.6.23-rc6-mm1 -- powerpc pSeries_log_error panic in rtas_call/early_enable_eeh

2007-09-19 Thread Andy Whitcroft
Seeing the following panic booting an old powerpc LPAR: Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc0047b48 cpu 0x0: Vector: 300 (Data Access) at [c06a3750] pc: c0047b48: .pSeries_log_error+0x364/0x420 lr: c

Re: 2.6.23-rc6-mm1 -- powerpc link failure

2007-09-19 Thread Andy Whitcroft
On Wed, Sep 19, 2007 at 06:36:29PM +0200, Segher Boessenkool wrote: > >I am seeing this strange link error from a PowerMac G5 (powerpc): > > > > [...] > >KSYM.tmp_kallsyms2.S > >AS .tmp_kallsyms2.o > >LD vmlinux.o > > ld: dynreloc miscount for fs/built-in.o, section .opd

2.6.23-rc7-mm1 -- powerpc rtas panic

2007-09-24 Thread Andy Whitcroft
Seeing the following from an older power LPAR, pretty sure we had this in the previous -mm also: Unable to handle kernel paging request for data at address 0x Faulting instruction address: 0xc0047ac8 cpu 0x0: Vector: 300 (Data Access) at [c058f750] pc: c0047ac8:

Re: 2.6.23-rc6-mm1 -- powerpc link failure

2007-09-25 Thread Andy Whitcroft
On Wed, Sep 19, 2007 at 07:44:03PM +0200, Sam Ravnborg wrote: > On Wed, Sep 19, 2007 at 10:28:48AM +0100, Andy Whitcroft wrote: > > I am seeing this strange link error from a PowerMac G5 (powerpc): > > > > [...] > > KSYM.tmp_kallsyms2.S > > AS

Re: [PATCH] Discourage use of __initcall() in favour of device_initcall()

2008-05-16 Thread Andy Whitcroft
On Fri, May 16, 2008 at 11:49:14AM +1000, Michael Ellerman wrote: > Add a comment above the definition of __initcall(), just in case > someone looks here. > > And add a checkpatch warning for new uses of __initcall(). > > Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]> > --- > > How's this?

[PATCH 1/1] powerpc: add 64 bit version of huge_ptep_set_wrprotect

2008-06-26 Thread Andy Whitcroft
hash is calculated we will flush the wrong pages, potentially leaving live hashes to the original page. Move the definition of huge_ptep_set_wrprotect() to the 32/64 bit specific headers. Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]> --- include/asm-powerpc/hugetlb.h

Re: [PATCH 2/2 v2] Add DIU platform code for MPC8610HPCD

2008-03-25 Thread Andy Whitcroft
On Thu, Mar 20, 2008 at 03:33:04PM -0700, Andrew Morton wrote: > On Wed, 19 Mar 2008 13:50:27 -0500 > York Sun <[EMAIL PROTECTED]> wrote: > > > Add platform code to support Freescale DIU. The platform code includes > > framebuffer memory allocation, pixel format, monitor port, etc. > > > > ... > >

Re: [BUG] 2.6.25-rc8-mm1 kernel panic while bootup on powerpc

2008-04-04 Thread Andy Whitcroft
On Tue, Apr 01, 2008 at 11:39:09PM -0700, Andrew Morton wrote: > On Wed, 02 Apr 2008 11:55:36 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote: > > > Hi Andrew, > > > > The 2.6.25-rc8-mm1 kernel panic's while bootup on the power machine(s). > > > > [0.00] [ cut here ]

Re: checkpatch nits ...

2008-08-28 Thread Andy Whitcroft
each \n). > > Can you explain why you need that inline assembly? All you do in there > > are arithmetic operations, so you should be able to express that using > > C, or at least using the helpers we already have. > > > > Checkpatch thinks that what you wrote is a declar

Re: [patch 1/3] ps3: Disk Storage Driver

2007-07-24 Thread Andy Whitcroft
Andrew Morton wrote: >> +start_sector = req->sector*priv->blocking_factor; >> +sectors = req->nr_sectors*priv->blocking_factor; > > s/*/ * /. checkpatch missed this. Ok, this is something we need to decide on. Currently we only ask for consistent spacing on all the mathematic operators