On Wed, Dec 19, 2007 at 11:23:48PM -0700, Grant Likely wrote:
> + /* Make the sysace device 'live' */
> + if (ace->fsm_state != ACE_FSM_STATE_INVALIDATE_MEDIA);
> + add_disk(ace->gd);
checkpatch.pl reports the above if as suspect due to the trailing ;.
On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Kluin wrote:
> Joe Perches wrote:
> > On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote:
> >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]>
> >> ---
> >> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c
> >> index ebf9e21..dcfb459 10064
The check then is to see if a non {}'d block has no statements in it if the
ifdef is null. Hmmm. May be possible. Will think on it.
if (err)
+#ifdef CONFIG_GFAR_NAPI
napi_disable(&priv->napi);
+#endif
-apw
___
Linuxppc-dev mai
On Tue, Nov 06, 2007 at 07:09:40PM +0530, Balbir Singh wrote:
> Kamalesh Babulal wrote:
> > David Miller wrote:
> >> From: Johannes Berg <[EMAIL PROTECTED]>
> >> Date: Tue, 06 Nov 2007 11:54:46 +0100
> >>
> > CHK include/linux/compile.h
> > AS arch/powerpc/kernel/swsusp_32.o
>
Seems that a trailing ';' has slipped onto the end of the
get_slice_psize checks under CONFIG_PPC_MM_SLICES causing us to
return unconditionally and never preload.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
Cc: Paul Mackerras <[EMAIL PROTECTED]>
Cc: linuxppc-de
Am seeing the following compile error on all of my powerpc platforms:
CC kernel/sched.o
kernel/sched.c: In function `cpu_to_phys_group':
kernel/sched.c:5937: error: `per_cpu__cpu_sibling_map' undeclared (first use
in this function)
kernel/sched.c:5937: error: (Each undeclared identif
Anton, this seems a little reminicient of that bug which popped up in
2.6.23-rc3 so do with SLB loading (if memory serves), with machine
checks and signal 7's. Of course that is _supposed_ to be fixed by this
time ...
I believe it was Paul who fixed up that one, and he is already copied.
-apw
O
On Tue, Sep 18, 2007 at 02:43:48PM +0530, Kamalesh Babulal wrote:
> Andrew Morton wrote:
> >ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23-rc6/2.6.23-rc6-mm1/
> >
> >2.6.23-rc6-mm1 is a 29MB diff against 2.6.23-rc6.
> >
> >
>
>
> Hi Andrew,
>
> The 2.6.23-rc6-mm1build fai
I am seeing this strange link error from a PowerMac G5 (powerpc):
[...]
KSYM.tmp_kallsyms2.S
AS .tmp_kallsyms2.o
LD vmlinux.o
ld: dynreloc miscount for fs/built-in.o, section .opd
ld: can not edit opd Bad value
make: *** [vmlinux.o] Error 1
Compiler version below
Seeing the following panic booting an old powerpc LPAR:
Unable to handle kernel paging request for data at address 0x
Faulting instruction address: 0xc0047b48
cpu 0x0: Vector: 300 (Data Access) at [c06a3750]
pc: c0047b48: .pSeries_log_error+0x364/0x420
lr: c
On Wed, Sep 19, 2007 at 06:36:29PM +0200, Segher Boessenkool wrote:
> >I am seeing this strange link error from a PowerMac G5 (powerpc):
> >
> > [...]
> >KSYM.tmp_kallsyms2.S
> >AS .tmp_kallsyms2.o
> >LD vmlinux.o
> > ld: dynreloc miscount for fs/built-in.o, section .opd
Seeing the following from an older power LPAR, pretty sure we had
this in the previous -mm also:
Unable to handle kernel paging request for data at address 0x
Faulting instruction address: 0xc0047ac8
cpu 0x0: Vector: 300 (Data Access) at [c058f750]
pc: c0047ac8:
On Wed, Sep 19, 2007 at 07:44:03PM +0200, Sam Ravnborg wrote:
> On Wed, Sep 19, 2007 at 10:28:48AM +0100, Andy Whitcroft wrote:
> > I am seeing this strange link error from a PowerMac G5 (powerpc):
> >
> > [...]
> > KSYM.tmp_kallsyms2.S
> > AS
On Fri, May 16, 2008 at 11:49:14AM +1000, Michael Ellerman wrote:
> Add a comment above the definition of __initcall(), just in case
> someone looks here.
>
> And add a checkpatch warning for new uses of __initcall().
>
> Signed-off-by: Michael Ellerman <[EMAIL PROTECTED]>
> ---
>
> How's this?
hash is calculated we will flush the wrong
pages, potentially leaving live hashes to the original page.
Move the definition of huge_ptep_set_wrprotect() to the 32/64 bit specific
headers.
Signed-off-by: Andy Whitcroft <[EMAIL PROTECTED]>
---
include/asm-powerpc/hugetlb.h
On Thu, Mar 20, 2008 at 03:33:04PM -0700, Andrew Morton wrote:
> On Wed, 19 Mar 2008 13:50:27 -0500
> York Sun <[EMAIL PROTECTED]> wrote:
>
> > Add platform code to support Freescale DIU. The platform code includes
> > framebuffer memory allocation, pixel format, monitor port, etc.
> >
> > ...
> >
On Tue, Apr 01, 2008 at 11:39:09PM -0700, Andrew Morton wrote:
> On Wed, 02 Apr 2008 11:55:36 +0530 Kamalesh Babulal <[EMAIL PROTECTED]> wrote:
>
> > Hi Andrew,
> >
> > The 2.6.25-rc8-mm1 kernel panic's while bootup on the power machine(s).
> >
> > [0.00] [ cut here ]
each \n).
> > Can you explain why you need that inline assembly? All you do in there
> > are arithmetic operations, so you should be able to express that using
> > C, or at least using the helpers we already have.
> >
> > Checkpatch thinks that what you wrote is a declar
Andrew Morton wrote:
>> +start_sector = req->sector*priv->blocking_factor;
>> +sectors = req->nr_sectors*priv->blocking_factor;
>
> s/*/ * /. checkpatch missed this.
Ok, this is something we need to decide on. Currently we only ask for
consistent spacing on all the mathematic operators
19 matches
Mail list logo