On Thu, Mar 20, 2008 at 03:33:04PM -0700, Andrew Morton wrote: > On Wed, 19 Mar 2008 13:50:27 -0500 > York Sun <[EMAIL PROTECTED]> wrote: > > > Add platform code to support Freescale DIU. The platform code includes > > framebuffer memory allocation, pixel format, monitor port, etc. > > > > ... > > > > +unsigned int mpc8610hpcd_get_pixel_format > > + (unsigned int bits_per_pixel, int monitor_port)
This seems like it might be detectable, does this seem like something we should try an report? WARNING: arguments for function declarations should follow identifier #7: FILE: Z110.c:7: +int __init preallocate_diu_videomemory > Again, please do > > unsigned int mpc8610hpcd_get_pixel_format(unsigned int bits_per_pixel, > int monitor_port) > > (and anywhere else where this was done) > > > +int __init preallocate_diu_videomemory(void); > > Nope, please don't put extern declarations in .c files. Find a suitable > header for it - one which is included by the defining file and by all users > of the symbol. > > Andy, checkpatch missed this. Yeah, we did only look for explicitly extern'd declarations. But this form seems detectable, will be in v0.17. WARNING: externs should be avoided in .c files #2: FILE: Z110.c:2: +int __init preallocate_diu_videomemory(void); -apw _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
