uick succession that the counter won't
hit 5 in a real failure case.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
d either way - I just don't get the logic of restoring the count.
I agree with this logic.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
eturn -EINVAL;
}
+ if (!cxl_compatible_caia_version(adapter)) {
+ dev_info(&dev->dev, "Ignoring card. PSL type is not supported "
+ "(caia version: %d)\n",
adapter->caia_major);
+ return -ENODEV;
+
rint_flags(flags, "|", \
+ { CXL_PSL9_DSISR_An_CO_MASK,"FR" }, \
+
o need the information in later
patches.
So rename existing PNV_PHB_NPU type to PNV_PHB_NPU_NVLINK and add a
new type PNV_PHB_NPU_OCAPI.
Signed-off-by: Frederic Barrat
Signed-off-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/npu-dma.c | 2 +-
arch/powerpc/platforms/powernv/pci-i
in.o pci.o config.o file.o pasid.o
+ocxl-y += link.o context.o afu_irq.o sysfs.o trace.o
+obj-$(CONFIG_OCXL) += ocxl.o
+
+# For tracepoints to include our trace.h from tracepoint infrastructure:
+CFLAGS_trace.o := -I$(src)
+
+# ccflags-y += -DDEBUG
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
river currently doesn't handle memory attached to the
opencapi device.
Signed-off-by: Frederic Barrat
Signed-off-by: Andrew Donnellan
Signed-off-by: Alastair D'Silva
A bunch of sparse warnings we should look at. (there's a few more that
appear in later patches too)
---
driver
dev_err(&dev->dev,
+ "Can't translation xsl interrupt for device\n");
Can't get?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
md->sa.ioasc = 0;
cmd->rcb.ctx_id = hwq->ctx_hndl;
cmd->rcb.msi = SISL_MSI_RRQ_UPDATED;
cmd->rcb.port_sel = CHAN2PORTMASK(scp->device->channel);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
This patch assign a unique TIDR (thread id) for the current thread which
will be used in the process element entry.
Signed-off-by: Christophe Lombard
Reviewed-by: Philippe Bergheaud
Acked-by: Andrew Donnellan
---
Changelog[v7]
- Rebased to latest upstream.
- Added boolean: "ne
On 20/01/18 20:52, Michael Ellerman wrote:> On my Power8 PowerVM LPAR:
Will fix...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
written! :D
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
< 0
Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices")
Signed-off-by: Colin Ian King
Thanks for picking this up!
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/
_psl9() and its
references from the code.
Signed-off-by: Vaibhav Jain
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
non-debug images
doesn't have any impact.
Signed-off-by: Vaibhav Jain
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
Acked-by: Andrew Donnellan
On 15/02/18 17:19, Vaibhav Jain wrote:
For PSL9 the contents of PSL_TB_CTLSTAT register have changed in PSL9
and all of the register is now readonly. Hence we don't need an sl_ops
implementation for 'write_timebase_ctrl' for to populate this register
f
an "powernv platform"?
systems that don't add function notify_resume.
Signed-off-by: Juan J. Alvarez
Reviewed-by: Bryant G. Ly
Tested-by: Carol L. Soto
Reviewed-by: Andrew Donnellan
---
arch/powerpc/kernel/eeh_driver.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-
ate this. When
cxl_data_cache_flush() is called it checks the flag and if set bails
out early without requesting a data-cache flush operation to the PSL.
Signed-off-by: Vaibhav Jain
LGTM
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
configuration or
application registers.
The specific sysfs entry "/sys/class/cxl/cardxx/psl_timebase_synced" is
now dynamically updated according the content of the PSL Timebase
register.
Signed-off-by: Christophe Lombard
Acked-by: Andrew Donnellan
--
Andrew Donnellan O
: Frederic Barrat
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/file.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index 2dd2db9bc1c9..337462e1569f 100644
--- a/drivers/misc/ocxl/file.c
+++ b/drivers/misc/ocxl
userspace.
Signed-off-by: Alastair D'Silva
Seems fine.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
number set.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 17/02/18 05:38, Masahiro Yamada wrote:
For PowerPC, GCC 5.2 is the requirement for GCC plugins. Move the
version check to Kconfig, and remove the ugly checker.
Signed-off-by: Masahiro Yamada
The old checker was as non-ugly as I could make it. :)
Acked-by: Andrew Donnellan
--
Andrew
userspace.
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 22/02/18 15:17, Alastair D'Silva wrote:
From: Alastair D'Silva
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ch of the ocxl-specific stuff as I can get to,
though I'm a bit busy with the OpenCAPI skiboot work and reviewing the
libocxl userspace library at the moment.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
to depend on OCXL in all cases? IMHO it should be
possible to build a cxl-only version without ocxl, though I don't feel
very strongly on this.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
my response to the first version of this series, at some point we
might want to make this not depend on OCXL in all cases, but I don't
feel strongly on that.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
exit paths of the driver.
Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
One comment below
Reviewed-by: Andrew Donnellan
---
drivers/scsi/cxlflash/backend.h | 1 +
drivers/scsi/cxlflash/cxl_hw.c | 6 ++
drivers/scsi/cxlflash/main.c| 9 +++--
drivers/scsi/cxlflash
Reviewed-by: Andrew Donnellan
---
drivers/scsi/cxlflash/ocxl_hw.c | 41 +
drivers/scsi/cxlflash/ocxl_hw.h | 2 ++
2 files changed, 43 insertions(+)
diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c
index e3a0a9b..dc32a73
afu = adapter->afu[i];
- if (afu->phb == NULL)
+ if (afu == NULL || afu->phb == NULL)
continue;
list_for_each_entry(afu_dev, &afu->phb->bus->devices, bus_list)
{
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
. For cxlflash devices only a single
function per host is expected and thus the entire range is assigned.
Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
Reviewed-by: Andrew Donnellan
diff --git a/drivers/scsi/cxlflash/ocxl_hw.h b/drivers/scsi/cxlflash/ocxl_hw.h
index 658f420..190d71a
Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.
Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
Reviewed-by: Andrew Donnellan
diff --git a/drivers/scsi/cxlflash/ocxl_hw.h b/drivers/scsi/cxlflash/ocxl_hw.h
index f6af247..9c675fa 100644
--- a/drivers/scsi/cxlflash/ocxl_hw.h
+++ b/drivers/scsi/cxlflash/ocxl_hw.h
@@ -22,4 +22,6
range is used.
Signed-off-by: Uma Krishnan
Acked-by: Matthew R. Ochs
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
.18, of course.
Slowly getting through it, though as of next Friday I'll be disappearing
from the face of the earth for 3 weeks and I'm not sure I'll be finished
by then.
Fred: could you take a look at this series if you have spare cycles?
--
Andrew Donnellan Oz
On 09/03/18 13:59, Vaibhav Jain wrote:
Thanks for looking into this patch Andrew,
Andrew Donnellan writes:
On 08/03/18 21:05, Vaibhav Jain wrote:
It is possible for a CXL card to have a valid PSL but no valid
AFUs. When this happens we have a valid instance of 'struct cxl'
repres
On 12/03/18 22:36, Arvind Yadav wrote:
if device_register() returned an error! Always use put_device()
to give up the reference initialized.
Signed-off-by: Arvind Yadav
This looks right, thanks for picking it up.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
ags which I
suppose imply what the correct platform is, but really they're just
feature flags?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
th the CPU features code but
nothing seems overly wrong...
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
return -EINVAL;
if (t != current)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ue.id == 0.
Signed-off-by: Vaibhav Jain
LGTM. Does this need to be sent to stable?
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
f a similar name.
But I don't feel strongly about this at all, so:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
looks good to me
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
This patch adds a CPU feature bit to show whether the CPU has
the TIDR register available, enabling as_notify/wait in userspace.
Signed-off-by: Alastair D'Silva
Per my previous email:
Reviewed-by: A
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
Switch the use of TIDR on it's CPU feature, rather than assuming it
is available based on architecture.
Signed-off-by: Alastair D'Silva
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
Signed-off-by: Alastair D'Silva
This looks better.
Acked-by: Andrew Donnellan
---
Documentation/accelerators/ocxl.rst | 11 +++
1 file changed, 11 insertions(+)
diff --git a/Documentation/accele
On 18/04/18 11:08, Alastair D'Silva wrote:
From: Alastair D'Silva
In order for a userspace AFU driver to call the Power9 specific
OCXL_IOCTL_ENABLE_P9_WAIT, it needs to verify that it can actually
make that call.
Signed-off-by: Alastair D'Silva
Looks good to me
Acked-by: A
return rc;
-
- t->thread.tidr = rc;
+ t->thread.tidr = (u16)task_pid_nr(t);
mtspr(SPRN_TIDR, t->thread.tidr);
return 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ir D'Silva
nitpicks below
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/context.c | 5 +++-
drivers/misc/ocxl/file.c | 53 +++
drivers/misc/ocxl/link.c | 36 ++
drivers/misc/ocxl/ocxl_internal.h |
. Alastair has also confirmed with me that truncating the pid to a u16
should be safe, so therefore:
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
n the next Patchwork release, but
in the meantime this restriction should stop us running into any issues
on this list.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
n
---
Change-log:
Resend -> Updated the commit description to add more info on the
issue seen [Andrew]
Thanks for redoing the commit message.
This looks good to me.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ad this is.
Thanks to Vaibhav Jain (who made a previous attempt at this), Mikey
Neuling, Ben Herrenschmidt, Gavin Shan, Bill Daly and JT Kellington for
advice on various bits of this.
Andrew
[0] http://patchwork.ozlabs.org/patch/670781/
[1] http://patchwork.ozlabs.org/patch/670782/
Andrew Donnell
Signed-off-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/pci-ioda.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
b/arch/powerpc/platforms/powernv/pci-ioda.c
index c16d790..ca5e9b5 100644
--- a/arch/powerpc/platforms
boots that support this).
Signed-off-by: Andrew Donnellan
---
Corresponding skiboot RFC: http://patchwork.ozlabs.org/patch/670781/
---
arch/powerpc/include/asm/opal-api.h| 3 ++-
arch/powerpc/include/asm/opal.h| 1 +
arch/powerpc/platforms/powernv/opal-wrappers.S | 1
complete reset in order to disable CAPI mode.
This requires a version of skiboot that implements the
OPAL_PCI_GET_PHB_CAPI_MODE call (introduced at the same time that the
capability to disable CAPI mode during complete resets was introduced).
Signed-off-by: Andrew Donnellan
---
Corresponding
If we fail to allocate work, we don't end up using hp_errlog_copy. Free it
in the error path.
Signed-off-by: Andrew Donnellan
---
Found by Coverity Scan. Compile tested only.
---
arch/powerpc/platforms/pseries/dlpar.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/powerpc/plat
deric Barrat
Otherwise looks good to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
lp if there are any active Process
Elements on the card, as the cache would likely get new dirty cache
lines immediately, but if resetting an idle adapter, it should avoid
any bad surprises from data left over from terminated Process Elements.
Signed-off-by: Frederic Barrat
Reviewed-by: Andrew Donn
stand for ?
"+ve" and "-ve" are common English scientific/engineering abbreviations
for "positive" and "negative" respectively. I suppose they may be
unfamiliar to those who didn't get an English science education, so it
might be clearer to say &
.
Signed-off-by: Vaibhav Jain
All the changes look good to me.
Reviewed-by: Andrew Donnellan
diff --git a/Documentation/ABI/testing/sysfs-class-cxl
b/Documentation/ABI/testing/sysfs-class-cxl
index 4ba0a2a..dae2b38 100644
--- a/Documentation/ABI/testing/sysfs-class-cxl
+++ b/Documentati
.
Signed-off-by: Vaibhav Jain
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ic Barrat
Signed-off-by: Vaibhav Jain
Reviewed-by: Andrew Donnellan
---
drivers/misc/cxl/api.c | 2 ++
drivers/misc/cxl/file.c | 22 +-
2 files changed, 15 insertions(+), 9 deletions(-)
diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index af23d7d..2e5233b 1
ng it, simplify a bit the code.
Signed-off-by: Christophe JAILLET
Reviewed-by: Andrew Donnellan
---
un-compiled because I don't have the required cross build environment.
Compiles on my system!
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 31/10/16 08:34, Christophe JAILLET wrote:
'cxl_dev_context_init()' returns an error pointer in case of error, not
NULL. So test it with IS_ERR.
Signed-off-by: Christophe JAILLET
Reviewed-by: Andrew Donnellan
---
un-compiled because I don't have the required cross bu
On 31/10/16 08:40, Christophe JAILLET wrote:
'cxl_dev_context_init()' returns an error pointer in case of error, not
NULL. So test it with IS_ERR.
Signed-off-by: Christophe JAILLET
Reviewed-by: Andrew Donnellan
---
un-compiled because I don't have the required cross bu
(In future please remember to cc linuxppc-dev.)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
(particularly so
we pick it up in distros) but I'm not convinced that enabling HW
breakpoints on a platform where it has *never* worked qualifies as an
"actual bug".
(BTW many thanks for fixing this - I had a shot at it late last year but
never quite got there!)
--
A
Since the KERN_CONT changes, the current code in show_instructions() prints
out a whole bunch of unnecessary newlines. Change occurrences of
printk("\n") to pr_cont("\n"). While we're here, change all the other
cases of printk(KERN_CONT ...) to pr_cont() as well.
Signed
t.
Cc: sta...@vger.kernel.org
Fixes: 62fa19d4 ("cxl: Add ability to reset the card")
Acked-by: Frederic Barrat
Reviewed-by: Andrew Donnellan
Signed-off-by: Vaibhav Jain
When I inject an EEH error, this patch causes the following WARN. Thoughts?
[ 55.965011] EEH: PHB#0 failure de
] [c031ec70]
SyS_pread64+0xb0/0xd0
This isn't a WARN - this stack trace is printed explicitly by the EEH
code in the case of a PHB failure. arch/powerpc/kernel/eeh.c, line 403.
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
efinitely* looks related to this patch...
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ones are
broken so we can put a version check in...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
f-by: Russell Currey
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
tch/694415/ is applied though?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
d that was measured on one device.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
dev);
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 21/11/16 21:14, Michael Ellerman wrote:
From: Michael Ellerman
Not the most publicly resolvable of domains :)
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
powernv_idle_driver isn't exported, it can be made static. Found by sparse.
Signed-off-by: Andrew Donnellan
---
drivers/cpuidle/cpuidle-powernv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpuidle/cpuidle-powernv.c
b/drivers/cpuidle/cpuidle-powernv.c
lement the OPAL_REBOOT_FULL_IPL reboot type, this will force an IPL. On
versions that do not, print an error message on reboot and proceed with a
regular reboot (which could be a full IPL or a fast reboot).
Cc: Stewart Smith
Cc: Benjamin Herrenschmidt
Signed-off-by: Andrew Donnellan
---
Correspondi
drivers/misc/cxl/native.c:57:2-3: Unneeded semicolon
drivers/misc/cxl/native.c:170:2-3: Unneeded semicolon
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/debugfs.c | 6 --
drivers/misc/cxl/guest.c | 2 +-
drivers/misc/cxl/irq.c | 2 +-
drivers/misc/cxl/native.c | 4 ++--
4
t;force", which already exists, though I can't quite see
what that actually means on x86.
Hmm.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 23/11/16 12:37, Andrew Donnellan wrote:
There's existing logic in kernel/reboot.c to handle a reboot= command
line parameter, which can set the reboot_mode, so my preference would be
that we use that.
Currently we completely ignore the reboot_mode, so there's no backward
compatibi
on
scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 24/11/16 02:27, Geliang Tang wrote:
Drop duplicate header sched.h from native.c.
Signed-off-by: Geliang Tang
Good catch!
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 24/11/16 13:05, Balbir Singh wrote:
9. The license for these files is now GPL v3 or later
As much as I love the GPLv3, isn't this an instant NAK?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
().
Add a call to pci_unlock_rescan_remove() in the eeh_clear_pe_frozen_state()
error path so that we don't cause a deadlock later on.
Reported-by: Pradipta Ghosh
Fixes: 78954700631f ("powerpc/eeh: Avoid I/O access during PE reset")
Cc: sta...@vger.kernel.org
Signed-off-by: Andrew Donne
pci_hp_add_devices(bus);
if (!list_empty(&bus->devices)) {
info->adapter_status = CONFIGURED;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
__
introduced.
* Remove variable "busdn" in find_bus_among_children()
* Use PCI_DN() to convert device node to pci_dn
Signed-off-by: Gavin Shan
Acked-by: Benjamin Herrenschmidt
Looks good to me
Reviewed-by: Andrew Donnellan
---
arch/powerpc/kernel/pci-hotplug.c
On 04/05/16 14:48, Ian Munsie wrote:
From: Ian Munsie
These defines are not used, but other equivalent definitions
(CXL_SPA_SW_CMD_*) are used. Remove the unused defines.
Signed-off-by: Ian Munsie
They definitely look unused.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan
I've done some basic sanity testing on powerpc with the cyclomatic
complexity plugin (with LE native + cross-compilers) and it seems to
work with the patch below.
Signed-off-by: Andrew Donnellan
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
index a18a0dc..0cfed5b 100644
---
On 18/05/16 20:33, Emese Revfy wrote:
Did you test the plugins with all gcc versions (4.5-6)?
No, I tested with 4.8 and 5.2 as those are the toolchains I have on hand
- I'll try to test with the rest of 4.5 - 6.1.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel..
d in 4.5, so we don't care about <=4.4.
However if Andrew's only tested on little endian, then that select should be
guarded with an "if CPU_LITTLE_ENDIAN". And to build LE you need gcc >= 4.9.
I'm going to give BE a test too just to be sure.
--
Andrew Donnellan
;ed on the plugin
infrastructure
so that arch maintainers are aware of this?
Upon further testing it does seem we've got header issues as well as
hitting a segfault on 4.7.0. Looking into it further...
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Au
On 31/05/16 09:01, Michael Ellerman wrote:
Those come from
XSL_databook_09_June_2014.pdf
Where do I find that?
My understanding is that it's IBM Confidential and isn't available to
the general community, unfortunately.
Andrew
--
Andrew Donnellan OzLabs, AD
On 20/05/16 16:41, Gavin Shan wrote:
The macro defined in arch/powerpc/platforms/powernv/pci.c isn't
used by anyone. Just remove it.
Signed-off-by: Gavin Shan
Looks like the only user of it disappeared in late 2014...
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan O
eeh_cache.c doesn't build cleanly with -DDEBUG when
CONFIG_PHYS_ADDR_T_64BIT is set, as a couple of pr_debug()s use "%lx" for
resource_size_t parameters.
Use "%pap" instead, as it's the correct format specifier for types deriving
from phys_addr_t.
Signed-off-by:
any private data structures they may use.
Signed-off-by: Michael Neuling
Signed-off-by: Ian Munsie
Signed-off-by: Philippe Bergheaud
As per v3:
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
irq_names list into the cxl_context_init
routine so that it will be valid for the entire lifetime of the context
and will not cause a NULL pointer dereference.
Signed-off-by: Ian Munsie
As it's nice having your machine not crash on every shutdown...
Reviewed-by: Andrew Donnellan
--
A
801 - 900 of 1086 matches
Mail list logo
