On 11/3/21 4:44 am, Laurent Dufour wrote:
It is better to rely on the API provided by the MM layer instead of
directly manipulating the mm_users field.
Signed-off-by: Laurent Dufour
LGTM, thanks for picking this up
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL
On 22/3/21 1:33 pm, Bhaskar Chowdhury wrote:
s/filesytem/filesystem/
s/symantics/semantics/
Signed-off-by: Bhaskar Chowdhury
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/context.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/cxl/context.c b
On 26/3/21 10:53 pm, dingsen...@163.com wrote:
From: dingsenjie
Remove unneeded variable: "rc".
Signed-off-by: dingsenjie
This looks obviously correct and doesn't raise any checkpatch warnings.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs,
ressing the issues in Daniel's review.
I haven't tested it, but this patch looks sensible enough to me.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
nge prom.h, but
nothing here looks concerning.
Acked-by: Andrew Donnellan
---
drivers/misc/cxl/api.c | 1 +
drivers/misc/cxl/cxl.h | 2 ++
drivers/misc/cxl/cxllib.c | 1 +
drivers/misc/cxl/flash.c| 1 +
drivers/misc/cxl/guest.c| 2 ++
drivers/misc/cxl/irq.c | 1 +
d
On 6/4/22 16:52, Christophe Leroy wrote:
Thanks. Can you take the patch through your tree ?
We don't have a tree of our own, we rely on mpe to take it through powerpc.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
y: Nathan Lynch
This appears to correctly rename all users of the macro.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
but
they are wrong :)
Fixes: f204e0b8ce ("cxl: Driver code for powernv PCIe based cards for userspace
access")
Signed-off-by: Christophe JAILLET
Apart from my comment above:
Acked-by: Andrew Donnellan
Thanks for catching this!
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 9/6/21 7:23 am, t...@redhat.com wrote:
From: Tom Rix
Change use of 'a fpga' to 'an fpga'
Signed-off-by: Tom Rix
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
]
178 | __be32 *data, drc_index, phandle;
| ^
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
]
178 | __be32 *data, drc_index, phandle;
| ^
Cc: Frederic Barrat
Cc: Andrew Donnellan
Cc: linuxppc-dev@lists.ozlabs.org
Signed-off-by: Lee Jones
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
limov
Thanks.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
trcmp(token_name, "ibm,errinjct"))
+ size = 1024;
+ else if (!strcmp(token_name, "ibm,update-nodes") ||
+!strcmp(token_name, "ibm,update-properties") ||
+
hrough all of them to populate that field
at init time.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
es. For compatibility with any applications we are not aware of
that require other calls, the filter can be turned off at build time.
Reported-by: Daniel Axtens
Cc: sta...@vger.kernel.org
Signed-off-by: Andrew Donnellan
---
v1->v2:
- address comments from mpe
- shorten the names of some struc
Add a selftest to test the basic functionality of CONFIG_RTAS_FILTER.
Signed-off-by: Andrew Donnellan
---
v1->v2:
- new patch
---
.../selftests/powerpc/syscalls/Makefile | 2 +-
.../selftests/powerpc/syscalls/rtas_filter.c | 285 ++
2 files changed, 286 inserti
ff-by: Daniel Axtens
I grepped through, confirmed there's no other references to
of_show_percpuinfo().
Reviewed-by: Andrew Donnellan
(First linuxppc patch written and sent live on a twitch stream?)
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 15/9/21 12:32 am, Mauro Carvalho Chehab wrote:
The What: field should have just the location of the ABI.
Anything else should be inside the description.
This fixes its parsing by get_abi.pl script.
Signed-off-by: Mauro Carvalho Chehab
Looks fine to me.
Acked-by: Andrew Donnellan
rg
Cc: Andrew Donnellan
Cc: Lu Baolu
Reviewed-by: Frederic Barrat
Signed-off-by: Ben Widawsky
Looks good to me, it's essentially identical to the existing
implementation in ocxl.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@lin
implementation. As that change is less trivial it is
reserved for later.
Cc: linuxppc-dev@lists.ozlabs.org
Cc: Andrew Donnellan
Acked-by: Frederic Barrat (v1)
Signed-off-by: Ben Widawsky
Looks fine, but we should clean up find_dvsec_from_pos() afterwards.
Reviewed-by: Andrew Donnellan
;err_handler
&&
I'm not a huge fan of assignments in if statements and if you send a v6
I'd prefer you break it up.
Apart from that everything in the powerpc and cxl sections looks good to me.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
at any of the cxl PCI error handling paths brings back
nightmares from a few years ago... Fred: I wonder if we need to add a
lock here?
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
zlabs.org
Description:read only
-Decimal value of the the lowest version of the userspace API
-this this kernel supports.
+Decimal value of the lowest version of the userspace API
+ this kernel supports.
Users:
On 7/10/21 2:50 am, Sohaib Mohamed wrote:
Remove repeated words: "the the lowest" and "this this kernel"
Signed-off-by: Sohaib Mohamed
Thanks for catching this.
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com
t;vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver")
Signed-off-by: Alexey Kardashevskiy
Should this be Cc: stable?
Andrew
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
/job/snowpatch/job/snowpatch-linux-checkpatch/16267//artifact/linux/checkpatch.log
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 9/10/20 12:20 pm, Andrew Donnellan wrote:
The Linux kernel for powerpc has an issue with the Run-Time Abstraction
Services (RTAS) interface, allowing root (or CAP_SYS_ADMIN users) in a
VM to overwrite some parts of memory, including kernel memory.
This issue impacts guests running on top
y errinjct)
Which is producing this when trying to invoke the errinjct tool.
I'll send a fixes patch out shortly.
*sigh*
Thanks for picking this up!
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 24/11/20 1:41 am, Andrew Donnellan wrote:
On 9/10/20 12:20 pm, Andrew Donnellan wrote:
The Linux kernel for powerpc has an issue with the Run-Time
Abstraction Services (RTAS) interface, allowing root (or CAP_SYS_ADMIN
users) in a VM to overwrite some parts of memory, including kernel
tching this!
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
Sometimes we can't read an error log from OPAL, and we print an error
message accordingly. But the OPAL userspace tools seem to like retrying a
lot, in which case we flood the kernel log with a lot of messages.
Change pr_err() to pr_err_ratelimited() to help with this.
Signed-off-by: A
On 25/12/20 12:24 am, Zheng Yongjun wrote:
mutex lock can be initialized automatically with DEFINE_MUTEX()
rather than explicitly calling mutex_init().
Signed-off-by: Zheng Yongjun
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com
ces :)
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 15/1/21 8:59 am, Nathan Lynch wrote:
Add kerneldoc for ppc_rtas_rmo_buf_show(), the callback for
/proc/powerpc/rtas/rmo_buffer, explaining its expected use.
Signed-off-by: Nathan Lynch
Looks good.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a
On 15/1/21 9:00 am, Nathan Lynch wrote:
This constant is unused.
Signed-off-by: Nathan Lynch
A quick grep agrees.
Reviewed-by: Andrew Donnellan
---
arch/powerpc/kernel/rtas-proc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/powerpc/kernel/rtas-proc.c b/arch/powerpc
On 15/1/21 9:00 am, Nathan Lynch wrote:
There's not a compelling reason to cache the value of the token for
the ibm,suspend-me function. Just look it up when needed in the RTAS
syscall's special case for it.
Signed-off-by: Nathan Lynch
Reviewed-by: Andrew Donnellan
---
ar
lue in terms of the
number of work areas allocated.
Signed-off-by: Nathan Lynch
squash! powerpc/rtas: rename RTAS_RMOBUF_MAX to RTAS_USER_REGION_SIZE
I think you meant to get rid of this line...
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
uot;).
Thanks for picking this up.
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 29/1/21 7:25 pm, Yang Li wrote:
Fix the following coccicheck warning:
./drivers/misc/cxl/sysfs.c:181:48-53: WARNING: conversion to bool not
needed here
Reported-by: Abaci Robot
Signed-off-by: Yang Li
Reviewed-by: Andrew Donnellan
Thanks!
---
drivers/misc/cxl/sysfs.c | 2 +-
1 file
holas Piggin
Fixes: 68b34588e202 ("powerpc/64/sycall: Implement syscall entry/exit logic in
C")
Signed-off-by: Daniel Axtens
This seems reasonable - I've verified that this does indeed suppress the
kcov trace calls.
Acked-by: Andrew Donnellan
(does this need to be tagged f
The CXL_AFU_DRIVER_OPS and CXL_LIB Kconfig options were added to coordinate
merging of new features. They no longer serve any purpose, so remove them.
Signed-off-by: Andrew Donnellan
---
drivers/misc/cxl/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/misc/cxl/Kconfig
The CXL_AFU_DRIVER_OPS Kconfig option was added to coordinate merging of
new features. It no longer serves any purpose, so remove it.
Signed-off-by: Andrew Donnellan
---
v1->v2:
- keep CXL_LIB for now to avoid breaking a driver that is currently out of
tree
---
drivers/misc/cxl/Kconfig
r1: so it falls through?
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 3/6/20 9:57 pm, wanghai (M) wrote:
kfree(cr) can be called when
kobject_put()-->kobject_release()-->kobject_cleanup()-->kobj_type->release()
is called. The kobj_type here is afu_config_record_type
Of course, I missed that.
In that case
Acked-by: Andrew Donnellan
Thanks
this is specific to the IBM CFG
implementation and the IBM-specific DVSEC?
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
: Philippe Bergheaud
Signed-off-by: Frederic Barrat
Reviewed-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
es. For compatibility with any applications we are not aware of
that require other calls, the filter can be turned off at build time.
Reported-by: Daniel Axtens
Cc: sta...@vger.kernel.org
Signed-off-by: Andrew Donnellan
---
arch/powerpc/Kconfig | 13 +++
ar
On 3/8/21 8:01 pm, Uwe Kleine-König wrote:
This prepares removing the driver member of struct pci_dev which holds the
same information than struct pci_dev::dev->driver.
Signed-off-by: Uwe Kleine-König
cxl hunks look alright.
Acked-by: Andrew Donnellan # cxl
--
Andrew Donnel
phan: while this is not linked to
the main index.rst file, in order to avoid build warnings.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Andrew Donnellan # cxl
Minor possible improvement below, otherwise compiled output looks very nice.
diff --git a/Documentation/powerpc/cxl.txt b
ic on the card (CFG, TLX) won't be reset, so
-* there's no guarantee that it will be enough.
-*/
- rc = ocxl_config_read_function(dev, &fn->config);
- if (rc)
- return rc;
-
- rc = set_function_device(fn, dev);
- if (rc)
- return rc;
-
- rc = assign_function_actag(fn);
- if (rc)
- return rc;
-
- rc = set_function_pasid(fn);
- if (rc)
- return rc;
-
- rc = ocxl_link_setup(dev, 0, &fn->link);
- if (rc)
- return rc;
-
- rc = ocxl_config_set_TL(dev, fn->config.dvsec_tl_pos);
- if (rc) {
- ocxl_link_release(dev, fn->link);
- return rc;
- }
- return 0;
-}
-
-static void deconfigure_function(struct ocxl_fn *fn)
-{
- struct pci_dev *dev = to_pci_dev(fn->dev.parent);
-
- ocxl_link_release(dev, fn->link);
- pci_disable_device(dev);
-}
-
-static struct ocxl_fn *init_function(struct pci_dev *dev)
-{
- struct ocxl_fn *fn;
- int rc;
-
- fn = alloc_function(dev);
- if (!fn)
- return ERR_PTR(-ENOMEM);
-
- rc = configure_function(fn, dev);
- if (rc) {
- free_function(fn);
- return ERR_PTR(rc);
- }
-
- rc = device_register(&fn->dev);
- if (rc) {
- deconfigure_function(fn);
- put_device(&fn->dev);
- return ERR_PTR(rc);
- }
- return fn;
-}
-
-static void remove_function(struct ocxl_fn *fn)
-{
- deconfigure_function(fn);
- device_unregister(&fn->dev);
-}
-
static int ocxl_probe(struct pci_dev *dev, const struct pci_device_id *id)
{
int rc, afu_count = 0;
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
On 27/3/19 4:31 pm, Alastair D'Silva wrote:
From: Alastair D'Silva
This data is already available in a struct
Signed-off-by: Alastair D'Silva
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/core.c | 38 +-
1 file changed, 21 in
uldn't be allowed in
lockdown.
So, if you can disable lockdown on the console that's probably OK, but
it should be specifically disabling lockdown, not randomly editing
memory with xmon.
That makes sense.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
Use my @linux.ibm.com email to avoid a layer of redirection.
Signed-off-by: Andrew Donnellan
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 5c38f21aee78..386e2336fe7e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4293,7
kernel.org
Signed-off-by: Andrew Donnellan
---
arch/powerpc/platforms/powernv/opal.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c
b/arch/powerpc/platforms/powernv/opal.c
index 2b0eca104f86..505460a72052 100644
--- a/ar
kernel.org
Signed-off-by: Andrew Donnellan
---
v1->v2:
- fix tabs vs spaces (Greg)
---
arch/powerpc/platforms/powernv/opal.c | 11 +++
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal.c
b/arch/powerpc/platforms/powernv/opal.c
index
On 3/5/19 5:48 pm, Greg KH wrote:
no tab?
checkpatch.pl is your friend :)
Ughh.
Sadly our CI is currently down ;)
Respun.
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
ou are racing userspace when you create this
sysfs file, why not add it to the device's default attributes so the
driver core creates it for you at the correct time?
I was not previously aware of default attributes...
Are we actually racing against userspace in a subsys initcall?
--
Andrew D
On 3/5/19 6:35 pm, Greg KH wrote:
Are we actually racing against userspace in a subsys initcall?
You can be, if you subsys is a module :)
For various reasons, we don't compile core system firmware interfaces
into modules... that could be an interesting exercise. :D
--
Andrew Donn
On 4/5/19 8:27 pm, YueHaibing wrote:
Fix sparse warning:
drivers/misc/ocxl/pci.c:44:6: warning:
symbol 'ocxl_remove' was not declared. Should it be static?
Reported-by: Hulk Robot
Signed-off-by: YueHaibing
Good catch!
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl
;ocxl: move event_fd handling to frontend")
Signed-off-by: Wei Yongjun
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ocxl/file.c b/drivers/misc/ocxl/file.c
index 8aa22893ed76..2870c25da166 10
toggle_count_cache_flush(true);
}
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
On 7/5/19 12:43 pm, Christopher M. Riedl wrote:
Add support for disabling the kernel implemented spectre v2 mitigation
(count cache flush on context switch) via the nospectre_v2 cmdline
option.
Suggested-by: Michael Ellerman
Signed-off-by: Christopher M. Riedl
Reviewed-by: Andrew Donnellan
show up in menuconfig, as previously it was the only labelled option in
sysdev/Kconfig and wasn't actually in a menu.
Signed-off-by: Andrew Donnellan
---
arch/powerpc/include/asm/scom.h | 4 ++--
arch/powerpc/platforms/powernv/Kconfig| 5 -
arch/powerpc/plat
On 8/5/19 10:27 pm, Michael Ellerman wrote:
Andrew Donnellan writes:
The powernv platform is the only one that directly accesses SCOMs. Move the
support code to platforms/powernv, and get rid of the PPC_SCOM Kconfig
option, as SCOM support is always selected when compiling for powernv.
This
Nothing is using scom_map_device() or scom_find_parent(). Remove them.
Also don't export scom_controller, there are no other users of it.
Signed-off-by: Andrew Donnellan
---
v1->v2:
- new patch
---
arch/powerpc/platforms/powernv/scom.c | 67 ---
arch/powerpc/p
show up in menuconfig, as previously it was the only labelled option in
sysdev/Kconfig and wasn't actually in a menu.
Signed-off-by: Andrew Donnellan
---
v1->v2:
- move scom.h as well (mpe)
- add all the other patches in this series
---
arch/powerpc/platforms/powernv/Kconfig
Signed-off-by: Andrew Donnellan
---
v1->v2:
- new patch
---
arch/powerpc/platforms/powernv/opal-xscom.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal-xscom.c
b/arch/powerpc/platforms/powernv/opal-xscom.c
index e16b0e346
ned-off-by: Andrew Donnellan
---
v1->v2:
- new patch
---
arch/powerpc/configs/powernv_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/configs/powernv_defconfig
b/arch/powerpc/configs/powernv_defconfig
index ef2ef98d3f28..d5a6608cb2e0 100644
--- a/arch/po
controller and make everything much simpler and
more direct.
While we're here, fix up the comment block at the top and add a SPDX
header.
Signed-off-by: Andrew Donnellan
---
v1->v2:
- new patch
---
arch/powerpc/platforms/powernv/Makefile | 2 +-
arch/powerpc/platforms/powernv/
d like to see this moved there,
but perhaps this patch can wait until then. I'll let mpe decide.
Andrew
Signed-off-by: Andrew Donnellan
---
v1->v2:
- new patch
---
arch/powerpc/configs/powernv_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/pow
On 18/5/19 12:20 am, Frederic Barrat wrote:
If we couldn't fully init a context, we were leaking memory.
Fixes: b9721d275cc2 ("ocxl: Allow external drivers to use OpenCAPI contexts")
Signed-off-by: Frederic Barrat
Acked-by: Andrew Donnellan
---
drivers/misc/ocxl/context.c
Acked-by: Andrew Donnellan
On 20/5/19 5:16 pm, Frederic Barrat wrote:
If we couldn't fully init a context, we were leaking memory.
Fixes: b9721d275cc2 ("ocxl: Allow external drivers to use OpenCAPI contexts")
Signed-off-by: Frederic Barrat
---
Changelog:
v2: reset context poi
h, the matching skiboot
change:
http://patchwork.ozlabs.org/patch/1104076/
Still always safest to hold off until merged into skiboot :)
Reviewed-by: Andrew Donnellan
arch/powerpc/include/asm/opal-api.h | 1 +
arch/powerpc/platforms/powernv/opal-hmi.c | 40 +++
clear all breakpoints, set xmon read-only mode
(2) lockdown=none -> lockdown=confidentiality
clear all breakpoints, prevent re-entry into xmon
(3) lockdown=integrity -> lockdown=confidentiality
prevent re-entry into xmon
Suggested-by: Andrew Donnellan
Signed-off-by: Christ
On 9/5/19 3:11 pm, Andrew Donnellan wrote:
The powernv platform is the only one that directly accesses SCOMs. Move the
support code to platforms/powernv, and get rid of the PPC_SCOM Kconfig
option, as SCOM support is always selected when compiling for powernv.
This also means that the Kconfig
d in some manner - if there is a better way I am all ears :)
Integrity mode merely means we are aiming to prevent modifications to
kernel memory. IMHO leaving existing breakpoints in place is fine as
long as when we hit the breakpoint xmon is in read-only mode.
(dja/mpe might have
/1083801/
If you choose to proceed with this patch:
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm.com IBM Australia Limited
hem, in order
to silent this warning.
Signed-off-by: Mauro Carvalho Chehab
ocxl:
Acked-by: Andrew Donnellan
We should find somewhere to put it...
---
Documentation/accelerators/ocxl.rst | 2 ++
Documentation/arm/stm32/overview.rst| 2 ++
Documentation/a
-by: Andrew Donnellan
snowpatch is whinging about this breaking the build for some reason...
https://patchwork.ozlabs.org/patch/1104583/
---
v4->v5:
Fix checkpatch complaint
arch/powerpc/kernel/security.c | 19 ---
1 file changed, 16 insertions(+), 3 deleti
On 15/12/21 5:04 pm, cgel@gmail.com wrote:
From: Minghao Chi
Return value from ocxl_context_attach() directly instead
of taking this in another redundant variable.
Reported-by: Zeal Robot
Signed-off-by: Minghao Chi
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs
On 9/2/22 14:24, Cai Huoqing wrote:
Replace "struct list_head head = LIST_HEAD_INIT(head)" with
"LIST_HEAD(head)" to simplify the code.
Signed-off-by: Cai Huoqing
LGTM
Acked-by: Andrew Donnellan
--
Andrew Donnellan OzLabs, ADL Canberra
a...@linux.ibm
.
Signed-off-by: Vaibhav Jain
Comments below.
Reviewed-by: Andrew Donnellan
---
drivers/misc/cxl/cxl.h| 3 ---
drivers/misc/cxl/native.c | 56 ++-
drivers/misc/cxl/pci.c| 44 -
3 files changed, 55 insertions
Reviewed-by: Andrew Donnellan
On 14/03/17 22:08, Christophe Lombard wrote:
The two fields pid and tid of the structure cxl_irq_info are only used
in the guest environment. To avoid confusion, it's not necessary
to fill the fields in the bare-metal environment.
The PSL Process and T
sory look and
can't see it.
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
Commit 65c059bcaa73 ("powerpc: Enable support for GCC plugins") enabled GCC
plugins on powerpc, but neglected to update the architecture list in the
docs. Rectify this.
Fixes: 65c059bcaa73 ("powerpc: Enable support for GCC plugins")
Signed-off-by: Andrew Donnellan
--
afu->attr_afud.size = 0;
+ dev_err(&afu->dev,
+ "Unable to create afu_desc attr for the afu.
Err(%d)\n",
+ rc);
+ goto err1;
+ }
+ }
+
return 0;
err1:
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
ext exists")
Reported-by: Andrew Donnellan
Signed-off-by: Vaibhav Jain
---
Change-Log:
v2..v1
- Moved the call to cxl_adapter_context_force_lock() from
cxl_pci_error_detected() to cxl_remove. (Fred)
---
drivers/misc/cxl/cxl.h | 3 +++
drivers/misc/cxl/main.c | 10 ++
drivers/misc/
implementation-specific code.
Patch 7 introduces the core of the PSL9-specific code.
Is patch 1 (cxl: Read vsec perst load image) from the last version of
the series missing in this one?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
to be dependent on CONFIG_DEBUG_FS
Whoops, looks like I screwed that up when I rebased. :/
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
bin_attr->size);
+}
+
+static struct bin_attribute *exported_attrs;
+static char **attr_name;
Can these be moved inside opal_export_attrs()?
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com IBM Australia Limited
is stopped by the /dev/mem filter.
Signed-off-by: Matt Brown
Reviewed-by: Andrew Donnellan
---
Changelog:
v7:
- moved exported_attrs and attr_name into opal_export_attrs
---
arch/powerpc/platforms/powernv/opal.c | 84 +++
1 file changed, 84
On 27/03/17 18:38, Andrew Donnellan wrote:
On 01/02/17 07:24, Kees Cook wrote:
From: Emese Revfy
The kernel already has a mechanism to free up code and data memory that
is only used during kernel or module initialization. This plugin will
teach the compiler to find more such code and data
Reviewed-by: Andrew Donnellan
On 29/03/17 02:14, Christophe Lombard wrote:
This bit is used to cause a flash image load for programmable
CAIA-compliant implementation. If this bit is set to ‘0’, a power
cycle of the adapter is required to load a programmable CAIA-com-
pliant implementation
avoid undefined behavior on bare-metal.
The PSL Process and Thread Identification Register (CXL_PSL_PID_TID_An)
is only used when attaching a dedicated process for PSL8 only. This
register goes away in CAIA2.
Signed-off-by: Christophe Lombard
Reviewed-by: Andrew Donnellan
---
drivers/misc/cx
mm_struct can't
be freed. The mm_struct will be released when the context is detached.
A reference on mm_users is not kept to avoid a circular dependency if
the process mmaps its cxl mmio and forget to unmap before exiting.
Signed-off-by: Christophe Lombard
Reviewed-by: Andrew Donnellan
--
A
the PSL and forwards them as PowerBus data
packets. The PSL also has an optional DMA feature which allows the AFU
to send native PCIe reads and writes to the Processor.
Today Mikey reminded me that Documentation/powerpc/cxl.txt still exists
- we probably ought to update it.
--
Andrew Donnellan
psl interrupts.
- Debug registers for the adapter and the afu.
- Traces.
Each environment implements its own functions, and the common code uses
them through function pointers, defined in cxl_service_layer_ops.
Signed-off-by: Christophe Lombard
Reviewed-by: Andrew Donnellan
---
drivers/misc
phe Lombard
Looks fine to me
Reviewed-by: Andrew Donnellan
---
drivers/misc/cxl/cxl.h | 26 +-
drivers/misc/cxl/debugfs.c | 6 +++---
drivers/misc/cxl/guest.c | 2 +-
drivers/misc/cxl/irq.c | 2 +-
drivers/misc/cxl/native.c | 12 ++--
drivers/mis
== PCI_ERS_RESULT_DISCONNECT)
+ result = PCI_ERS_RESULT_DISCONNECT;
+ else if ((afu_result == PCI_ERS_RESULT_NONE) &&
+(result == PCI_ERS_RESULT_NEED_RESET))
+ result = PCI_ERS_RESULT_NONE;
}
/* should take the
Reviewed-by: Andrew Donnellan
On 08/04/17 00:11, Christophe Lombard wrote:
This bit is used to cause a flash image load for programmable
CAIA-compliant implementation. If this bit is set to ‘0’, a power
cycle of the adapter is required to load a programmable CAIA-com-
pliant implementation
601 - 700 of 1086 matches
Mail list logo
