Re: [PATCH v2 07/29] ABI: sysfs-class-cxl: place "not in a guest" at description

[Andrew Donnellan]

On 15/9/21 12:32 am, Mauro Carvalho Chehab wrote:

The What: field should have just the location of the ABI.
Anything else should be inside the description.

This fixes its parsing by get_abi.pl script.

Signed-off-by: Mauro Carvalho Chehab <mchehab+hua...@kernel.org>

Looks fine to me.

Acked-by: Andrew Donnellan <a...@linux.ibm.com>

---
  Documentation/ABI/testing/sysfs-class-cxl | 15 ++++++++++-----
  1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/Documentation/ABI/testing/sysfs-class-cxl 
b/Documentation/ABI/testing/sysfs-class-cxl
index 818f55970efb..3c77677e0ca7 100644
--- a/Documentation/ABI/testing/sysfs-class-cxl
+++ b/Documentation/ABI/testing/sysfs-class-cxl
@@ -166,10 +166,11 @@ Description:    read only
                  Decimal value of the Per Process MMIO space length.
  Users:                https://github.com/ibm-capi/libcxl

-What: /sys/class/cxl/<afu>m/pp_mmio_off (not in a guest)

+What:           /sys/class/cxl/<afu>m/pp_mmio_off
  Date:           September 2014
  Contact:        linuxppc-dev@lists.ozlabs.org
  Description:    read only
+                (not in a guest)
                  Decimal value of the Per Process MMIO space offset.
  Users:                https://github.com/ibm-capi/libcxl

@@ -190,28 +191,31 @@ Description: read only

                  Identifies the revision level of the PSL.
  Users:                https://github.com/ibm-capi/libcxl

-What: /sys/class/cxl/<card>/base_image (not in a guest)

+What:           /sys/class/cxl/<card>/base_image
  Date:           September 2014
  Contact:        linuxppc-dev@lists.ozlabs.org
  Description:    read only
+                (not in a guest)
                  Identifies the revision level of the base image for devices
                  that support loadable PSLs. For FPGAs this field identifies
                  the image contained in the on-adapter flash which is loaded
                  during the initial program load.
  Users:                https://github.com/ibm-capi/libcxl

-What: /sys/class/cxl/<card>/image_loaded (not in a guest)

+What:           /sys/class/cxl/<card>/image_loaded
  Date:           September 2014
  Contact:        linuxppc-dev@lists.ozlabs.org
  Description:    read only
+                (not in a guest)
                  Will return "user" or "factory" depending on the image loaded
                  onto the card.
  Users:                https://github.com/ibm-capi/libcxl

-What: /sys/class/cxl/<card>/load_image_on_perst (not in a guest)

+What:           /sys/class/cxl/<card>/load_image_on_perst
  Date:           December 2014
  Contact:        linuxppc-dev@lists.ozlabs.org
  Description:    read/write
+                (not in a guest)
                  Valid entries are "none", "user", and "factory".
                  "none" means PERST will not cause image to be loaded to the
                  card.  A power cycle is required to load the image.
@@ -235,10 +239,11 @@ Description:    write only
                  contexts on the card AFUs.
  Users:                https://github.com/ibm-capi/libcxl

-What: /sys/class/cxl/<card>/perst_reloads_same_image (not in a guest)

+What:          /sys/class/cxl/<card>/perst_reloads_same_image
  Date:         July 2015
  Contact:      linuxppc-dev@lists.ozlabs.org
  Description:  read/write
+                (not in a guest)
                Trust that when an image is reloaded via PERST, it will not
                have changed.

--
Andrew Donnellan              OzLabs, ADL Canberra
a...@linux.ibm.com             IBM Australia Limited