[PATCH] Documentation: Fix description format for powerpc RTAS ioctls

2025-04-29 Thread Haren Myneni
Fix the description format for the following build warnings: "Documentation/userspace-api/ioctl/ioctl-number.rst:369: ERROR: Malformed table. Text in column margin in table line 301. 0xB2 03-05 arch/powerpc/include/uapi/asm/papr-indices.h powerpc/pseries indices API <

Re: [v3 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-29 Thread Eric Biggers
On Wed, Apr 30, 2025 at 10:27:15AM +0800, Herbert Xu wrote: > On Tue, Apr 29, 2025 at 09:57:49AM -0700, Eric Biggers wrote: > > > > To be clear, the objections I have on your v2 patchset still hold. Your > > unsolicited changes to my patches add unnecessary complexity and redundancy, > > make the

Re: [v3 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-29 Thread Herbert Xu
On Tue, Apr 29, 2025 at 07:38:49PM -0700, Eric Biggers wrote: > > Nothing requires that the export formats be consistent, but also the fact that > padlock-sha uses a weird format in the first place is an artificial problem > that > you introduced just a couple weeks ago. And even if we *must* use

Re: [PATCH v4 01/13] crypto: sha256 - support arch-optimized lib and expose through shash

2025-04-29 Thread Herbert Xu
On Mon, Apr 28, 2025 at 10:00:26AM -0700, Eric Biggers wrote: > From: Eric Biggers > > As has been done for various other algorithms, rework the design of the > SHA-256 library to support arch-optimized implementations, and make > crypto/sha256.c expose both generic and arch-optimized shash algor

Re: [PATCH] powerpc/pseries: Include linux/types.h in papr-platform-dump.h

2025-04-29 Thread Stephen Rothwell
Hi Haren, Thanks for this. I have a small nitpick below. On Tue, 29 Apr 2025 14:14:18 -0700 Haren Myneni wrote: > > Fix the following build warning: > usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type > without #include > > Fixes: 8aa9efc0be66 ("powerpc/pseries: Add papr

RE: [PATCH v6 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-04-29 Thread Wei Fang
> [Some people who received this message don't often get email from > ti...@kernel.org. Learn why this is important at > https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Apr 28, 2025 at 6:19 AM Wei Fang wrote: > > +void enetc_remove_debugfs(struct enetc_si *si) > > +{ > > + debug

Re: [PATCH v3 8/9] lockdown: Make the relationship to MODULE_SIG a dependency

2025-04-29 Thread Paul Moore
On Tue, Apr 29, 2025 at 9:04 AM Thomas Weißschuh wrote: > > The new hash-based module integrity checking will also be able to > satisfy the requirements of lockdown. > Such an alternative is not representable with "select", so use > "depends on" instead. > > Signed-off-by: Thomas Weißschuh > ---

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event

2025-04-29 Thread Mark Brown
On Mon, Apr 28, 2025 at 11:20:42AM +0200, Christophe Leroy wrote: > Le 10/04/2025 à 15:47, Mark Brown a écrit : > Would it be possible to get this patch into one of the v6.15 rc as it is a > bug fix ? It appears to be queued as a fix, could you be more specific please? Please delete unneeded con

Re: [v3 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-29 Thread Herbert Xu
On Tue, Apr 29, 2025 at 09:57:49AM -0700, Eric Biggers wrote: > > To be clear, the objections I have on your v2 patchset still hold. Your > unsolicited changes to my patches add unnecessary complexity and redundancy, > make the crypto_shash API even harder to use correctly, and also break the > b

Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad()

2025-04-29 Thread Thorsten Blum
Hi Christophe, On 29. Apr 2025, at 13:58, Christophe Leroy wrote: > Le 29/04/2025 à 13:47, Ioana Ciornei a écrit: >> On Tue, Apr 29, 2025 at 12:41:48PM +0200, Thorsten Blum wrote: >>> Both destination buffers are already zero-initialized, making strscpy() >>> sufficient for safely copying 'obj_typ

[PATCH] Documentation: ioctl-number: Extend "Include File" column width

2025-04-29 Thread Bagas Sanjaya
Stephen Rothwell reports htmldocs warning when merging powerpc tree for linux-next: Documentation/userspace-api/ioctl/ioctl-number.rst:369: ERROR: Malformed table. Text in column margin in table line 301. = === ==

[PATCH v3 5/9] module: Make module loading policy usable without MODULE_SIG

2025-04-29 Thread Thomas Weißschuh
The loading policy functionality will also be used by the hash-based module validation. Split it out from CONFIG_MODULE_SIG so it is usable by both. Signed-off-by: Thomas Weißschuh --- include/linux/module.h | 8 kernel/module/Kconfig | 6 +- kernel/module/main.c| 26 ++

[PATCH v3 9/9] module: Introduce hash-based integrity checking

2025-04-29 Thread Thomas Weißschuh
The current signature-based module integrity checking has some drawbacks in combination with reproducible builds: Either the module signing key is generated at build time, which makes the build unreproducible, or a static key is used, which precludes rebuilds by third parties and makes the whole bu

[PATCH v3 7/9] module: Move lockdown check into generic module loader

2025-04-29 Thread Thomas Weißschuh
The lockdown check buried in module_sig_check() will not compose well with the introduction of hash-based module validation. Move it into module_integrity_check() which will work better. Signed-off-by: Thomas Weißschuh --- kernel/module/main.c| 6 +- kernel/module/signing.c | 3 +-- 2 fi

[PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-04-29 Thread Thomas Weißschuh
The current signature-based module integrity checking has some drawbacks in combination with reproducible builds: Either the module signing key is generated at build time, which makes the build unreproducible, or a static key is used, which precludes rebuilds by third parties and makes the whole bu

[PATCH v3 6/9] module: Move integrity checks into dedicated function

2025-04-29 Thread Thomas Weißschuh
With the addition of hash-based integrity checking, the configuration matrix is easier to represent in a dedicated function and with explicit usage of IS_ENABLED(). Drop the now unnecessary stub for module_sig_check(). Signed-off-by: Thomas Weißschuh --- kernel/module/internal.h | 7 --- k

[PATCH v3 3/9] kbuild: add stamp file for vmlinux BTF data

2025-04-29 Thread Thomas Weißschuh
The upcoming module hashes functionality will build the modules in between the generation of the BTF data and the final link of vmlinux. Having a dependency from the modules on vmlinux would make this impossible as it would mean having a cyclic dependency. Break this cyclic dependency by introducin

[PATCH v3 8/9] lockdown: Make the relationship to MODULE_SIG a dependency

2025-04-29 Thread Thomas Weißschuh
The new hash-based module integrity checking will also be able to satisfy the requirements of lockdown. Such an alternative is not representable with "select", so use "depends on" instead. Signed-off-by: Thomas Weißschuh --- security/lockdown/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 del

[PATCH v3 4/9] kbuild: generate module BTF based on vmlinux.unstripped

2025-04-29 Thread Thomas Weißschuh
The upcoming module hashes functionality will build the modules in between the generation of the BTF data and the final link of vmlinux. At this point vmlinux is not yet built and therefore can't be used for module BTF generation. vmlinux.unstripped however is usable and sufficient for BTF generati

[PATCH v3 1/9] powerpc/ima: Drop unnecessary check for CONFIG_MODULE_SIG

2025-04-29 Thread Thomas Weißschuh
When CONFIG_MODULE_SIG is disabled set_module_sig_enforced() is defined as an empty stub, so the check is unnecessary. The specific configuration option for set_module_sig_enforced() is about to change and removing the check avoids some later churn. Signed-off-by: Thomas Weißschuh --- This patch

[PATCH v3 2/9] ima: efi: Drop unnecessary check for CONFIG_MODULE_SIG/CONFIG_KEXEC_SIG

2025-04-29 Thread Thomas Weißschuh
When configuration settings are disabled the guarded functions are defined as empty stubs, so the check is unnecessary. The specific configuration option for set_module_sig_enforced() is about to change and removing the checks avoids some later churn. Signed-off-by: Thomas Weißschuh --- This pat

[RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad()

2025-04-29 Thread Thorsten Blum
Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary. If the destination buffer has a fixed length, strscpy() automatically determines its size using sizeof() when the

Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad()

2025-04-29 Thread Christophe Leroy
Le 29/04/2025 à 13:47, Ioana Ciornei a écrit : On Tue, Apr 29, 2025 at 12:41:48PM +0200, Thorsten Blum wrote: Both destination buffers are already zero-initialized, making strscpy() sufficient for safely copying 'obj_type'. The additional NUL-padding performed by strscpy_pad() is unnecessary.

Re: [RESEND PATCH] bus: fsl-mc: Use strscpy() instead of strscpy_pad()

2025-04-29 Thread Ioana Ciornei
On Tue, Apr 29, 2025 at 12:41:48PM +0200, Thorsten Blum wrote: > Both destination buffers are already zero-initialized, making strscpy() > sufficient for safely copying 'obj_type'. The additional NUL-padding > performed by strscpy_pad() is unnecessary. > > If the destination buffer has a fixed len

linux-next: build warning after merge of the powerpc tree

2025-04-29 Thread Stephen Rothwell
Hi all, After merging the powerpc tree, today's linux-next build (htmldocs) produced this warning: Documentation/userspace-api/ioctl/ioctl-number.rst:369: ERROR: Malformed table. Text in column margin in table line 301. = === ==

Re: [PATCH v3 02/13] crypto: powerpc - drop redundant dependencies on PPC

2025-04-29 Thread Christophe Leroy
Le 22/04/2025 à 17:27, Eric Biggers a écrit : From: Eric Biggers arch/powerpc/crypto/Kconfig is sourced only when CONFIG_PPC=y, so there is no need for the symbols defined inside it to depend on PPC. Acked-by: Ard Biesheuvel Signed-off-by: Eric Biggers Reviewed-by: Christophe Leroy N

linux-next: build warning after merge of the powerpc tree

2025-04-29 Thread Stephen Rothwell
Hi all, After merging the powerpc tree, today's linux-next build (powerpc allyesconfig) produced this warning: usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include Introduced by commit 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver

Re: [v3 PATCH 00/13] Architecture-optimized SHA-256 library API

2025-04-29 Thread Eric Biggers
On Mon, Apr 28, 2025 at 01:17:02PM +0800, Herbert Xu wrote: > Changes in v3: > - Add shash sha256-lib/sha224-lib to provide test coverage for libsha256. > > This is based on > > https://patchwork.kernel.org/project/linux-crypto/list/?series=957558 > > Original description: > > Following t

Re: [PATCH 1/2] powerpc, bpf: Support internal-only MOV instruction to resolve per-CPU addrs

2025-04-29 Thread Saket Kumar Bhaskar
On Tue, Mar 11, 2025 at 06:38:23PM +0100, Christophe Leroy wrote: > > > Le 11/03/2025 à 17:09, Saket Kumar Bhaskar a écrit : > > [Vous ne recevez pas souvent de courriers de sk...@linux.ibm.com. Découvrez > > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification > > ] > >

Re: [PATCH v6 net-next 05/14] net: enetc: add debugfs interface to dump MAC filter

2025-04-29 Thread Timur Tabi
On Mon, Apr 28, 2025 at 6:19 AM Wei Fang wrote: > +void enetc_remove_debugfs(struct enetc_si *si) > +{ > + debugfs_remove_recursive(si->debugfs_root); You can just call debugfs_remove() here. debugfs_remove_recursive() is deprecated: void debugfs_remove(struct dentry *dentry); #define deb

Re: [PATCH 2/2] powerpc, bpf: Inline bpf_get_smp_processor_id()

2025-04-29 Thread Saket Kumar Bhaskar
On Tue, Mar 11, 2025 at 06:51:28PM +0100, Christophe Leroy wrote: > > > Le 11/03/2025 à 17:09, Saket Kumar Bhaskar a écrit : > > [Vous ne recevez pas souvent de courriers de sk...@linux.ibm.com. Découvrez > > pourquoi ceci est important à https://aka.ms/LearnAboutSenderIdentification > > ] > >

[PATCH 4/4 v2] ACPI: extlog: Trace CPER CXL Protocol Errors

2025-04-29 Thread Fabio M. De Francesco
When Firmware First is enabled, BIOS handles errors first and then it makes them available to the kernel via the Common Platform Error Record (CPER) sections (UEFI 2.10 Appendix N). Linux parses the CPER sections via one of two similar paths, either ELOG or GHES. Currently, ELOG and GHES show some

[PATCH 3/4 v2] ACPI: extlog: Trace CPER PCI Express Error Section

2025-04-29 Thread Fabio M. De Francesco
I/O Machine Check Arcitecture events may signal failing PCIe components or links. The AER event contains details on what was happening on the wire when the error was signaled. Trace the CPER PCIe Error section (UEFI v2.10, Appendix N.2.7) reported by the I/O MCA. Cc: Dan Williams Signed-off-by:

[PATCH 2/4 v2] PCI/AER: Modify pci_print_aer() to take log level

2025-04-29 Thread Fabio M. De Francesco
Modify pci_print_aer() to take a printk() log level in preparation of a patch that logs PCIe Components and Link errors from ELOG. Cc: Dan Williams Acked-by: Bjorn Helgaas Signed-off-by: Fabio M. De Francesco --- drivers/cxl/core/pci.c | 2 +- drivers/pci/pcie/aer.c | 16 inc

[PATCH 1/4 v2] ACPI: extlog: Trace CPER Non-standard Section Body

2025-04-29 Thread Fabio M. De Francesco
ghes_do_proc() has a catch-all for unknown or unhandled CPER formats (UEFI v2.10 Appendix N 2.3), extlog_print() does not. This gap was noticed by a RAS test that injected CXL protocol errors which were notified to extlog_print() via the IOMCA (I/O Machine Check Architecture) mechanism. Bring parit

[PATCH 0/4 v2] Make ELOG log and trace consistently with GHES

2025-04-29 Thread Fabio M. De Francesco
When Firmware First is enabled, BIOS handles errors first and then it makes them available to the kernel via the Common Platform Error Record (CPER) sections (UEFI 2.10 Appendix N). Linux parses the CPER sections via one of two similar paths, either ELOG or GHES. Currently, ELOG and GHES show some

Re: [PATCH 3/4 v2] ACPI: extlog: Trace CPER PCI Express Error Section

2025-04-29 Thread Yazen Ghannam
On Tue, Apr 29, 2025 at 07:21:08PM +0200, Fabio M. De Francesco wrote: > I/O Machine Check Arcitecture events may signal failing PCIe components > or links. The AER event contains details on what was happening on the wire > when the error was signaled. > > Trace the CPER PCIe Error section (UEFI v

Re: [PATCH 4/4 v2] ACPI: extlog: Trace CPER CXL Protocol Errors

2025-04-29 Thread Yazen Ghannam
On Tue, Apr 29, 2025 at 07:21:09PM +0200, Fabio M. De Francesco wrote: > When Firmware First is enabled, BIOS handles errors first and then it > makes them available to the kernel via the Common Platform Error Record > (CPER) sections (UEFI 2.10 Appendix N). Linux parses the CPER sections > via one

Re: [PATCH v3 0/9] module: Introduce hash-based integrity checking

2025-04-29 Thread James Bottomley
On Tue, 2025-04-29 at 15:04 +0200, Thomas Weißschuh wrote: > The current signature-based module integrity checking has some > drawbacks in combination with reproducible builds: > Either the module signing key is generated at build time, which makes > the build unreproducible, I don't believe it do

[PATCH] powerpc/pseries: Include linux/types.h in papr-platform-dump.h

2025-04-29 Thread Haren Myneni
Fix the following build warning: usr/include/asm/papr-platform-dump.h:12: found __[us]{8,16,32,64} type without #include Fixes: 8aa9efc0be66 ("powerpc/pseries: Add papr-platform-dump character driver for dump retrieval") Closes: https://lore.kernel.org/linux-next/20250429185735.034ba...@canb.a