Re: [PATCH v2] powerpc: Remove eieio() in PowerPC IO functions

2025-01-31 Thread Arnd Bergmann
On Wed, Jan 29, 2025, at 12:14, Segher Boessenkool wrote: > On Wed, Jan 29, 2025 at 10:45:10AM +0100, Julian Vetter wrote: >> Remove the eieio() calls in IO functions for PowerPC. While other >> architectures permit prefetching, combining, and reordering, the eieio() >> calls on PowerPC prevent suc

Re: [PATCH 0/9] YAML conversion of several Freescale/PowerPC DT bindings

2025-01-31 Thread J . Neuschäfer
On Wed, Jan 29, 2025 at 05:29:41PM -0500, Frank Li wrote: > On Sun, Jan 26, 2025 at 07:58:55PM +0100, J. Neuschäfer wrote: > > This is a spin-off of the series titled > > "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". > > > > During the development of that series, it became clear that many > >

[PATCH v3 2/7] crash: remove an unused argument from reserve_crashkernel_generic()

2025-01-31 Thread Sourabh Jain
cmdline argument is not used in reserve_crashkernel_generic() so remove it. Correspondingly, all the callers have been updated as well. No functional change intended. Cc: Andrew Morton Cc: Madhavan Srinivasan Cc: Mahesh Salgaonkar Cc: Michael Ellerman Cc: ke...@lists.infradead.org Cc: linux-k

[PATCH v3 4/7] powerpc/crash: Use generic APIs to locate memory hole for kdump

2025-01-31 Thread Sourabh Jain
On PowerPC, the memory reserved for the crashkernel can contain components like RTAS, TCE, OPAL, etc., which should be avoided when loading kexec segments into crashkernel memory. Due to these special components, PowerPC has its own set of APIs to locate holes in the crashkernel memory for loading

[PATCH v3 1/7] kexec: Initialize ELF lowest address to ULONG_MAX

2025-01-31 Thread Sourabh Jain
kexec_elf_load() loads an ELF executable and sets the address of the lowest PT_LOAD section to the address held by the lowest_load_addr function argument. To determine the lowest PT_LOAD address, a local variable lowest_addr (type unsigned long) is initialized to UINT_MAX. After loading each PT_LO

[PATCH v3 7/7] powerpc/crash: use generic crashkernel reservation

2025-01-31 Thread Sourabh Jain
Commit 0ab97169aa05 ("crash_core: add generic function to do reservation") added a generic function to reserve crashkernel memory. So let's use the same function on powerpc and remove the architecture-specific code that essentially does the same thing. The generic crashkernel reservation also prov

[PATCH v3 6/7] powerpc: insert System RAM resource to prevent crashkernel conflict

2025-01-31 Thread Sourabh Jain
The next patch in the series with title "powerpc/crash: use generic crashkernel reservation" enables powerpc to use generic crashkernel reservation instead of custom implementation. This leads to exporting of `Crash Kernel` memory to iomem_resource (/proc/iomem) via insert_crashkernel_resources():k

[PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area

2025-01-31 Thread Sourabh Jain
Although the crashkernel area is reserved, on architectures like PowerPC, it is possible for the crashkernel reserved area to contain components like RTAS, TCE, OPAL, etc. To avoid placing kexec segments over these components, PowerPC has its own set of APIs to locate holes in the crashkernel reser

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 06:18:54PM +1100, Paul Mackerras wrote: > Interesting. I looked in my copy of v2.07 (PowerISA_V2.07_PUBLIC.pdf) > and it mentions rfscv in a couple of places, but has no description of > scv or rfscv. I'll change it to v3.0. Huh, rfscv is 3.0 and later according to later

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 06:20:31PM +1000, Nicholas Piggin wrote: > Perfectly reasonable to not add broadcast tlbie in microwatt. If you call "the easy way out" reasonable, then sure. This pretty trivial hardware addition causes so many software headaches whenn missing, it isn't funny. "Friends d

Re: [PATCH 0/5] Microwatt updates

2025-01-31 Thread Segher Boessenkool
Hi! On Wed, Jan 29, 2025 at 09:49:49AM +1100, Paul Mackerras wrote: > This patch series updates the kernel support for the Microwatt > soft-core and its implementation on FPGA systems, particularly the > Digilent Arty A7-100 FPGA development board. > > Microwatt now supports almost all of the fea

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 06:10:43PM +1100, Paul Mackerras wrote: > > Hate to bikeshed, but would it be annoying to make this an affirmative > > option? > > I guess we'd have to make all the platforms that do have broadcast > tlbie (and a book3s-64 MMU with radix) select that option. Which > would

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 09:52:09AM +1100, Paul Mackerras wrote: > - isa = <3000>; > + isa = <3010>; Does this mean 3.1, or 3.01? If the former, can this also encode 3.1C? Should uwatt say to support that? > little-endian { > -

Re: [PATCH 2/5] powerpc/microwatt: Device-tree updates

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 04:36:14PM +1000, Nicholas Piggin wrote: > On Wed Jan 29, 2025 at 8:52 AM AEST, Paul Mackerras wrote: > > Microwatt now implements ISA v3.1 (SFFS compliancy subset), including > > prefixed instructions, scv/rfscv, and the FSCR, HFSCR, TAR, and CTRL > > registers. The privil

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-31 Thread J . Neuschäfer
On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote: > On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > > The devicetree bindings for Freescale DMA engines have so far existed as > > a text file. This patch converts them to YAML, and specifies all the > > compatible strings

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-31 Thread Segher Boessenkool
Hi! > +static void microwatt_idle(void) > +{ > + if (!prep_irq_for_idle()) > + return; > + > + __asm__ __volatile__ ("wait"); > +} All asm without outputs is always implicitly volatile (if it wasn't, it could always be transfirmed whatever way you want, like, optimised away co

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 04:06:03PM +1000, Nicholas Piggin wrote: > Does wait cause MSR[EE] to be set? If not, do you need to use > prep_irq_for_idle_irqsoff() here maybe? Assuming this does implement the standard ISA 2.03 wait instruction (and it better), this does not do anything other than to st

Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area

2025-01-31 Thread Baoquan he
On 01/31/25 at 05:08pm, Sourabh Jain wrote: > Although the crashkernel area is reserved, on architectures like > PowerPC, it is possible for the crashkernel reserved area to contain > components like RTAS, TCE, OPAL, etc. To avoid placing kexec segments > over these components, PowerPC has its own

Re: [PATCH v3 3/7] crash: Let arch decide usable memory range in reserved area

2025-01-31 Thread Sourabh Jain
Hello Baoquan, On 01/02/25 09:52, Baoquan he wrote: On 01/31/25 at 05:08pm, Sourabh Jain wrote: Although the crashkernel area is reserved, on architectures like PowerPC, it is possible for the crashkernel reserved area to contain components like RTAS, TCE, OPAL, etc. To avoid placing kexec seg

Re: [PATCH 2/2] powerpc/fadump: fix additional param memory reservation for HASH MMU

2025-01-31 Thread Hari Bathini
On 23/01/25 7:54 pm, Avnish Chouhan wrote: On 2025-01-23 15:26, Hari Bathini wrote: On 20/01/25 11:05 pm, Sourabh Jain wrote: Commit 683eab94da75bc ("powerpc/fadump: setup additional parameters for dump capture kernel") introduced the additional parameter feature in fadump for HASH MMU with

Re: [PATCH 2/9] dt-bindings: ata: Convert fsl,pq-sata binding to YAML

2025-01-31 Thread J . Neuschäfer
On Mon, Jan 27, 2025 at 08:22:55AM +0900, Damien Le Moal wrote: > On 1/27/25 03:58, J. Neuschäfer via B4 Relay wrote: > > From: "J. Neuschäfer" > > > > Convert the Freescale PowerQUICC SATA controller binding from text form > > to YAML. The list of compatible strings reflects current usage. > >

[PATCH v3 0/7] powerpc/crash: use generic crashkernel reservation

2025-01-31 Thread Sourabh Jain
Commit 0ab97169aa05 ("crash_core: add generic function to do reservation") added a generic function to reserve crashkernel memory. So let's use the same function on powerpc and remove the architecture-specific code that essentially does the same thing. The generic crashkernel reservation also prov

[PATCH v3 5/7] powerpc/crash: preserve user-specified memory limit

2025-01-31 Thread Sourabh Jain
Commit 59d58189f3d9 ("crash: fix crash memory reserve exceed system memory bug") fails crashkernel parsing if the crash size is found to be higher than system RAM, which makes the memory_limit adjustment code ineffective due to an early exit from reserve_crashkernel(). Regardless lets not violate

Re: [PATCH 4/5] powerpc: Define config option for processors without broadcast TLBIE

2025-01-31 Thread Segher Boessenkool
On Wed, Jan 29, 2025 at 09:53:44AM +1100, Paul Mackerras wrote: > Power ISA v3.1 implementations in the Linux Compliancy Subset and > lower are not required to implement broadcast TLBIE, and in fact > Microwatt doesn't. But this pretty much means that such systems cannot be SMP systems at all. Im

Re: [PATCH 0/5] Microwatt updates

2025-01-31 Thread Paul Mackerras
On Fri, Jan 31, 2025 at 10:13:43AM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 29, 2025 at 09:49:49AM +1100, Paul Mackerras wrote: > > This patch series updates the kernel support for the Microwatt > > soft-core and its implementation on FPGA systems, particularly the > > Digilent Arty

Re: [PATCH 3/5] powerpc/microwatt: Define an idle power-save function

2025-01-31 Thread Paul Mackerras
On Fri, Jan 31, 2025 at 10:32:55AM -0600, Segher Boessenkool wrote: > On Wed, Jan 29, 2025 at 04:06:03PM +1000, Nicholas Piggin wrote: > > Does wait cause MSR[EE] to be set? If not, do you need to use > > prep_irq_for_idle_irqsoff() here maybe? > > Assuming this does implement the standard ISA 2.0

Re: [PATCH 5/9] dt-bindings: dma: Convert fsl,elo*-dma bindings to YAML

2025-01-31 Thread Rob Herring
On Fri, Jan 31, 2025 at 8:03 AM J. Neuschäfer wrote: > > On Sun, Jan 26, 2025 at 10:47:35PM -0600, Rob Herring wrote: > > On Sun, Jan 26, 2025 at 07:59:00PM +0100, J. Neuschäfer wrote: > > > The devicetree bindings for Freescale DMA engines have so far existed as > > > a text file. This patch conv