Re: [PATCHv2 net-next] net: use pdev instead of OF funcs

2024-11-12 Thread Marc Kleine-Budde
On 11.11.2024 13:03:16, Rosen Penev wrote: > np here is the node coming from platform_device. No children are used. > > I changed irq_of_parse_and_map to platform_get_irq to pass it directly. > > I changed of_address_to_resource to platform_get_resource for the same > reason. > > It ends up bein

[PATCH] EDAC/powerpc: Remove PPC_MAPLE drivers

2024-11-12 Thread Michael Ellerman
These two drivers are only buildable for the powerpc "maple" platform (CONFIG_PPC_MAPLE), which has now been removed, see commit 62f8f307c80e ("powerpc/64: Remove maple platform"). Remove the drivers. Signed-off-by: Michael Ellerman --- drivers/edac/Kconfig| 18 -- drivers/edac/Makefil

[PATCH] cpufreq: maple: Remove maple driver

2024-11-12 Thread Michael Ellerman
This driver is no longer buildable since the PPC_MAPLE platform was removed, see commit 62f8f307c80e ("powerpc/64: Remove maple platform"). Remove the driver. Note that the comment in the driver says it supports "SMU & 970FX based G5 Macs", but that's not true, that comment was copied from pmac64

Re: [PATCH] cpufreq: maple: Remove maple driver

2024-11-12 Thread Viresh Kumar
On 12-11-24, 19:51, Michael Ellerman wrote: > This driver is no longer buildable since the PPC_MAPLE platform was > removed, see commit 62f8f307c80e ("powerpc/64: Remove maple platform"). > > Remove the driver. > > Note that the comment in the driver says it supports "SMU & 970FX > based G5 Macs"

[PATCHv3 net-next] net: modernize IRQ resource acquisition

2024-11-12 Thread Rosen Penev
In probe, np == pdev->dev.of_node. It's easier to pass pdev directly. Replace irq_of_parse_and_map() by platform_get_irq() to do so. Requires removing the error message as well as fixing the return type. Replace of_address_to_resource() with platform_get_resource() for the same reason. Signed-of

Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition

2024-11-12 Thread Florian Fainelli
On 11/12/24 13:14, Rosen Penev wrote: In probe, np == pdev->dev.of_node. It's easier to pass pdev directly. Replace irq_of_parse_and_map() by platform_get_irq() to do so. Requires removing the error message as well as fixing the return type. Replace of_address_to_resource() with platform_get_re

Re: [PATCH v3] mm/kfence: Add a new kunit test test_use_after_free_read_nofault()

2024-11-12 Thread IBM
Marco Elver writes: > On Fri, 18 Oct 2024 at 19:46, Ritesh Harjani (IBM) > wrote: >> >> From: Nirjhar Roy >> >> Faults from copy_from_kernel_nofault() needs to be handled by fixup >> table and should not be handled by kfence. Otherwise while reading >> /proc/kcore which uses copy_from_kernel_no

Re: [RFC v3 -next] cma: Enforce non-zero pageblock_order during cma_init_reserved_mem()

2024-11-12 Thread IBM
"Ritesh Harjani (IBM)" writes: > cma_init_reserved_mem() checks base and size alignment with > CMA_MIN_ALIGNMENT_BYTES. However, some users might call this during > early boot when pageblock_order is 0. That means if base and size does > not have pageblock_order alignment, it can cause functional

Re: [PATCH v2] crash, powerpc: Default to CRASH_DUMP=n on PPC_BOOK3S_32

2024-11-12 Thread Baoquan He
Hi Andrew, On 09/19/24 at 10:57am, Baoquan He wrote: > On 09/17/24 at 12:37pm, Dave Vasilevsky wrote: > > Fixes boot failures on 6.9 on PPC_BOOK3S_32 machines using > > Open Firmware. On these machines, the kernel refuses to boot > > from non-zero PHYSICAL_START, which occurs when CRASH_DUMP is on

Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition

2024-11-12 Thread Jakub Kicinski
On Tue, 12 Nov 2024 13:14:42 -0800 Rosen Penev wrote: > drivers/net/ethernet/moxa/moxart_ether.c | 6 ++--- > .../ethernet/samsung/sxgbe/sxgbe_platform.c | 24 +++ coccicheck says: drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:130:6-26: WARNING: Unsigned expression

Re: [PATCHv3 net-next] net: modernize IRQ resource acquisition

2024-11-12 Thread Marc Kleine-Budde
On 12.11.2024 13:14:42, Rosen Penev wrote: > In probe, np == pdev->dev.of_node. It's easier to pass pdev directly. > > Replace irq_of_parse_and_map() by platform_get_irq() to do so. Requires > removing the error message as well as fixing the return type. > > Replace of_address_to_resource() with

Re: [PATCH v2 6/8] powerpc/entry: factout irqentry-state

2024-11-12 Thread Thomas Gleixner
On Mon, Nov 11 2024 at 11:19, Luming Yu wrote: factout? > To have lowlevel paca.h include high level entry-common.h cause > include file dependency mess. That's not a technical explanation which explains which problem this patch is trying to solve. > Split irqentry-state.h to have the irqentry_

[PATCH v3 1/2] powerpc/fadump: allocate memory for additional parameters early

2024-11-12 Thread Sourabh Jain
From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using memblock. But as slab is already available by this time, allocation happens via the buddy allocator. This may work for radix MMU but is likely to fail in most case

Re: [PATCH v2 8/8] powerpc/entry: fix ppc syscall entry issues for common entry

2024-11-12 Thread Thomas Gleixner
On Mon, Nov 11 2024 at 11:19, Luming Yu wrote: > Due to the common layer and internal calls details are hidden from > the top level at the call side in ppc arch code, there are some > difficulties in preserving > all semantics implications of the original code in the patch. e.g when > we got -1 re

[PATCH v3 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread Sourabh Jain
The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the param memory area is reserved in fadump kernel if it is above boot_mem_top. However, it should be reserved if it is below boot_mem_top because the fadump kernel already pres

linux-next: manual merge of the powerpc tree with the kbuild tree

2024-11-12 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the powerpc tree got a conflict in: arch/powerpc/Makefile between commit: de51342c5157 ("kbuild: add $(objtree)/ prefix to some in-kernel build artifacts") from the kbuild tree and commit: bee08a9e6ab0 ("powerpc: Adjust adding stack protector flags t

Re: [RFC v3 -next] cma: Enforce non-zero pageblock_order during cma_init_reserved_mem()

2024-11-12 Thread Andrew Morton
On Wed, 13 Nov 2024 07:23:43 +0530 Ritesh Harjani (IBM) wrote: > "Ritesh Harjani (IBM)" writes: > > > cma_init_reserved_mem() checks base and size alignment with > > CMA_MIN_ALIGNMENT_BYTES. However, some users might call this during > > early boot when pageblock_order is 0. That means if base

Re: [RFC v3 -next] cma: Enforce non-zero pageblock_order during cma_init_reserved_mem()

2024-11-12 Thread Andrew Morton
On Fri, 11 Oct 2024 20:26:09 +0530 "Ritesh Harjani (IBM)" wrote: > cma_init_reserved_mem() checks base and size alignment with > CMA_MIN_ALIGNMENT_BYTES. However, some users might call this during > early boot when pageblock_order is 0. This sounds like "some users" are in error. Please tell u

Re: [PATCH v2 3/8] powerpc/debug: implement HAVE_USER_RETURN_NOTIFIER

2024-11-12 Thread Thomas Gleixner
On Mon, Nov 11 2024 at 11:19, Luming Yu wrote: > enable the common entry of user return notifier for powerpc as > a debug feature. What's the debug feature? There are ZERO user return notifiers registered in PowerPC, so your "debug feature" is just a waste of CPU cycles. Thanks, tglx

Re: [PATCH v2 5/8] powerpc/entry: add irqentry_state and generic entry support

2024-11-12 Thread Thomas Gleixner
On Mon, Nov 11 2024 at 11:19, Luming Yu wrote: > generic irq entry support via generic irqentry is added for powerpc. > There may be duplciate calls and missing callbacks requires further > work. No. This needs to be a transition which is consistent and correct at any stage of the series. You can

Re: [PATCH v2 2/8] powerpc/entry: cleanup syscall entry

2024-11-12 Thread Thomas Gleixner
On Mon, Nov 11 2024 at 11:19, Luming Yu wrote: > cleanup do_syscall_trace_enter/leave and do_seccomp. What's the cleanup here? All what this patch does is removing code, but what replaces that functionality? The subject line should probably be: "Break syscall entry" Thanks, tglx

Re: [PATCH v2] crash, powerpc: Default to CRASH_DUMP=n on PPC_BOOK3S_32

2024-11-12 Thread Dave Vasilevsky
On 2024-09-17 12:37, Dave Vasilevsky wrote: > Fixes boot failures on 6.9 on PPC_BOOK3S_32 machines using > Open Firmware. On these machines, the kernel refuses to boot > from non-zero PHYSICAL_START, which occurs when CRASH_DUMP is on. Hi Eric, and other kexec people, Is there anywhere else I sho

Re: [PATCH v2 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread IBM
Sourabh Jain writes: > Hello Ritesh, > > > On 12/11/24 17:23, Ritesh Harjani (IBM) wrote: >> Ritesh Harjani (IBM) writes: >> >>> Sourabh Jain writes: >>> Hello Ritesh, On 12/11/24 11:51, Ritesh Harjani (IBM) wrote: > Sourabh Jain writes: > >> The param area is a

Re: [PATCH v2 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread Sourabh Jain
Hello Ritesh, On 12/11/24 11:51, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the param memory area is reserved in fadump kernel if it is above boot_mem_top. However,

[PATCH] powerpc/cell: Remove dead extern declaration for spu_priv1_beat_ops

2024-11-12 Thread Michael Ellerman
spu_priv1_beat_ops were removed in commit bf4981a00636 ("powerpc: Remove the celleb support"), remove the unneeded extern. Signed-off-by: Michael Ellerman --- arch/powerpc/include/asm/spu_priv1.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/include/asm/spu_priv1.h b/arch/powe

Re: [PATCH v2 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread IBM
Sourabh Jain writes: > Hello Ritesh, > > > On 12/11/24 11:51, Ritesh Harjani (IBM) wrote: >> Sourabh Jain writes: >> >>> The param area is a memory region where the kernel places additional >>> command-line arguments for fadump kernel. Currently, the param memory >>> area is reserved in fadump k

Re: [PATCH v2 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread IBM
Ritesh Harjani (IBM) writes: > Sourabh Jain writes: > >> Hello Ritesh, >> >> >> On 12/11/24 11:51, Ritesh Harjani (IBM) wrote: >>> Sourabh Jain writes: >>> The param area is a memory region where the kernel places additional command-line arguments for fadump kernel. Currently, the par

[PATCH 07/21] soc/qman: test: Use kthread_run_on_cpu()

2024-11-12 Thread Frederic Weisbecker
Use the proper API instead of open coding it. However it looks like kthreads here could be replaced by the use of a per-cpu workqueue instead. Signed-off-by: Frederic Weisbecker --- drivers/soc/fsl/qbman/qman_test_stash.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH v2 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread Sourabh Jain
Hello Ritesh, On 12/11/24 17:23, Ritesh Harjani (IBM) wrote: Ritesh Harjani (IBM) writes: Sourabh Jain writes: Hello Ritesh, On 12/11/24 11:51, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: The param area is a memory region where the kernel places additional command-line argument

[PATCH v2 1/2] PCI/DPC: Run recovery on device that detected the error

2024-11-12 Thread Shuai Xue
The current implementation of pcie_do_recovery() assumes that the recovery process is executed on the device that detected the error. However, the DPC driver currently passes the error port that experienced the DPC event to pcie_do_recovery(). Use the SOURCE ID register to correctly identify the d

[PATCH v2 2/2] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd

2024-11-12 Thread Shuai Xue
The AER driver has historically avoided reading the configuration space of an endpoint or RCiEP that reported a fatal error, considering the link to that device unreliable. Consequently, when a fatal error occurs, the AER and DPC drivers do not report specific error types, resulting in logs like:

[PATCH v2 0/2] PCI/AER: Report fatal errors of RCiEP and EP if link recoverd

2024-11-12 Thread Shuai Xue
changes since v1: - rewrite commit log per Bjorn - refactor aer_get_device_error_info to reduce duplication per Keith - fix to avoid reporting fatal errors twice for root and downstream ports per Keith The AER driver has historically avoided reading the configuration space of an endpoint or RCiEP

Re: [PATCH v2 1/2] powerpc/fadump: allocate memory for additional parameters early

2024-11-12 Thread Sourabh Jain
Hello Ritesh On 12/11/24 12:33, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: From: Hari Bathini Memory for passing additional parameters to fadump capture kernel is allocated during subsys_initcall level, using memblock. But as slab is already available by this time, allocation happens

[RESEND PATCH v5 1/6] ALSA: compress: Add output rate and output format support

2024-11-12 Thread Shengjiu Wang
Add 'pcm_format' for struct snd_codec, add 'pcm_formats' for struct snd_codec_desc, these are used for accelerator usage. Current accelerator example is sample rate converter (SRC). Define struct snd_codec_desc_src for descript minmum and maxmum sample rates. And add 'src_d' in union snd_codec_opt

[RESEND PATCH v5 3/6] ASoC: fsl_easrc: define functions for memory to memory usage

2024-11-12 Thread Shengjiu Wang
ASRC can be used on memory to memory case, define several functions for m2m usage and export them as function pointer. Signed-off-by: Shengjiu Wang Acked-by: Jaroslav Kysela --- sound/soc/fsl/fsl_easrc.c | 228 ++ sound/soc/fsl/fsl_easrc.h | 4 + 2 files ch

[RESEND PATCH v5 2/6] ASoC: fsl_asrc: define functions for memory to memory usage

2024-11-12 Thread Shengjiu Wang
ASRC can be used on memory to memory case, define several functions for m2m usage. m2m_prepare: prepare for the start step m2m_start: the start step m2m_unprepare: unprepare for stop step, optional m2m_stop: stop step m2m_check_format: check format is supported or not m2m_calc_out_len: calculate o

[RESEND PATCH v5 4/6] ASoC: fsl_asrc_m2m: Add memory to memory function

2024-11-12 Thread Shengjiu Wang
Implement the ASRC memory to memory function using the compress framework, user can use this function with compress ioctl interface. This feature can be shared by ASRC and EASRC drivers Signed-off-by: Shengjiu Wang Acked-by: Jaroslav Kysela --- sound/soc/fsl/Kconfig | 1 + sound/so

[RESEND PATCH v5 6/6] ASoC: fsl_easrc: register m2m platform device

2024-11-12 Thread Shengjiu Wang
Register m2m platform device,that user can use M2M feature. Signed-off-by: Shengjiu Wang Acked-by: Jaroslav Kysela --- sound/soc/fsl/fsl_easrc.c | 33 +++-- 1 file changed, 31 insertions(+), 2 deletions(-) diff --git a/sound/soc/fsl/fsl_easrc.c b/sound/soc/fsl/fsl_e

[RESEND PATCH v5 5/6] ASoC: fsl_asrc: register m2m platform device

2024-11-12 Thread Shengjiu Wang
Register m2m platform device, that user can use M2M feature. Signed-off-by: Shengjiu Wang Acked-by: Jaroslav Kysela --- sound/soc/fsl/fsl_asrc.c | 37 + 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fs

[RESEND PATCH v5 0/6] ASoC: fsl: add memory to memory function for ASRC

2024-11-12 Thread Shengjiu Wang
This function is base on the accelerator implementation for compress API: https://patchwork.kernel.org/project/alsa-devel/patch/20241002093904.1809799-1-pe...@perex.cz/ Audio signal processing also has the requirement for memory to memory similar as Video. This asrc memory to memory (memory ->asr

Re: [PATCH v2 2/2] fadump: reserve param area if below boot_mem_top

2024-11-12 Thread Sourabh Jain
Hello Ritesh, On 12/11/24 18:40, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: Hello Ritesh, On 12/11/24 17:23, Ritesh Harjani (IBM) wrote: Ritesh Harjani (IBM) writes: Sourabh Jain writes: Hello Ritesh, On 12/11/24 11:51, Ritesh Harjani (IBM) wrote: Sourabh Jain writes: The