Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring

2022-11-30 Thread Roger Pau Monné
On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: > On Tue, 29 Nov 2022, Roger Pau Monne wrote: > > The hvc machinery registers both a console and a tty device based on > > the hv ops provided by the specific implementation. Those two > > interfaces however have different locks,

Re: [PATCH] macintosh: macio-adb: Fix warning comparing pointer to 0

2022-11-30 Thread Michael Ellerman
On Thu, 17 Mar 2022 17:24:49 +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > Applied to powerpc/next. [1/1] macintosh: macio-adb: Fix warning comparing pointer to 0 https://git.kernel.org/powerpc/c/fc21ed8f26d980428f9b4e08e0fb72c7f7ffc9b8 cheer

Re: [PATCH] macintosh: windfarm_pm121: Fix warning comparing pointer to 0

2022-11-30 Thread Michael Ellerman
On Thu, 17 Mar 2022 10:57:02 +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > Applied to powerpc/next. [1/1] macintosh: windfarm_pm121: Fix warning comparing pointer to 0 https://git.kernel.org/powerpc/c/a823307bf0a3b79b27eea916bf6499ba4377cdf9

Re: [PATCH] macintosh: adb: Fix warning comparing pointer to 0

2022-11-30 Thread Michael Ellerman
On Thu, 17 Mar 2022 10:35:54 +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > Applied to powerpc/next. [1/1] macintosh: adb: Fix warning comparing pointer to 0 https://git.kernel.org/powerpc/c/2f59562c140d3119328f869126e8e593a99a392f cheers

Re: [PATCH] macintosh: windfarm_pm81: Fix warning comparing pointer to 0

2022-11-30 Thread Michael Ellerman
On Thu, 17 Mar 2022 10:32:39 +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > Applied to powerpc/next. [1/1] macintosh: windfarm_pm81: Fix warning comparing pointer to 0 https://git.kernel.org/powerpc/c/e0acfdd13474815696595206e11169736b4bca9d c

Re: [PATCH] macintosh: windfarm_pm91: Fix warning comparing pointer to 0

2022-11-30 Thread Michael Ellerman
On Thu, 17 Mar 2022 10:42:33 +0800, Haowen Bai wrote: > Avoid pointer type value compared with 0 to make code clear. > > Applied to powerpc/next. [1/1] macintosh: windfarm_pm91: Fix warning comparing pointer to 0 https://git.kernel.org/powerpc/c/88316944c3b3aa3ce3249c51689ef1621049df9d c

Re: [PATCH v3 -next] powerpc/powermac: Fix symbol not declared warnings

2022-11-30 Thread Michael Ellerman
On Thu, 3 Nov 2022 15:01:22 +0800, Chen Lifu wrote: > 1. ppc_override_l2cr and ppc_override_l2cr_value are only used in > l2cr_init() function, remove them and used *l2cr directly. > 2. has_l2cache is not used outside of the file, so mark it static and > do not initialise statics to 0. > >

Re: [PATCH] powerpc: platforms: 52xx: Fix a resource leak in an error handling path

2022-11-30 Thread Michael Ellerman
On Sat, 29 Jan 2022 08:16:04 +0100, Christophe JAILLET wrote: > The error handling path of mpc52xx_lpbfifo_probe() and a request_irq() is > not balanced by a corresponding free_irq(). > > Add the missing call, as already done in the remove function. > > Applied to powerpc/next. [1/1] powerpc:

Re: [PATCH] powerpc/sysdev: Remove some duplicate prefix in some messages

2022-11-30 Thread Michael Ellerman
On Sun, 9 Oct 2022 12:49:50 +0200, Christophe JAILLET wrote: > At the beginning of the file, we have: >#define pr_fmt(fmt) "xive: " fmt > > So, there is no need to duplicate "XIVE:" in debug and error messages. > > For the records, these useless prefix have been added in commit > 5af50993850a

Re: [PATCH] powerpc/8xx: Reverse order entries are written by __set_pte_at()

2022-11-30 Thread Michael Ellerman
On Wed, 28 Sep 2022 08:29:22 +0200, Christophe Leroy wrote: > At the time being, with 16k pages __set_pte_at() writes table entries > in reverse order: > > 294: 91 49 00 0c stw r10,12(r9) > 298: 91 49 00 08 stw r10,8(r9) > 29c: 91 49 00 04 stw r10,4(r9) > 2a0: 91 49 00

Re: [PATCH] powerpc/8xx: Simplify pte_update() with 16k pages

2022-11-30 Thread Michael Ellerman
On Wed, 28 Sep 2022 08:29:00 +0200, Christophe Leroy wrote: > While looking at code generated for code patching, I saw that > pte_clear generated: > > 2d8: 38 a0 00 00 li r5,0 > 2dc: 38 e0 10 00 li r7,4096 > 2e0: 39 00 20 00 li r8,8192 > 2e4: 39 40 30 00 li

Re: [PATCH] powerpc: Remove find_current_mm_pte()

2022-11-30 Thread Michael Ellerman
On Wed, 9 Mar 2022 10:29:50 +0100, Christophe Leroy wrote: > Last usage of find_current_mm_pte() was removed by > commit 15759cb054ef ("powerpc/perf/callchain: Use > __get_user_pages_fast in read_user_stack_slow") > > Remove it. > > > [...] Applied to powerpc/next. [1/1] powerpc: Remove find_c

Re: [PATCH] selftests/powerpc: Fix spelling mistake "mmaping" -> "mmapping"

2022-11-30 Thread Michael Ellerman
On Fri, 21 Oct 2022 09:45:45 +0100, Colin Ian King wrote: > There is a spelling mistake in a perror message. Fix it. > > Applied to powerpc/next. [1/1] selftests/powerpc: Fix spelling mistake "mmaping" -> "mmapping" https://git.kernel.org/powerpc/c/04757c5e21ea17615b66f45e38f1cab32a7a0654

Re: [PATCH] drivers/ps3: Fix double word in comments

2022-11-30 Thread Michael Ellerman
On Sun, 4 Sep 2022 11:51:02 -0400, Shaomin Deng wrote: > Drop the repeated word "when" in comments. > > Applied to powerpc/next. [1/1] drivers/ps3: Fix double word in comments https://git.kernel.org/powerpc/c/ff8fae94e26f5cd2779ceda0ee6d714a10501abd cheers

Re: [PATCH] selftests/powerpc: Remove repeated word in comments

2022-11-30 Thread Michael Ellerman
On Sat, 29 Oct 2022 05:46:43 -0400, Shaomin Deng wrote: > Remove the repeated word "not" in comments. > > Applied to powerpc/next. [1/1] selftests/powerpc: Remove repeated word in comments https://git.kernel.org/powerpc/c/ad8284ead833379fc57d90e50dbae1352b116c2b cheers

Re: [PATCH v2 0/2] Remove unused macros from asm-offset

2022-11-30 Thread Michael Ellerman
On Fri, 16 Sep 2022 16:27:34 +0530, Disha Goel wrote: > The kvm code was refactored to convert some of kvm assembly routines to C. > This includes commits which moved code path for the kvm guest entry/exit > for p7/8 from aseembly to C. As part of the code changes, usage of some of > the macros wer

Re: [PATCH] powerpc/sgy_cts1000: convert to using gpiod API and facelift

2022-11-30 Thread Michael Ellerman
On Tue, 27 Sep 2022 12:23:58 -0700, Dmitry Torokhov wrote: > This patch converts the driver to newer gpiod API, and away from > OF-specific legacy gpio API that we want to stop using. > > While at it, let's address a few more issues: > > - switch to using dev_info()/pr_info() and friends > - canc

Re: [PATCH] powerpc/warp: switch to using gpiod API

2022-11-30 Thread Michael Ellerman
On Mon, 26 Sep 2022 23:03:25 -0700, Dmitry Torokhov wrote: > This switches PIKA Warp away from legacy gpio API and to newer gpiod > API, so that we can eventually deprecate the former. > > Because LEDs are normally driven by leds-gpio driver, but the > platform code also wants to access the LEDs d

Re: [PATCH v2] macintosh/via-pmu: Avoid compiler warnings when CONFIG_PROC_FS is disabled

2022-11-30 Thread Michael Ellerman
On Mon, 21 Mar 2022 20:28:00 +1100, Finn Thain wrote: > drivers/macintosh/via-pmu.c:897:12: warning: 'pmu_battery_proc_show' defined > but not used [-Wunused-function] > static int pmu_battery_proc_show(struct seq_file *m, void *v) > ^ > drivers/macintosh/via-pmu.c

Re: [PATCH][next] powerpc/xmon: Fix -Wswitch-unreachable warning in bpt_cmds

2022-11-30 Thread Michael Ellerman
On Fri, 16 Sep 2022 15:15:04 +0100, Gustavo A. R. Silva wrote: > When building with automatic stack variable initialization, GCC 12 > complains about variables defined outside of switch case statements. > Move the variable into the case that uses it, which silences the warning: > > arch/powerpc/xm

Re: [PATCH v2] powerpc/microwatt: Add litesd

2022-11-30 Thread Michael Ellerman
On Fri, 30 Sep 2022 16:20:12 +0930, Joel Stanley wrote: > This is the register layout of the litesd peripheral for the fusesoc > based Microwatt SoC. > > It requires a description of the system clock, which is hardcoded to > 100MHz. > > > [...] Applied to powerpc/next. [1/1] powerpc/microwatt:

Re: [PATCH] cxl: fix typo in comment

2022-11-30 Thread Michael Ellerman
On Sat, 21 May 2022 13:11:32 +0200, Julia Lawall wrote: > Spelling mistake (triple letters) in comment. > Detected with the help of Coccinelle. > > Applied to powerpc/next. [1/1] cxl: fix typo in comment https://git.kernel.org/powerpc/c/37195edebf479b94f1e20c2a83a29e4beebe7ff5 cheers

Re: [PATCH] cxl: Fix refcount leak in cxl_calc_capp_routing

2022-11-30 Thread Michael Ellerman
On Sun, 5 Jun 2022 10:00:38 +0400, Miaoqian Lin wrote: > of_get_next_parent() returns a node pointer with refcount incremented, > we should use of_node_put() on it when not need anymore. > This function only calls of_node_put() in normal path, > missing it in the error path. > Add missing of_node_p

Re: [PATCH] powerpc/pseries/eeh: Fix some kernel-doc warnings

2022-11-30 Thread Michael Ellerman
On Mon, 31 Oct 2022 02:37:06 -0400, Bo Liu wrote: > Fixes the following W=1 kernel build warning(s): > arch/powerpc/platforms/pseries/eeh_pseries.c:163: warning: Function > parameter or member 'config_addr' not described in 'pseries_eeh_phb_reset' > arch/powerpc/platforms/pseries/eeh_pseries.c

Re: (subset) [PATCH 0/5] powerpc/kprobes: preempt related changes and cleanups

2022-11-30 Thread Michael Ellerman
On Thu, 20 Oct 2022 22:58:56 +0530, Naveen N. Rao wrote: > This series attempts to address some of the concerns raised in > https://github.com/linuxppc/issues/issues/440 > > The last two patches are minor cleanups in related kprobes code. > > - Naveen > > [...] Applied to powerpc/next. [1/5] p

Re: [PATCH] powerpc/ftrace: Ignore weak functions

2022-11-30 Thread Michael Ellerman
On Tue, 9 Aug 2022 16:24:25 +0530, Naveen N. Rao wrote: > Extend commit b39181f7c6907d ("ftrace: Add FTRACE_MCOUNT_MAX_OFFSET to > avoid adding weak function") to ppc32 and ppc64 -mprofile-kernel by > defining FTRACE_MCOUNT_MAX_OFFSET. > > For ppc64 -mprofile-kernel ABI, we can have two instructio

Re: [PATCH 1/2] powerpc: Make instruction dump work with scripts/decodecode

2022-11-30 Thread Michael Ellerman
On Thu, 6 Oct 2022 14:20:18 +1100, Michael Ellerman wrote: > Matt reported that scripts/decodecode doesn't work for the instruction > dump in the powerpc oops output. Although there are scripts around that > can decode it, it would be preferable if the standard in-tree script > worked. > > All oth

Re: [PATCH 0/6] powerpc/pseries - bugfixes/cleanups for PLPKS driver

2022-11-30 Thread Michael Ellerman
On Sun, 6 Nov 2022 15:58:33 -0500, Nayna Jain wrote: > This patchset fixes some bugs and does some cleanups. > > Nayna Jain (6): > powerpc/pseries: fix the object owners enum value in plpks driver > powerpc/pseries: Fix the H_CALL error code in PLPKS driver > powerpc/pseries: Return -EIO ins

Re: [PATCH] docs: powerpc: add POWER9 and POWER10 to CPU families

2022-11-30 Thread Michael Ellerman
On Wed, 10 Aug 2022 04:03:21 +, Nicholas Miehlbradt wrote: > Add POWER9 and POWER10 to CPU families and list Radix MMU. > > Applied to powerpc/next. [1/1] docs: powerpc: add POWER9 and POWER10 to CPU families https://git.kernel.org/powerpc/c/addebe1cfa71eb29caa9d5c6bc719171e4e76414 c

Re: [PATCH] powerpc: remove the last remnants of cputime_t

2022-11-30 Thread Michael Ellerman
On Thu, 6 Oct 2022 20:56:53 +1000, Nicholas Piggin wrote: > cputime_t was a core kernel type, removed by commits > ed5c8c854f2b..b672592f0221. As explained in commit b672592f0221 > ("sched/cputime: Remove generic asm headers"), the final cleanup > is for the arch to provide cputime_to_nsec[s](). Co

Re: [PATCH v3] powerpc: add compile-time support for lbarx, lharx

2022-11-30 Thread Michael Ellerman
On Fri, 9 Sep 2022 15:23:12 +1000, Nicholas Piggin wrote: > ISA v2.06 (POWER7 and up) as well as e6500 support lbarx and lharx. > Add a compile option that allows code to use it, and add support in > cmpxchg and xchg 8 and 16 bit values without shifting and masking. > > Applied to powerpc/next.

Re: [PATCH] powerpc/mpc52xx_lpbfifo: fix all kernel-doc warnings

2022-11-30 Thread Michael Ellerman
On Wed, 23 Nov 2022 22:19:18 -0800, Randy Dunlap wrote: > Fix multiple kernel-doc warnings in mpc52xx_lpbfifo.c: > > arch/powerpc/platforms/52xx/mpc52xx_lpbfifo.c:377: warning: expecting > prototype for mpc52xx_lpbfifo_bcom_poll(). Prototype was for > mpc52xx_lpbfifo_poll() instead > > mpc52xx_

Re: [PATCH -next v2] powerpc/mpic_msgr: fix cast removes address space of expression warnings

2022-11-30 Thread Michael Ellerman
On Wed, 19 Oct 2022 14:34:14 +0800, ruanjinjie wrote: > When build Linux kernel, encounter the following warnings: > > ./arch/powerpc/sysdev/mpic_msgr.c:230:38: warning: cast removes address space > '__iomem' of expression > ./arch/powerpc/sysdev/mpic_msgr.c:230:27: warning: incorrect type in >

Re: [PATCH] powerpc/8xx: Fix warning in hw_breakpoint_handler()

2022-11-30 Thread Michael Ellerman
On Mon, 24 Oct 2022 15:13:46 +1100, Russell Currey wrote: > In hw_breakpoint_handler(), ea is set by wp_get_instr_detail() except > for 8xx, leading the variable to be passed uninitialised to > wp_check_constraints(). This is safe as wp_check_constraints() returns > early without using ea, so just

Re: [PATCH] powerpc: suppress some linker warnings in recent linker versions

2022-11-30 Thread Michael Ellerman
On Mon, 10 Oct 2022 16:57:21 +1100, Stephen Rothwell wrote: > This is a follow on from commit > > 0d362be5b142 ("Makefile: link with -z noexecstack --no-warn-rwx-segments") > > for arch/powerpc/boot to address wanrings like: > > ld: warning: opal-calls.o: missing .note.GNU-stack section impl

Re: [PATCH v2] macintosh: via-pmu-backlight: Use backlight helper

2022-11-30 Thread Michael Ellerman
On Thu, 16 Jun 2022 19:04:24 +0200, Stephen Kitt wrote: > backlight_properties.fb_blank is deprecated. The states it represents > are handled by other properties; but instead of accessing those > properties directly, drivers should use the helpers provided by > backlight.h. > > Instead of retrievi

Re: [PATCH] mm: check the return value of ioremap() in macio_init()

2022-11-30 Thread Michael Ellerman
On Tue, 2 Aug 2022 15:41:48 +0800, studentxs...@163.com wrote: > From: Xie Shaowen > > The function ioremap() in macio_init() can fail, so > its return value should be checked. > > Applied to powerpc/next. [1/1] mm: check the return value of ioremap() in macio_init() https://git.kernel.

Re: (subset) [PATCH 000/606] i2c: Complete conversion to i2c_probe_new

2022-11-30 Thread Michael Ellerman
On Fri, 18 Nov 2022 23:35:34 +0100, Uwe Kleine-König wrote: > since commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() > call-back type") from 2016 there is a "temporary" alternative probe > callback for i2c drivers. > > This series completes all drivers to this new callback (unless I mis

Re: [PATCH] powerpc: Fix formatting problems to make code look more beautiful

2022-11-30 Thread Michael Ellerman
On Fri, 1 Jul 2022 05:45:53 -0400, Deming Wang wrote: > Operators should be separated by spaces in tce_buildmulti_pSeriesLP > > Applied to powerpc/next. [1/1] powerpc: Fix formatting problems to make code look more beautiful https://git.kernel.org/powerpc/c/14b5d59a261b1947db287b3b52f4bb1

Re: [PATCH] powerpc/xive: remove unused parameter

2022-11-30 Thread Michael Ellerman
On Wed, 13 Apr 2022 06:55:07 -0400, Deming wrote: > From: Deming Wang > > the parameter xc balongng to xive_cleanup_single_escalation is unused,so we > need to remove it. > > Applied to powerpc/next. [1/1] powerpc/xive: remove unused parameter https://git.kernel.org/powerpc/c/932c6dea4f

Re: [PATCH] powerpc: pasemi: add __init/__exit annotations to module init/exit funcs

2022-11-30 Thread Michael Ellerman
On Sun, 11 Sep 2022 16:43:44 +0800, Xiu Jianfeng wrote: > Add missing __init/__exit annotations to module init/exit funcs. > > Applied to powerpc/next. [1/1] powerpc: pasemi: add __init/__exit annotations to module init/exit funcs https://git.kernel.org/powerpc/c/d87a233717da400792fa601b2

Re: [PATCH] powerpc: Use "grep -E" instead of "egrep"

2022-11-30 Thread Michael Ellerman
On Fri, 18 Nov 2022 17:40:29 +0800, Tiezhu Yang wrote: > The latest version of grep claims the egrep is now obsolete so the build > now contains warnings that look like: > egrep: warning: egrep is obsolescent; using grep -E > fix this up by moving the related file to use "grep -E" instead. >

Re: [PATCH 1/2] cxl: fix possible null-ptr-deref in cxl_guest_init_afu|adapter()

2022-11-30 Thread Michael Ellerman
On Fri, 11 Nov 2022 22:54:39 +0800, Yang Yingliang wrote: > If device_register() fails in cxl_register_afu|adapter(), the device > is not added, device_unregister() can not be called in the error path, > otherwise it will cause a null-ptr-deref because of removing not added > device. > > As commen

Re: [PATCH] misc: ocxl: fix possible name leak in ocxl_file_register_afu()

2022-11-30 Thread Michael Ellerman
On Fri, 11 Nov 2022 22:59:29 +0800, Yang Yingliang wrote: > If device_register() returns error in ocxl_file_register_afu(), > the name allocated by dev_set_name() need be freed. As comment > of device_register() says, it should use put_device() to give > up the reference in the error path. So fix t

Re: [PATCH -next] macintosh: Switch to use for_each_child_of_node() macro

2022-11-30 Thread Michael Ellerman
On Fri, 16 Sep 2022 22:16:38 +0800, Yang Yingliang wrote: > Use for_each_child_of_node() macro instead of open coding it. > No functional change. > > Applied to powerpc/next. [1/1] macintosh: Switch to use for_each_child_of_node() macro https://git.kernel.org/powerpc/c/3aa16303dc98b7b8baa

Re: [PATCH] powerpc/xive: add missing iounmap() in error path in xive_spapr_populate_irq_data()

2022-11-30 Thread Michael Ellerman
On Mon, 17 Oct 2022 11:23:33 +0800, Yang Yingliang wrote: > If remapping 'data->trig_page' fails, the 'data->eoi_mmio' need be unmapped > before returning from xive_spapr_populate_irq_data(). > > Applied to powerpc/next. [1/1] powerpc/xive: add missing iounmap() in error path in xive_spapr_pop

Re: [PATCH v2] macintosh: fix possible memory leak in macio_add_one_device()

2022-11-30 Thread Michael Ellerman
On Fri, 4 Nov 2022 11:25:51 +0800, Yang Yingliang wrote: > Afer commit 1fa5ae857bb1 ("driver core: get rid of struct device's > bus_id string array"), the name of device is allocated dynamically, > it need be freed when of_device_register() fails, call put_device() > to give up the reference that h

Re: [PATCH v2] ocxl: fix pci device refcount leak when calling get_function_0()

2022-11-30 Thread Michael Ellerman
On Mon, 21 Nov 2022 23:43:39 +0800, Yang Yingliang wrote: > get_function_0() calls pci_get_domain_bus_and_slot(), as comment > says, it returns a pci device with refcount increment, so after > using it, pci_dev_put() needs be called. > > Get the device reference when get_function_0() is not called

Re: [PATCH] macintosh/ams/ams: Add header file macro definition

2022-11-30 Thread Michael Ellerman
On Thu, 7 Jul 2022 09:53:52 +0800, Li zeming wrote: > Add header file macro definition. > > Applied to powerpc/next. [1/1] macintosh/ams/ams: Add header file macro definition https://git.kernel.org/powerpc/c/2dfcace75e1e1dfbd89af63fce1bfe8aebe38427 cheers

Re: [PATCH] macintosh/windfarm_pid: Add header file macro definition

2022-11-30 Thread Michael Ellerman
On Thu, 7 Jul 2022 09:59:49 +0800, Li zeming wrote: > I think the header file could avoid redefinition errors. > at compile time by adding macro definitions. > > Applied to powerpc/next. [1/1] macintosh/windfarm_pid: Add header file macro definition https://git.kernel.org/powerpc/c/e3e52

Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring

2022-11-30 Thread Jan Beulich
On 30.11.2022 10:26, Roger Pau Monné wrote: > On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: >> On Tue, 29 Nov 2022, Roger Pau Monne wrote: >>> The hvc machinery registers both a console and a tty device based on >>> the hv ops provided by the specific implementation. Those tw

Re: [PATCH] hvc/xen: prevent concurrent accesses to the shared ring

2022-11-30 Thread Roger Pau Monné
On Wed, Nov 30, 2022 at 10:34:41AM +0100, Jan Beulich wrote: > On 30.11.2022 10:26, Roger Pau Monné wrote: > > On Tue, Nov 29, 2022 at 02:12:10PM -0800, Stefano Stabellini wrote: > >> On Tue, 29 Nov 2022, Roger Pau Monne wrote: > >>> The hvc machinery registers both a console and a tty device based

Re: [syzbot] WARNING in btrfs_free_reserved_data_space_noquota

2022-11-30 Thread Michael Ellerman
syzbot writes: > Hello, > > syzbot found the following issue on: > > HEAD commit:b7b275e60bcd Linux 6.1-rc7 > git tree: upstream > console+strace: https://syzkaller.appspot.com/x/log.txt?x=158a7b7388 > kernel config: https://syzkaller.appspot.com/x/.config?x=2325e409a9a893e1 > dashb

Re: linux-next: build warnings after merge of the powerpc-objtool tree

2022-11-30 Thread Sathvika Vasireddy
On 29/11/22 20:58, Christophe Leroy wrote: Le 29/11/2022 à 16:13, Sathvika Vasireddy a écrit : Hi all, On 25/11/22 09:00, Stephen Rothwell wrote: Hi all, After merging the powerpc-objtool tree, today's linux-next build (powerpc pseries_le_defconfig) produced these warnings: arch/powerpc/k

[PATCH v2] hvc/xen: prevent concurrent accesses to the shared ring

2022-11-30 Thread Roger Pau Monne
The hvc machinery registers both a console and a tty device based on the hv ops provided by the specific implementation. Those two interfaces however have different locks, and there's no single locks that's shared between the tty and the console implementations, hence the driver needs to protect i

Re: [PATCH v3 3/3] block: sed-opal: keyring support for SED keys

2022-11-30 Thread Greg Joyce
On Wed, 2022-11-30 at 08:00 +0100, Hannes Reinecke wrote: > On 11/30/22 00:25, gjo...@linux.vnet.ibm.com wrote: > > From: Greg Joyce > > > > Extend the SED block driver so it can alternatively > > obtain a key from a sed-opal kernel keyring. The SED > > ioctls will indicate the source of the key,

[PATCH v2] hvc/xen: lock console list traversal

2022-11-30 Thread Roger Pau Monne
The currently lockless access to the xen console list in vtermno_to_xencons() is incorrect, as additions and removals from the list can happen anytime, and as such the traversal of the list to get the private console data for a given termno needs to happen with the lock held. Note users that modif

[linux-next:master] BUILD REGRESSION 700e0cd3a5ce6a2cb90d9a2aab729b52f092a7d6

2022-11-30 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 700e0cd3a5ce6a2cb90d9a2aab729b52f092a7d6 Add linux-next specific files for 20221130 Error/Warning reports: https://lore.kernel.org/oe-kbuild-all/202211090634.ryfkk0ws-...@intel.com https

[PATCH v3] powerpc/hv-gpci: Fix hv_gpci event list

2022-11-30 Thread Kajol Jain
Based on getPerfCountInfo v1.018 documentation, some of the hv_gpci events were deprecated for platform firmware that supports counter_info_version 0x8 or above. Fix the hv_gpci event list by adding a new attribute group called "hv_gpci_event_attrs_v6" and a "ENABLE_EVENTS_COUNTERINFO_V6" macro to

[PATCH v5 1/3] block: sed-opal: SED Opal keystore

2022-11-30 Thread gjoyce
From: Greg Joyce Add read and write functions that allow SED Opal keys to stored in a permanent keystore. Signed-off-by: Greg Joyce Reviewed-by: Jonathan Derrick --- block/Makefile | 2 +- block/sed-opal-key.c | 23 +++ include/linux/sed-opal-key.h |

[PATCH v5 2/3] powerpc/pseries: PLPKS SED Opal keystore support

2022-11-30 Thread gjoyce
From: Greg Joyce Define operations for SED Opal to read/write keys from POWER LPAR Platform KeyStore(PLPKS). This allows for non-volatile storage of SED Opal keys. Signed-off-by: Greg Joyce Reviewed-by: Jonathan Derrick --- arch/powerpc/platforms/pseries/Makefile | 1 + .../powerpc/pl

[PATCH v5 3/3] block: sed-opal: keystore access for SED Opal keys

2022-11-30 Thread gjoyce
From: Greg Joyce Allow for permanent SED authentication keys by reading/writing to the SED Opal non-volatile keystore. Signed-off-by: Greg Joyce Reviewed-by: Jonathan Derrick --- block/sed-opal.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/block/sed

[PATCH v5 0/3] generic and PowerPC SED Opal keystore

2022-11-30 Thread gjoyce
From: Greg Joyce Changelog v5: - added check for key length based on review comment by "Elliott, Robert (Servers)" Changelog v4: - scope reduced to cover just SED Opal keys - base SED Opal keystore is now in SED block driver - removed use of enum to ind

Re: [RFC PATCH] Disable Book-E KVM support?

2022-11-30 Thread Crystal Wood
On Mon, 2022-11-28 at 14:36 +1000, Nicholas Piggin wrote: > BookE KVM is in a deep maintenance state, I'm not sure how much testing > it gets. I don't have a test setup, and it does not look like QEMU has > any HV architecture enabled. It hasn't been too painful but there are > some cases where it

[Bug 216713] BUG: Bad page map in process init pte:c0ab684c pmd:01182000 (on a PowerMac G4 DP)

2022-11-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=216713 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added Status|NEW |RESOLVED Resol

Re: [PATCH 32/44] KVM: x86: Unify pr_fmt to use module name for all KVM modules

2022-11-30 Thread Sean Christopherson
On Thu, Nov 10, 2022, Sean Christopherson wrote: > On Thu, Nov 10, 2022, Robert Hoo wrote: > > After this patch set, still find some printk()s left in arch/x86/kvm/*, > > consider clean all of them up? > > Hmm, yeah, I suppose at this point it makes sense to tack on a patch to clean > them up. Ac

[PATCH v2 01/50] KVM: Register /dev/kvm as the _very_ last thing during initialization

2022-11-30 Thread Sean Christopherson
Register /dev/kvm, i.e. expose KVM to userspace, only after all other setup has completed. Once /dev/kvm is exposed, userspace can start invoking KVM ioctls, creating VMs, etc... If userspace creates a VM before KVM is done with its configuration, bad things may happen, e.g. KVM will fail to prop

[PATCH v2 00/50] KVM: Rework kvm_init() and hardware enabling

2022-11-30 Thread Sean Christopherson
The main theme of this series is to kill off kvm_arch_init(), kvm_arch_hardware_(un)setup(), and kvm_arch_check_processor_compat(), which all originated in x86 code from way back when, and needlessly complicate both common KVM code and architecture code. E.g. many architectures don't mark function

[PATCH v2 02/50] KVM: Initialize IRQ FD after arch hardware setup

2022-11-30 Thread Sean Christopherson
Move initialization of KVM's IRQ FD workqueue below arch hardware setup as a step towards consolidating arch "init" and "hardware setup", and eventually towards dropping the hooks entirely. There is no dependency on the workqueue being created before hardware setup, the workqueue is used only when

[PATCH v2 03/50] KVM: Allocate cpus_hardware_enabled after arch hardware setup

2022-11-30 Thread Sean Christopherson
Allocate cpus_hardware_enabled after arch hardware setup so that arch "init" and "hardware setup" are called back-to-back and thus can be combined in a future patch. cpus_hardware_enabled is never used before kvm_create_vm(), i.e. doesn't have a dependency with hardware setup and only needs to be

[PATCH v2 04/50] KVM: Teardown VFIO ops earlier in kvm_exit()

2022-11-30 Thread Sean Christopherson
Move the call to kvm_vfio_ops_exit() further up kvm_exit() to try and bring some amount of symmetry to the setup order in kvm_init(), and more importantly so that the arch hooks are invoked dead last by kvm_exit(). This will allow arch code to move away from the arch hooks without any change in ord

[PATCH v2 05/50] KVM: s390: Unwind kvm_arch_init() piece-by-piece() if a step fails

2022-11-30 Thread Sean Christopherson
In preparation for folding kvm_arch_hardware_setup() into kvm_arch_init(), unwind initialization one step at a time instead of simply calling kvm_arch_exit(). Using kvm_arch_exit() regardless of which initialization step failed relies on all affected state playing nice with being undone even if sa

[PATCH v2 06/50] KVM: s390: Move hardware setup/unsetup to init/exit

2022-11-30 Thread Sean Christopherson
Now that kvm_arch_hardware_setup() is called immediately after kvm_arch_init(), fold the guts of kvm_arch_hardware_(un)setup() into kvm_arch_{init,exit}() as a step towards dropping one of the hooks. No functional change intended. Signed-off-by: Sean Christopherson Reviewed-by: Eric Farman ---

[PATCH v2 07/50] KVM: x86: Do timer initialization after XCR0 configuration

2022-11-30 Thread Sean Christopherson
Move kvm_arch_init()'s call to kvm_timer_init() down a few lines below the XCR0 configuration code. A future patch will move hardware setup into kvm_arch_init() and slot in vendor hardware setup before the call to kvm_timer_init() so that timer initialization (among other stuff) doesn't need to be

[PATCH v2 08/50] KVM: x86: Move hardware setup/unsetup to init/exit

2022-11-30 Thread Sean Christopherson
Now that kvm_arch_hardware_setup() is called immediately after kvm_arch_init(), fold the guts of kvm_arch_hardware_(un)setup() into kvm_arch_{init,exit}() as a step towards dropping one of the hooks. To avoid having to unwind various setup, e.g registration of several notifiers, slot in the vendor

[PATCH v2 09/50] KVM: Drop arch hardware (un)setup hooks

2022-11-30 Thread Sean Christopherson
Drop kvm_arch_hardware_setup() and kvm_arch_hardware_unsetup() now that all implementations are nops. No functional change intended. Signed-off-by: Sean Christopherson Reviewed-by: Eric Farman # s390 Acked-by: Anup Patel --- arch/arm64/include/asm/kvm_host.h | 1 - arch/arm64/kvm/arm.c

[PATCH v2 10/50] KVM: VMX: Reset eVMCS controls in VP assist page during hardware disabling

2022-11-30 Thread Sean Christopherson
Reset the eVMCS controls in the per-CPU VP assist page during hardware disabling instead of waiting until kvm-intel's module exit. The controls are activated if and only if KVM creates a VM, i.e. don't need to be reset if hardware is never enabled. Doing the reset during hardware disabling will n

[PATCH v2 11/50] KVM: VMX: Don't bother disabling eVMCS static key on module exit

2022-11-30 Thread Sean Christopherson
Don't disable the eVMCS static key on module exit, kvm_intel.ko owns the key so there can't possibly be users after the kvm_intel.ko is unloaded, at least not without much bigger issues. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 4 1 file changed, 4 deletions(-) diff

[PATCH v2 12/50] KVM: VMX: Move Hyper-V eVMCS initialization to helper

2022-11-30 Thread Sean Christopherson
Move Hyper-V's eVMCS initialization to a dedicated helper to clean up vmx_init(), and add a comment to call out that the Hyper-V init code doesn't need to be unwound if vmx_init() ultimately fails. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/vmx.c | 73

[PATCH v2 13/50] KVM: x86: Move guts of kvm_arch_init() to standalone helper

2022-11-30 Thread Sean Christopherson
Move the guts of kvm_arch_init() to a new helper, kvm_x86_vendor_init(), so that VMX can do _all_ arch and vendor initialization before calling kvm_init(). Calling kvm_init() must be the _very_ last step during init, as kvm_init() exposes /dev/kvm to userspace, i.e. allows creating VMs. No functi

[PATCH v2 14/50] KVM: VMX: Do _all_ initialization before exposing /dev/kvm to userspace

2022-11-30 Thread Sean Christopherson
Call kvm_init() only after _all_ setup is complete, as kvm_init() exposes /dev/kvm to userspace and thus allows userspace to create VMs (and call other ioctls). E.g. KVM will encounter a NULL pointer when attempting to add a vCPU to the per-CPU loaded_vmcss_on_cpu list if userspace is able to crea

[PATCH v2 15/50] KVM: x86: Serialize vendor module initialization (hardware setup)

2022-11-30 Thread Sean Christopherson
Acquire a new mutex, vendor_module_lock, in kvm_x86_vendor_init() while doing hardware setup to ensure that concurrent calls are fully serialized. KVM rejects attempts to load vendor modules if a different module has already been loaded, but doesn't handle the case where multiple vendor modules are

[PATCH v2 16/50] KVM: arm64: Simplify the CPUHP logic

2022-11-30 Thread Sean Christopherson
From: Marc Zyngier For a number of historical reasons, the KVM/arm64 hotplug setup is pretty complicated, and we have two extra CPUHP notifiers for vGIC and timers. It looks pretty pointless, and gets in the way of further changes. So let's just expose some helpers that can be called from the co

[PATCH v2 17/50] KVM: arm64: Free hypervisor allocations if vector slot init fails

2022-11-30 Thread Sean Christopherson
Teardown hypervisor mode if vector slot setup fails in order to avoid leaking any allocations done by init_hyp_mode(). Fixes: b881cdce77b4 ("KVM: arm64: Allocate hyp vectors statically") Signed-off-by: Sean Christopherson --- arch/arm64/kvm/arm.c | 15 --- 1 file changed, 8 insertion

[PATCH v2 18/50] KVM: arm64: Unregister perf callbacks if hypervisor finalization fails

2022-11-30 Thread Sean Christopherson
Undo everything done by init_subsystems() if a later initialization step fails, i.e. unregister perf callbacks in addition to unregistering the power management notifier. Fixes: bfa79a805454 ("KVM: arm64: Elevate hypervisor mappings creation at EL2") Signed-off-by: Sean Christopherson --- arch/a

[PATCH v2 19/50] KVM: arm64: Do arm/arch initialization without bouncing through kvm_init()

2022-11-30 Thread Sean Christopherson
Do arm/arch specific initialization directly in arm's module_init(), now called kvm_arm_init(), instead of bouncing through kvm_init() to reach kvm_arch_init(). Invoking kvm_arch_init() is the very first action performed by kvm_init(), so from a initialization perspective this is a glorified nop.

[PATCH v2 20/50] KVM: arm64: Mark kvm_arm_init() and its unique descendants as __init

2022-11-30 Thread Sean Christopherson
Tag kvm_arm_init() and its unique helper as __init, and tag data that is only ever modified under the kvm_arm_init() umbrella as read-only after init. Opportunistically name the boolean param in kvm_timer_hyp_init()'s prototype to match its definition. Signed-off-by: Sean Christopherson --- arc

[PATCH v2 21/50] KVM: MIPS: Hardcode callbacks to hardware virtualization extensions

2022-11-30 Thread Sean Christopherson
Now that KVM no longer supports trap-and-emulate (see commit 45c7e8af4a5e "MIPS: Remove KVM_TE support"), hardcode the MIPS callbacks to the virtualization callbacks. Harcoding the callbacks eliminates the technically-unnecessary check on non-NULL kvm_mips_callbacks in kvm_arch_init(). MIPS has n

[PATCH v2 22/50] KVM: MIPS: Setup VZ emulation? directly from kvm_mips_init()

2022-11-30 Thread Sean Christopherson
Invoke kvm_mips_emulation_init() directly from kvm_mips_init() instead of bouncing through kvm_init()=>kvm_arch_init(). Functionally, this is a glorified nop as invoking kvm_arch_init() is the very first action performed by kvm_init(). Emptying kvm_arch_init() will allow dropping the hook entirel

[PATCH v2 23/50] KVM: MIPS: Register die notifier prior to kvm_init()

2022-11-30 Thread Sean Christopherson
Call kvm_init() only after _all_ setup is complete, as kvm_init() exposes /dev/kvm to userspace and thus allows userspace to create VMs (and call other ioctls). Signed-off-by: Sean Christopherson Reviewed-by: Philippe Mathieu-Daudé --- arch/mips/kvm/mips.c | 9 + 1 file changed, 5 inser

[PATCH v2 24/50] KVM: RISC-V: Do arch init directly in riscv_kvm_init()

2022-11-30 Thread Sean Christopherson
Fold the guts of kvm_arch_init() into riscv_kvm_init() instead of bouncing through kvm_init()=>kvm_arch_init(). Functionally, this is a glorified nop as invoking kvm_arch_init() is the very first action performed by kvm_init(). Moving setup to riscv_kvm_init(), which is tagged __init, will allow

[PATCH v2 25/50] KVM: RISC-V: Tag init functions and data with __init, __ro_after_init

2022-11-30 Thread Sean Christopherson
Now that KVM setup is handled directly in riscv_kvm_init(), tag functions and data that are used/set only during init with __init/__ro_after_init. Signed-off-by: Sean Christopherson Acked-by: Anup Patel --- arch/riscv/include/asm/kvm_host.h | 6 +++--- arch/riscv/kvm/mmu.c | 12 ++

[PATCH v2 26/50] KVM: PPC: Move processor compatibility check to module init

2022-11-30 Thread Sean Christopherson
Move KVM PPC's compatibility checks to their respective module_init() hooks, there's no need to wait until KVM's common compat check, nor is there a need to perform the check on every CPU (provided by common KVM's hook), as the compatibility checks operate on global data. arch/powerpc/include/as

[PATCH v2 27/50] KVM: s390: Do s390 specific init without bouncing through kvm_init()

2022-11-30 Thread Sean Christopherson
Move the guts of kvm_arch_init() into a new helper, __kvm_s390_init(), and invoke the new helper directly from kvm_s390_init() instead of bouncing through kvm_init(). Invoking kvm_arch_init() is the very first action performed by kvm_init(), i.e. this is a glorified nop. Moving setup to __kvm_s39

[PATCH v2 28/50] KVM: s390: Mark __kvm_s390_init() and its descendants as __init

2022-11-30 Thread Sean Christopherson
Tag __kvm_s390_init() and its unique helpers as __init. These functions are only ever called during module_init(), but could not be tagged accordingly while they were invoked from the common kvm_arch_init(), which is not __init because of x86. Signed-off-by: Sean Christopherson Reviewed-by: Eric

[PATCH v2 29/50] KVM: Drop kvm_arch_{init,exit}() hooks

2022-11-30 Thread Sean Christopherson
Drop kvm_arch_init() and kvm_arch_exit() now that all implementations are nops. No functional change intended. Signed-off-by: Sean Christopherson Reviewed-by: Eric Farman # s390 Reviewed-by: Philippe Mathieu-Daudé Acked-by: Anup Patel --- arch/arm64/kvm/arm.c| 11 ---

[PATCH v2 30/50] KVM: VMX: Make VMCS configuration/capabilities structs read-only after init

2022-11-30 Thread Sean Christopherson
Tag vmcs_config and vmx_capability structs as __init, the canonical configuration is generated during hardware_setup() and must never be modified after that point. Signed-off-by: Sean Christopherson --- arch/x86/kvm/vmx/capabilities.h | 4 ++-- arch/x86/kvm/vmx/vmx.c | 4 ++-- 2 files c

[PATCH v2 31/50] KVM: x86: Do CPU compatibility checks in x86 code

2022-11-30 Thread Sean Christopherson
Move the CPU compatibility checks to pure x86 code, i.e. drop x86's use of the common kvm_x86_check_cpu_compat() arch hook. x86 is the only architecture that "needs" to do per-CPU compatibility checks, moving the logic to x86 will allow dropping the common code, and will also give x86 more control

[PATCH 1/5] dt-bindings: net: qca,ar71xx: remove label = "cpu" from examples

2022-11-30 Thread Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from the examples. Signed-off-by: Arınç ÜNAL --- Documentation/devicetree/bindings/net/qca,ar71xx.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/qca,ar71xx.yaml b/Documentation/devicetree/binding

[PATCH 2/5] arm: dts: remove label = "cpu" from DSA dt-binding

2022-11-30 Thread Arınç ÜNAL
This is not used by the DSA dt-binding, so remove it from all devicetrees. Signed-off-by: Arınç ÜNAL --- arch/arm/boot/dts/armada-370-rd.dts | 1 - arch/arm/boot/dts/armada-381-netgear-gs110emx.dts | 1 - arch/arm/boot/dts/armada-385-clearfog-gtr-l8.dts | 1

  1   2   >