On Fri, 11 Nov 2022 22:54:39 +0800, Yang Yingliang wrote: > If device_register() fails in cxl_register_afu|adapter(), the device > is not added, device_unregister() can not be called in the error path, > otherwise it will cause a null-ptr-deref because of removing not added > device. > > As comment of device_register() says, it should use put_device() to give > up the reference in the error path. So split device_unregister() into > device_del() and put_device(), then goes to put dev when register fails. > > [...]
Applied to powerpc/next. [1/2] cxl: fix possible null-ptr-deref in cxl_guest_init_afu|adapter() https://git.kernel.org/powerpc/c/f949ccee1dde970bc77dc871b4f0b5e651577344 [2/2] cxl: fix possible null-ptr-deref in cxl_pci_init_afu|adapter() https://git.kernel.org/powerpc/c/8bf03f557d6c6e108cf47bea32f4a68e276e1157 cheers