Re: [PATCH 17/28] mm: remove the prot argument from vm_map_ram

2020-04-08 Thread Gao Xiang
On Wed, Apr 08, 2020 at 01:59:15PM +0200, Christoph Hellwig wrote: > This is always GFP_KERNEL - for long term mappings with other properties > vmap should be used. > > Signed-off-by: Christoph Hellwig > --- > drivers/gpu/drm/i915/gem/selftests/mock_dmabuf.c | 2 +- > drivers/media/common/vide

[PATCHv2 1/2] powerpc/pseries: group lmb operation and memblock's

2020-04-08 Thread Pingfan Liu
This patch prepares for the incoming patch which swaps the order of KOBJ_ uevent and dt's updating. It has no functional effect, just groups lmb operation and memblock's in order to insert dt updating operation easily, and makes it easier to review. Signed-off-by: Pingfan Liu Cc: Michael Ellerma

[PATCHv2 2/2] powerpc/pseries: update device tree before ejecting hotplug uevents

2020-04-08 Thread Pingfan Liu
A bug is observed on pseries by taking the following steps on rhel: -1. drmgr -c mem -r -q 5 -2. echo c > /proc/sysrq-trigger And then, the failure looks like: kdump: saving to /sysroot//var/crash/127.0.0.1-2020-01-16-02:06:14/ kdump: saving vmcore-dmesg.txt kdump: saving vmcore-dmesg.txt complete

Re: [PATCH v1 1/2] powerpc/pseries/hotplug-memory: stop checking is_mem_section_removable()

2020-04-08 Thread piliu
On 04/08/2020 10:46 AM, Baoquan He wrote: > Add Pingfan to CC since he usually handles ppc related bugs for RHEL. > > On 04/07/20 at 03:54pm, David Hildenbrand wrote: >> In commit 53cdc1cb29e8 ("drivers/base/memory.c: indicate all memory >> blocks as removable"), the user space interface to com

Re: Linux-next POWER9 NULL pointer NIP since 1st Apr.

2020-04-08 Thread Qian Cai
> On Apr 7, 2020, at 9:30 AM, Steven Rostedt wrote: > > On Tue, 7 Apr 2020 09:01:10 -0400 > Qian Cai wrote: > >> + Steven >> >>> On Apr 7, 2020, at 8:42 AM, Michael Ellerman wrote: >>> >>> Qian Cai writes: Ever since 1st Apr, linux-next starts to trigger a NULL pointer NIP on >>>

Re: [RFC PATCH v0 0/5] powerpc/mm/radix: Memory unplug fixes

2020-04-08 Thread Bharata B Rao
On Mon, Apr 06, 2020 at 09:19:20AM +0530, Bharata B Rao wrote: > Memory unplug has a few bugs which I had attempted to fix ealier > at https://lists.ozlabs.org/pipermail/linuxppc-dev/2019-July/194087.html > > Now with Leonardo's patch for PAPR changes that add a separate flag bit > to LMB flags fo

Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

2020-04-08 Thread Jordan Niethe
On Thu, Apr 9, 2020 at 4:21 AM Segher Boessenkool wrote: > > Hi! > > On Mon, Apr 06, 2020 at 06:09:20PM +1000, Jordan Niethe wrote: > > +static inline int ppc_inst_opcode(u32 x) > > +{ > > + return x >> 26; > > +} > > Maybe you should have "primary opcode" in this function name? Thanks, that i

Re: [PATCH v5 13/21] powerpc/xmon: Use a function for reading instructions

2020-04-08 Thread Balamuruhan S
On Wed, 2020-04-08 at 12:18 +1000, Jordan Niethe wrote: > On Tue, Apr 7, 2020 at 9:31 PM Balamuruhan S wrote: > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > > Currently in xmon, mread() is used for reading instructions. In > > > preparation for prefixed instructions, create and us

Re: [PATCH v5 13/21] powerpc/xmon: Use a function for reading instructions

2020-04-08 Thread Jordan Niethe
On Thu, Apr 9, 2020 at 3:04 PM Balamuruhan S wrote: > > On Wed, 2020-04-08 at 12:18 +1000, Jordan Niethe wrote: > > On Tue, Apr 7, 2020 at 9:31 PM Balamuruhan S wrote: > > > On Mon, 2020-04-06 at 18:09 +1000, Jordan Niethe wrote: > > > > Currently in xmon, mread() is used for reading instructions

Re: [PATCH 31/35] powerpc: docs: cxl.rst: mark two section titles as such

2020-04-08 Thread Mauro Carvalho Chehab
Em Thu, 9 Apr 2020 10:37:52 +1000 Andrew Donnellan escreveu: > On 9/4/20 1:46 am, Mauro Carvalho Chehab wrote: > > The User API chapter contains two sub-chapters. Mark them as > > such. > > > > Signed-off-by: Mauro Carvalho Chehab > > Thanks. > > Though the other subsections in this file us

Re: [PATCH v5 02/21] powerpc/xmon: Move out-of-line instructions to text section

2020-04-08 Thread Christophe Leroy
Le 06/04/2020 à 10:09, Jordan Niethe a écrit : To execute an instruction out of line after a breakpoint, the NIP is set to the address of struct bpt::instr. Here a copy of the instruction that was replaced with a breakpoint is kept, along with a trap so normal flow can be resumed after XOLing.

[PATCH] powernv/pci: Print an error when device enable is blocked

2020-04-08 Thread Oliver O'Halloran
If the platform decides to block enabling the device nothing is printed currently. This can lead to some confusion since the dmesg output will usually print an error with no context e.g. e1000e: probe of 0022:01:00.0 failed with error -22 This shouldn't be spammy since pci_enable_device()

Re: [PATCH] powernv/pci: Print an error when device enable is blocked

2020-04-08 Thread Oliver O'Halloran
On Thu, Apr 9, 2020 at 4:13 PM Oliver O'Halloran wrote: > > If the platform decides to block enabling the device nothing is printed > currently. This can lead to some confusion since the dmesg output will > usually print an error with no context e.g. > > e1000e: probe of 0022:01:00.0 faile

Re: usb: gadget: fsl_udc_core: Checking for a failed platform_get_irq() call in fsl_udc_probe()

2020-04-08 Thread Markus Elfring
>> Would you like to reconsider the shown condition check? > > Thanks for the finding. This is truly a software issue that need to > be fixed. I was unsure if I noticed another programming mistake. > Would you submit a patch for it Do other contributors know the affected software module better

Re: [PATCH v5 00/21] Initial Prefixed Instruction support

2020-04-08 Thread Christophe Leroy
On 04/06/2020 08:09 AM, Jordan Niethe wrote: A future revision of the ISA will introduce prefixed instructions. A prefixed instruction is composed of a 4-byte prefix followed by a 4-byte suffix. All prefixes have the major opcode 1. A prefix will never be a valid word instruction. A suffix ma

<    1   2